Uh oh!
There was an error while loading. Please reload this page.
Fix some clippy lints - #455
Conversation
Codecov Report
@@ Coverage Diff @@## master #455 +/- ##
==========================================
+ Coverage 87.64% 87.66% +0.01%
==========================================
Files 63 63 Lines 3352 3356 +4 ==========================================
+ Hits 2938 2942 +4
Misses 414 414
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@## master #455 +/- ##
==========================================
+ Coverage 87.66% 87.66% +<.01%
==========================================
Files 63 63 Lines 3355 3356 +1 ==========================================
+ Hits 2941 2942 +1
Misses 414 414
Continue to review full report at Codecov.
|
| py: Python<'p>, | ||
| elements: impl IntoIterator<Item = T, IntoIter = U>, | ||
| ) -> &'p PyList | ||
| pub fn new<T, U>(py: Python<'_>, elements: impl IntoIterator<Item = T, IntoIter = U>) -> &PyList |
There was a problem hiding this comment.
Oh it was stabilized a year ago rust-lang/rust#49458.
Maybe I have to learn Rust once more 😅
There was a problem hiding this comment.
The edition guide and the official rust blog (esp. the release notes) are really good resources for that
| #[inline] | ||
| pub fn is_empty(&self) -> PyResult<bool> { | ||
| let len = self.len()?; |
There was a problem hiding this comment.
I prefer to self.len().map(|l| l == 0).
| let empty_seq = empty_list.cast_as::<PySequence>(py).unwrap(); | ||
| assert_eq!(empty_seq.is_empty().unwrap(), true); | ||
| } | ||
There was a problem hiding this comment.
Just a nit but I don't like this empty line.
Thanks, I left some comments but mostly looks good. |
Alexander-N
commented
Apr 23, 2019
Ok, done. |
kngwyu
commented
Apr 24, 2019
Thanks again |
No description provided.