Skip to content

Stabilize underscore lifetimes - #49458

Merged
bors merged 1 commit into
rust-lang:masterfrom
cramertj:stable-underscore-lt
Mar 29, 2018
Merged

Stabilize underscore lifetimes#49458
bors merged 1 commit into
rust-lang:masterfrom
cramertj:stable-underscore-lt

Conversation

@cramertj

Copy link
Copy Markdown
Member

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2018
@bors

bors commented Mar 28, 2018

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #49394) made this pull request unmergeable. Please resolve the merge conflicts.

@cramertj
cramertjforce-pushed the stable-underscore-lt branch 5 times, most recently from 40ac247 to c3f0228CompareMarch 28, 2018 22:27
@cramertj
cramertjforce-pushed the stable-underscore-lt branch from c3f0228 to e6e6bd2CompareMarch 28, 2018 22:27
@cramertj

Copy link
Copy Markdown
MemberAuthor

@bors r=nikomatsakis p=100

b.c. he said so

@bors

bors commented Mar 28, 2018

Copy link
Copy Markdown
Collaborator

📌 Commit e6e6bd2 has been approved by nikomatsakis

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2018
@bors

bors commented Mar 29, 2018

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e6e6bd2 with merge 1e652bd...

bors added a commit that referenced this pull request Mar 29, 2018
@bors

bors commented Mar 29, 2018

Copy link
Copy Markdown
Collaborator

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing 1e652bd to master...

@bors
bors merged commit e6e6bd2 into rust-lang:masterMar 29, 2018
@cramertj
cramertj deleted the stable-underscore-lt branch March 30, 2018 11:23
@kennytmkennytm added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 4, 2018
@kennytmkennytm mentioned this pull request Apr 4, 2018
@steveklabniksteveklabnik mentioned this pull request Apr 4, 2018
@alercah

alercah commented May 11, 2018

Copy link
Copy Markdown

For anyone coming from the release notes, you can read the RFC of which this feature forms a part.

@kngwyukngwyu mentioned this pull request Apr 24, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@cramertj@bors@alercah@kennytm@nikomatsakis@rust-highfive