Skip to content

fix: blacklist highs 1.14.0 - #654

Merged
coroa merged 6 commits into
PyPSA:masterfrom
coroa:fix/blacklist-highs-1-14-0
Apr 17, 2026
Merged

fix: blacklist highs 1.14.0#654
coroa merged 6 commits into
PyPSA:masterfrom
coroa:fix/blacklist-highs-1-14-0

Conversation

@coroa

@coroacoroa commented Apr 17, 2026

Copy link
Copy Markdown
Member

Closes#648 and #646 .

Changes proposed in this Pull Request

Highs 1.14.0 is producing wrong results (due to broken presolve) and crashes on certain Windows machines.

Typing overloads for expressions.merge.

The version constraints for individual solvers to python<=1.12 were relaxed.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Unit tests for new features were added (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the MIT license.

@coroacoroa changed the title fix: blacklist highs 1.14.0, relax python constraintsfix: blacklist highs 1.14.0Apr 17, 2026
@maurerle

Copy link
Copy Markdown
Contributor

Maybe add 7c323f5 to this PR so that the CI runs through..? Or just merge this, and #647 afterwards

@coroa
coroaforce-pushed the fix/blacklist-highs-1-14-0 branch from b05fc68 to 4a06615CompareApril 17, 2026 08:11
@coroa
coroaforce-pushed the fix/blacklist-highs-1-14-0 branch from 4a06615 to bb4418aCompareApril 17, 2026 08:33
@FBumann

Copy link
Copy Markdown
Collaborator

@coroa Could we use a more expressive name for ExpVarDs? I think it would really help readability.

Comment threadpyproject.toml
"toolz",
"numexpr",
"xarray>=2024.2.0",
"xarray>=2024.2.0,<2026.4",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we merge this, we should remove this line again in #647

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please

@coroa

Copy link
Copy Markdown
MemberAuthor

@coroa Could we use a more expressive name for ExpVarDs? I think it would really help readability.

I was going for ExpressionLike but that was already taken. Suggestions?

@FBumann

Copy link
Copy Markdown
Collaborator

@coroa Could we use a more expressive name for ExpVarDs? I think it would really help readability.

I was going for ExpressionLike but that was already taken. Suggestions?

I Don't have a good suggestion either. As it's purely internal and pretty local it's not really important anyway...

@coroa

Copy link
Copy Markdown
MemberAuthor

@coroa Could we use a more expressive name for ExpVarDs? I think it would really help readability.

I was going for ExpressionLike but that was already taken. Suggestions?

I Don't have a good suggestion either. As it's purely internal and pretty local it's not really important anyway...

found a good compromise. now the test failures

@coroa
coroa merged commit 5514510 into PyPSA:masterApr 17, 2026
20 of 21 checks passed
@coroa
coroa deleted the fix/blacklist-highs-1-14-0 branch April 17, 2026 13:19
@FBumann

Copy link
Copy Markdown
Collaborator

@coroa
I like Mergeable
It tells that's it's tightly coupled to that one method

@FabianHofmannFabianHofmann mentioned this pull request Apr 21, 2026
5 tasks
@FBumannFBumann mentioned this pull request May 12, 2026
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

highs: wrong optimization result with presolve since highs v1.14.0

3 participants

@coroa@maurerle@FBumann