Skip to content

3.x: Add missing throwIfFatal calls - #6801

Merged
akarnokd merged 1 commit into
ReactiveX:3.xfrom
akarnokd:CatchThrowIfFatal
Dec 26, 2019
Merged

3.x: Add missing throwIfFatal calls#6801
akarnokd merged 1 commit into
ReactiveX:3.xfrom
akarnokd:CatchThrowIfFatal

Conversation

@akarnokd

Copy link
Copy Markdown
Member
  • Add missing Exceptions.throwIfFatal calls in catch (Throwable blocks.
  • Add validator that checks for the existence of these throwIfFatal, wrapOrThrow or fail calls.
  • Fix AutoCloseableDisposable to use wrapOrThrow like the other Disposable wrapper implementations.

Resolves#6796

@akarnokdakarnokd added this to the 3.0 milestone Dec 26, 2019
@codecov

codecovBot commented Dec 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6801 into 3.x will increase coverage by <.01%.
The diff coverage is 87.87%.

Impacted file tree graph

@@ Coverage Diff @@## 3.x #6801 +/- ##
============================================
+ Coverage 98.24% 98.24% +<.01% - Complexity 6375 6378 +3 
============================================
Files 711 711 Lines 46214 46247 +33 Branches 6330 6330 ============================================
+ Hits 45403 45437 +34 - Misses 289 291 +2 + Partials 522 519 -3
Impacted FilesCoverage ΔComplexity Δ
.../internal/operators/flowable/FlowableDoOnEach.java93.25% <0%> (-2.15%)3 <0> (ø)
...ternal/operators/observable/ObservableCollect.java100% <100%> (ø)2 <0> (ø)⬇️
...ternal/schedulers/ScheduledDirectPeriodicTask.java100% <100%> (ø)2 <0> (ø)⬇️
...nternal/operators/flowable/FlowableScalarXMap.java100% <100%> (ø)7 <0> (ø)⬇️
...nal/operators/observable/ObservableScalarXMap.java97.72% <100%> (+0.02%)7 <0> (ø)⬇️
...java3/internal/schedulers/InstantPeriodicTask.java100% <100%> (ø)20 <0> (ø)⬇️
...s/observable/ObservableWindowBoundarySelector.java96.44% <100%> (+0.01%)2 <0> (ø)⬇️
...ators/flowable/FlowableWindowBoundarySelector.java95.26% <100%> (+0.02%)2 <0> (ø)⬇️
...nternal/operators/observable/ObservableReplay.java96.3% <100%> (ø)19 <0> (ø)⬇️
.../operators/observable/ObservableCollectSingle.java100% <100%> (ø)3 <0> (ø)⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38bcd5e...1280490. Read the comment docs.

@akarnokd
akarnokd merged commit a97d871 into ReactiveX:3.xDec 26, 2019
@akarnokd
akarnokd deleted the CatchThrowIfFatal branch December 26, 2019 23:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.x: Add validator to check the existence of throwIfFatal in a catch block

1 participant

@akarnokd