Skip to content

Change a method name to make consistent with PR#6801 - #7080

Merged
akarnokd merged 1 commit into
ReactiveX:3.xfrom
T45K:make_consistent_with_6801
Sep 21, 2020
Merged

Change a method name to make consistent with PR#6801#7080
akarnokd merged 1 commit into
ReactiveX:3.xfrom
T45K:make_consistent_with_6801

Conversation

@T45K

@T45KT45K commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Thank you for contributing to RxJava. Before pressing the "Create Pull Request" button, please consider the following points:

  • Please give a description about what and why you are contributing, even if it's trivial.

In #6801, a method name, FlowableZipIterable#error is changed to fail, but its similar class, ObservableZipIterable was not changed.
I changed it for consistency.

  • Please include the issue list number(s) or other PR numbers in the description if you are contributing in response to those.

This PR is related to #6801

  • Please include a reasonable set of unit tests if you contribute new code or change an existing one. If you contribute an operator, (if applicable) please make sure you have tests for working with an empty, just, range of values as well as an error source, with and/or without backpressure and see if unsubscription/cancellation propagates correctly.

This change will not affect external behavior.

@codecov

codecovBot commented Sep 21, 2020

Copy link
Copy Markdown

Codecov Report

Merging #7080 into 3.x will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@## 3.x #7080 +/- ##
============================================
- Coverage 99.51% 99.49% -0.02% 
Complexity 6667 6667 ============================================
Files 742 742 Lines 47275 47275 Branches 6374 6374 ============================================
- Hits 47044 47037 -7 - Misses 105 110 +5 - Partials 126 128 +2 
Impacted FilesCoverage ΔComplexity Δ
...al/operators/observable/ObservableZipIterable.java100.00% <100.00%> (ø)3.00 <0.00> (ø)
.../operators/observable/ObservableFlatMapSingle.java94.44% <0.00%> (-3.18%)2.00% <0.00%> (ø%)
...va/io/reactivex/rxjava3/subjects/MaybeSubject.java97.75% <0.00%> (-2.25%)45.00% <0.00%> (-1.00%)
.../internal/disposables/ListCompositeDisposable.java98.00% <0.00%> (-2.00%)34.00% <0.00%> (-1.00%)
...tivex/rxjava3/disposables/CompositeDisposable.java98.14% <0.00%> (-1.86%)39.00% <0.00%> (-1.00%)
...internal/operators/flowable/FlowableFromArray.java96.61% <0.00%> (-1.70%)3.00% <0.00%> (ø%)
...java3/internal/operators/flowable/FlowableZip.java98.97% <0.00%> (-1.03%)6.00% <0.00%> (ø%)
...a3/internal/operators/flowable/FlowableCreate.java98.05% <0.00%> (-0.98%)6.00% <0.00%> (ø%)
...operators/observable/ObservableMergeWithMaybe.java99.09% <0.00%> (-0.91%)2.00% <0.00%> (ø%)
...a3/internal/operators/flowable/FlowableReplay.java98.92% <0.00%> (-0.86%)21.00% <0.00%> (ø%)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b48855...8d8fb84. Read the comment docs.

@akarnokdakarnokd added this to the 3.1 milestone Sep 21, 2020
@akarnokd
akarnokd merged commit fe71f6a into ReactiveX:3.xSep 21, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@T45K@akarnokd