feat(route getting started page): getting started page by arat3091 · Pull Request #43 · ReactiveX/rxjs-docs

arat3091 · 2017-10-18T14:21:44Z

route for the getting started page and link to andre staltz page

ladyleet · 2017-10-20T08:10:48Z

@btroncone @kwonoj can one of you two approve review so we can get this merged? thanks! and thanks @arat3091! <3

Split descriptions for combineAll and combineLatest between two lines to satisfy lint requirement (line +140 chars)

feat(operators): operator browser page

- Added basic tooling configuration for linting using prettier, tslint. - Added precommit to run lint on staged files CloseReactiveX#45

chore(tooling): Add prettier, lint-staged and precommit hook for tooling

chore(danger): fix dangerfile

chore(travis): update build coverage config

router for the getting started page and link to andre staltz page ReactiveX#33

removing test ReactiveX#33

Review comments by the members ReactiveX#33

merge from upstrem master ReactiveX#33

removing test ReactiveX#33

…com/arat3091/rxjs-docs into arat3091/pr33-getting-started-guide

adding formating ReactiveX#33

arat3091 · 2017-10-23T09:00:37Z

@ladyleet .. hope you doing good .. i just merged from master to this branch now so that you can easily merge ...

arat3091 · 2017-10-23T12:19:49Z

I am lost on DANGER_GITHUB_API_TOKEN ... can anyone help ?

kwonoj · 2017-10-23T13:32:33Z

It's not token issue. check #43 (comment) 's warning and failure.

arat3091 · 2017-10-23T13:43:19Z

@kwonoj .. but i am not able to find the problem. i am follwing as it says ..my commit message says
feat(subject): some content

body

issue number link

guide for starters none

arat3091 · 2017-10-24T17:31:26Z

Hi @ladyleet or @kwonoj or @btroncone , can you help me in merging this one . I have no idea y my commit message fails. I am trying to follow the same as stated in the guideline.

ladyleet · 2017-10-28T04:10:43Z

hmm... @ashwin-sureshkumar or @btroncone can you guys help with this for @arat3091 ?

ladyleet · 2017-11-16T18:13:44Z

@ashwin-sureshkumar if you have time to help with this! // @btroncone @sumitarora

xlozinguez · 2017-11-17T18:56:05Z

@arat3091 the issue seems to come from the commit 47bf72c1d3ebb9630a3eab49d900334529edc71c, I would suggest you try the following:

 git rebase -i HEAD~3

and then edit the offending commit message and force push. I can give it a shot on a separate branch if you prefer.

ashwin-sureshkumar · 2017-12-04T11:53:35Z

@xlozinguez @arat3091 - Any progress on this PR ? Please rebase as well.

niklas-wortmann · 2018-02-01T20:04:49Z

is there any way to get this pr merged? If there is any way to provide some help or something like that, just let me know.

btroncone added 30 commits October 3, 2017 16:31

added stubs for all operators
c95a00d

updated operator formatting
11fc524

update lint settings
363484d

correctly type doc objects
242b28d

styling and grouping updates
05fc934

basic operator outline
62cb886

operator styling updates
38f2c27

sidenav navigation tweaks
ba8fbbf

operator toc start
e886d00

operator styling progress
0cbec6f

styling updates
0f25ced

updated to material beta.12
90577f1

operator navigation update
a6985eb

added highlight.js
bfb948e

operator routing update
acea05d

operator formatting update
a43f86d

styling and formatting updates
5bc28e2

media helpers
bf4bd05

filling in info and styling updates
94d4188

fixed source url
700b247

merge upstream
363f68f

update routing to module
f365292

split up operator components
317449b

added walkthrough
2eaa156

update active color
6c7f2c4

added copy + operator styling updates
68a52b1

operator display tweaks
a73d3b6

styling + quick link updates
cdd9152

Merge branch 'master' into operator-section
df94a2c

removed unused routes
0bf3e2b

btronconeand others added 17 commits October 20, 2017 10:06

Merge remote-tracking branch 'upstream/master' into operator-section
d22320a

style(operators): split description between lines to fix linting problem
f454d49
Split descriptions for combineAll and combineLatest between two lines to satisfy lint requirement (line +140 chars)

Merge pull requestReactiveX#34from btroncone/operator-section
73a724e
feat(operators): operator browser page

chore(tooling): Add prettier, lint-staged and precommit hook for tooling
99b382b
- Added basic tooling configuration for linting using prettier, tslint. - Added precommit to run lint on staged files CloseReactiveX#45

Merge pull requestReactiveX#49from ashwin-sureshkumar/issue-45
b78856e
chore(tooling): Add prettier, lint-staged and precommit hook for tooling

chore(danger): fix dangerfile
35fdf0b

Merge pull requestReactiveX#59from kwonoj/fix-lodash
c45f65c
chore(danger): fix dangerfile

chore(danger): update rules
4c6ce9e

chore(travis): update build coverage config
626fa7d

Merge pull requestReactiveX#60from kwonoj/chore-coverage
86bdde6
chore(travis): update build coverage config

feat(route getting started page): getting started page
82b830a
router for the getting started page and link to andre staltz page ReactiveX#33

fix(removing test): removing test
fba476d
removing test ReactiveX#33

fix(link to external docs): Review comments
2726b16
Review comments by the members ReactiveX#33

fix(merge from upstream)
e3992c9
merge from upstrem master ReactiveX#33

fix(removing test): removing test
a025699
removing test ReactiveX#33

Merge branch 'arat3091/pr33-getting-started-guide' ofhttps://github.…
d9bcd7e
…com/arat3091/rxjs-docs into arat3091/pr33-getting-started-guide

fix(adding formatting)
47bf72c
adding formating ReactiveX#33

ankur added 2 commits October 23, 2017 16:08

fix(getting started guide): getting started guide
d0e1c08

fix(guide): guide for starters
5e153c8
guide for starters none

Navigation Menu

Uh oh!

feat(route getting started page): getting started page - #43

feat(route getting started page): getting started page#43
arat3091 wants to merge 74 commits into
ReactiveX:masterfrom
arat3091:arat3091/pr33-getting-started-guide

arat3091 commented Oct 18, 2017

Uh oh!

ladyleet commented Oct 20, 2017

Uh oh!

arat3091 commented Oct 23, 2017

Uh oh!

arat3091 commented Oct 23, 2017

Uh oh!

kwonoj commented Oct 23, 2017

Uh oh!

arat3091 commented Oct 23, 2017

Uh oh!

arat3091 commented Oct 24, 2017

Uh oh!

ladyleet commented Oct 28, 2017

Uh oh!

ladyleet commented Nov 16, 2017

Uh oh!

xlozinguez commented Nov 17, 2017

Uh oh!

ashwin-sureshkumar commented Dec 4, 2017•
edited
Loading

Uh oh!

niklas-wortmann commented Feb 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

arat3091 commented Oct 18, 2017

Uh oh!

ladyleet commented Oct 20, 2017

Uh oh!

arat3091 commented Oct 23, 2017

Uh oh!

arat3091 commented Oct 23, 2017

Uh oh!

kwonoj commented Oct 23, 2017

Uh oh!

arat3091 commented Oct 23, 2017

Uh oh!

arat3091 commented Oct 24, 2017

Uh oh!

ladyleet commented Oct 28, 2017

Uh oh!

ladyleet commented Nov 16, 2017

Uh oh!

xlozinguez commented Nov 17, 2017

Uh oh!

ashwin-sureshkumar commented Dec 4, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

niklas-wortmann commented Feb 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ashwin-sureshkumar commented Dec 4, 2017•
edited
Loading