Uh oh!
There was an error while loading. Please reload this page.
fix(security): vulnerabilities + remove coveralls - #1333
Merged
Conversation
benjlevesqueforce-pushed
the
fix/security/vulnerabilities
branch
from
January 18, 2024 10:53
8a32e1c to
77d45fbComparebenjlevesque
marked this pull request as ready for review
January 18, 2024 11:23
github-actionsBot
requested review from
KolevDarko, MantisClone, alexandre-abrioux and kevindaveeJanuary 18, 2024 11:23
alexandre-abrioux
approved these changes
Jan 18, 2024
Uh oh!
There was an error while loading. Please reload this page.
kevindavee
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR upgrades Lerna from 3 to 6, there is no breaking change and the new version is actually pretty nice. We'll need to confirm publish still works. NB: Lerna was the cause of many vulnerabilities.
It also drops
coverallsand thepublish-coveragestep from the CI. I don't think code coverage is worth having critical vulnerabilities, and there's no fix available (the library hasn't been maintained for 3 years)Resolutions
Before:
After:
NB: this is optimistic, the OpenZeppelin vulnerabilities will not be removed by this PR
Critical
https://github.com/RequestNetwork/requestNetwork/security/dependabot/207
https://github.com/RequestNetwork/requestNetwork/security/dependabot/177
https://github.com/RequestNetwork/requestNetwork/security/dependabot/137
https://github.com/RequestNetwork/requestNetwork/security/dependabot/123
https://github.com/RequestNetwork/requestNetwork/security/dependabot/51
https://github.com/RequestNetwork/requestNetwork/security/dependabot/14
High
https://github.com/RequestNetwork/requestNetwork/security/dependabot/182
https://github.com/RequestNetwork/requestNetwork/security/dependabot/172
https://github.com/RequestNetwork/requestNetwork/security/dependabot/165
https://github.com/RequestNetwork/requestNetwork/security/dependabot/124
https://github.com/RequestNetwork/requestNetwork/security/dependabot/120
https://github.com/RequestNetwork/requestNetwork/security/dependabot/113
https://github.com/RequestNetwork/requestNetwork/security/dependabot/101
https://github.com/RequestNetwork/requestNetwork/security/dependabot/80
https://github.com/RequestNetwork/requestNetwork/security/dependabot/75
https://github.com/RequestNetwork/requestNetwork/security/dependabot/45