Skip to content

chore(cd): fix clean script for cd - #1338

Merged
yomarion merged 5 commits into
masterfrom
chore-cd/fix-clean-for-cd
Jan 19, 2024
Merged

chore(cd): fix clean script for cd#1338
yomarion merged 5 commits into
masterfrom
chore-cd/fix-clean-for-cd

Conversation

@yomarion

@yomarionyomarion commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

Description of the changes

This fixes the issue introduced by #1328 , when running next-release as part of the CI.

Partial view of the problem:

> @requestnetwork/data-format:clean
$ shx rm -rf dist tsconfig.tsbuildinfo tsconfig.build.tsbuildinfo
rm: no such file or directory: tsconfig.tsbuildinfo

@yomarion
yomarion marked this pull request as ready for review January 19, 2024 09:42
@yomarion
yomarion merged commit bd20408 into masterJan 19, 2024
@yomarion
yomarion deleted the chore-cd/fix-clean-for-cd branch January 19, 2024 10:25
@benjlevesque

Copy link
Copy Markdown
Contributor

I don't think the issue comes from #1328, but from #1237

@benjlevesque

Copy link
Copy Markdown
Contributor

still not 😅
actually #1333

@yomarion

Copy link
Copy Markdown
ContributorAuthor

still not 😅 actually #1333

@benjlevesque of course! The previous one failed to build so it's a different issue. I was looking for the lerna change from previous commits but it's not in the name. Thanks.

@benjlevesque

Copy link
Copy Markdown
Contributor

what's strange is that the file missing is in data-format, which is a good argument for #1328, but the build and released worked

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@yomarion@benjlevesque@alexandre-abrioux