Skip to content

[FIX] Push notification's deep linking not working when opened from a cold state on Android - #4648

Merged
diegolmello merged 4 commits into
developfrom
fix.react-native-notifications-issue
Nov 4, 2022
Merged

[FIX] Push notification's deep linking not working when opened from a cold state on Android#4648
diegolmello merged 4 commits into
developfrom
fix.react-native-notifications-issue

Conversation

@diegolmello

@diegolmello diegolmello commented Nov 3, 2022

Copy link
Copy Markdown
Member

Proposed changes

Applied wix/react-native-notifications#908 and tested isReactInitialized as well.
Is there any way to call mAppLifecycleFacade directly?

Issue(s)

Closes #4606

How to test or reproduce

What's been fixed

  • Receive a push notification (try it both with the app in background and killed)
  • Tap on it and the app should redirect to it
  • Go to another room and try to send a message
  • (fail) On Android, the app is going to trigger the deep link again and behave like you tapped the push notification again

Other tests

  • Everything related to push notification (ping me if you need help thinking on possible test cases)
  • Previously, receiving a push and trying to share an image would also trigger the deep link

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-135

@diegolmello diegolmello changed the title [WIP] Push notification's deep linking not working when opened from a cold state on Android [FIX] Push notification's deep linking not working when opened from a cold state on Android Nov 3, 2022
@diegolmello
diegolmello force-pushed the fix.react-native-notifications-issue branch from 929ec66 to 1a11717 Compare November 4, 2022 14:13
@diegolmello
diegolmello merged commit 80d53d3 into develop Nov 4, 2022
@diegolmello
diegolmello deleted the fix.react-native-notifications-issue branch November 4, 2022 16:33
diegolmello added a commit that referenced this pull request Dec 2, 2022
diegolmello added a commit that referenced this pull request Dec 2, 2022
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App running deep link without need on Android

2 participants