Skip to content

Chore: Bump react-native-notifications to 4.3.3 - #4692

Merged
diegolmello merged 1 commit into
developfrom
bump-rnn-433
Nov 16, 2022
Merged

Chore: Bump react-native-notifications to 4.3.3#4692
diegolmello merged 1 commit into
developfrom
bump-rnn-433

Conversation

@diegolmello

@diegolmello diegolmello commented Nov 16, 2022

Copy link
Copy Markdown
Member

Proposed changes

Updates the lib and applies wix/react-native-notifications#906 (comment)

Issue(s)

Related to:

How to test or reproduce

Test base

  • Receive a push notification
  • Tap it and the app should redirect to the message

Test 1

  • (Test base)
  • Go to rooms list, send it to background and open it again
  • It should not redirect again
  • Send it to backgroud
  • Receive a push on another room
  • It should redirect to the correct message
  • (rerun this whole test starting with the app killed and with the app open in background)

Test 2

  • (Test base)
  • Go to another room
  • Upload a photo
  • (rerun this whole test starting with the app killed and with the app open in background)

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-160

@diegolmello
diegolmello merged commit 44f062f into develop Nov 16, 2022
@diegolmello
diegolmello deleted the bump-rnn-433 branch November 16, 2022 21:09
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
navislavo pushed a commit to NextiaDev/Rocket.Chat.ReactNative that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants