Uh oh!
There was an error while loading. Please reload this page.
add comment to specify the rand version - #473
Merged
Merged
Conversation
tarcieri
commented
Feb 13, 2025
Member
@Its-Just-Nans can you rebase? |
Its-Just-Nansforce-pushed
the
document-rand-version
branch
from
February 13, 2025 20:33
d18a829 to
e27e99cCompareAuthor
Yes, done |
tarcieri
approved these changes
Feb 14, 2025
dignifiedquire
approved these changes
Feb 14, 2025
dignifiedquire
left a comment
Member
There was a problem hiding this comment.
thanks, it is a bit annoying, but I guess for the time being at least helps users understand the situation
newpavlov
commented
Feb 21, 2025
Member
This PR should be probably merged into the |
Its-Just-Nansforce-pushed
the
document-rand-version
branch
from
February 21, 2025 13:38
e27e99c to
cdc5367CompareIts-Just-Nans
commented
Feb 21, 2025
Author
I've updated the base branch |
newpavlov
commented
Mar 12, 2025
Member
Hm. Should we merge it regardless of the CI failures? |
tarcieri
commented
Mar 12, 2025
Member
Not sure what broke the build, but maybe we should fix it |
Its-Just-Nans
commented
Mar 12, 2025
Author
Hi The commit "Fix CI" 3f83141 fixed the CI by removing unused import (also by updating cargo.lock) |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is not super useful BUT can be useful.
Of course this PR should be kind of reversed/updated when the rand 0.9 will be supported
Linked to
rand_corev0.9 support #466Feel free to close if not useful enough to be merged