Skip to content

bump rand_core from 0.6.4 to 0.9.2; edition 2024; bump MSRV to 1.85 - #478

Merged
newpavlov merged 2 commits into
RustCrypto:masterfrom
baloo:baloo/rand-core/0.9.0
Mar 12, 2025
Merged

bump rand_core from 0.6.4 to 0.9.2; edition 2024; bump MSRV to 1.85#478
newpavlov merged 2 commits into
RustCrypto:masterfrom
baloo:baloo/rand-core/0.9.0

Conversation

@baloo

@baloobaloo commented Feb 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch 2 times, most recently from ca5074d to 79160aeCompareFebruary 14, 2025 22:58
baloo
baloo commented Feb 14, 2025
View reviewed changes
Comment threadsrc/unwrap_rng.rs Outdated
@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch 3 times, most recently from e8d858e to 6402ddeCompareFebruary 16, 2025 20:41
@baloobaloo changed the title bump rand_core from 0.6.4 to 0.9.0bump rand_core from 0.6.4 to 0.9.1Feb 16, 2025
@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch 2 times, most recently from 3babac7 to a61d022CompareFebruary 18, 2025 20:45
newpavlov
newpavlov reviewed Feb 19, 2025
View reviewed changes
Comment threadsrc/traits/padding.rs Outdated
@baloobaloo mentioned this pull request Feb 19, 2025
Merged
@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch 5 times, most recently from 1c7dc3c to 1aab5a9CompareFebruary 20, 2025 17:45
@newpavlovnewpavlov mentioned this pull request Feb 21, 2025
Merged
@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch from 1aab5a9 to 612d94fCompareFebruary 22, 2025 19:59
@baloobaloo changed the title bump rand_core from 0.6.4 to 0.9.1bump rand_core from 0.6.4 to 0.9.2Feb 22, 2025
@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch from 612d94f to c3e9a87CompareFebruary 22, 2025 19:59
@baloo

baloo commented Feb 22, 2025

Copy link
Copy Markdown
MemberAuthor

I believe this is now ready to merge.

@baloo

baloo commented Feb 22, 2025

Copy link
Copy Markdown
MemberAuthor

nightly doesn't have edition2024 ?! This is going to be interesting.

@newpavlov

newpavlov commented Feb 22, 2025•
edited
Loading

Copy link
Copy Markdown
Member

You need to update the pinned nightly version here.

Could you also look into why the minimal-versions job fails?

@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch 2 times, most recently from 4e1191a to 241340fCompareFebruary 22, 2025 20:10
@baloo

baloo commented Feb 22, 2025

Copy link
Copy Markdown
MemberAuthor

Ha i missed the pin! thank you!

I think the minimal-version was because I forgot to bump the version of crypto-primes.

@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch from 241340f to 82d679fCompareFebruary 22, 2025 20:30
@baloo

baloo commented Feb 22, 2025

Copy link
Copy Markdown
MemberAuthor

tests fixed \o/

newpavlov
newpavlov reviewed Feb 22, 2025
View reviewed changes

@newpavlovnewpavlov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments below are not relevant to this PR per se, but it could be worth to fix them while we are at it.

Comment threadbenches/key.rs Outdated
Comment threadsrc/oaep.rs Outdated
Comment threadsrc/key.rs Outdated
Comment threadsrc/oaep/decrypting_key.rs Outdated
Comment threadsrc/pkcs1v15.rs Outdated
Comment threadsrc/pss/blinded_signing_key.rs Outdated
Comment threadsrc/pss/blinded_signing_key.rs Outdated
Comment threadsrc/pss/signing_key.rs Outdated
Comment threadsrc/pss/signing_key.rs Outdated
Comment threadsrc/traits/padding.rs Outdated
@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch from 82d679f to 20fcb3eCompareFebruary 22, 2025 21:31
baloo
baloo commented Feb 22, 2025
View reviewed changes
Comment threadsrc/pss/signing_key.rs Outdated
{
fn sign_prehash(&self, prehash: &[u8]) -> signature::Result<Signature> {
self.sign_prehash_with_rng(&mut OsRng, prehash)
self.sign_prehash_with_rng(&mut OsRng.unwrap_err(), prehash)

@baloobalooFeb 22, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something we can improve here.

@baloobalooFeb 22, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires: RustCrypto/traits#1765

@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch 2 times, most recently from 84f79c1 to e174e9fCompareFebruary 22, 2025 21:52
@baloo

baloo commented Feb 22, 2025

Copy link
Copy Markdown
MemberAuthor

huum, wait I also need to pull RustCrypto/traits#1766

@baloo
baloo marked this pull request as draft February 22, 2025 22:01
@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch from e174e9f to 35f1ab1CompareFebruary 22, 2025 22:03
@baloo
baloo marked this pull request as ready for review February 22, 2025 22:03
@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch from 35f1ab1 to 503031aCompareFebruary 25, 2025 17:44
@baloobaloo changed the title bump rand_core from 0.6.4 to 0.9.2bump rand_core from 0.6.4 to 0.9.2; edition 2024; bump MSRV to 1.85Feb 25, 2025
@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch 2 times, most recently from c0e2720 to d4f716eCompareFebruary 26, 2025 04:04
@Snowiiii

Snowiiii commented Feb 27, 2025

Copy link
Copy Markdown

Seems like everything is done, Or is something missing ?

@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch from 2447167 to 7d0353aCompareFebruary 28, 2025 22:34
@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch 5 times, most recently from f8d8e59 to 3172381CompareMarch 10, 2025 05:19
@baloo
balooforce-pushed the baloo/rand-core/0.9.0 branch from 3172381 to 57ab112CompareMarch 10, 2025 05:54
@newpavlov
newpavlov merged commit baac80b into RustCrypto:masterMar 12, 2025
takumi-earth pushed a commit to earthlings-dev/RSA that referenced this pull request Jan 27, 2026
@baloo
bump rand_core from 0.6.4 to 0.9.2; edition 2024; bump MSRV to …
31f5470
…1.85 (RustCrypto#478)
This also bumps the dependency of `signature` from `2.3.0-pre.4` to `2.3.0-pre.5`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@newpavlovnewpavlovnewpavlov approved these changes
@dignifiedquiredignifiedquireAwaiting requested review from dignifiedquire

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

rand_core v0.9 support

3 participants

@baloo@newpavlov@Snowiiii