Skip to content

RsaPssParams and RsaOaepParams fixes - #1010

Merged
tarcieri merged 2 commits into
RustCrypto:masterfrom
lumag:pkcs1-params
Apr 18, 2023
Merged

RsaPssParams and RsaOaepParams fixes#1010
tarcieri merged 2 commits into
RustCrypto:masterfrom
lumag:pkcs1-params

Conversation

@lumag

@lumaglumag commented Apr 18, 2023

Copy link
Copy Markdown
Contributor
  • Use NULL parameters for digest params (as required by mozilla)
  • Add functions to construct known-good parameters.

Dmitry Baryshkov
pkcs1: params: use NULL parameters for SHA AlgorithmIdentifiers
9eb0004
Obviously Mozilla policy insists on having NULL parameters for MD/SHA
algorithm identifiers. Change RsaPssParams/RsaOaepParams defaults to
use NULL instead of empty parameters.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
@lumag

lumag commented Apr 18, 2023

Copy link
Copy Markdown
ContributorAuthor

@tarcieri if possible, could you please cut the pkcs1 release afterwards?
I'd like to use this in RSA crate to fix issues in #1007 (ugh).

tarcieri
tarcieri reviewed Apr 18, 2023
View reviewed changes
Comment threadpkcs1/src/params.rs Outdated
tarcieri
tarcieri reviewed Apr 18, 2023
View reviewed changes
Comment threadpkcs1/tests/params.rs
@tarcieri

tarcieri commented Apr 18, 2023

Copy link
Copy Markdown
Member

This looks mostly ok though I'm a bit curious about the usage of &'a dyn AsRef<[u8]> as opposed to &'a impl AsRef<[u8]> or just &'a [u8]

Dmitry Baryshkov
pkcs1: params: provide functions to construct RsaPss and RsaOaepParams
837e6e3
Implement RsaPssParams::new() and RsaOaepParams::new(), two functions to
generate correct parameters for the provided Digest and data.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
@tarcieri
tarcieri merged commit 8c62e09 into RustCrypto:masterApr 18, 2023
@tarcieritarcieri mentioned this pull request Apr 18, 2023
Merged
@lumag
lumag deleted the pkcs1-params branch April 18, 2023 15:03
@lumag

lumag commented Apr 18, 2023

Copy link
Copy Markdown
ContributorAuthor

@tarcieri thank you!

@lumaglumag mentioned this pull request Apr 18, 2023
Merged
baloo added a commit to baloo/formats that referenced this pull request May 23, 2024
@baloo
[wip] pkcs1: make sure AlgorithmIdentifier is encoded with Any
e1e7d61
reverts parts of RustCrypto#799 and RustCrypto#1010
@baloobaloo mentioned this pull request May 23, 2024
Closed
baloo added a commit to baloo/formats that referenced this pull request May 23, 2024
@baloo
[wip] pkcs1: make sure AlgorithmIdentifier is encoded with Any
e28a8ea
reverts parts of RustCrypto#799 and RustCrypto#1010
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lumag@tarcieri