Uh oh!
There was an error while loading. Please reload this page.
der: introduce an AnyLike trait to mark parameters - #1415
Conversation
| //! let alg_id = AlgorithmIdentifier { | ||
| //! oid: alg_oid, | ||
| //! parameters: Some(params_oid) | ||
| //! parameters: Some(Any::encode_from(¶ms_oid).unwrap()) |
There was a problem hiding this comment.
I believe this was a regression introduced in #769
There was a problem hiding this comment.
How is this a regression? The change seems like a regression.
baloo
commented
May 23, 2024
Last set of CI errors are related to #799 I think. |
baloo
commented
May 23, 2024
I'm not sure I understand the purpose of this trait or why you're adding bounds for it, nearly all of which seem unused?
...but |
I guess your goal here is to try to constrain the parameters specifically to the ...but that seems needlessly restrictive. The ASN.1 concept of Is there a specific motivation for this change? |
Notably this precludes using e.g. |
baloo
commented
May 24, 2024
The motivation was to compare the parameter to |
This newly defined
AnyLiketrait would help to make sure the parameters ofspki::AlgorithmIdentifierare serialized as Any.