Add custom error types to the Decode and DecodeValue traits. by turbocool3r · Pull Request #1055 · RustCrypto/formats

turbocool3r · 2023-05-08T17:24:42Z

Adds support for specifying custom error types for the Encode, Decode, EncodeValue, DecodeValue, DerOrd and ValueOrd traits (see #1053).

tarcieri · 2023-05-08T17:27:01Z

Just to set expectations: it will probably be a few months before we're ready to start making breaking changes again

turbocool3r · 2023-05-08T17:54:39Z

Just to set expectations: it will probably be a few months before we're ready to start making breaking changes again

That's ok, I'll leave this PR in place until it can be accepted.

tarcieri · 2024-01-21T23:48:28Z

It's possible to make breaking changes now.

However, I've opened #1328 which provides a less invasive alternative: it allows der::Error to carry with it an arbitrary error source when the std feature is enabled. It's not perfect but at least provides a stopgap solution.

That said, I think this approach is still interesting, and closer to e.g. what serde does.

tarcieri · 2024-01-22T01:10:52Z

@turbocool3r if you can get this PR green we can consider it over #1328.

turbocool3r · 2024-01-22T01:13:27Z

Ok, I'll try to do this by Wednesday

turbocool3r · 2024-01-23T21:17:56Z

It seems this won't be completely green because there are some dependencies on external crates like signature which should be modified separately.

There also was an issue with the DecodePem trait: adding a generic error type there causes the from_pem method to fail the borrow check even if both T and Error are marked as 'static. Forcing the error to be der::Error there fixes the issue.

tarcieri · 2024-01-23T21:18:54Z

It seems this won't be completely green because there are some dependencies on external crates like signature which should be modified separately.

Err, how so?

turbocool3r · 2024-01-23T21:20:28Z

Like here https://github.com/RustCrypto/formats/actions/runs/7631920556/job/20790968317?pr=1055#step:4:297.

tarcieri · 2024-01-23T21:25:59Z

Aah, in ecdsa. I can open a PR for that if you'd like.

turbocool3r · 2024-01-23T21:31:00Z

Aah, in ecdsa. I can open a PR for that if you'd like.

It would be nice. I think we need to first get this as it goes to see the complete list of crates that need to be modified.

turbocool3r · 2024-01-23T21:38:22Z

Yes, it seems it's only ecdsa, not signature.

turbocool3r · 2024-02-13T18:45:19Z

Hey, how about that pull request? I could probably do that myself to save some time.

tarcieri · 2024-02-13T20:15:29Z

Sorry, I've been meaning to get to it and I'd love to land this, but if you'd like to go for it that works too.

It's going to be oddly circular so you need to make a PR to https://github.com/rustcrypto/formats which uses a [patch.crates-io] directive to point to this branch, then you'll need to reference the branch in this PR to complete the cycle.

turbocool3r · 2024-02-14T10:14:34Z

Did you mean the https://github.com/RustCrypto/signatures repo? By this branch do you mean my fork or some other branch?

tarcieri · 2024-02-14T14:32:47Z

Err sorry, yes https://github.com/RustCrypto/signatures

You'll need to point to your branch on your fork for both this repo when updating signatures and again in a circular manner in your fork of signatures to update this PR

Goes in pair with [this](RustCrypto/formats#1055) PR to `formats`.

turbocool3r · 2024-02-14T21:09:30Z

Seems all green now, the signatures PR is RustCrypto/signatures#809.

tarcieri · 2024-02-14T21:13:58Z

Thanks, will review and try to get this merged ASAP

turbocool3r · 2024-02-14T21:25:19Z

Thanks!

Goes in pair with [this](RustCrypto/formats#1055) PR to `formats`.

Goes with this `formats` PR: RustCrypto/formats#1055

This reverts commit 7784f2d. This ended up complicating downstream error types, particularly in `no_std` contexts. It's also not really necessary now that #1055 has landed.

…" (#1371) This reverts commit 7784f2d. This ended up complicating downstream error types, particularly in `no_std` contexts. It's also not really necessary now that #1055 has landed.

This signature was missed in RustCrypto#1055

This signature was missed in #1055

Goes with this `formats` PR: RustCrypto/formats#1055

## Added - Custom error types support to the `Decode` and `DecodeValue` traits (#1055) - `EncodingRules` enum (#1321) - `Decode::from_ber` (#1389) - Documentation for field-level `tag_mode` attribute (#1401) - `Hash` implementation for `AlgorithmIdentifier` (#1414) - `SequenceRef::as_bytes` and `AsRef<[u8]>` impl (#1454) - `Reader::peek_into` (#1478) - `GeneralString` variant to `Tag` (#1512) - Conversions from `OctetString(Ref)` to `Vec`/`Bytes` (#1540) - Custom error types in derive macros (#1560) - Support for tags beyond 30 (#1651) - Const `::new` to `Length`, `BytesRef`, and `AnyRef` (#1713) - Const `GeneralizedTime::from_date_time` (#1718) - `Decode::from_der_partial` (#1725) - Conversions between `BitStringRef`/`OctetStringRef` and `[u8; N]` (#1731) - Add class bits consts for Application and Private tag support (#1721) - conversions between `heapless:Vec<u8>` and `OctetStringRef` (#1735) - `IsConstructed` trait, impl'ed on any `FixedTag` (#1744) - Implement `Hash` for `SetOf` (#1764) - Implement `Uint`/`Int` conversions from native types (#1762) - Support for `APPLICATION`, `CONTEXT-SPECIFIC` and `PRIVATE` tags (#1819, #1825, #1944) - Support `Cow<[u8]>` in `derive(Sequence)` (#1850) - `diagnostic::on_unimplemented` attributes (#1876) - `Reader::read_value`, auto-nest `DecodeValue` (#1877, #1895, #1897, #1901) - Indefinite length support for BER (#1884, #1885, #1894, #1900, #1902, #1910) - Constructed OctetString support (#1899, #1922) - string conversions, predicate methods for EncodingRules (#1903, #1953) - `Any::header` (#1935) - `Tag::RelativeOid` (#1942) - `ber` feature (#1948, #1950) - Hash derive for `StringOwned` and `Ia5String` (#1973) - Implement `DecodeValue/EncodeValue/Tagged` for `Cow` (#2093) - Add doc examples for `EncodeValue`, `Encode`, `DecodeValue`, `Decode`, `Error`, `ErrorKind`, `Tagged`, `FixedTag`, `IsConstructed`, `Tag`, `Length`, `Header` (#2075, #2071, #2070, #2064, #2058, #2052, #2053, #2051) - `SequenceRef::new` (#2224) ## Changed - Return `Tag::Integer.length_error()` on empty ints (#1400) - Allow all blanket impls on `?Sized` types (#1451) - Refactor `Tag::peek` (#1479) - Refactor `Header::peek` (#1480) - Use `core::error::Error` (#1553) - Use 2024 edition, bump MSRV to 1.85 (#1670) - Bump `const-oid` to v0.10 (#1676) - Reject zero lengths reads (#1716) - Deprecate `TagNumber::new` (#1727) - Use strict context-specific skipping condition (equal tag numbers only) (#1740) - Const `Any::to_ref`, `BytesOwned::to_ref` (#1797) - Return `ErrorKind::Noncanonical` in `EXPLICIT` when primitive (#1818) - Use `read_nested` to check length of `IMPLICIT` types (#1739) - Simplify `From<&UintRef<'a>>` for `Uint` (#1840) - Make `ObjectIdentifier<MAX_SIZE>` impls generic (#1851) - Extract `reader::position::Position` (#1880) - Make `Reader` cloneable (#1883) - Simplify `Header::peek` and `Tag::peek` (#1886) - Improve constructed bit handling (#1919) - Use fat pointer in `OctetStringRef`, consolidate bytes/string modules, improve internal ref types (#1920, #1921, #1998, #2040) - Change constructor `Header::new`, add `Header::with_length`, tests for constructed octet string (#1931, #1930) - Simplify `der_cmp` for `Length` (#1997) - Rename variable encoder -> writer and improve example (#2078) - Have `PemReader` decode to `Cow::Owned` (#2094) - Only sort `SET OF` types with `EncodingRules::Der` (#2219) - `SetOf` and `SequenceOf` now require `heapless` feature (#2220, #2229) ## Fixed - Append in `Encode::encode_to_vec` (#1760) - Derive optional OCTET/BIT STRING on `Option<&[u8]>` (#1737) - X.680 tag order: compare class and number first (#1790) - BMPString compatibility in derive macros (#1793) - `Tag::peek_optional` for 6-byte and 7+ byte tags (#1804) - `Header::peek` for 11-byte tag-lengths (#1828) - Panic in `value_cmp`: add `Iterator::size_hint` (#1830) - Error position tracking improvements (#1889, #2080, #2079) - Bound `Decode(Value)::Error` on `core::error::Error` (#2137) - Have `SetOf(Vec)::insert` check for duplicates (#2217) ## Removed - `TagNumber::N0..N30` consts (#1724) - 256MiB limit on `Length` (#1726) - Generic `<T>` from `Reader::finish` (#1833) - Deprecated `SetOf(Vec)::add` methods (#2232) - `SequenceRef` lifetime (#2224)

## Added - Custom error types support to the Decode and DecodeValue traits (#1055) - PrivateKeyInfoRef / PrivateKeyInfoOwned type aliases (#1483) - Implement core::error::Error trait for Error (#2302) - Implement DecodePrivateKey/EncodePrivateKey traits for PrivateKeyInfoOwned (#2306) - KeyError enum (#2305) - ctutils feature (#2308) - getrandom feature (#2311) ## Changed - Eagerly decode PEM labels for better error messages (#1163) - Use pbes2::Parameters::generate_recommended (#1430, #2296) - Make PrivateKeyInfo generic around its backing storage (#1483) - Bump rand_core to 0.9 (#1658) - Use 2024 edition; bump MSRV to 1.85 (#1670) - Bump rand_core to v0.10 (#2198) - Error::KeyMalformed now wraps an inner KeyError for providing more detail (#2305) - Use TryCryptoRng instead of CryptoRng (#2309) ## Removed - subtle feature (#2308)

tarcieri reviewed May 8, 2023
View reviewed changes

Comment threadder/src/ord.rs Outdated

turbocool3r force-pushed the custom-errors branch from 44ac421 to 33a17caCompare May 8, 2023 20:17

turbocool3r changed the title ~~Add custom error types to the Encode/Decode and (Der|Value)Ord traits.~~Add custom error types to the Decode and DecodeValue traits.May 8, 2023

turbocool3r mentioned this pull request Jan 22, 2024
der: add Error::(set_)source; remove Clone + Copy#1328
Merged

turbocool3r force-pushed the custom-errors branch 7 times, most recently from 1ff2bf5 to 5638fc3Compare January 23, 2024 21:13

turbocool3r force-pushed the custom-errors branch from 5638fc3 to 58468d3Compare January 23, 2024 21:26

turbocool3r marked this pull request as ready for review January 23, 2024 21:45

turbocool3r force-pushed the custom-errors branch from 58468d3 to 97bf668Compare February 14, 2024 20:20

turbocool3r added a commit to turbocool3r/signatures that referenced this pull request Feb 14, 2024
Add support for custom error types in der.
d9d394a
Goes in pair with [this](RustCrypto/formats#1055) PR to `formats`.

turbocool3r mentioned this pull request Feb 14, 2024
Add support for custom error types in der. RustCrypto/signatures#809
Merged

turbocool3r force-pushed the custom-errors branch from 97bf668 to d477874Compare February 14, 2024 20:37

baloo reviewed Feb 14, 2024
View reviewed changes

Comment threadCargo.toml Outdated

Add custom error types support to the Decode and DecodeValue traits.
b48d95d

turbocool3r force-pushed the custom-errors branch from d477874 to b48d95dCompare February 15, 2024 08:14

tarcieri approved these changes Mar 2, 2024
View reviewed changes

tarcieri merged commit c501837 into RustCrypto:masterMar 2, 2024

turbocool3r deleted the custom-errors branch March 3, 2024 07:28

turbocool3r restored the custom-errors branch March 3, 2024 16:26

turbocool3r added a commit to turbocool3r/signatures that referenced this pull request Mar 3, 2024
Add support for custom error types in der.
8620031
Goes in pair with [this](RustCrypto/formats#1055) PR to `formats`.

tarcieri pushed a commit to RustCrypto/signatures that referenced this pull request Mar 3, 2024
dsa+ecdsa: supportdercustom error types (#809)
31838b9
Goes with this `formats` PR: RustCrypto/formats#1055

turbocool3r deleted the custom-errors branch March 6, 2024 17:29

tarcieri mentioned this pull request Mar 28, 2024
Revert "der: add Error::(set_)source; remove Clone + Copy (#1328)" #1371
Merged

baloo added a commit to baloo/formats that referenced this pull request Mar 28, 2024
der: fixup windows write_secret_file helper
63fd014
This signature was missed in RustCrypto#1055

baloo mentioned this pull request Mar 28, 2024
der: fixup windows write_secret_file helper #1372
Merged

baloo added a commit that referenced this pull request Mar 28, 2024
der: fixup windowswrite_secret_filehelper (#1372)
c03c066
This signature was missed in #1055

tarcieri mentioned this pull request Aug 18, 2024
der: Support custom error types. #1053
Closed

scv35 pushed a commit to scv35/Signature-algorithms that referenced this pull request Jul 4, 2025
dsa+ecdsa: support der custom error types (#809)
d72b5e7
Goes with this `formats` PR: RustCrypto/formats#1055

tarcieri mentioned this pull request Feb 13, 2026
der v0.8.0 #2234
Merged

tarcieri mentioned this pull request Apr 27, 2026
pkcs8 v0.11.0 #2314
Merged

Uh oh!

Conversation

turbocool3r commented May 8, 2023

Uh oh!

tarcieri commented May 8, 2023

Uh oh!

Uh oh!

turbocool3r commented May 8, 2023

Uh oh!

tarcieri commented Jan 21, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tarcieri commented Jan 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

turbocool3r commented Jan 22, 2024

Uh oh!

turbocool3r commented Jan 23, 2024

Uh oh!

tarcieri commented Jan 23, 2024

Uh oh!

turbocool3r commented Jan 23, 2024

Uh oh!

tarcieri commented Jan 23, 2024

Uh oh!

turbocool3r commented Jan 23, 2024

Uh oh!

turbocool3r commented Jan 23, 2024

Uh oh!

turbocool3r commented Feb 13, 2024

Uh oh!

tarcieri commented Feb 13, 2024

Uh oh!

turbocool3r commented Feb 14, 2024

Uh oh!

tarcieri commented Feb 14, 2024

Uh oh!

turbocool3r commented Feb 14, 2024

Uh oh!

tarcieri commented Feb 14, 2024

Uh oh!

turbocool3r commented Feb 14, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tarcieri commented Jan 21, 2024•
edited
Loading

tarcieri commented Jan 22, 2024•
edited
Loading