Skip to content

der: fix BER IMPLICIT constructed octet string - #1922

Merged
tarcieri merged 7 commits into
RustCrypto:masterfrom
dishmaker:dishmaker/der_implicit_constructed_octet_string
Jul 9, 2025
Merged

der: fix BER IMPLICIT constructed octet string#1922
tarcieri merged 7 commits into
RustCrypto:masterfrom
dishmaker:dishmaker/der_implicit_constructed_octet_string

Conversation

@dishmaker

@dishmakerdishmaker commented Jul 8, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Ignores the encoding shall be constructed if the base encoding is constructed when using BER.

Issue reported in #779

tarcieri
tarcieri reviewed Jul 8, 2025
View reviewed changes
Comment threadder/src/bytes.rs Outdated
@dishmaker
dishmaker marked this pull request as ready for review July 8, 2025 18:28
@dishmaker

dishmaker commented Jul 8, 2025

Copy link
Copy Markdown
ContributorAuthor

@dwhjames is this correct? I added inner_tag: Tag (that would be OctetString)
and is different from header.tag: Tag (which would be ContextSpecific)

tarcieri
tarcieri reviewed Jul 8, 2025
View reviewed changes
Comment threadder/src/length/indefinite.rs Outdated
tarcieri
tarcieri reviewed Jul 9, 2025
View reviewed changes
Comment threadder/src/bytes.rs
})
}
/// Decodes [`BytesOwned`] as DER, or from parts, when using a BER reader.
pub fn decode_value_parts<'a, R: Reader<'a>>(

@tarcieritarcieriJul 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not wild about this name, but I can't think of a better one for now

@tarcieri
tarcieri merged commit 9c32817 into RustCrypto:masterJul 9, 2025
@tarcieritarcieri mentioned this pull request Jul 9, 2025
Closed
dwhjames
dwhjames reviewed Jul 9, 2025
View reviewed changes

@dwhjamesdwhjames left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor thing about the test strings

Comment threadder/src/asn1/octet_string.rs
Comment threadder/src/asn1/octet_string.rs
Comment threadder/src/asn1/octet_string.rs
@tarcieri

tarcieri commented Jul 9, 2025

Copy link
Copy Markdown
Member

@dishmaker can you submit a followup with those changes?

@dishmaker

dishmaker commented Jul 9, 2025

Copy link
Copy Markdown
ContributorAuthor

Followup in #1928

@tarcieritarcieri mentioned this pull request Feb 13, 2026
Merged
tarcieri added a commit that referenced this pull request Feb 13, 2026
@tarcieri
der v0.8.0 (#2234)
7784544
## Added
- Custom error types support to the `Decode` and `DecodeValue` traits (#1055)
- `EncodingRules` enum (#1321)
- `Decode::from_ber` (#1389)
- Documentation for field-level `tag_mode` attribute (#1401)
- `Hash` implementation for `AlgorithmIdentifier` (#1414)
- `SequenceRef::as_bytes` and `AsRef<[u8]>` impl (#1454)
- `Reader::peek_into` (#1478)
- `GeneralString` variant to `Tag` (#1512)
- Conversions from `OctetString(Ref)` to `Vec`/`Bytes` (#1540)
- Custom error types in derive macros (#1560)
- Support for tags beyond 30 (#1651)
- Const `::new` to `Length`, `BytesRef`, and `AnyRef` (#1713)
- Const `GeneralizedTime::from_date_time` (#1718)
- `Decode::from_der_partial` (#1725)
- Conversions between `BitStringRef`/`OctetStringRef` and `[u8; N]` (#1731)
- Add class bits consts for Application and Private tag support (#1721)
- conversions between `heapless:Vec<u8>` and `OctetStringRef` (#1735)
- `IsConstructed` trait, impl'ed on any `FixedTag` (#1744)
- Implement `Hash` for `SetOf` (#1764)
- Implement `Uint`/`Int` conversions from native types (#1762)
- Support for `APPLICATION`, `CONTEXT-SPECIFIC` and `PRIVATE` tags (#1819, #1825, #1944)
- Support `Cow<[u8]>` in `derive(Sequence)` (#1850)
- `diagnostic::on_unimplemented` attributes (#1876)
- `Reader::read_value`, auto-nest `DecodeValue` (#1877, #1895, #1897, #1901)
- Indefinite length support for BER (#1884, #1885, #1894, #1900, #1902, #1910)
- Constructed OctetString support (#1899, #1922)
- string conversions, predicate methods for EncodingRules (#1903, #1953)
- `Any::header` (#1935)
- `Tag::RelativeOid` (#1942)
- `ber` feature (#1948, #1950)
- Hash derive for `StringOwned` and `Ia5String` (#1973)
- Implement `DecodeValue/EncodeValue/Tagged` for `Cow` (#2093)
- Add doc examples for `EncodeValue`, `Encode`, `DecodeValue`, `Decode`, `Error`, `ErrorKind`, `Tagged`, `FixedTag`,
`IsConstructed`, `Tag`, `Length`, `Header` (#2075, #2071, #2070, #2064, #2058, #2052, #2053, #2051)
- `SequenceRef::new` (#2224)
## Changed
- Return `Tag::Integer.length_error()` on empty ints (#1400)
- Allow all blanket impls on `?Sized` types (#1451)
- Refactor `Tag::peek` (#1479)
- Refactor `Header::peek` (#1480)
- Use `core::error::Error` (#1553)
- Use 2024 edition, bump MSRV to 1.85 (#1670)
- Bump `const-oid` to v0.10 (#1676)
- Reject zero lengths reads (#1716)
- Deprecate `TagNumber::new` (#1727)
- Use strict context-specific skipping condition (equal tag numbers only) (#1740)
- Const `Any::to_ref`, `BytesOwned::to_ref` (#1797)
- Return `ErrorKind::Noncanonical` in `EXPLICIT` when primitive (#1818)
- Use `read_nested` to check length of `IMPLICIT` types (#1739)
- Simplify `From<&UintRef<'a>>` for `Uint` (#1840)
- Make `ObjectIdentifier<MAX_SIZE>` impls generic (#1851)
- Extract `reader::position::Position` (#1880)
- Make `Reader` cloneable (#1883)
- Simplify `Header::peek` and `Tag::peek` (#1886)
- Improve constructed bit handling (#1919)
- Use fat pointer in `OctetStringRef`, consolidate bytes/string modules, improve internal ref types
(#1920, #1921, #1998, #2040)
- Change constructor `Header::new`, add `Header::with_length`, tests for constructed octet string (#1931, #1930)
- Simplify `der_cmp` for `Length` (#1997)
- Rename variable encoder -> writer and improve example (#2078)
- Have `PemReader` decode to `Cow::Owned` (#2094)
- Only sort `SET OF` types with `EncodingRules::Der` (#2219)
- `SetOf` and `SequenceOf` now require `heapless` feature (#2220, #2229)
## Fixed
- Append in `Encode::encode_to_vec` (#1760)
- Derive optional OCTET/BIT STRING on `Option<&[u8]>` (#1737)
- X.680 tag order: compare class and number first (#1790)
- BMPString compatibility in derive macros (#1793)
- `Tag::peek_optional` for 6-byte and 7+ byte tags (#1804)
- `Header::peek` for 11-byte tag-lengths (#1828)
- Panic in `value_cmp`: add `Iterator::size_hint` (#1830)
- Error position tracking improvements (#1889, #2080, #2079)
- Bound `Decode(Value)::Error` on `core::error::Error` (#2137)
- Have `SetOf(Vec)::insert` check for duplicates (#2217)
## Removed
- `TagNumber::N0..N30` consts (#1724)
- 256MiB limit on `Length` (#1726)
- Generic `<T>` from `Reader::finish` (#1833)
- Deprecated `SetOf(Vec)::add` methods (#2232)
- `SequenceRef` lifetime (#2224)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes
+1 more reviewer
@dwhjamesdwhjamesdwhjames left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dishmaker@tarcieri@dwhjames