Derived Version Structs by npmccallum · Pull Request #410 · RustCrypto/formats

npmccallum · 2022-02-10T16:10:43Z

add a derive macro for deriving enumerations that are tagged as INTEGER.
use the new macro for pkcs10::Version.
add x509::Version.

tarcieri · 2022-02-11T12:42:23Z

+#[proc_macro_derive(Integer)]
+#[proc_macro_error]
+pub fn derive_integer(input: TokenStream) -> TokenStream {
+ let input = parse_macro_input!(input as DeriveInput);
+ DeriveEnumerated::new(input, true).to_tokens().into()
 }


This seems like you're somewhat needlessly defining another proc macro which is ultimately just a 1-argument wrapper for Enumerated.
Integer is really not very descriptive name and kind of ambiguous here: what it's doing is mapping integers to enums, just like Enumerated.
I'd suggest just making the Enumerated macro more flexible instead.

Add I said before, I already tried that. But Rust doesn't remove the type-level attribute, so it is passed through to the final AST and generates a compile error.

That must've been a bug in your code, as I've written many proc macros that do that without issue, including this one (see TypeAttrs)

tarcieri · 2022-02-11T12:43:40Z

+ /// Whether or not to tag the enum as an integer
+ integer: bool,
+


This seems like an inextensible way to override the tag of an Enumerated, so why not just add a #[asn1(tag = "...")] argument instead that lets you override the ENUMERATED tag however you want? Then it could potentially work for more than just INTEGER.

npmccallum · 2022-02-11T17:49:39Z

@tarcieri I have implemented it with the attributes. However, the error I mentioned before has returned:

error: cannot find attribute `asn1` in this scope
--> pkcs10/src/version.rs:9:3
|
9 | #[asn1(type = "INTEGER")]
| ^^^^

This is because the derive macro outputs the asn1 attribute in the final AST. But Rust doesn't know about this attribute.

tarcieri · 2022-02-11T18:01:41Z

@npmccallum the problem is in the definition of the Enumerated proc macro:

https://github.com/RustCrypto/formats/blob/master/der/derive/src/lib.rs#L213-L218

#[proc_macro_derive(Enumerated)]#[proc_macro_error]pubfnderive_enumerated(input:TokenStream) -> TokenStream{let input = parse_macro_input!(input asDeriveInput);DeriveEnumerated::new(input).to_tokens().into()}

You'll need to notate that it accepts an asn1 attribute. Change:

#[proc_macro_derive(Enumerated)]

to

#[proc_macro_derive(Enumerated, attributes(asn1))]

npmccallum · 2022-02-11T18:08:31Z

@tarcieri THANK YOU! You have no idea how much I was pulling my hair out on that one.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum · 2022-02-11T18:18:19Z

@tarcieri This is ready for final review now.

tarcieri · 2022-02-11T19:15:45Z

+ if let Ok(Meta::List(MetaList { nested, .. })) = attr.parse_meta() {
+ for meta in nested {
+ if let NestedMeta::Meta(Meta::NameValue(nv)) = meta {
+ if nv.path.is_ident("type") {
+ if let Lit::Str(lit) = nv.lit {
+ match lit.value().as_str() {
+ "ENUMERATED" => integer = false,
+ "INTEGER" => integer = true,
+ s => abort!(lit, "`type = \"{}\"` is unsupported", s),
+ }
+ }
+ }
+ }
+ }
+ }


This is... less than ideal, but I have some ideas about how to refactor this along with attribute parsing in general which I can do in a followup PR.

npmccallum · 2022-02-10T16:10:43Z

add a derive macro for deriving enumerations that are tagged as INTEGER.
use the new macro for pkcs10::Version.
add x509::Version.

tarcieri · 2022-02-11T12:42:23Z

+#[proc_macro_derive(Integer)]
+#[proc_macro_error]
+pub fn derive_integer(input: TokenStream) -> TokenStream {
+ let input = parse_macro_input!(input as DeriveInput);
+ DeriveEnumerated::new(input, true).to_tokens().into()
 }


This seems like you're somewhat needlessly defining another proc macro which is ultimately just a 1-argument wrapper for Enumerated.
Integer is really not very descriptive name and kind of ambiguous here: what it's doing is mapping integers to enums, just like Enumerated.
I'd suggest just making the Enumerated macro more flexible instead.

Add I said before, I already tried that. But Rust doesn't remove the type-level attribute, so it is passed through to the final AST and generates a compile error.

That must've been a bug in your code, as I've written many proc macros that do that without issue, including this one (see TypeAttrs)

tarcieri · 2022-02-11T12:43:40Z

+ /// Whether or not to tag the enum as an integer
+ integer: bool,
+


This seems like an inextensible way to override the tag of an Enumerated, so why not just add a #[asn1(tag = "...")] argument instead that lets you override the ENUMERATED tag however you want? Then it could potentially work for more than just INTEGER.

npmccallum · 2022-02-11T17:49:39Z

@tarcieri I have implemented it with the attributes. However, the error I mentioned before has returned:

error: cannot find attribute `asn1` in this scope
--> pkcs10/src/version.rs:9:3
|
9 | #[asn1(type = "INTEGER")]
| ^^^^

This is because the derive macro outputs the asn1 attribute in the final AST. But Rust doesn't know about this attribute.

tarcieri · 2022-02-11T18:01:41Z

@npmccallum the problem is in the definition of the Enumerated proc macro:

https://github.com/RustCrypto/formats/blob/master/der/derive/src/lib.rs#L213-L218

#[proc_macro_derive(Enumerated)]#[proc_macro_error]pubfnderive_enumerated(input:TokenStream) -> TokenStream{let input = parse_macro_input!(input asDeriveInput);DeriveEnumerated::new(input).to_tokens().into()}

You'll need to notate that it accepts an asn1 attribute. Change:

#[proc_macro_derive(Enumerated)]

to

#[proc_macro_derive(Enumerated, attributes(asn1))]

npmccallum · 2022-02-11T18:08:31Z

@tarcieri THANK YOU! You have no idea how much I was pulling my hair out on that one.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum · 2022-02-11T18:18:19Z

@tarcieri This is ready for final review now.

tarcieri · 2022-02-11T19:15:45Z

+ if let Ok(Meta::List(MetaList { nested, .. })) = attr.parse_meta() {
+ for meta in nested {
+ if let NestedMeta::Meta(Meta::NameValue(nv)) = meta {
+ if nv.path.is_ident("type") {
+ if let Lit::Str(lit) = nv.lit {
+ match lit.value().as_str() {
+ "ENUMERATED" => integer = false,
+ "INTEGER" => integer = true,
+ s => abort!(lit, "`type = \"{}\"` is unsupported", s),
+ }
+ }
+ }
+ }
+ }
+ }


This is... less than ideal, but I have some ideas about how to refactor this along with attribute parsing in general which I can do in a followup PR.

npmccallum · 2022-02-10T16:10:43Z

add a derive macro for deriving enumerations that are tagged as INTEGER.
use the new macro for pkcs10::Version.
add x509::Version.

tarcieri · 2022-02-11T12:42:23Z

+#[proc_macro_derive(Integer)]
+#[proc_macro_error]
+pub fn derive_integer(input: TokenStream) -> TokenStream {
+ let input = parse_macro_input!(input as DeriveInput);
+ DeriveEnumerated::new(input, true).to_tokens().into()
 }


This seems like you're somewhat needlessly defining another proc macro which is ultimately just a 1-argument wrapper for Enumerated.
Integer is really not very descriptive name and kind of ambiguous here: what it's doing is mapping integers to enums, just like Enumerated.
I'd suggest just making the Enumerated macro more flexible instead.

Add I said before, I already tried that. But Rust doesn't remove the type-level attribute, so it is passed through to the final AST and generates a compile error.

That must've been a bug in your code, as I've written many proc macros that do that without issue, including this one (see TypeAttrs)

tarcieri · 2022-02-11T12:43:40Z

+ /// Whether or not to tag the enum as an integer
+ integer: bool,
+


This seems like an inextensible way to override the tag of an Enumerated, so why not just add a #[asn1(tag = "...")] argument instead that lets you override the ENUMERATED tag however you want? Then it could potentially work for more than just INTEGER.

npmccallum · 2022-02-11T17:49:39Z

@tarcieri I have implemented it with the attributes. However, the error I mentioned before has returned:

error: cannot find attribute `asn1` in this scope
--> pkcs10/src/version.rs:9:3
|
9 | #[asn1(type = "INTEGER")]
| ^^^^

This is because the derive macro outputs the asn1 attribute in the final AST. But Rust doesn't know about this attribute.

tarcieri · 2022-02-11T18:01:41Z

@npmccallum the problem is in the definition of the Enumerated proc macro:

https://github.com/RustCrypto/formats/blob/master/der/derive/src/lib.rs#L213-L218

#[proc_macro_derive(Enumerated)]#[proc_macro_error]pubfnderive_enumerated(input:TokenStream) -> TokenStream{let input = parse_macro_input!(input asDeriveInput);DeriveEnumerated::new(input).to_tokens().into()}

You'll need to notate that it accepts an asn1 attribute. Change:

#[proc_macro_derive(Enumerated)]

to

#[proc_macro_derive(Enumerated, attributes(asn1))]

npmccallum · 2022-02-11T18:08:31Z

@tarcieri THANK YOU! You have no idea how much I was pulling my hair out on that one.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum · 2022-02-11T18:18:19Z

@tarcieri This is ready for final review now.

tarcieri · 2022-02-11T19:15:45Z

+ if let Ok(Meta::List(MetaList { nested, .. })) = attr.parse_meta() {
+ for meta in nested {
+ if let NestedMeta::Meta(Meta::NameValue(nv)) = meta {
+ if nv.path.is_ident("type") {
+ if let Lit::Str(lit) = nv.lit {
+ match lit.value().as_str() {
+ "ENUMERATED" => integer = false,
+ "INTEGER" => integer = true,
+ s => abort!(lit, "`type = \"{}\"` is unsupported", s),
+ }
+ }
+ }
+ }
+ }
+ }


This is... less than ideal, but I have some ideas about how to refactor this along with attribute parsing in general which I can do in a followup PR.

npmccallum · 2022-02-10T16:10:43Z

add a derive macro for deriving enumerations that are tagged as INTEGER.
use the new macro for pkcs10::Version.
add x509::Version.

tarcieri · 2022-02-11T12:42:23Z

+#[proc_macro_derive(Integer)]
+#[proc_macro_error]
+pub fn derive_integer(input: TokenStream) -> TokenStream {
+ let input = parse_macro_input!(input as DeriveInput);
+ DeriveEnumerated::new(input, true).to_tokens().into()
 }


This seems like you're somewhat needlessly defining another proc macro which is ultimately just a 1-argument wrapper for Enumerated.
Integer is really not very descriptive name and kind of ambiguous here: what it's doing is mapping integers to enums, just like Enumerated.
I'd suggest just making the Enumerated macro more flexible instead.

Add I said before, I already tried that. But Rust doesn't remove the type-level attribute, so it is passed through to the final AST and generates a compile error.

That must've been a bug in your code, as I've written many proc macros that do that without issue, including this one (see TypeAttrs)

tarcieri · 2022-02-11T12:43:40Z

+ /// Whether or not to tag the enum as an integer
+ integer: bool,
+


This seems like an inextensible way to override the tag of an Enumerated, so why not just add a #[asn1(tag = "...")] argument instead that lets you override the ENUMERATED tag however you want? Then it could potentially work for more than just INTEGER.

npmccallum · 2022-02-11T17:49:39Z

@tarcieri I have implemented it with the attributes. However, the error I mentioned before has returned:

error: cannot find attribute `asn1` in this scope
--> pkcs10/src/version.rs:9:3
|
9 | #[asn1(type = "INTEGER")]
| ^^^^

This is because the derive macro outputs the asn1 attribute in the final AST. But Rust doesn't know about this attribute.

tarcieri · 2022-02-11T18:01:41Z

@npmccallum the problem is in the definition of the Enumerated proc macro:

https://github.com/RustCrypto/formats/blob/master/der/derive/src/lib.rs#L213-L218

#[proc_macro_derive(Enumerated)]#[proc_macro_error]pubfnderive_enumerated(input:TokenStream) -> TokenStream{let input = parse_macro_input!(input asDeriveInput);DeriveEnumerated::new(input).to_tokens().into()}

You'll need to notate that it accepts an asn1 attribute. Change:

#[proc_macro_derive(Enumerated)]

to

#[proc_macro_derive(Enumerated, attributes(asn1))]

npmccallum · 2022-02-11T18:08:31Z

@tarcieri THANK YOU! You have no idea how much I was pulling my hair out on that one.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum · 2022-02-11T18:18:19Z

@tarcieri This is ready for final review now.

tarcieri · 2022-02-11T19:15:45Z

+ if let Ok(Meta::List(MetaList { nested, .. })) = attr.parse_meta() {
+ for meta in nested {
+ if let NestedMeta::Meta(Meta::NameValue(nv)) = meta {
+ if nv.path.is_ident("type") {
+ if let Lit::Str(lit) = nv.lit {
+ match lit.value().as_str() {
+ "ENUMERATED" => integer = false,
+ "INTEGER" => integer = true,
+ s => abort!(lit, "`type = \"{}\"` is unsupported", s),
+ }
+ }
+ }
+ }
+ }
+ }


This is... less than ideal, but I have some ideas about how to refactor this along with attribute parsing in general which I can do in a followup PR.

npmccallum · 2022-02-10T16:10:43Z

add a derive macro for deriving enumerations that are tagged as INTEGER.
use the new macro for pkcs10::Version.
add x509::Version.

tarcieri · 2022-02-11T12:42:23Z

+#[proc_macro_derive(Integer)]
+#[proc_macro_error]
+pub fn derive_integer(input: TokenStream) -> TokenStream {
+ let input = parse_macro_input!(input as DeriveInput);
+ DeriveEnumerated::new(input, true).to_tokens().into()
 }


This seems like you're somewhat needlessly defining another proc macro which is ultimately just a 1-argument wrapper for Enumerated.
Integer is really not very descriptive name and kind of ambiguous here: what it's doing is mapping integers to enums, just like Enumerated.
I'd suggest just making the Enumerated macro more flexible instead.

Add I said before, I already tried that. But Rust doesn't remove the type-level attribute, so it is passed through to the final AST and generates a compile error.

That must've been a bug in your code, as I've written many proc macros that do that without issue, including this one (see TypeAttrs)

tarcieri · 2022-02-11T12:43:40Z

+ /// Whether or not to tag the enum as an integer
+ integer: bool,
+


This seems like an inextensible way to override the tag of an Enumerated, so why not just add a #[asn1(tag = "...")] argument instead that lets you override the ENUMERATED tag however you want? Then it could potentially work for more than just INTEGER.

npmccallum · 2022-02-11T17:49:39Z

@tarcieri I have implemented it with the attributes. However, the error I mentioned before has returned:

error: cannot find attribute `asn1` in this scope
--> pkcs10/src/version.rs:9:3
|
9 | #[asn1(type = "INTEGER")]
| ^^^^

This is because the derive macro outputs the asn1 attribute in the final AST. But Rust doesn't know about this attribute.

tarcieri · 2022-02-11T18:01:41Z

@npmccallum the problem is in the definition of the Enumerated proc macro:

https://github.com/RustCrypto/formats/blob/master/der/derive/src/lib.rs#L213-L218

#[proc_macro_derive(Enumerated)]#[proc_macro_error]pubfnderive_enumerated(input:TokenStream) -> TokenStream{let input = parse_macro_input!(input asDeriveInput);DeriveEnumerated::new(input).to_tokens().into()}

You'll need to notate that it accepts an asn1 attribute. Change:

#[proc_macro_derive(Enumerated)]

to

#[proc_macro_derive(Enumerated, attributes(asn1))]

npmccallum · 2022-02-11T18:08:31Z

@tarcieri THANK YOU! You have no idea how much I was pulling my hair out on that one.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum · 2022-02-11T18:18:19Z

@tarcieri This is ready for final review now.

tarcieri · 2022-02-11T19:15:45Z

+ if let Ok(Meta::List(MetaList { nested, .. })) = attr.parse_meta() {
+ for meta in nested {
+ if let NestedMeta::Meta(Meta::NameValue(nv)) = meta {
+ if nv.path.is_ident("type") {
+ if let Lit::Str(lit) = nv.lit {
+ match lit.value().as_str() {
+ "ENUMERATED" => integer = false,
+ "INTEGER" => integer = true,
+ s => abort!(lit, "`type = \"{}\"` is unsupported", s),
+ }
+ }
+ }
+ }
+ }
+ }


This is... less than ideal, but I have some ideas about how to refactor this along with attribute parsing in general which I can do in a followup PR.

npmccallum · 2022-02-10T16:10:43Z

add a derive macro for deriving enumerations that are tagged as INTEGER.
use the new macro for pkcs10::Version.
add x509::Version.

tarcieri · 2022-02-11T12:42:23Z

+#[proc_macro_derive(Integer)]
+#[proc_macro_error]
+pub fn derive_integer(input: TokenStream) -> TokenStream {
+ let input = parse_macro_input!(input as DeriveInput);
+ DeriveEnumerated::new(input, true).to_tokens().into()
 }


This seems like you're somewhat needlessly defining another proc macro which is ultimately just a 1-argument wrapper for Enumerated.
Integer is really not very descriptive name and kind of ambiguous here: what it's doing is mapping integers to enums, just like Enumerated.
I'd suggest just making the Enumerated macro more flexible instead.

Add I said before, I already tried that. But Rust doesn't remove the type-level attribute, so it is passed through to the final AST and generates a compile error.

That must've been a bug in your code, as I've written many proc macros that do that without issue, including this one (see TypeAttrs)

tarcieri · 2022-02-11T12:43:40Z

+ /// Whether or not to tag the enum as an integer
+ integer: bool,
+


This seems like an inextensible way to override the tag of an Enumerated, so why not just add a #[asn1(tag = "...")] argument instead that lets you override the ENUMERATED tag however you want? Then it could potentially work for more than just INTEGER.

npmccallum · 2022-02-11T17:49:39Z

@tarcieri I have implemented it with the attributes. However, the error I mentioned before has returned:

error: cannot find attribute `asn1` in this scope
--> pkcs10/src/version.rs:9:3
|
9 | #[asn1(type = "INTEGER")]
| ^^^^

This is because the derive macro outputs the asn1 attribute in the final AST. But Rust doesn't know about this attribute.

tarcieri · 2022-02-11T18:01:41Z

@npmccallum the problem is in the definition of the Enumerated proc macro:

https://github.com/RustCrypto/formats/blob/master/der/derive/src/lib.rs#L213-L218

#[proc_macro_derive(Enumerated)]#[proc_macro_error]pubfnderive_enumerated(input:TokenStream) -> TokenStream{let input = parse_macro_input!(input asDeriveInput);DeriveEnumerated::new(input).to_tokens().into()}

You'll need to notate that it accepts an asn1 attribute. Change:

#[proc_macro_derive(Enumerated)]

to

#[proc_macro_derive(Enumerated, attributes(asn1))]

npmccallum · 2022-02-11T18:08:31Z

@tarcieri THANK YOU! You have no idea how much I was pulling my hair out on that one.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum · 2022-02-11T18:18:19Z

@tarcieri This is ready for final review now.

tarcieri · 2022-02-11T19:15:45Z

+ if let Ok(Meta::List(MetaList { nested, .. })) = attr.parse_meta() {
+ for meta in nested {
+ if let NestedMeta::Meta(Meta::NameValue(nv)) = meta {
+ if nv.path.is_ident("type") {
+ if let Lit::Str(lit) = nv.lit {
+ match lit.value().as_str() {
+ "ENUMERATED" => integer = false,
+ "INTEGER" => integer = true,
+ s => abort!(lit, "`type = \"{}\"` is unsupported", s),
+ }
+ }
+ }
+ }
+ }
+ }


This is... less than ideal, but I have some ideas about how to refactor this along with attribute parsing in general which I can do in a followup PR.

npmccallum · 2022-02-10T16:10:43Z

add a derive macro for deriving enumerations that are tagged as INTEGER.
use the new macro for pkcs10::Version.
add x509::Version.

tarcieri · 2022-02-11T12:42:23Z

+#[proc_macro_derive(Integer)]
+#[proc_macro_error]
+pub fn derive_integer(input: TokenStream) -> TokenStream {
+ let input = parse_macro_input!(input as DeriveInput);
+ DeriveEnumerated::new(input, true).to_tokens().into()
 }


This seems like you're somewhat needlessly defining another proc macro which is ultimately just a 1-argument wrapper for Enumerated.
Integer is really not very descriptive name and kind of ambiguous here: what it's doing is mapping integers to enums, just like Enumerated.
I'd suggest just making the Enumerated macro more flexible instead.

Add I said before, I already tried that. But Rust doesn't remove the type-level attribute, so it is passed through to the final AST and generates a compile error.

That must've been a bug in your code, as I've written many proc macros that do that without issue, including this one (see TypeAttrs)

tarcieri · 2022-02-11T12:43:40Z

+ /// Whether or not to tag the enum as an integer
+ integer: bool,
+


This seems like an inextensible way to override the tag of an Enumerated, so why not just add a #[asn1(tag = "...")] argument instead that lets you override the ENUMERATED tag however you want? Then it could potentially work for more than just INTEGER.

npmccallum · 2022-02-11T17:49:39Z

@tarcieri I have implemented it with the attributes. However, the error I mentioned before has returned:

error: cannot find attribute `asn1` in this scope
--> pkcs10/src/version.rs:9:3
|
9 | #[asn1(type = "INTEGER")]
| ^^^^

This is because the derive macro outputs the asn1 attribute in the final AST. But Rust doesn't know about this attribute.

tarcieri · 2022-02-11T18:01:41Z

@npmccallum the problem is in the definition of the Enumerated proc macro:

https://github.com/RustCrypto/formats/blob/master/der/derive/src/lib.rs#L213-L218

#[proc_macro_derive(Enumerated)]#[proc_macro_error]pubfnderive_enumerated(input:TokenStream) -> TokenStream{let input = parse_macro_input!(input asDeriveInput);DeriveEnumerated::new(input).to_tokens().into()}

You'll need to notate that it accepts an asn1 attribute. Change:

#[proc_macro_derive(Enumerated)]

to

#[proc_macro_derive(Enumerated, attributes(asn1))]

npmccallum · 2022-02-11T18:08:31Z

@tarcieri THANK YOU! You have no idea how much I was pulling my hair out on that one.

Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum · 2022-02-11T18:18:19Z

@tarcieri This is ready for final review now.

tarcieri · 2022-02-11T19:15:45Z

+ if let Ok(Meta::List(MetaList { nested, .. })) = attr.parse_meta() {
+ for meta in nested {
+ if let NestedMeta::Meta(Meta::NameValue(nv)) = meta {
+ if nv.path.is_ident("type") {
+ if let Lit::Str(lit) = nv.lit {
+ match lit.value().as_str() {
+ "ENUMERATED" => integer = false,
+ "INTEGER" => integer = true,
+ s => abort!(lit, "`type = \"{}\"` is unsupported", s),
+ }
+ }
+ }
+ }
+ }
+ }


This is... less than ideal, but I have some ideas about how to refactor this along with attribute parsing in general which I can do in a followup PR.

npmccallum force-pushed the integer branch from ca3555d to 55bde59Compare February 10, 2022 17:39

This was referenced Feb 11, 2022
Large Cleanup of the x509 crate #414
Merged
x501+x509: CertificateDocument, X509Version, and more additions #393
Closed

tarcieri reviewed Feb 11, 2022
View reviewed changes

Scarjit mentioned this pull request Feb 11, 2022
pkcs8 & pkcs1 should not have duplicate implementations for Decodeable/Encodeable #419
Closed

npmccallum force-pushed the integer branch from 55bde59 to 8076a06Compare February 11, 2022 17:45

npmccallum force-pushed the integer branch from 8076a06 to 82e16dcCompare February 11, 2022 18:08

npmccallum added 3 commits February 11, 2022 13:12

der: allow #[asn1(type = "INTEGER")] on derive(Enumerated)
f6ee1a4
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Derive Integer for pkcs10::Version
ea00dfc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Add a Version enum to x509
fdc0dd5
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum force-pushed the integer branch from 82e16dc to fdc0dd5Compare February 11, 2022 18:12

tarcieri reviewed Feb 11, 2022
View reviewed changes

tarcieri approved these changes Feb 11, 2022
View reviewed changes

tarcieri merged commit 9c25616 into RustCrypto:masterFeb 11, 2022

npmccallum deleted the integer branch March 10, 2022 20:46

npmccallum force-pushed the integer branch from ca3555d to 55bde59Compare February 10, 2022 17:39

This was referenced Feb 11, 2022
Large Cleanup of the x509 crate #414
Merged
x501+x509: CertificateDocument, X509Version, and more additions #393
Closed

tarcieri reviewed Feb 11, 2022
View reviewed changes

Scarjit mentioned this pull request Feb 11, 2022
pkcs8 & pkcs1 should not have duplicate implementations for Decodeable/Encodeable #419
Closed

npmccallum force-pushed the integer branch from 55bde59 to 8076a06Compare February 11, 2022 17:45

npmccallum force-pushed the integer branch from 8076a06 to 82e16dcCompare February 11, 2022 18:08

npmccallum added 3 commits February 11, 2022 13:12

der: allow #[asn1(type = "INTEGER")] on derive(Enumerated)
f6ee1a4
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Derive Integer for pkcs10::Version
ea00dfc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Add a Version enum to x509
fdc0dd5
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum force-pushed the integer branch from 82e16dc to fdc0dd5Compare February 11, 2022 18:12

tarcieri reviewed Feb 11, 2022
View reviewed changes

tarcieri approved these changes Feb 11, 2022
View reviewed changes

tarcieri merged commit 9c25616 into RustCrypto:masterFeb 11, 2022

npmccallum deleted the integer branch March 10, 2022 20:46

npmccallum force-pushed the integer branch from ca3555d to 55bde59Compare February 10, 2022 17:39

This was referenced Feb 11, 2022
Large Cleanup of the x509 crate #414
Merged
x501+x509: CertificateDocument, X509Version, and more additions #393
Closed

tarcieri reviewed Feb 11, 2022
View reviewed changes

Scarjit mentioned this pull request Feb 11, 2022
pkcs8 & pkcs1 should not have duplicate implementations for Decodeable/Encodeable #419
Closed

npmccallum force-pushed the integer branch from 55bde59 to 8076a06Compare February 11, 2022 17:45

npmccallum force-pushed the integer branch from 8076a06 to 82e16dcCompare February 11, 2022 18:08

npmccallum added 3 commits February 11, 2022 13:12

der: allow #[asn1(type = "INTEGER")] on derive(Enumerated)
f6ee1a4
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Derive Integer for pkcs10::Version
ea00dfc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Add a Version enum to x509
fdc0dd5
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum force-pushed the integer branch from 82e16dc to fdc0dd5Compare February 11, 2022 18:12

tarcieri reviewed Feb 11, 2022
View reviewed changes

tarcieri approved these changes Feb 11, 2022
View reviewed changes

tarcieri merged commit 9c25616 into RustCrypto:masterFeb 11, 2022

npmccallum deleted the integer branch March 10, 2022 20:46

npmccallum force-pushed the integer branch from ca3555d to 55bde59Compare February 10, 2022 17:39

This was referenced Feb 11, 2022
Large Cleanup of the x509 crate #414
Merged
x501+x509: CertificateDocument, X509Version, and more additions #393
Closed

tarcieri reviewed Feb 11, 2022
View reviewed changes

Scarjit mentioned this pull request Feb 11, 2022
pkcs8 & pkcs1 should not have duplicate implementations for Decodeable/Encodeable #419
Closed

npmccallum force-pushed the integer branch from 55bde59 to 8076a06Compare February 11, 2022 17:45

npmccallum force-pushed the integer branch from 8076a06 to 82e16dcCompare February 11, 2022 18:08

npmccallum added 3 commits February 11, 2022 13:12

der: allow #[asn1(type = "INTEGER")] on derive(Enumerated)
f6ee1a4
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Derive Integer for pkcs10::Version
ea00dfc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Add a Version enum to x509
fdc0dd5
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum force-pushed the integer branch from 82e16dc to fdc0dd5Compare February 11, 2022 18:12

tarcieri reviewed Feb 11, 2022
View reviewed changes

tarcieri approved these changes Feb 11, 2022
View reviewed changes

tarcieri merged commit 9c25616 into RustCrypto:masterFeb 11, 2022

npmccallum deleted the integer branch March 10, 2022 20:46

npmccallum force-pushed the integer branch from ca3555d to 55bde59Compare February 10, 2022 17:39

This was referenced Feb 11, 2022
Large Cleanup of the x509 crate #414
Merged
x501+x509: CertificateDocument, X509Version, and more additions #393
Closed

tarcieri reviewed Feb 11, 2022
View reviewed changes

Scarjit mentioned this pull request Feb 11, 2022
pkcs8 & pkcs1 should not have duplicate implementations for Decodeable/Encodeable #419
Closed

npmccallum force-pushed the integer branch from 55bde59 to 8076a06Compare February 11, 2022 17:45

npmccallum force-pushed the integer branch from 8076a06 to 82e16dcCompare February 11, 2022 18:08

npmccallum added 3 commits February 11, 2022 13:12

der: allow #[asn1(type = "INTEGER")] on derive(Enumerated)
f6ee1a4
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Derive Integer for pkcs10::Version
ea00dfc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Add a Version enum to x509
fdc0dd5
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum force-pushed the integer branch from 82e16dc to fdc0dd5Compare February 11, 2022 18:12

tarcieri reviewed Feb 11, 2022
View reviewed changes

tarcieri approved these changes Feb 11, 2022
View reviewed changes

tarcieri merged commit 9c25616 into RustCrypto:masterFeb 11, 2022

npmccallum deleted the integer branch March 10, 2022 20:46

npmccallum force-pushed the integer branch from ca3555d to 55bde59Compare February 10, 2022 17:39

This was referenced Feb 11, 2022
Large Cleanup of the x509 crate #414
Merged
x501+x509: CertificateDocument, X509Version, and more additions #393
Closed

tarcieri reviewed Feb 11, 2022
View reviewed changes

Scarjit mentioned this pull request Feb 11, 2022
pkcs8 & pkcs1 should not have duplicate implementations for Decodeable/Encodeable #419
Closed

npmccallum force-pushed the integer branch from 55bde59 to 8076a06Compare February 11, 2022 17:45

npmccallum force-pushed the integer branch from 8076a06 to 82e16dcCompare February 11, 2022 18:08

npmccallum added 3 commits February 11, 2022 13:12

der: allow #[asn1(type = "INTEGER")] on derive(Enumerated)
f6ee1a4
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Derive Integer for pkcs10::Version
ea00dfc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Add a Version enum to x509
fdc0dd5
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum force-pushed the integer branch from 82e16dc to fdc0dd5Compare February 11, 2022 18:12

tarcieri reviewed Feb 11, 2022
View reviewed changes

tarcieri approved these changes Feb 11, 2022
View reviewed changes

tarcieri merged commit 9c25616 into RustCrypto:masterFeb 11, 2022

npmccallum deleted the integer branch March 10, 2022 20:46

npmccallum force-pushed the integer branch from ca3555d to 55bde59Compare February 10, 2022 17:39

This was referenced Feb 11, 2022
Large Cleanup of the x509 crate #414
Merged
x501+x509: CertificateDocument, X509Version, and more additions #393
Closed

tarcieri reviewed Feb 11, 2022
View reviewed changes

Scarjit mentioned this pull request Feb 11, 2022
pkcs8 & pkcs1 should not have duplicate implementations for Decodeable/Encodeable #419
Closed

npmccallum force-pushed the integer branch from 55bde59 to 8076a06Compare February 11, 2022 17:45

npmccallum force-pushed the integer branch from 8076a06 to 82e16dcCompare February 11, 2022 18:08

npmccallum added 3 commits February 11, 2022 13:12

der: allow #[asn1(type = "INTEGER")] on derive(Enumerated)
f6ee1a4
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Derive Integer for pkcs10::Version
ea00dfc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

Add a Version enum to x509
fdc0dd5
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>

npmccallum force-pushed the integer branch from 82e16dc to fdc0dd5Compare February 11, 2022 18:12

tarcieri reviewed Feb 11, 2022
View reviewed changes

tarcieri approved these changes Feb 11, 2022
View reviewed changes

tarcieri merged commit 9c25616 into RustCrypto:masterFeb 11, 2022

npmccallum deleted the integer branch March 10, 2022 20:46

		/// Whether or not to tag the enum as an integer
		integer: bool,

Uh oh!

Conversation

npmccallum commented Feb 10, 2022

Uh oh!

tarcieriFeb 11, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

npmccallum commented Feb 11, 2022

Uh oh!

tarcieri commented Feb 11, 2022

Uh oh!

npmccallum commented Feb 11, 2022

Uh oh!

npmccallum commented Feb 11, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

npmccallum commented Feb 10, 2022

Uh oh!

tarcieriFeb 11, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

npmccallum commented Feb 11, 2022

Uh oh!

tarcieri commented Feb 11, 2022

Uh oh!

npmccallum commented Feb 11, 2022

Uh oh!

npmccallum commented Feb 11, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

npmccallum commented Feb 10, 2022

Uh oh!

tarcieriFeb 11, 2022• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

npmccallum commented Feb 11, 2022

Uh oh!

tarcieriFeb 11, 2022•
edited
Loading

tarcieriFeb 11, 2022•
edited
Loading

tarcieriFeb 11, 2022•
edited
Loading

tarcieriFeb 11, 2022•
edited
Loading