Skip to content

Large Cleanup of the x509 crate - #414

Merged
tarcieri merged 28 commits into
RustCrypto:masterfrom
npmccallum:cleanup
Feb 16, 2022
Merged

Large Cleanup of the x509 crate#414
tarcieri merged 28 commits into
RustCrypto:masterfrom
npmccallum:cleanup

Conversation

@npmccallum

@npmccallumnpmccallum commented Feb 11, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR depends on:

Yes, there's a lot of commits here. However, this PR actually represents a significant reduction in code in the x509 crate without loss of functionality. All types are derived and there are no custom implementations.

@npmccallum
npmccallumforce-pushed the cleanup branch 4 times, most recently from c7478fb to 408abf9CompareFebruary 11, 2022 06:59
tarcieri
tarcieri reviewed Feb 11, 2022
View reviewed changes
Comment threadder/Cargo.toml Outdated
rust-version = "1.57"

[dependencies]
flagset = { version = "^0.4.3", optional = true }

@tarcieritarcieriFeb 11, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR incorporates #412 (and I'm guessing some of the others as well)?

BTW the ^ is redundant as Cargo defaults to that type of range comparison:

Suggested change
flagset = { version = "^0.4.3", optional = true }
flagset = { version = "0.4.3", optional = true }

@npmccallumnpmccallumFeb 11, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarcieri Yes. The description field at the top of the PR has check boxes for each of the dependency PRs.

@tarcieritarcieri mentioned this pull request Feb 11, 2022
Merged
@npmccallumnpmccallum mentioned this pull request Feb 11, 2022
Merged
@npmccallum

npmccallum commented Feb 11, 2022

Copy link
Copy Markdown
ContributorAuthor

I have moved the early part of this PR into #422 for independent review.

@npmccallum
npmccallumforce-pushed the cleanup branch 3 times, most recently from 484475e to 46d4a10CompareFebruary 11, 2022 21:21
@npmccallum

npmccallum commented Feb 11, 2022

Copy link
Copy Markdown
ContributorAuthor

@tarcieri@carl-wallace All the dependencies for this PR have now been merged. What remains in this PR is just moving types around to create a better hierarchical module structure and improving documentation. I think the best way to review this PR is to check it out and run cargo doc to inspect the layout.

@npmccallumnpmccallum mentioned this pull request Feb 11, 2022
Closed
@npmccallum
npmccallumforce-pushed the cleanup branch 3 times, most recently from 42f7617 to ac8f79bCompareFebruary 11, 2022 22:42
@npmccallum
x509: add new extension structure
85fd7f8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DirectoryString
f7743c7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::EdiPartyName
841056a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::OtherName
d000ea7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::GeneralName*
60e2c45
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DistributionPointName
0ec72da
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move oids to the pkix module
935c9e3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move AuthorityKeyIdentifier into the pkix module
e4bceb8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectKeyIdentifier into the pkix module
5689f81
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move KeyUsage into the pkix module
22fffc9
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CertificatePolicies into the pkix module
0561f13
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyMapping* into the pkix module
90a6dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectAltName into the pkix module
5eb9dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move IssuerAltName into the pkix module
cb7820f
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectDirectoryAttributes into the pkix module
d754a02
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move BasicConstraints into the pkix module
3af14ee
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move NameConstraints into the pkix module
ebc7174
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyConstraints into the pkix module
490eff3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move ExtendedKeyUsage into the pkix module
d5873c8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move InhibitAnyPolicy into the pkix module
46fc96a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move *InfoAccessSyntax into the pkix module
1382e52
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PrivateKeyUsagePeriod into the pkix module
98d11c6
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PivNaciIndicator into the ext module
2313628
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move OcspNoCheck into the ext module
b962ab8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CRL types into the pkix module
50180bd
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@ScarjitScarjit mentioned this pull request Feb 14, 2022
Closed
@npmccallum

npmccallum commented Feb 15, 2022

Copy link
Copy Markdown
ContributorAuthor

@tarcieri Any progress on this? I have more types to add, but I want to add them to the post-reorg structure.

tarcieri
tarcieri reviewed Feb 15, 2022
View reviewed changes
Comment threadx509/src/lib.rs Outdated
tarcieri
tarcieri reviewed Feb 15, 2022
View reviewed changes
Comment threadx509/src/ext/mod.rs
@npmccallum
Update module conventions to the "new" style
8eff67c
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
npmccallumforce-pushed the cleanup branch 3 times, most recently from 9a210fb to a50dc37CompareFebruary 16, 2022 13:06
@npmccallum
x509: rearrange top-level types
8860860
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: rename anchor module
24e4e36
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri
tarcieri reviewed Feb 16, 2022
View reviewed changes
Comment threadx509/src/lib.rs
@@ -1,4 +1,4 @@
#![no_std]
#![cfg_attr(not(test), no_std)]

@tarcieritarcieriFeb 16, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason for this? I couldn't see why it was needed.

The main problem with doing this is potential build failures for std-dependent (or std prelude-dependent) features that you only see when doing cargo build that are masked when doing cargo test

@npmccallumnpmccallumFeb 16, 2022

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it because tests didn't run without it. But I forget why. I can investigate this afternoon.

tarcieri
tarcieri approved these changes Feb 16, 2022
View reviewed changes

@tarcieritarcieri left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go ahead and approve this. Can take a look at the tests separately.

@tarcieri
tarcieri merged commit 0018228 into RustCrypto:masterFeb 16, 2022
@npmccallum
npmccallum deleted the cleanup branch March 10, 2022 20:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@npmccallum@tarcieri
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Large Cleanup of the x509 crate by npmccallum · Pull Request #414 · RustCrypto/formats · GitHub
Skip to content
Large Cleanup of the x509 crate - #414
Merged
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Feb 16, 2022
Merged
Large Cleanup of the x509 crate#414
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Conversation
@npmccallum
@npmccallumnpmccallum
commented
Feb 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR depends on:
Yes, there's a lot of commits here. However, this PR actually represents a significant reduction in code in the x509 crate without loss of functionality. All types are derived and there are no custom implementations.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
4 times, most recently
from
c7478fb to
408abf9CompareFebruary 11, 2022 06:59
tarcieri
tarcieri
reviewed
Feb 11, 2022
View reviewed changes
Comment threadder/Cargo.toml
Outdated

rust-version = "1.57"

[dependencies]
flagset = { version = "^0.4.3", optional = true }
@tarcieritarcieriFeb 11, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR incorporates #412 (and I'm guessing some of the others as well)?
BTW the ^ is redundant as Cargo defaults to that type of range comparison:

Suggested change

flagset = { version = "^0.4.3", optional = true }
flagset = { version = "0.4.3", optional = true }
@npmccallumnpmccallumFeb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarcieri Yes. The description field at the top of the PR has check boxes for each of the dependency PRs.
@tarcieritarcieri
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I have moved the early part of this PR into #422 for independent review.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
484475e to
46d4a10CompareFebruary 11, 2022 21:21
@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri@carl-wallace All the dependencies for this PR have now been merged. What remains in this PR is just moving types around to create a better hierarchical module structure and improving documentation. I think the best way to review this PR is to check it out and run cargo doc to inspect the layout.
@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Closed

@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
42f7617 to
ac8f79bCompareFebruary 11, 2022 22:42
@npmccallum
x509: add new extension structure
85fd7f8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DirectoryString
f7743c7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::EdiPartyName
841056a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::OtherName
d000ea7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::GeneralName*
60e2c45
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DistributionPointName
0ec72da
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move oids to the pkix module
935c9e3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move AuthorityKeyIdentifier into the pkix module
e4bceb8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectKeyIdentifier into the pkix module
5689f81
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move KeyUsage into the pkix module
22fffc9
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CertificatePolicies into the pkix module
0561f13
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyMapping* into the pkix module
90a6dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectAltName into the pkix module
5eb9dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move IssuerAltName into the pkix module
cb7820f
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectDirectoryAttributes into the pkix module
d754a02
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move BasicConstraints into the pkix module
3af14ee
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move NameConstraints into the pkix module
ebc7174
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyConstraints into the pkix module
490eff3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move ExtendedKeyUsage into the pkix module
d5873c8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move InhibitAnyPolicy into the pkix module
46fc96a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move *InfoAccessSyntax into the pkix module
1382e52
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PrivateKeyUsagePeriod into the pkix module
98d11c6
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PivNaciIndicator into the ext module
2313628
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move OcspNoCheck into the ext module
b962ab8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CRL types into the pkix module
50180bd
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@ScarjitScarjit
mentioned this pull request
Feb 14, 2022
 Closed

@npmccallum
npmccallum
commented
Feb 15, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri Any progress on this? I have more types to add, but I want to add them to the post-reorg structure.
tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/lib.rs
Outdated

tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/ext/mod.rs
@npmccallum
Update module conventions to the "new" style
8eff67c
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
9a210fb to
a50dc37CompareFebruary 16, 2022 13:06
@npmccallum
x509: rearrange top-level types
8860860
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: rename anchor module
24e4e36
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri
tarcieri
reviewed
Feb 16, 2022
View reviewed changes
Comment threadx509/src/lib.rs
@@ -1,4 +1,4 @@
#![no_std]
#![cfg_attr(not(test), no_std)]
@tarcieritarcieriFeb 16, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason for this? I couldn't see why it was needed.
The main problem with doing this is potential build failures for std-dependent (or std prelude-dependent) features that you only see when doing cargo build that are masked when doing cargo test
@npmccallumnpmccallumFeb 16, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it because tests didn't run without it. But I forget why. I can investigate this afternoon.
tarcieri
tarcieri
approved these changes
Feb 16, 2022
View reviewed changes
@tarcieritarcieri
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go ahead and approve this. Can take a look at the tests separately.
@tarcieri
tarcieri
merged commit 0018228
into
RustCrypto:masterFeb 16, 2022
@npmccallum
npmccallum
deleted the

cleanup

branch
March 10, 2022 20:46
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@npmccallum@tarcieri

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Large Cleanup of the x509 crate by npmccallum · Pull Request #414 · RustCrypto/formats · GitHub
Skip to content
Large Cleanup of the x509 crate - #414
Merged
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Feb 16, 2022
Merged
Large Cleanup of the x509 crate#414
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Conversation
@npmccallum
@npmccallumnpmccallum
commented
Feb 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR depends on:
Yes, there's a lot of commits here. However, this PR actually represents a significant reduction in code in the x509 crate without loss of functionality. All types are derived and there are no custom implementations.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
4 times, most recently
from
c7478fb to
408abf9CompareFebruary 11, 2022 06:59
tarcieri
tarcieri
reviewed
Feb 11, 2022
View reviewed changes
Comment threadder/Cargo.toml
Outdated

rust-version = "1.57"

[dependencies]
flagset = { version = "^0.4.3", optional = true }
@tarcieritarcieriFeb 11, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR incorporates #412 (and I'm guessing some of the others as well)?
BTW the ^ is redundant as Cargo defaults to that type of range comparison:

Suggested change

flagset = { version = "^0.4.3", optional = true }
flagset = { version = "0.4.3", optional = true }
@npmccallumnpmccallumFeb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarcieri Yes. The description field at the top of the PR has check boxes for each of the dependency PRs.
@tarcieritarcieri
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I have moved the early part of this PR into #422 for independent review.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
484475e to
46d4a10CompareFebruary 11, 2022 21:21
@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri@carl-wallace All the dependencies for this PR have now been merged. What remains in this PR is just moving types around to create a better hierarchical module structure and improving documentation. I think the best way to review this PR is to check it out and run cargo doc to inspect the layout.
@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Closed

@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
42f7617 to
ac8f79bCompareFebruary 11, 2022 22:42
@npmccallum
x509: add new extension structure
85fd7f8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DirectoryString
f7743c7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::EdiPartyName
841056a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::OtherName
d000ea7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::GeneralName*
60e2c45
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DistributionPointName
0ec72da
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move oids to the pkix module
935c9e3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move AuthorityKeyIdentifier into the pkix module
e4bceb8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectKeyIdentifier into the pkix module
5689f81
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move KeyUsage into the pkix module
22fffc9
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CertificatePolicies into the pkix module
0561f13
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyMapping* into the pkix module
90a6dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectAltName into the pkix module
5eb9dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move IssuerAltName into the pkix module
cb7820f
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectDirectoryAttributes into the pkix module
d754a02
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move BasicConstraints into the pkix module
3af14ee
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move NameConstraints into the pkix module
ebc7174
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyConstraints into the pkix module
490eff3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move ExtendedKeyUsage into the pkix module
d5873c8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move InhibitAnyPolicy into the pkix module
46fc96a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move *InfoAccessSyntax into the pkix module
1382e52
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PrivateKeyUsagePeriod into the pkix module
98d11c6
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PivNaciIndicator into the ext module
2313628
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move OcspNoCheck into the ext module
b962ab8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CRL types into the pkix module
50180bd
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@ScarjitScarjit
mentioned this pull request
Feb 14, 2022
 Closed

@npmccallum
npmccallum
commented
Feb 15, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri Any progress on this? I have more types to add, but I want to add them to the post-reorg structure.
tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/lib.rs
Outdated

tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/ext/mod.rs
@npmccallum
Update module conventions to the "new" style
8eff67c
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
9a210fb to
a50dc37CompareFebruary 16, 2022 13:06
@npmccallum
x509: rearrange top-level types
8860860
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: rename anchor module
24e4e36
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri
tarcieri
reviewed
Feb 16, 2022
View reviewed changes
Comment threadx509/src/lib.rs
@@ -1,4 +1,4 @@
#![no_std]
#![cfg_attr(not(test), no_std)]
@tarcieritarcieriFeb 16, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason for this? I couldn't see why it was needed.
The main problem with doing this is potential build failures for std-dependent (or std prelude-dependent) features that you only see when doing cargo build that are masked when doing cargo test
@npmccallumnpmccallumFeb 16, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it because tests didn't run without it. But I forget why. I can investigate this afternoon.
tarcieri
tarcieri
approved these changes
Feb 16, 2022
View reviewed changes
@tarcieritarcieri
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go ahead and approve this. Can take a look at the tests separately.
@tarcieri
tarcieri
merged commit 0018228
into
RustCrypto:masterFeb 16, 2022
@npmccallum
npmccallum
deleted the

cleanup

branch
March 10, 2022 20:46
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@npmccallum@tarcieri

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Large Cleanup of the x509 crate by npmccallum · Pull Request #414 · RustCrypto/formats · GitHub
Skip to content
Large Cleanup of the x509 crate - #414
Merged
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Feb 16, 2022
Merged
Large Cleanup of the x509 crate#414
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Conversation
@npmccallum
@npmccallumnpmccallum
commented
Feb 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR depends on:
Yes, there's a lot of commits here. However, this PR actually represents a significant reduction in code in the x509 crate without loss of functionality. All types are derived and there are no custom implementations.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
4 times, most recently
from
c7478fb to
408abf9CompareFebruary 11, 2022 06:59
tarcieri
tarcieri
reviewed
Feb 11, 2022
View reviewed changes
Comment threadder/Cargo.toml
Outdated

rust-version = "1.57"

[dependencies]
flagset = { version = "^0.4.3", optional = true }
@tarcieritarcieriFeb 11, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR incorporates #412 (and I'm guessing some of the others as well)?
BTW the ^ is redundant as Cargo defaults to that type of range comparison:

Suggested change

flagset = { version = "^0.4.3", optional = true }
flagset = { version = "0.4.3", optional = true }
@npmccallumnpmccallumFeb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarcieri Yes. The description field at the top of the PR has check boxes for each of the dependency PRs.
@tarcieritarcieri
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I have moved the early part of this PR into #422 for independent review.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
484475e to
46d4a10CompareFebruary 11, 2022 21:21
@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri@carl-wallace All the dependencies for this PR have now been merged. What remains in this PR is just moving types around to create a better hierarchical module structure and improving documentation. I think the best way to review this PR is to check it out and run cargo doc to inspect the layout.
@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Closed

@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
42f7617 to
ac8f79bCompareFebruary 11, 2022 22:42
@npmccallum
x509: add new extension structure
85fd7f8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DirectoryString
f7743c7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::EdiPartyName
841056a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::OtherName
d000ea7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::GeneralName*
60e2c45
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DistributionPointName
0ec72da
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move oids to the pkix module
935c9e3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move AuthorityKeyIdentifier into the pkix module
e4bceb8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectKeyIdentifier into the pkix module
5689f81
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move KeyUsage into the pkix module
22fffc9
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CertificatePolicies into the pkix module
0561f13
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyMapping* into the pkix module
90a6dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectAltName into the pkix module
5eb9dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move IssuerAltName into the pkix module
cb7820f
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectDirectoryAttributes into the pkix module
d754a02
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move BasicConstraints into the pkix module
3af14ee
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move NameConstraints into the pkix module
ebc7174
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyConstraints into the pkix module
490eff3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move ExtendedKeyUsage into the pkix module
d5873c8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move InhibitAnyPolicy into the pkix module
46fc96a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move *InfoAccessSyntax into the pkix module
1382e52
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PrivateKeyUsagePeriod into the pkix module
98d11c6
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PivNaciIndicator into the ext module
2313628
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move OcspNoCheck into the ext module
b962ab8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CRL types into the pkix module
50180bd
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@ScarjitScarjit
mentioned this pull request
Feb 14, 2022
 Closed

@npmccallum
npmccallum
commented
Feb 15, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri Any progress on this? I have more types to add, but I want to add them to the post-reorg structure.
tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/lib.rs
Outdated

tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/ext/mod.rs
@npmccallum
Update module conventions to the "new" style
8eff67c
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
9a210fb to
a50dc37CompareFebruary 16, 2022 13:06
@npmccallum
x509: rearrange top-level types
8860860
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: rename anchor module
24e4e36
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri
tarcieri
reviewed
Feb 16, 2022
View reviewed changes
Comment threadx509/src/lib.rs
@@ -1,4 +1,4 @@
#![no_std]
#![cfg_attr(not(test), no_std)]
@tarcieritarcieriFeb 16, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason for this? I couldn't see why it was needed.
The main problem with doing this is potential build failures for std-dependent (or std prelude-dependent) features that you only see when doing cargo build that are masked when doing cargo test
@npmccallumnpmccallumFeb 16, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it because tests didn't run without it. But I forget why. I can investigate this afternoon.
tarcieri
tarcieri
approved these changes
Feb 16, 2022
View reviewed changes
@tarcieritarcieri
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go ahead and approve this. Can take a look at the tests separately.
@tarcieri
tarcieri
merged commit 0018228
into
RustCrypto:masterFeb 16, 2022
@npmccallum
npmccallum
deleted the

cleanup

branch
March 10, 2022 20:46
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@npmccallum@tarcieri

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Large Cleanup of the x509 crate by npmccallum · Pull Request #414 · RustCrypto/formats · GitHub
Skip to content
Large Cleanup of the x509 crate - #414
Merged
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Feb 16, 2022
Merged
Large Cleanup of the x509 crate#414
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Conversation
@npmccallum
@npmccallumnpmccallum
commented
Feb 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR depends on:
Yes, there's a lot of commits here. However, this PR actually represents a significant reduction in code in the x509 crate without loss of functionality. All types are derived and there are no custom implementations.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
4 times, most recently
from
c7478fb to
408abf9CompareFebruary 11, 2022 06:59
tarcieri
tarcieri
reviewed
Feb 11, 2022
View reviewed changes
Comment threadder/Cargo.toml
Outdated

rust-version = "1.57"

[dependencies]
flagset = { version = "^0.4.3", optional = true }
@tarcieritarcieriFeb 11, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR incorporates #412 (and I'm guessing some of the others as well)?
BTW the ^ is redundant as Cargo defaults to that type of range comparison:

Suggested change

flagset = { version = "^0.4.3", optional = true }
flagset = { version = "0.4.3", optional = true }
@npmccallumnpmccallumFeb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarcieri Yes. The description field at the top of the PR has check boxes for each of the dependency PRs.
@tarcieritarcieri
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I have moved the early part of this PR into #422 for independent review.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
484475e to
46d4a10CompareFebruary 11, 2022 21:21
@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri@carl-wallace All the dependencies for this PR have now been merged. What remains in this PR is just moving types around to create a better hierarchical module structure and improving documentation. I think the best way to review this PR is to check it out and run cargo doc to inspect the layout.
@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Closed

@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
42f7617 to
ac8f79bCompareFebruary 11, 2022 22:42
@npmccallum
x509: add new extension structure
85fd7f8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DirectoryString
f7743c7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::EdiPartyName
841056a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::OtherName
d000ea7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::GeneralName*
60e2c45
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DistributionPointName
0ec72da
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move oids to the pkix module
935c9e3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move AuthorityKeyIdentifier into the pkix module
e4bceb8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectKeyIdentifier into the pkix module
5689f81
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move KeyUsage into the pkix module
22fffc9
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CertificatePolicies into the pkix module
0561f13
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyMapping* into the pkix module
90a6dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectAltName into the pkix module
5eb9dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move IssuerAltName into the pkix module
cb7820f
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectDirectoryAttributes into the pkix module
d754a02
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move BasicConstraints into the pkix module
3af14ee
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move NameConstraints into the pkix module
ebc7174
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyConstraints into the pkix module
490eff3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move ExtendedKeyUsage into the pkix module
d5873c8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move InhibitAnyPolicy into the pkix module
46fc96a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move *InfoAccessSyntax into the pkix module
1382e52
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PrivateKeyUsagePeriod into the pkix module
98d11c6
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PivNaciIndicator into the ext module
2313628
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move OcspNoCheck into the ext module
b962ab8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CRL types into the pkix module
50180bd
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@ScarjitScarjit
mentioned this pull request
Feb 14, 2022
 Closed

@npmccallum
npmccallum
commented
Feb 15, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri Any progress on this? I have more types to add, but I want to add them to the post-reorg structure.
tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/lib.rs
Outdated

tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/ext/mod.rs
@npmccallum
Update module conventions to the "new" style
8eff67c
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
9a210fb to
a50dc37CompareFebruary 16, 2022 13:06
@npmccallum
x509: rearrange top-level types
8860860
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: rename anchor module
24e4e36
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri
tarcieri
reviewed
Feb 16, 2022
View reviewed changes
Comment threadx509/src/lib.rs
@@ -1,4 +1,4 @@
#![no_std]
#![cfg_attr(not(test), no_std)]
@tarcieritarcieriFeb 16, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason for this? I couldn't see why it was needed.
The main problem with doing this is potential build failures for std-dependent (or std prelude-dependent) features that you only see when doing cargo build that are masked when doing cargo test
@npmccallumnpmccallumFeb 16, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it because tests didn't run without it. But I forget why. I can investigate this afternoon.
tarcieri
tarcieri
approved these changes
Feb 16, 2022
View reviewed changes
@tarcieritarcieri
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go ahead and approve this. Can take a look at the tests separately.
@tarcieri
tarcieri
merged commit 0018228
into
RustCrypto:masterFeb 16, 2022
@npmccallum
npmccallum
deleted the

cleanup

branch
March 10, 2022 20:46
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@npmccallum@tarcieri

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Large Cleanup of the x509 crate by npmccallum · Pull Request #414 · RustCrypto/formats · GitHub
Skip to content
Large Cleanup of the x509 crate - #414
Merged
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Feb 16, 2022
Merged
Large Cleanup of the x509 crate#414
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Conversation
@npmccallum
@npmccallumnpmccallum
commented
Feb 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR depends on:
Yes, there's a lot of commits here. However, this PR actually represents a significant reduction in code in the x509 crate without loss of functionality. All types are derived and there are no custom implementations.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
4 times, most recently
from
c7478fb to
408abf9CompareFebruary 11, 2022 06:59
tarcieri
tarcieri
reviewed
Feb 11, 2022
View reviewed changes
Comment threadder/Cargo.toml
Outdated

rust-version = "1.57"

[dependencies]
flagset = { version = "^0.4.3", optional = true }
@tarcieritarcieriFeb 11, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR incorporates #412 (and I'm guessing some of the others as well)?
BTW the ^ is redundant as Cargo defaults to that type of range comparison:

Suggested change

flagset = { version = "^0.4.3", optional = true }
flagset = { version = "0.4.3", optional = true }
@npmccallumnpmccallumFeb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarcieri Yes. The description field at the top of the PR has check boxes for each of the dependency PRs.
@tarcieritarcieri
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I have moved the early part of this PR into #422 for independent review.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
484475e to
46d4a10CompareFebruary 11, 2022 21:21
@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri@carl-wallace All the dependencies for this PR have now been merged. What remains in this PR is just moving types around to create a better hierarchical module structure and improving documentation. I think the best way to review this PR is to check it out and run cargo doc to inspect the layout.
@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Closed

@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
42f7617 to
ac8f79bCompareFebruary 11, 2022 22:42
@npmccallum
x509: add new extension structure
85fd7f8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DirectoryString
f7743c7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::EdiPartyName
841056a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::OtherName
d000ea7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::GeneralName*
60e2c45
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DistributionPointName
0ec72da
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move oids to the pkix module
935c9e3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move AuthorityKeyIdentifier into the pkix module
e4bceb8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectKeyIdentifier into the pkix module
5689f81
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move KeyUsage into the pkix module
22fffc9
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CertificatePolicies into the pkix module
0561f13
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyMapping* into the pkix module
90a6dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectAltName into the pkix module
5eb9dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move IssuerAltName into the pkix module
cb7820f
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectDirectoryAttributes into the pkix module
d754a02
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move BasicConstraints into the pkix module
3af14ee
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move NameConstraints into the pkix module
ebc7174
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyConstraints into the pkix module
490eff3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move ExtendedKeyUsage into the pkix module
d5873c8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move InhibitAnyPolicy into the pkix module
46fc96a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move *InfoAccessSyntax into the pkix module
1382e52
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PrivateKeyUsagePeriod into the pkix module
98d11c6
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PivNaciIndicator into the ext module
2313628
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move OcspNoCheck into the ext module
b962ab8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CRL types into the pkix module
50180bd
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@ScarjitScarjit
mentioned this pull request
Feb 14, 2022
 Closed

@npmccallum
npmccallum
commented
Feb 15, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri Any progress on this? I have more types to add, but I want to add them to the post-reorg structure.
tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/lib.rs
Outdated

tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/ext/mod.rs
@npmccallum
Update module conventions to the "new" style
8eff67c
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
9a210fb to
a50dc37CompareFebruary 16, 2022 13:06
@npmccallum
x509: rearrange top-level types
8860860
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: rename anchor module
24e4e36
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri
tarcieri
reviewed
Feb 16, 2022
View reviewed changes
Comment threadx509/src/lib.rs
@@ -1,4 +1,4 @@
#![no_std]
#![cfg_attr(not(test), no_std)]
@tarcieritarcieriFeb 16, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason for this? I couldn't see why it was needed.
The main problem with doing this is potential build failures for std-dependent (or std prelude-dependent) features that you only see when doing cargo build that are masked when doing cargo test
@npmccallumnpmccallumFeb 16, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it because tests didn't run without it. But I forget why. I can investigate this afternoon.
tarcieri
tarcieri
approved these changes
Feb 16, 2022
View reviewed changes
@tarcieritarcieri
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go ahead and approve this. Can take a look at the tests separately.
@tarcieri
tarcieri
merged commit 0018228
into
RustCrypto:masterFeb 16, 2022
@npmccallum
npmccallum
deleted the

cleanup

branch
March 10, 2022 20:46
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@npmccallum@tarcieri

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Large Cleanup of the x509 crate by npmccallum · Pull Request #414 · RustCrypto/formats · GitHub
Skip to content
Large Cleanup of the x509 crate - #414
Merged
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Feb 16, 2022
Merged
Large Cleanup of the x509 crate#414
tarcieri merged 28 commits into
RustCrypto:masterfrom 
npmccallum:cleanup
Conversation
@npmccallum
@npmccallumnpmccallum
commented
Feb 11, 2022•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR depends on:
Yes, there's a lot of commits here. However, this PR actually represents a significant reduction in code in the x509 crate without loss of functionality. All types are derived and there are no custom implementations.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
4 times, most recently
from
c7478fb to
408abf9CompareFebruary 11, 2022 06:59
tarcieri
tarcieri
reviewed
Feb 11, 2022
View reviewed changes
Comment threadder/Cargo.toml
Outdated

rust-version = "1.57"

[dependencies]
flagset = { version = "^0.4.3", optional = true }
@tarcieritarcieriFeb 11, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this PR incorporates #412 (and I'm guessing some of the others as well)?
BTW the ^ is redundant as Cargo defaults to that type of range comparison:

Suggested change

flagset = { version = "^0.4.3", optional = true }
flagset = { version = "0.4.3", optional = true }
@npmccallumnpmccallumFeb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tarcieri Yes. The description field at the top of the PR has check boxes for each of the dependency PRs.
@tarcieritarcieri
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Merged

@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
I have moved the early part of this PR into #422 for independent review.
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
484475e to
46d4a10CompareFebruary 11, 2022 21:21
@npmccallum
npmccallum
commented
Feb 11, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri@carl-wallace All the dependencies for this PR have now been merged. What remains in this PR is just moving types around to create a better hierarchical module structure and improving documentation. I think the best way to review this PR is to check it out and run cargo doc to inspect the layout.
@npmccallumnpmccallum
mentioned this pull request
Feb 11, 2022
 Closed

@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
42f7617 to
ac8f79bCompareFebruary 11, 2022 22:42
@npmccallum
x509: add new extension structure
85fd7f8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DirectoryString
f7743c7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::EdiPartyName
841056a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::OtherName
d000ea7
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::GeneralName*
60e2c45
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: add ext::pkix::name::DistributionPointName
0ec72da
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move oids to the pkix module
935c9e3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move AuthorityKeyIdentifier into the pkix module
e4bceb8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectKeyIdentifier into the pkix module
5689f81
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move KeyUsage into the pkix module
22fffc9
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CertificatePolicies into the pkix module
0561f13
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyMapping* into the pkix module
90a6dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectAltName into the pkix module
5eb9dbc
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move IssuerAltName into the pkix module
cb7820f
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move SubjectDirectoryAttributes into the pkix module
d754a02
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move BasicConstraints into the pkix module
3af14ee
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move NameConstraints into the pkix module
ebc7174
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PolicyConstraints into the pkix module
490eff3
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move ExtendedKeyUsage into the pkix module
d5873c8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move InhibitAnyPolicy into the pkix module
46fc96a
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move *InfoAccessSyntax into the pkix module
1382e52
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PrivateKeyUsagePeriod into the pkix module
98d11c6
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move PivNaciIndicator into the ext module
2313628
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move OcspNoCheck into the ext module
b962ab8
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: move CRL types into the pkix module
50180bd
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@ScarjitScarjit
mentioned this pull request
Feb 14, 2022
 Closed

@npmccallum
npmccallum
commented
Feb 15, 2022

Copy link


Copy Markdown

ContributorAuthor
@tarcieri Any progress on this? I have more types to add, but I want to add them to the post-reorg structure.
tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/lib.rs
Outdated

tarcieri
tarcieri
reviewed
Feb 15, 2022
View reviewed changes
Comment threadx509/src/ext/mod.rs
@npmccallum
Update module conventions to the "new" style
8eff67c
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
npmccallumforce-pushed
the
cleanup
branch
3 times, most recently
from
9a210fb to
a50dc37CompareFebruary 16, 2022 13:06
@npmccallum
x509: rearrange top-level types
8860860
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
@npmccallum
x509: rename anchor module
24e4e36
Signed-off-by: Nathaniel McCallum <nathaniel@profian.com>
tarcieri
tarcieri
reviewed
Feb 16, 2022
View reviewed changes
Comment threadx509/src/lib.rs
@@ -1,4 +1,4 @@
#![no_std]
#![cfg_attr(not(test), no_std)]
@tarcieritarcieriFeb 16, 2022

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a specific reason for this? I couldn't see why it was needed.
The main problem with doing this is potential build failures for std-dependent (or std prelude-dependent) features that you only see when doing cargo build that are masked when doing cargo test
@npmccallumnpmccallumFeb 16, 2022

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it because tests didn't run without it. But I forget why. I can investigate this afternoon.
tarcieri
tarcieri
approved these changes
Feb 16, 2022
View reviewed changes
@tarcieritarcieri
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will go ahead and approve this. Can take a look at the tests separately.
@tarcieri
tarcieri
merged commit 0018228
into
RustCrypto:masterFeb 16, 2022
@npmccallum
npmccallum
deleted the

cleanup

branch
March 10, 2022 20:46
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tarcieritarcieritarcieri approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@npmccallum@tarcieri