Skip to content

x509-cert: make name an owned type - #771

Merged
tarcieri merged 9 commits into
RustCrypto:masterfrom
baloo:baloo/owned-api/v2-submit
Dec 13, 2022
Merged

x509-cert: make name an owned type#771
tarcieri merged 9 commits into
RustCrypto:masterfrom
baloo:baloo/owned-api/v2-submit

Conversation

@baloo

@baloobaloo commented Nov 27, 2022

Copy link
Copy Markdown
Member

NOTE: breaking change.

This changes x509 from a zero copy type to an owned type.
This brings along a rewrite of der::Any and a new der::ByteVec to come closer to der::ByteSlice backing der::AnyRef

@baloo

baloo commented Nov 27, 2022

Copy link
Copy Markdown
MemberAuthor

unlike #768 let's try a cleaner git history! :)

@baloo
balooforce-pushed the baloo/owned-api/v2-submit branch from 355f7bc to 3dd5e79CompareNovember 27, 2022 06:14
tarcieri
tarcieri reviewed Nov 27, 2022
View reviewed changes
Comment threadder/src/asn1/any.rs Outdated
tarcieri
tarcieri reviewed Nov 27, 2022
View reviewed changes
Comment threadder/src/asn1/any.rs Outdated
tarcieri
tarcieri reviewed Nov 27, 2022
View reviewed changes
Comment threadder/src/byte_vec.rs Outdated
tarcieri
tarcieri reviewed Nov 27, 2022
View reviewed changes
Comment threadder/src/byte_vec.rs Outdated
@baloo
balooforce-pushed the baloo/owned-api/v2-submit branch 4 times, most recently from 86b09c4 to 8dc0807CompareNovember 28, 2022 22:08
tarcieri
tarcieri reviewed Nov 28, 2022
View reviewed changes
Comment threadder/src/asn1/any.rs Outdated
@baloo
balooforce-pushed the baloo/owned-api/v2-submit branch from 8dc0807 to dccebd9CompareNovember 28, 2022 23:15
@baloobaloo mentioned this pull request Nov 30, 2022
Closed
@baloo
balooforce-pushed the baloo/owned-api/v2-submit branch from dccebd9 to 64947d9CompareDecember 13, 2022 18:58
@baloo
balooforce-pushed the baloo/owned-api/v2-submit branch from 64947d9 to 32cc657CompareDecember 13, 2022 19:14
@baloo
baloo requested a review from tarcieriDecember 13, 2022 20:34
tarcieri
tarcieri reviewed Dec 13, 2022
View reviewed changes
Comment threadder/src/asn1/any.rs Outdated
tarcieri
tarcieri reviewed Dec 13, 2022
View reviewed changes
Comment threadder/src/bytes.rs Outdated
@tarcieri
tarcieri merged commit 72ef39a into RustCrypto:masterDec 13, 2022
@baloo
baloo deleted the baloo/owned-api/v2-submit branch December 13, 2022 23:00
sorah added a commit to sorah/needroleshere that referenced this pull request Nov 4, 2023
@sorah
Roll dependency updates (Nov 2023)
9a16a3f
Resolve incompatibilities as follows:
- src/certificate.rs: RustCrypto/formats#771
- src/cmd/serve.rs: Move to FromRequestParts and use headers crate
- src/ecdsa_sha256.rs: RustCrypto/traits#1196
and RustCrypto/signatures#574
- src/error.rs: Remove Duplicates
- src/identity.rs: Remove owned validation logic as it should be done at
x509_cert::serial_number::SerialNumber<x509_cert::certificate::Rfc5280>
- src/sign.rs: RustCrypto/RSA#244
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarcieritarcieritarcieri left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baloo@tarcieri