Uh oh!
There was an error while loading. Please reload this page.
spki: make SubjectPublicKeyInfo own the public key - #778
Conversation
NOTE: breaking change. Previously `AlgorithmIdentifier::parameters` were always `AnyRef`. This commit changes them to a generic parameter `Params`. An alias `AlgorithmIdentifierRef` provides a type identical to the original with `AnyRef` as its `parameters`, which is used in all of the other crates in this repo.
6adaae7 to
1efe27aCompare| #[derive(Copy, Clone, Debug, Eq, PartialEq)] | ||
| pub struct SubjectPublicKeyInfo<'a, Params> { | ||
| #[derive(Clone, Debug, Eq, PartialEq)] | ||
| pub struct SubjectPublicKeyInfo<Params> { |
There was a problem hiding this comment.
This obviously doesn't work as this, the intention was to remove the lifetime from here, maybe I should add a parameter like
| pubstructSubjectPublicKeyInfo<Params>{ | |
| pubstructSubjectPublicKeyInfo<Params,Pkey>{ |
And consume that as a
SubjectPublicKeyInfo<Any,BitString> // Owned version
pub type SubjectPublicKeyInfoRef<'a> = SubjectPublicKeyInfo<AnyRef<'a>,BitStringRef<'a>> // zero copy versionThere was a problem hiding this comment.
It definitely needs a generic parameter so as to continue supporting a heapless profile.
I was thinking of using a generic Bits parameter with &[u8] and Box<[u8]> type aliased as you propose. The former could be aliased as something like type SubjectPublicKeyInfoOwned.
There's a potential argument to be made that using a BitString* type is semantically more correct, although I'm not aware of any public key formats which aren't octet-aligned.
There was a problem hiding this comment.
I went with BitString/BitStringRef to stick as close as possible to the RFC definition.
I can reuse the Bytes type I introduced in #771
tarcieri
commented
Nov 29, 2022
This was definitely my next planned followup to #769, but if you want to work on it in parallel that's cool. |
baloo
commented
Nov 29, 2022
haha :) I missed that! sorry. |
763cc8f to
b259658Compareb259658 to
25b9e19Compareb09ff11 to
d6741cbComparetarcieri
commented
Dec 11, 2022
@baloo this was closed by way of me deleting the |
baloo
commented
Dec 12, 2022
yup, that took me some time to clean my changes. |
This is based on #769