Uh oh!
There was an error while loading. Please reload this page.
lms: bump rand_core from 0.6 to 0.9.0 - #905
Closed
baloo wants to merge 1 commit into
Closed
Conversation
baloo
marked this pull request as draft
February 16, 2025 04:00
baloo
commented
Feb 16, 2025
| // Generate the message randomizer C | ||
| let mut c = <Output<Mode::Hasher>>::default(); | ||
| rng.fill_bytes(&mut c); | ||
| rng.try_fill_bytes(&mut c).map_err(|_| Error::new())?; |
MemberAuthor
There was a problem hiding this comment.
We kind of eat the error here. This might be a bad idea.
I wish we could do Error::from_source instead, but that would require the RandomizedSignerMut to change its signature to something like:
fn try_sign_with_rng<E: core:error::Error, R: TryCryptoRng<Error = E>>(
&mut self,
rng: &mut R,
msg: &[u8],
) -> Result<Signature<Mode>, Error> {
Not sure.
(see ecdsa where this happens too: #901 (comment))
balooforce-pushed
the
baloo/lms/rand_core-0.9
branch
from
February 16, 2025 04:13
0269b6e to
9655757Comparebaloo
marked this pull request as ready for review
February 16, 2025 04:13
balooforce-pushed
the
baloo/lms/rand_core-0.9
branch
from
February 20, 2025 19:09
9655757 to
8ceddf4Comparebalooforce-pushed
the
baloo/lms/rand_core-0.9
branch
from
February 20, 2025 21:08
8ceddf4 to
d6d4770Comparebaloo
commented
Feb 23, 2025
MemberAuthor
closed in favor of #913 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.