Uh oh!
There was an error while loading. Please reload this page.
Upgrade all crates to the 2024 edition and bump MSRV to 1.85 - #913
Conversation
436380a to
e6cdcfbCompare
baloo
left a comment
There was a problem hiding this comment.
Opinion about RandomizedSignerMut signature?
| // Generate the message randomizer C | ||
| let mut c = <Output<Mode::Hasher>>::default(); | ||
| rng.fill_bytes(&mut c); | ||
| rng.try_fill_bytes(&mut c).map_err(|_| Error::new())?; |
There was a problem hiding this comment.
We kind of eat the error here. This might be a bad idea.
I wish we could do Error::from_source instead, but that would require the RandomizedSignerMut to change its signature to something like:
fn try_sign_with_rng<E: core:error::Error, R: TryCryptoRng<Error = E>>(
&mut self,
rng: &mut R,
msg: &[u8],
) -> Result<Signature<Mode>, Error> {
``
Not sure.
There was a problem hiding this comment.
We can potentially consider something like that
| let z = bits2field::<C>(prehash)?; | ||
| let mut ad = FieldBytes::<C>::default(); | ||
| rng.fill_bytes(&mut ad); | ||
| rng.try_fill_bytes(&mut ad).map_err(|_| Error::new())?; |
2e419ca to
733b105Comparetarcieri
commented
Feb 24, 2025
@baloo can you rebase? |
309e627 to
9d6fe57Compare9a7625f to
6ad65c7Compareerik-3milabs
commented
Feb 24, 2025
Would it be possible to include new Currently,
I might be mistaken, but all I think needs to happen is:
If this is not the right place and/or time, I'm happy to create a separate issue for it :) |
tarcieri
commented
Feb 24, 2025
@erik-3milabs we generally do releases in separate PRs to keep ones like this focused |
Just to mitigate expectations, I don't know if we'll be able to release elliptic-curve until the situation of |
erik-3milabs
commented
Feb 27, 2025
In that case, would there be a point in raising an issue for this? |
tarcieri
commented
Feb 27, 2025
Sure, please open a separate issue |
baloo
commented
Feb 28, 2025
Anything else needed here? |
This currently excludes:
This depends on:
Sizedrequirements on Rng traits#1767rand_corefrom0.6.4to0.9.0crypto-bigint#762