fix(social): get_students 400s on nonexistent courses.user_id (#158) - #253

Closed
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column
Closed

fix(social): get_students 400s on nonexistent courses.user_id (#158)#253
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column

Conversation

@Jose-Gael-Cruz-Lopez

Copy link
Copy Markdown
Member

After the #12 course_id migration, courses is a shared catalog with no user_id (enrollment lives in user_courses). get_students ran table("courses").select("user_id,course_name") and indexed courses_by_user[c["user_id"]]. PostgREST rejects selecting a nonexistent column with HTTP 400 (column courses.user_id does not exist), so the entire students / class-intel endpoint errored — and it's live (frontend/src/lib/api.tsgetStudents).

Fix — backend/routes/social.py

Join through user_courses and embed the course name:

enrollment_rows=table("user_courses").select("user_id,courses(course_name)")
forrowinenrollment_rows:
course=row.get("courses")
name=course.get("course_name") ifisinstance(course, dict) elseNoneifname:
courses_by_user[row["user_id"]].append(name)

Tests — backend/tests/test_social_get_students.py

Verification

  • ruff check . clean; gated suite green (+3 new). The new tests fail against the pre-fix code (the catalog path yields no enrollments), confirming real coverage.

Closes#158.

@coderabbitai

coderabbitaiBot commented Jun 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 18 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c8aa414-96aa-4a5f-875b-2fb17bfe39d3

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and 3fc48bb.

📒 Files selected for processing (2)
  • backend/routes/social.py
  • backend/tests/test_social_get_students.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/social-get-students-courses-column

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 22, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitUpdated (UTC)
❌ Deployment failed
View logs
frontenda9f1dd5Jun 22 2026, 04:12 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 24, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging3fc48bbCommit Preview URL

Branch Preview URL
Jun 24 2026, 02:42 PM

@AndresL230

Copy link
Copy Markdown
Collaborator

Superseded by the DB modular redesign (#279). social.get_students (#158) is rewired in the analytics slice to read enrollments → course_offerings → courses. Closing as obsolete. Reopen if not fully covered.

@AndresL230

Copy link
Copy Markdown
Collaborator

Reopening. Closed as superseded by #279, but this is an app-logic bugfix (social.get_students 400 on nonexistent course, #158), not a DB-structure change. Keeping it open to confirm the fix is actually covered by the redesign's analytics slice before closing again — if the rewired get_students already handles the missing-course case, we can re-close with a pointer to that commit; otherwise this fix still stands.

@AndresL230

Copy link
Copy Markdown
Collaborator

Closing this as superseded — the bug it targets is already fixed on main, and issue #158 is closed.

To be clear up front: the diagnosis in this PR was correct when it was written.courses.user_id genuinely didn't exist and the endpoint genuinely 400'd. What happened is that the schema moved underneath the branch while it was open.

What superseded it

PR #270 (db/analytics-code: social.py offering re-keying, epic slice PR4 of the #279 DB modular redesign — merged 2026-06-24, commit 736abc1) rewrote get_students on main to walk the enrollment chain:

enrollment_rows=table("enrollments").select("user_id,course_offerings(courses(course_name))")
name_map=get_display_names([u["id"] foruinusers])

That's the same fix this PR set out to make, arrived at independently, plus the services/profiles.py name resolution.

Why it can't be merged forward

This branch carries migrations up to 0018; main is at 0030. The fix here targets the 0018-era schema, so rebasing wouldn't rescue it — it would swap one nonexistent reference for another:

  • user_courses no longer exists.0020_academics_split.sql:84 renamed it to enrollments. The new query would fail with a PostgREST "relation does not exist" (404) instead of the original 400 — still broken, different error.
  • The courses(course_name) embed can't resolve.0020:85 renamed course_idoffering_id, FK'd to course_offerings(id) (0020:73-74). There's no direct enrollments → courses relationship; it has to go through course_offerings.
  • users.name is gone.0024_identity_split.sql:25 dropped it; names moved to the encrypted user_profiles.name and resolve via get_display_names(). Reading it directly returns nothing.

GitHub already reports this as CONFLICTING on backend/routes/social.py, which is the two fixes colliding rather than ordinary drift.

The tests would need rewriting, not rebasing

tests/test_social_get_students.py pins the old schema — assert "user_courses" in recorder would fail against main's correct query. They also patch("routes.social.table") wholesale, so they'd pass against any table name and never reproduce the real PostgREST error.

Worth salvaging separately

One idea here is better than what's on main today: neither this PR nor main routes through services/academics.py, which the conventions call for — both hand-roll the embed. academics.py exposes user_offering_ids_for_course/offering_course_id but has no bulk "names for all enrollments" helper. Worth a follow-up ticket.

Also surfaced while reviewing, unrelated to this PR and present on main: get_students returns every user in the DB with their courses, mastery stats, and top concepts. It's authenticated but not scoped — the session user_id it fetches at social.py:426 is dead code. That looks intentional for a discovery surface, but it's a global cross-course disclosure worth an explicit decision.

Thanks @Jose-Gael-Cruz-Lopez — the analysis was right, the schema just moved. Closing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

social.get_students selects courses.user_id (nonexistent column) → students/class-intel endpoint 400s

2 participants

@Jose-Gael-Cruz-Lopez@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(social): get_students 400s on nonexistent courses.user_id (#158) - #253

Closed
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column
Closed

fix(social): get_students 400s on nonexistent courses.user_id (#158)#253
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column

Conversation

@Jose-Gael-Cruz-Lopez

Copy link
Copy Markdown
Member

After the #12 course_id migration, courses is a shared catalog with no user_id (enrollment lives in user_courses). get_students ran table("courses").select("user_id,course_name") and indexed courses_by_user[c["user_id"]]. PostgREST rejects selecting a nonexistent column with HTTP 400 (column courses.user_id does not exist), so the entire students / class-intel endpoint errored — and it's live (frontend/src/lib/api.tsgetStudents).

Fix — backend/routes/social.py

Join through user_courses and embed the course name:

enrollment_rows=table("user_courses").select("user_id,courses(course_name)")
forrowinenrollment_rows:
course=row.get("courses")
name=course.get("course_name") ifisinstance(course, dict) elseNoneifname:
courses_by_user[row["user_id"]].append(name)

Tests — backend/tests/test_social_get_students.py

Verification

  • ruff check . clean; gated suite green (+3 new). The new tests fail against the pre-fix code (the catalog path yields no enrollments), confirming real coverage.

Closes#158.

@coderabbitai

coderabbitaiBot commented Jun 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 18 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c8aa414-96aa-4a5f-875b-2fb17bfe39d3

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and 3fc48bb.

📒 Files selected for processing (2)
  • backend/routes/social.py
  • backend/tests/test_social_get_students.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/social-get-students-courses-column

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 22, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitUpdated (UTC)
❌ Deployment failed
View logs
frontenda9f1dd5Jun 22 2026, 04:12 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 24, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging3fc48bbCommit Preview URL

Branch Preview URL
Jun 24 2026, 02:42 PM

@AndresL230

Copy link
Copy Markdown
Collaborator

Superseded by the DB modular redesign (#279). social.get_students (#158) is rewired in the analytics slice to read enrollments → course_offerings → courses. Closing as obsolete. Reopen if not fully covered.

@AndresL230

Copy link
Copy Markdown
Collaborator

Reopening. Closed as superseded by #279, but this is an app-logic bugfix (social.get_students 400 on nonexistent course, #158), not a DB-structure change. Keeping it open to confirm the fix is actually covered by the redesign's analytics slice before closing again — if the rewired get_students already handles the missing-course case, we can re-close with a pointer to that commit; otherwise this fix still stands.

@AndresL230

Copy link
Copy Markdown
Collaborator

Closing this as superseded — the bug it targets is already fixed on main, and issue #158 is closed.

To be clear up front: the diagnosis in this PR was correct when it was written.courses.user_id genuinely didn't exist and the endpoint genuinely 400'd. What happened is that the schema moved underneath the branch while it was open.

What superseded it

PR #270 (db/analytics-code: social.py offering re-keying, epic slice PR4 of the #279 DB modular redesign — merged 2026-06-24, commit 736abc1) rewrote get_students on main to walk the enrollment chain:

enrollment_rows=table("enrollments").select("user_id,course_offerings(courses(course_name))")
name_map=get_display_names([u["id"] foruinusers])

That's the same fix this PR set out to make, arrived at independently, plus the services/profiles.py name resolution.

Why it can't be merged forward

This branch carries migrations up to 0018; main is at 0030. The fix here targets the 0018-era schema, so rebasing wouldn't rescue it — it would swap one nonexistent reference for another:

  • user_courses no longer exists.0020_academics_split.sql:84 renamed it to enrollments. The new query would fail with a PostgREST "relation does not exist" (404) instead of the original 400 — still broken, different error.
  • The courses(course_name) embed can't resolve.0020:85 renamed course_idoffering_id, FK'd to course_offerings(id) (0020:73-74). There's no direct enrollments → courses relationship; it has to go through course_offerings.
  • users.name is gone.0024_identity_split.sql:25 dropped it; names moved to the encrypted user_profiles.name and resolve via get_display_names(). Reading it directly returns nothing.

GitHub already reports this as CONFLICTING on backend/routes/social.py, which is the two fixes colliding rather than ordinary drift.

The tests would need rewriting, not rebasing

tests/test_social_get_students.py pins the old schema — assert "user_courses" in recorder would fail against main's correct query. They also patch("routes.social.table") wholesale, so they'd pass against any table name and never reproduce the real PostgREST error.

Worth salvaging separately

One idea here is better than what's on main today: neither this PR nor main routes through services/academics.py, which the conventions call for — both hand-roll the embed. academics.py exposes user_offering_ids_for_course/offering_course_id but has no bulk "names for all enrollments" helper. Worth a follow-up ticket.

Also surfaced while reviewing, unrelated to this PR and present on main: get_students returns every user in the DB with their courses, mastery stats, and top concepts. It's authenticated but not scoped — the session user_id it fetches at social.py:426 is dead code. That looks intentional for a discovery surface, but it's a global cross-course disclosure worth an explicit decision.

Thanks @Jose-Gael-Cruz-Lopez — the analysis was right, the schema just moved. Closing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

social.get_students selects courses.user_id (nonexistent column) → students/class-intel endpoint 400s

2 participants

@Jose-Gael-Cruz-Lopez@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(social): get_students 400s on nonexistent courses.user_id (#158) - #253

Closed
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column
Closed

fix(social): get_students 400s on nonexistent courses.user_id (#158)#253
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column

Conversation

@Jose-Gael-Cruz-Lopez

Copy link
Copy Markdown
Member

After the #12 course_id migration, courses is a shared catalog with no user_id (enrollment lives in user_courses). get_students ran table("courses").select("user_id,course_name") and indexed courses_by_user[c["user_id"]]. PostgREST rejects selecting a nonexistent column with HTTP 400 (column courses.user_id does not exist), so the entire students / class-intel endpoint errored — and it's live (frontend/src/lib/api.tsgetStudents).

Fix — backend/routes/social.py

Join through user_courses and embed the course name:

enrollment_rows=table("user_courses").select("user_id,courses(course_name)")
forrowinenrollment_rows:
course=row.get("courses")
name=course.get("course_name") ifisinstance(course, dict) elseNoneifname:
courses_by_user[row["user_id"]].append(name)

Tests — backend/tests/test_social_get_students.py

Verification

  • ruff check . clean; gated suite green (+3 new). The new tests fail against the pre-fix code (the catalog path yields no enrollments), confirming real coverage.

Closes#158.

@coderabbitai

coderabbitaiBot commented Jun 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 18 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c8aa414-96aa-4a5f-875b-2fb17bfe39d3

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and 3fc48bb.

📒 Files selected for processing (2)
  • backend/routes/social.py
  • backend/tests/test_social_get_students.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/social-get-students-courses-column

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 22, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitUpdated (UTC)
❌ Deployment failed
View logs
frontenda9f1dd5Jun 22 2026, 04:12 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 24, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging3fc48bbCommit Preview URL

Branch Preview URL
Jun 24 2026, 02:42 PM

@AndresL230

Copy link
Copy Markdown
Collaborator

Superseded by the DB modular redesign (#279). social.get_students (#158) is rewired in the analytics slice to read enrollments → course_offerings → courses. Closing as obsolete. Reopen if not fully covered.

@AndresL230

Copy link
Copy Markdown
Collaborator

Reopening. Closed as superseded by #279, but this is an app-logic bugfix (social.get_students 400 on nonexistent course, #158), not a DB-structure change. Keeping it open to confirm the fix is actually covered by the redesign's analytics slice before closing again — if the rewired get_students already handles the missing-course case, we can re-close with a pointer to that commit; otherwise this fix still stands.

@AndresL230

Copy link
Copy Markdown
Collaborator

Closing this as superseded — the bug it targets is already fixed on main, and issue #158 is closed.

To be clear up front: the diagnosis in this PR was correct when it was written.courses.user_id genuinely didn't exist and the endpoint genuinely 400'd. What happened is that the schema moved underneath the branch while it was open.

What superseded it

PR #270 (db/analytics-code: social.py offering re-keying, epic slice PR4 of the #279 DB modular redesign — merged 2026-06-24, commit 736abc1) rewrote get_students on main to walk the enrollment chain:

enrollment_rows=table("enrollments").select("user_id,course_offerings(courses(course_name))")
name_map=get_display_names([u["id"] foruinusers])

That's the same fix this PR set out to make, arrived at independently, plus the services/profiles.py name resolution.

Why it can't be merged forward

This branch carries migrations up to 0018; main is at 0030. The fix here targets the 0018-era schema, so rebasing wouldn't rescue it — it would swap one nonexistent reference for another:

  • user_courses no longer exists.0020_academics_split.sql:84 renamed it to enrollments. The new query would fail with a PostgREST "relation does not exist" (404) instead of the original 400 — still broken, different error.
  • The courses(course_name) embed can't resolve.0020:85 renamed course_idoffering_id, FK'd to course_offerings(id) (0020:73-74). There's no direct enrollments → courses relationship; it has to go through course_offerings.
  • users.name is gone.0024_identity_split.sql:25 dropped it; names moved to the encrypted user_profiles.name and resolve via get_display_names(). Reading it directly returns nothing.

GitHub already reports this as CONFLICTING on backend/routes/social.py, which is the two fixes colliding rather than ordinary drift.

The tests would need rewriting, not rebasing

tests/test_social_get_students.py pins the old schema — assert "user_courses" in recorder would fail against main's correct query. They also patch("routes.social.table") wholesale, so they'd pass against any table name and never reproduce the real PostgREST error.

Worth salvaging separately

One idea here is better than what's on main today: neither this PR nor main routes through services/academics.py, which the conventions call for — both hand-roll the embed. academics.py exposes user_offering_ids_for_course/offering_course_id but has no bulk "names for all enrollments" helper. Worth a follow-up ticket.

Also surfaced while reviewing, unrelated to this PR and present on main: get_students returns every user in the DB with their courses, mastery stats, and top concepts. It's authenticated but not scoped — the session user_id it fetches at social.py:426 is dead code. That looks intentional for a discovery surface, but it's a global cross-course disclosure worth an explicit decision.

Thanks @Jose-Gael-Cruz-Lopez — the analysis was right, the schema just moved. Closing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

social.get_students selects courses.user_id (nonexistent column) → students/class-intel endpoint 400s

2 participants

@Jose-Gael-Cruz-Lopez@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(social): get_students 400s on nonexistent courses.user_id (#158) - #253

Closed
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column
Closed

fix(social): get_students 400s on nonexistent courses.user_id (#158)#253
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column

Conversation

@Jose-Gael-Cruz-Lopez

Copy link
Copy Markdown
Member

After the #12 course_id migration, courses is a shared catalog with no user_id (enrollment lives in user_courses). get_students ran table("courses").select("user_id,course_name") and indexed courses_by_user[c["user_id"]]. PostgREST rejects selecting a nonexistent column with HTTP 400 (column courses.user_id does not exist), so the entire students / class-intel endpoint errored — and it's live (frontend/src/lib/api.tsgetStudents).

Fix — backend/routes/social.py

Join through user_courses and embed the course name:

enrollment_rows=table("user_courses").select("user_id,courses(course_name)")
forrowinenrollment_rows:
course=row.get("courses")
name=course.get("course_name") ifisinstance(course, dict) elseNoneifname:
courses_by_user[row["user_id"]].append(name)

Tests — backend/tests/test_social_get_students.py

Verification

  • ruff check . clean; gated suite green (+3 new). The new tests fail against the pre-fix code (the catalog path yields no enrollments), confirming real coverage.

Closes#158.

@coderabbitai

coderabbitaiBot commented Jun 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 18 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c8aa414-96aa-4a5f-875b-2fb17bfe39d3

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and 3fc48bb.

📒 Files selected for processing (2)
  • backend/routes/social.py
  • backend/tests/test_social_get_students.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/social-get-students-courses-column

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 22, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitUpdated (UTC)
❌ Deployment failed
View logs
frontenda9f1dd5Jun 22 2026, 04:12 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 24, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging3fc48bbCommit Preview URL

Branch Preview URL
Jun 24 2026, 02:42 PM

@AndresL230

Copy link
Copy Markdown
Collaborator

Superseded by the DB modular redesign (#279). social.get_students (#158) is rewired in the analytics slice to read enrollments → course_offerings → courses. Closing as obsolete. Reopen if not fully covered.

@AndresL230

Copy link
Copy Markdown
Collaborator

Reopening. Closed as superseded by #279, but this is an app-logic bugfix (social.get_students 400 on nonexistent course, #158), not a DB-structure change. Keeping it open to confirm the fix is actually covered by the redesign's analytics slice before closing again — if the rewired get_students already handles the missing-course case, we can re-close with a pointer to that commit; otherwise this fix still stands.

@AndresL230

Copy link
Copy Markdown
Collaborator

Closing this as superseded — the bug it targets is already fixed on main, and issue #158 is closed.

To be clear up front: the diagnosis in this PR was correct when it was written.courses.user_id genuinely didn't exist and the endpoint genuinely 400'd. What happened is that the schema moved underneath the branch while it was open.

What superseded it

PR #270 (db/analytics-code: social.py offering re-keying, epic slice PR4 of the #279 DB modular redesign — merged 2026-06-24, commit 736abc1) rewrote get_students on main to walk the enrollment chain:

enrollment_rows=table("enrollments").select("user_id,course_offerings(courses(course_name))")
name_map=get_display_names([u["id"] foruinusers])

That's the same fix this PR set out to make, arrived at independently, plus the services/profiles.py name resolution.

Why it can't be merged forward

This branch carries migrations up to 0018; main is at 0030. The fix here targets the 0018-era schema, so rebasing wouldn't rescue it — it would swap one nonexistent reference for another:

  • user_courses no longer exists.0020_academics_split.sql:84 renamed it to enrollments. The new query would fail with a PostgREST "relation does not exist" (404) instead of the original 400 — still broken, different error.
  • The courses(course_name) embed can't resolve.0020:85 renamed course_idoffering_id, FK'd to course_offerings(id) (0020:73-74). There's no direct enrollments → courses relationship; it has to go through course_offerings.
  • users.name is gone.0024_identity_split.sql:25 dropped it; names moved to the encrypted user_profiles.name and resolve via get_display_names(). Reading it directly returns nothing.

GitHub already reports this as CONFLICTING on backend/routes/social.py, which is the two fixes colliding rather than ordinary drift.

The tests would need rewriting, not rebasing

tests/test_social_get_students.py pins the old schema — assert "user_courses" in recorder would fail against main's correct query. They also patch("routes.social.table") wholesale, so they'd pass against any table name and never reproduce the real PostgREST error.

Worth salvaging separately

One idea here is better than what's on main today: neither this PR nor main routes through services/academics.py, which the conventions call for — both hand-roll the embed. academics.py exposes user_offering_ids_for_course/offering_course_id but has no bulk "names for all enrollments" helper. Worth a follow-up ticket.

Also surfaced while reviewing, unrelated to this PR and present on main: get_students returns every user in the DB with their courses, mastery stats, and top concepts. It's authenticated but not scoped — the session user_id it fetches at social.py:426 is dead code. That looks intentional for a discovery surface, but it's a global cross-course disclosure worth an explicit decision.

Thanks @Jose-Gael-Cruz-Lopez — the analysis was right, the schema just moved. Closing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

social.get_students selects courses.user_id (nonexistent column) → students/class-intel endpoint 400s

2 participants

@Jose-Gael-Cruz-Lopez@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(social): get_students 400s on nonexistent courses.user_id (#158) - #253

Closed
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column
Closed

fix(social): get_students 400s on nonexistent courses.user_id (#158)#253
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column

Conversation

@Jose-Gael-Cruz-Lopez

Copy link
Copy Markdown
Member

After the #12 course_id migration, courses is a shared catalog with no user_id (enrollment lives in user_courses). get_students ran table("courses").select("user_id,course_name") and indexed courses_by_user[c["user_id"]]. PostgREST rejects selecting a nonexistent column with HTTP 400 (column courses.user_id does not exist), so the entire students / class-intel endpoint errored — and it's live (frontend/src/lib/api.tsgetStudents).

Fix — backend/routes/social.py

Join through user_courses and embed the course name:

enrollment_rows=table("user_courses").select("user_id,courses(course_name)")
forrowinenrollment_rows:
course=row.get("courses")
name=course.get("course_name") ifisinstance(course, dict) elseNoneifname:
courses_by_user[row["user_id"]].append(name)

Tests — backend/tests/test_social_get_students.py

Verification

  • ruff check . clean; gated suite green (+3 new). The new tests fail against the pre-fix code (the catalog path yields no enrollments), confirming real coverage.

Closes#158.

@coderabbitai

coderabbitaiBot commented Jun 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 18 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c8aa414-96aa-4a5f-875b-2fb17bfe39d3

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and 3fc48bb.

📒 Files selected for processing (2)
  • backend/routes/social.py
  • backend/tests/test_social_get_students.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/social-get-students-courses-column

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 22, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitUpdated (UTC)
❌ Deployment failed
View logs
frontenda9f1dd5Jun 22 2026, 04:12 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 24, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging3fc48bbCommit Preview URL

Branch Preview URL
Jun 24 2026, 02:42 PM

@AndresL230

Copy link
Copy Markdown
Collaborator

Superseded by the DB modular redesign (#279). social.get_students (#158) is rewired in the analytics slice to read enrollments → course_offerings → courses. Closing as obsolete. Reopen if not fully covered.

@AndresL230

Copy link
Copy Markdown
Collaborator

Reopening. Closed as superseded by #279, but this is an app-logic bugfix (social.get_students 400 on nonexistent course, #158), not a DB-structure change. Keeping it open to confirm the fix is actually covered by the redesign's analytics slice before closing again — if the rewired get_students already handles the missing-course case, we can re-close with a pointer to that commit; otherwise this fix still stands.

@AndresL230

Copy link
Copy Markdown
Collaborator

Closing this as superseded — the bug it targets is already fixed on main, and issue #158 is closed.

To be clear up front: the diagnosis in this PR was correct when it was written.courses.user_id genuinely didn't exist and the endpoint genuinely 400'd. What happened is that the schema moved underneath the branch while it was open.

What superseded it

PR #270 (db/analytics-code: social.py offering re-keying, epic slice PR4 of the #279 DB modular redesign — merged 2026-06-24, commit 736abc1) rewrote get_students on main to walk the enrollment chain:

enrollment_rows=table("enrollments").select("user_id,course_offerings(courses(course_name))")
name_map=get_display_names([u["id"] foruinusers])

That's the same fix this PR set out to make, arrived at independently, plus the services/profiles.py name resolution.

Why it can't be merged forward

This branch carries migrations up to 0018; main is at 0030. The fix here targets the 0018-era schema, so rebasing wouldn't rescue it — it would swap one nonexistent reference for another:

  • user_courses no longer exists.0020_academics_split.sql:84 renamed it to enrollments. The new query would fail with a PostgREST "relation does not exist" (404) instead of the original 400 — still broken, different error.
  • The courses(course_name) embed can't resolve.0020:85 renamed course_idoffering_id, FK'd to course_offerings(id) (0020:73-74). There's no direct enrollments → courses relationship; it has to go through course_offerings.
  • users.name is gone.0024_identity_split.sql:25 dropped it; names moved to the encrypted user_profiles.name and resolve via get_display_names(). Reading it directly returns nothing.

GitHub already reports this as CONFLICTING on backend/routes/social.py, which is the two fixes colliding rather than ordinary drift.

The tests would need rewriting, not rebasing

tests/test_social_get_students.py pins the old schema — assert "user_courses" in recorder would fail against main's correct query. They also patch("routes.social.table") wholesale, so they'd pass against any table name and never reproduce the real PostgREST error.

Worth salvaging separately

One idea here is better than what's on main today: neither this PR nor main routes through services/academics.py, which the conventions call for — both hand-roll the embed. academics.py exposes user_offering_ids_for_course/offering_course_id but has no bulk "names for all enrollments" helper. Worth a follow-up ticket.

Also surfaced while reviewing, unrelated to this PR and present on main: get_students returns every user in the DB with their courses, mastery stats, and top concepts. It's authenticated but not scoped — the session user_id it fetches at social.py:426 is dead code. That looks intentional for a discovery surface, but it's a global cross-course disclosure worth an explicit decision.

Thanks @Jose-Gael-Cruz-Lopez — the analysis was right, the schema just moved. Closing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

social.get_students selects courses.user_id (nonexistent column) → students/class-intel endpoint 400s

2 participants

@Jose-Gael-Cruz-Lopez@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(social): get_students 400s on nonexistent courses.user_id (#158) - #253

Closed
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column
Closed

fix(social): get_students 400s on nonexistent courses.user_id (#158)#253
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column

Conversation

@Jose-Gael-Cruz-Lopez

Copy link
Copy Markdown
Member

After the #12 course_id migration, courses is a shared catalog with no user_id (enrollment lives in user_courses). get_students ran table("courses").select("user_id,course_name") and indexed courses_by_user[c["user_id"]]. PostgREST rejects selecting a nonexistent column with HTTP 400 (column courses.user_id does not exist), so the entire students / class-intel endpoint errored — and it's live (frontend/src/lib/api.tsgetStudents).

Fix — backend/routes/social.py

Join through user_courses and embed the course name:

enrollment_rows=table("user_courses").select("user_id,courses(course_name)")
forrowinenrollment_rows:
course=row.get("courses")
name=course.get("course_name") ifisinstance(course, dict) elseNoneifname:
courses_by_user[row["user_id"]].append(name)

Tests — backend/tests/test_social_get_students.py

Verification

  • ruff check . clean; gated suite green (+3 new). The new tests fail against the pre-fix code (the catalog path yields no enrollments), confirming real coverage.

Closes#158.

@coderabbitai

coderabbitaiBot commented Jun 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 18 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c8aa414-96aa-4a5f-875b-2fb17bfe39d3

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and 3fc48bb.

📒 Files selected for processing (2)
  • backend/routes/social.py
  • backend/tests/test_social_get_students.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/social-get-students-courses-column

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 22, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitUpdated (UTC)
❌ Deployment failed
View logs
frontenda9f1dd5Jun 22 2026, 04:12 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 24, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging3fc48bbCommit Preview URL

Branch Preview URL
Jun 24 2026, 02:42 PM

@AndresL230

Copy link
Copy Markdown
Collaborator

Superseded by the DB modular redesign (#279). social.get_students (#158) is rewired in the analytics slice to read enrollments → course_offerings → courses. Closing as obsolete. Reopen if not fully covered.

@AndresL230

Copy link
Copy Markdown
Collaborator

Reopening. Closed as superseded by #279, but this is an app-logic bugfix (social.get_students 400 on nonexistent course, #158), not a DB-structure change. Keeping it open to confirm the fix is actually covered by the redesign's analytics slice before closing again — if the rewired get_students already handles the missing-course case, we can re-close with a pointer to that commit; otherwise this fix still stands.

@AndresL230

Copy link
Copy Markdown
Collaborator

Closing this as superseded — the bug it targets is already fixed on main, and issue #158 is closed.

To be clear up front: the diagnosis in this PR was correct when it was written.courses.user_id genuinely didn't exist and the endpoint genuinely 400'd. What happened is that the schema moved underneath the branch while it was open.

What superseded it

PR #270 (db/analytics-code: social.py offering re-keying, epic slice PR4 of the #279 DB modular redesign — merged 2026-06-24, commit 736abc1) rewrote get_students on main to walk the enrollment chain:

enrollment_rows=table("enrollments").select("user_id,course_offerings(courses(course_name))")
name_map=get_display_names([u["id"] foruinusers])

That's the same fix this PR set out to make, arrived at independently, plus the services/profiles.py name resolution.

Why it can't be merged forward

This branch carries migrations up to 0018; main is at 0030. The fix here targets the 0018-era schema, so rebasing wouldn't rescue it — it would swap one nonexistent reference for another:

  • user_courses no longer exists.0020_academics_split.sql:84 renamed it to enrollments. The new query would fail with a PostgREST "relation does not exist" (404) instead of the original 400 — still broken, different error.
  • The courses(course_name) embed can't resolve.0020:85 renamed course_idoffering_id, FK'd to course_offerings(id) (0020:73-74). There's no direct enrollments → courses relationship; it has to go through course_offerings.
  • users.name is gone.0024_identity_split.sql:25 dropped it; names moved to the encrypted user_profiles.name and resolve via get_display_names(). Reading it directly returns nothing.

GitHub already reports this as CONFLICTING on backend/routes/social.py, which is the two fixes colliding rather than ordinary drift.

The tests would need rewriting, not rebasing

tests/test_social_get_students.py pins the old schema — assert "user_courses" in recorder would fail against main's correct query. They also patch("routes.social.table") wholesale, so they'd pass against any table name and never reproduce the real PostgREST error.

Worth salvaging separately

One idea here is better than what's on main today: neither this PR nor main routes through services/academics.py, which the conventions call for — both hand-roll the embed. academics.py exposes user_offering_ids_for_course/offering_course_id but has no bulk "names for all enrollments" helper. Worth a follow-up ticket.

Also surfaced while reviewing, unrelated to this PR and present on main: get_students returns every user in the DB with their courses, mastery stats, and top concepts. It's authenticated but not scoped — the session user_id it fetches at social.py:426 is dead code. That looks intentional for a discovery surface, but it's a global cross-course disclosure worth an explicit decision.

Thanks @Jose-Gael-Cruz-Lopez — the analysis was right, the schema just moved. Closing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

social.get_students selects courses.user_id (nonexistent column) → students/class-intel endpoint 400s

2 participants

@Jose-Gael-Cruz-Lopez@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(social): get_students 400s on nonexistent courses.user_id (#158) - #253

Closed
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column
Closed

fix(social): get_students 400s on nonexistent courses.user_id (#158)#253
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column

Conversation

@Jose-Gael-Cruz-Lopez

Copy link
Copy Markdown
Member

After the #12 course_id migration, courses is a shared catalog with no user_id (enrollment lives in user_courses). get_students ran table("courses").select("user_id,course_name") and indexed courses_by_user[c["user_id"]]. PostgREST rejects selecting a nonexistent column with HTTP 400 (column courses.user_id does not exist), so the entire students / class-intel endpoint errored — and it's live (frontend/src/lib/api.tsgetStudents).

Fix — backend/routes/social.py

Join through user_courses and embed the course name:

enrollment_rows=table("user_courses").select("user_id,courses(course_name)")
forrowinenrollment_rows:
course=row.get("courses")
name=course.get("course_name") ifisinstance(course, dict) elseNoneifname:
courses_by_user[row["user_id"]].append(name)

Tests — backend/tests/test_social_get_students.py

Verification

  • ruff check . clean; gated suite green (+3 new). The new tests fail against the pre-fix code (the catalog path yields no enrollments), confirming real coverage.

Closes#158.

@coderabbitai

coderabbitaiBot commented Jun 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 18 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c8aa414-96aa-4a5f-875b-2fb17bfe39d3

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and 3fc48bb.

📒 Files selected for processing (2)
  • backend/routes/social.py
  • backend/tests/test_social_get_students.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/social-get-students-courses-column

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 22, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitUpdated (UTC)
❌ Deployment failed
View logs
frontenda9f1dd5Jun 22 2026, 04:12 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 24, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging3fc48bbCommit Preview URL

Branch Preview URL
Jun 24 2026, 02:42 PM

@AndresL230

Copy link
Copy Markdown
Collaborator

Superseded by the DB modular redesign (#279). social.get_students (#158) is rewired in the analytics slice to read enrollments → course_offerings → courses. Closing as obsolete. Reopen if not fully covered.

@AndresL230

Copy link
Copy Markdown
Collaborator

Reopening. Closed as superseded by #279, but this is an app-logic bugfix (social.get_students 400 on nonexistent course, #158), not a DB-structure change. Keeping it open to confirm the fix is actually covered by the redesign's analytics slice before closing again — if the rewired get_students already handles the missing-course case, we can re-close with a pointer to that commit; otherwise this fix still stands.

@AndresL230

Copy link
Copy Markdown
Collaborator

Closing this as superseded — the bug it targets is already fixed on main, and issue #158 is closed.

To be clear up front: the diagnosis in this PR was correct when it was written.courses.user_id genuinely didn't exist and the endpoint genuinely 400'd. What happened is that the schema moved underneath the branch while it was open.

What superseded it

PR #270 (db/analytics-code: social.py offering re-keying, epic slice PR4 of the #279 DB modular redesign — merged 2026-06-24, commit 736abc1) rewrote get_students on main to walk the enrollment chain:

enrollment_rows=table("enrollments").select("user_id,course_offerings(courses(course_name))")
name_map=get_display_names([u["id"] foruinusers])

That's the same fix this PR set out to make, arrived at independently, plus the services/profiles.py name resolution.

Why it can't be merged forward

This branch carries migrations up to 0018; main is at 0030. The fix here targets the 0018-era schema, so rebasing wouldn't rescue it — it would swap one nonexistent reference for another:

  • user_courses no longer exists.0020_academics_split.sql:84 renamed it to enrollments. The new query would fail with a PostgREST "relation does not exist" (404) instead of the original 400 — still broken, different error.
  • The courses(course_name) embed can't resolve.0020:85 renamed course_idoffering_id, FK'd to course_offerings(id) (0020:73-74). There's no direct enrollments → courses relationship; it has to go through course_offerings.
  • users.name is gone.0024_identity_split.sql:25 dropped it; names moved to the encrypted user_profiles.name and resolve via get_display_names(). Reading it directly returns nothing.

GitHub already reports this as CONFLICTING on backend/routes/social.py, which is the two fixes colliding rather than ordinary drift.

The tests would need rewriting, not rebasing

tests/test_social_get_students.py pins the old schema — assert "user_courses" in recorder would fail against main's correct query. They also patch("routes.social.table") wholesale, so they'd pass against any table name and never reproduce the real PostgREST error.

Worth salvaging separately

One idea here is better than what's on main today: neither this PR nor main routes through services/academics.py, which the conventions call for — both hand-roll the embed. academics.py exposes user_offering_ids_for_course/offering_course_id but has no bulk "names for all enrollments" helper. Worth a follow-up ticket.

Also surfaced while reviewing, unrelated to this PR and present on main: get_students returns every user in the DB with their courses, mastery stats, and top concepts. It's authenticated but not scoped — the session user_id it fetches at social.py:426 is dead code. That looks intentional for a discovery surface, but it's a global cross-course disclosure worth an explicit decision.

Thanks @Jose-Gael-Cruz-Lopez — the analysis was right, the schema just moved. Closing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

social.get_students selects courses.user_id (nonexistent column) → students/class-intel endpoint 400s

2 participants

@Jose-Gael-Cruz-Lopez@AndresL230
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(social): get_students 400s on nonexistent courses.user_id (#158) - #253

Closed
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column
Closed

fix(social): get_students 400s on nonexistent courses.user_id (#158)#253
Jose-Gael-Cruz-Lopez wants to merge 3 commits into
mainfrom
fix/social-get-students-courses-column

Conversation

@Jose-Gael-Cruz-Lopez

Copy link
Copy Markdown
Member

After the #12 course_id migration, courses is a shared catalog with no user_id (enrollment lives in user_courses). get_students ran table("courses").select("user_id,course_name") and indexed courses_by_user[c["user_id"]]. PostgREST rejects selecting a nonexistent column with HTTP 400 (column courses.user_id does not exist), so the entire students / class-intel endpoint errored — and it's live (frontend/src/lib/api.tsgetStudents).

Fix — backend/routes/social.py

Join through user_courses and embed the course name:

enrollment_rows=table("user_courses").select("user_id,courses(course_name)")
forrowinenrollment_rows:
course=row.get("courses")
name=course.get("course_name") ifisinstance(course, dict) elseNoneifname:
courses_by_user[row["user_id"]].append(name)

Tests — backend/tests/test_social_get_students.py

Verification

  • ruff check . clean; gated suite green (+3 new). The new tests fail against the pre-fix code (the catalog path yields no enrollments), confirming real coverage.

Closes#158.

@coderabbitai

coderabbitaiBot commented Jun 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Jose-Gael-Cruz-Lopez, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 18 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c8aa414-96aa-4a5f-875b-2fb17bfe39d3

📥 Commits

Reviewing files that changed from the base of the PR and between 32409a8 and 3fc48bb.

📒 Files selected for processing (2)
  • backend/routes/social.py
  • backend/tests/test_social_get_students.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/social-get-students-courses-column

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 22, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitUpdated (UTC)
❌ Deployment failed
View logs
frontenda9f1dd5Jun 22 2026, 04:12 AM

@cloudflare-workers-and-pages

cloudflare-workers-and-pagesBot commented Jun 24, 2026

Copy link
Copy Markdown

Deploying with Cloudflare Workers Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

StatusNameLatest CommitPreview URLUpdated (UTC)
✅ Deployment successful!
View logs
frontend-staging3fc48bbCommit Preview URL

Branch Preview URL
Jun 24 2026, 02:42 PM

@AndresL230

Copy link
Copy Markdown
Collaborator

Superseded by the DB modular redesign (#279). social.get_students (#158) is rewired in the analytics slice to read enrollments → course_offerings → courses. Closing as obsolete. Reopen if not fully covered.

@AndresL230

Copy link
Copy Markdown
Collaborator

Reopening. Closed as superseded by #279, but this is an app-logic bugfix (social.get_students 400 on nonexistent course, #158), not a DB-structure change. Keeping it open to confirm the fix is actually covered by the redesign's analytics slice before closing again — if the rewired get_students already handles the missing-course case, we can re-close with a pointer to that commit; otherwise this fix still stands.

@AndresL230

Copy link
Copy Markdown
Collaborator

Closing this as superseded — the bug it targets is already fixed on main, and issue #158 is closed.

To be clear up front: the diagnosis in this PR was correct when it was written.courses.user_id genuinely didn't exist and the endpoint genuinely 400'd. What happened is that the schema moved underneath the branch while it was open.

What superseded it

PR #270 (db/analytics-code: social.py offering re-keying, epic slice PR4 of the #279 DB modular redesign — merged 2026-06-24, commit 736abc1) rewrote get_students on main to walk the enrollment chain:

enrollment_rows=table("enrollments").select("user_id,course_offerings(courses(course_name))")
name_map=get_display_names([u["id"] foruinusers])

That's the same fix this PR set out to make, arrived at independently, plus the services/profiles.py name resolution.

Why it can't be merged forward

This branch carries migrations up to 0018; main is at 0030. The fix here targets the 0018-era schema, so rebasing wouldn't rescue it — it would swap one nonexistent reference for another:

  • user_courses no longer exists.0020_academics_split.sql:84 renamed it to enrollments. The new query would fail with a PostgREST "relation does not exist" (404) instead of the original 400 — still broken, different error.
  • The courses(course_name) embed can't resolve.0020:85 renamed course_idoffering_id, FK'd to course_offerings(id) (0020:73-74). There's no direct enrollments → courses relationship; it has to go through course_offerings.
  • users.name is gone.0024_identity_split.sql:25 dropped it; names moved to the encrypted user_profiles.name and resolve via get_display_names(). Reading it directly returns nothing.

GitHub already reports this as CONFLICTING on backend/routes/social.py, which is the two fixes colliding rather than ordinary drift.

The tests would need rewriting, not rebasing

tests/test_social_get_students.py pins the old schema — assert "user_courses" in recorder would fail against main's correct query. They also patch("routes.social.table") wholesale, so they'd pass against any table name and never reproduce the real PostgREST error.

Worth salvaging separately

One idea here is better than what's on main today: neither this PR nor main routes through services/academics.py, which the conventions call for — both hand-roll the embed. academics.py exposes user_offering_ids_for_course/offering_course_id but has no bulk "names for all enrollments" helper. Worth a follow-up ticket.

Also surfaced while reviewing, unrelated to this PR and present on main: get_students returns every user in the DB with their courses, mastery stats, and top concepts. It's authenticated but not scoped — the session user_id it fetches at social.py:426 is dead code. That looks intentional for a discovery surface, but it's a global cross-course disclosure worth an explicit decision.

Thanks @Jose-Gael-Cruz-Lopez — the analysis was right, the schema just moved. Closing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

social.get_students selects courses.user_id (nonexistent column) → students/class-intel endpoint 400s

2 participants

@Jose-Gael-Cruz-Lopez@AndresL230