feat: semester-scoped learning + Courses & Semesters hub

[Darkest-Teddy]

Summary

Adds a semester switcher (a redesigned Courses & Semesters hub) that scopes the learning surfaces to a chosen term, and enforces a no-retake rule. Implements the approved design/plan under docs/superpowers/.

Approach: Path A — read-time filtering, no schema change / no migration. The knowledge graph stays keyed on the abstract course_id; a term filter is applied at the read boundary. Retakes are disallowed, so each course lives in exactly one semester.

Backend

• services/academics.py: term_id_for_label (label → term id, mirrors gradebook) + user_course_ids_for_term (the courses a user is enrolled in for a term).
• services/graph_service.py: get_graph(semester=) and get_recommendations(semester=) filter nodes/edges/stats (and DB-side course_id in (...) for recs) to the term's courses; add_course now rejects re-adding a course enrolled in any term (no-retake), surfacing the existing term.
• routes/graph.py: optional ?semester=<term label> on GET /api/graph/{user} and /recommendations. Absent ⇒ all terms (unchanged).

Frontend

• lib/api.ts: EnrolledCourse.term; optional semester on getGraph/getRecommendations.
• lib/useActiveSemester.ts: persisted active-semester hook ([value, setter, hydrated]) + distinctTerms/resolveActiveSemester helpers.
• Dashboard / Tree / Learn / Quiz / Study scope to the active semester; graph fetches are gated on hydration to avoid an unscoped→scoped double-fetch.
• ManageCoursesModal → Courses & Semesters hub: term tabs (set the active semester), courses grouped by term, "Already taken · " disabled state, disabled "Personal learning — Coming soon" placeholder.

Test Plan

• Backend: python -m pytest tests/ -q → 981 passed, 1 skipped (1 pre-existing unrelated OCR event-loop error).
• Frontend: npm run typecheck clean, npm run lint 0 errors, npm run test 92 passed.
• Manual: open Courses & Semesters, switch term tabs, confirm Tree/Learn/Study/Quiz + dashboard graph scope to that term.
• Manual: search a course taken in a previous term in "Add a course" → shows "Already taken · ", disabled.

Known non-blocking follow-ups

• Recent-session lists (Dashboard/Tree) are not yet term-filtered (spec §1; needs a sessions backend change).
• Stale local course selection can persist if the semester is switched mid-screen (cosmetic; shared across Learn/Tree/Quiz/Study).
• resolveActiveSemester defaults to the most-recently-enrolled term (documented heuristic, not term sort_key).
• term_id_for_label duplicates gradebook's private _term_id_for_semester — a later cleanup could consolidate.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Semester-scoped learning: graph loading and recommendations (and the related learning screens) now optionally filter by a selected semester.
  • Added a persisted “active semester” selector with automatic fallback to the most recent enrolled term.
  • Updated course management to “Courses & Semesters,” including term-aware enrollment and no-retake enforcement across all terms.
  • Improved tutor retrieval with category-aware document chunking, plus stronger academic integrity guidance.

• Bug Fixes

  • Ensured semester-filtered graph, stats, and recommendation results stay consistent.

• Tests

  • Expanded coverage for semester filtering/resolution, term enrollment behavior, API passthrough, and category chunking/indexing.

[coderabbitai]

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f229de7-a3dd-498f-9b5b-3f790de13dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 3369301 and b3d80a6.

📒 Files selected for processing (35)

• backend/db/migrations/0036_offering_null_section_unique.sql
• backend/prompts/preamble.txt
• backend/routes/documents.py
• backend/routes/gradebook.py
• backend/routes/graph.py
• backend/scripts/backfill_document_chunks.py
• backend/services/academics.py
• backend/services/chunker.py
• backend/services/graph_service.py
• backend/tests/test_academics.py
• backend/tests/test_chunker.py
• backend/tests/test_document_indexing.py
• backend/tests/test_graph_service.py
• backend/tests/test_shared_course_context.py
• docs/frontend-testids.md
• docs/superpowers/plans/2026-07-20-per-type-document-chunking.md
• docs/superpowers/plans/2026-07-20-semester-scoped-learning.md
• docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md
• docs/superpowers/specs/2026-07-20-semester-scoped-learning-design.md
• frontend/e2e/semester-scope.spec.ts
• frontend/eslint-suppressions.json
• frontend/src/components/ManageCoursesModal.test.tsx
• frontend/src/components/ManageCoursesModal.tsx
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Tree.tsx
• frontend/src/lib/api.ts
• frontend/src/lib/semesters.test.ts
• frontend/src/lib/semesters.ts
• frontend/src/lib/useActiveSemester.test.ts
• frontend/src/lib/useActiveSemester.ts
• frontend/vitest.setup.ts

📝 Walkthrough

Walkthrough

Adds semester-scoped graph and learning data across backend and frontend, persists the active semester, updates course management UI, enforces cross-term no-retakes, adds category-aware prose chunking, and strengthens tutor academic-integrity prompts.

Changes

Semester-scoped learning

Layer / File(s)	Summary
Semester-scoping contracts docs/superpowers/...	Documents read-time semester filtering, active-semester behavior, no-retake rules, affected surfaces, and verification requirements.
Term resolution and backend enforcement backend/routes/graph.py, backend/services/..., backend/tests/*	Adds term-aware routes and services, filters graphs and recommendations, supports requested enrollment terms, and rejects cross-term duplicate enrollments.
Active-semester state and API frontend/src/lib/api.ts, frontend/src/lib/useActiveSemester.ts, frontend/src/lib/*test*, frontend/eslint-suppressions.json	Adds semester request parameters, course term typing, persisted active-semester state, synchronization, and helper tests.
Dashboard and course hub frontend/src/components/screens/Dashboard.tsx, frontend/src/components/ManageCoursesModal.tsx, frontend/src/components/screens/Dashboard.test.tsx	Scopes dashboard data and redesigns course management with term selection, per-term enrollment display, and no-retake messaging.
Learning surface filters frontend/src/components/screens/{Learn,Quiz,Study,Tree}.tsx, frontend/src/components/DocumentUploadModal.test.tsx	Threads the active semester into graph loading and filters course and concept choices across learning screens.

Category-aware document chunking

Layer / File(s)	Summary
Chunking contract and implementation backend/services/chunker.py, backend/tests/test_chunker.py, docs/superpowers/...	Adds deterministic sentence-window prose chunking and category-based dispatch while retaining block chunking for other categories.
Indexing integration backend/routes/documents.py, backend/scripts/backfill_document_chunks.py, backend/tests/test_document_indexing.py	Passes document categories through live and historical chunk generation and updates indexing tests.

Academic-integrity prompt guidance

Layer / File(s)	Summary
Tutor prompt rule backend/prompts/preamble.txt, backend/tests/test_shared_course_context.py	Adds academic-integrity restrictions and verifies their inclusion in generated prompts.

Estimated code review effort: 4 (Complex) | ~75 minutes

Possibly related issues

• [EPIC] Semesters — view grades & classes by term #142 — Covers adjacent semester-aware course and learning data, including structured semester and grade-related APIs.

Possibly related PRs

• SaplingLearn/Sapling#53 — Modifies the same course-creation route and request model while this change adds term propagation.

Suggested reviewers:andresl230, jose-gael-cruz-lopez

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: semester-scoped learning plus the redesigned Courses & Semesters hub.
Description check	✅ Passed	The description is detailed and covers the summary, backend/frontend changes, testing, and follow-ups, with only minor template sections omitted.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/semester-scoped-learning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	b3d80a6	Commit Preview URL Branch Preview URL	Jul 29 2026, 11:55 AM

[Darkest-Teddy]

Added: per-type document chunking (commits 1a49ebe..c3fcfdf)

Pushed on top of the semester-scoped work. Independent of it — touches only the RAG chunking path.

What & why: the RAG pipeline used one block chunker (\n\n splitting) for every document, which mangles continuous prose (essays, written problem-set work) that lacks blank-line boundaries. This adds a second strategy and routes by the classifier's existing category.

• services/chunker.py: new chunk_prose (sentence-window, ~200-word target, ~40-word overlap, deterministic, capped at _MAX_WORDS) + chunk_for_category(text, category) dispatch. chunk_document unchanged.
• Routing: reading/assignment/study_guide → prose; everything else (incl. unknown) → block chunker.
• Wired into _index_document_chunks (live upload) and scripts/backfill_document_chunks.py. seed_quiz_fixture.py intentionally stays on the block chunker.
• Determinism preserved so content-addressed chunk IDs stay stable.

Spec/plan:docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md, docs/superpowers/plans/2026-07-20-per-type-document-chunking.md

Tests:test_chunker.py (16) + test_document_indexing.py (3) + test_rag_service.py (10) pass; per-task + final whole-branch review clean.

Out of scope (deferred, noted in the spec): a tutor system-prompt rule to never hand students assignment answers — that's prompt behavior, not chunking.

🤖 Generated with Claude Code

[Darkest-Teddy]

Added: tutor academic-integrity rule (commit 168f054)

Follow-up to the chunking work — the deferred behavioral rule.

• backend/prompts/preamble.txt: a non-negotiable ACADEMIC INTEGRITY section in the shared tutor preamble (applies to all modes — socratic/expository/teachback). The tutor must teach toward the answer (hints, steps, analogous examples) and never hand over the completed graded deliverable or reproduce verbatim solution text from uploads/retrieved context. Concepts, definitions, and general worked examples are still fully explained.
• Regression test in test_shared_course_context.py asserts the rule is present in build_system_prompt output. 25 passed, ruff clean.
• Quiz prompt intentionally unchanged — a quiz legitimately contains the marked correct answer (self-test revealed after answering), so the tutor rule doesn't apply there.

🤖 Generated with Claude Code

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

frontend/src/components/screens/Dashboard.tsx (1)

1276-1280: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the semester-empty state reachable.

This branch can never render: CoursesKey returns null at Line 1133 whenever courseProgress.length === 0. Remove or adjust that early return so an active semester with no courses shows this message and still exposes course management.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 1276 - 1280,
Update CoursesKey so it does not return null when courseProgress.length is zero
for an active semester; allow rendering to continue to the “Nothing enrolled
this semester.” state while preserving course management controls.

🧹 Nitpick comments (1)

backend/tests/test_shared_course_context.py (1)

471-478: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover every tutor mode claimed by the test.

The docstring promises the rule is present “regardless of mode,” but this test exercises only expository. Parameterize it over the supported modes so a mode-specific prompt change cannot bypass the integrity rule.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@backend/tests/test_shared_course_context.py` around lines 471 - 478, Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 265-282: Update the dashboard loading flow around the Promise.all
requests so courses and semesters are fetched first, then derive an
effectiveSemester from the stored activeSemester or the existing
courseTermLabels/resolveActiveSemester fallback before requesting graph and
recommendation data. Pass effectiveSemester to getGraph and getRecommendations,
preserving unscoped requests only when no semester can be resolved; ensure the
default path passes “Spring 2026” rather than undefined and persists that
selected semester.
---
Outside diff comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 1276-1280: Update CoursesKey so it does not return null when
courseProgress.length is zero for an active semester; allow rendering to
continue to the “Nothing enrolled this semester.” state while preserving course
management controls.
---
Nitpick comments:
In `@backend/tests/test_shared_course_context.py`:
- Around line 471-478: Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6eedc26e-16af-4a02-b10b-c42176be693d

📥 Commits

Reviewing files that changed from the base of the PR and between c3fcfdf and 3369301.

📒 Files selected for processing (9)

• backend/prompts/preamble.txt
• backend/tests/test_shared_course_context.py
• frontend/eslint-suppressions.json
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/lib/api.ts

💤 Files with no reviewable changes (1)

• frontend/eslint-suppressions.json

🚧 Files skipped from review as they are similar to previous changes (4)

• frontend/src/lib/api.ts
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Learn.tsx

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Resolve the default semester before requesting graph data.

With no stored semester, Lines 266 and 270 request unscoped data, then Line 281 selects and persists a term. This briefly renders unscoped graph/stats/recommendations and performs a second fetch. Fetch courses/semesters first, derive an effectiveSemester, then use it for the graph and recommendations requests.

Also assert the default-path getGraph call receives "Spring 2026" rather than undefined.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 265 - 282, Update
the dashboard loading flow around the Promise.all requests so courses and
semesters are fetched first, then derive an effectiveSemester from the stored
activeSemester or the existing courseTermLabels/resolveActiveSemester fallback
before requesting graph and recommendation data. Pass effectiveSemester to
getGraph and getRecommendations, preserving unscoped requests only when no
semester can be resolved; ensure the default path passes “Spring 2026” rather
than undefined and persists that selected semester.

[AndresL230]

Code review

Found 3 issues:

1. The new cross-term no-retake guard in add_course is check-then-act with no atomic enforcement: course_offerings' UNIQUE(course_id, term_id, section) does not bind for NULL sections and a race that creates two different offering rows slips past enrollments' uniqueness — a double-click on Add for a never-enrolled course can create duplicate enrollments, violating the PR's own invariant. (bug due to backend/services/graph_service.py — read via user_offering_ids_for_course, then resolve_offering(..., create=True) + insert with no constraint backing the NULL-section case)

Sapling/backend/services/graph_service.py

Lines 372 to 396 in a53e809

	# rejected instead of silently creating a second enrollment.)
	existing_offerings=user_offering_ids_for_course(user_id, course_id)
	ifexisting_offerings:
	existing_term=term_for_offering(existing_offerings[0]) or {}
	return {
	"course_id": course_id,
	"already_existed": True,
	"term": existing_term.get("label", ""),
	}
	# Resolve the requested semester label → term id. An unknown label yields
	# None, which resolve_offering treats as "current term".
	term_id=term_id_for_label(term) iftermelseNone
	offering_id=resolve_offering(course_id, term_id=term_id, create=True)
	ifnotoffering_id:
	return {"course_id": course_id, "error": "No term available to enroll into"}
	# Check if already enrolled in this offering
	existing=table("enrollments").select(
	"id",
	filters={"user_id": f"eq.{user_id}", "offering_id": f"eq.{offering_id}"},
	)
	ifexisting:
	return {"course_id": course_id, "already_existed": True}

2. CoursesKey returns null whenever courseProgress is empty, so the "Nothing enrolled this semester." empty-state later in the same component is unreachable — an empty active semester renders nothing at all in that panel. (bug due to frontend/src/components/screens/Dashboard.tsx — early if (courseProgress.length === 0) return null; above the empty-state block)

Sapling/frontend/src/components/screens/Dashboard.tsx

Lines 1129 to 1131 in a53e809

	if(courseProgress.length===0)returnnull;

3. Only Dashboard and the Courses & Semesters hub ever resolve/persist a default active semester; Learn/Quiz/Tree/Study read it but never set one — a user who deep-links to /learn first stays permanently unscoped on those screens, silently defeating the semester-scoping feature there. (bug due to frontend/src/lib/useActiveSemester.ts consumers never resolving a default outside Dashboard)

Sapling/frontend/src/lib/useActiveSemester.ts

Lines 36 to 72 in a53e809

	}
	/** [activeSemester, setActiveSemester, hydrated] — persisted to localStorage, cross-tab + same-tab
	* reactive. `hydrated` is false until the localStorage read completes after mount. */
	exportfunctionuseActiveSemester(): [string,(v: string)=>void,boolean]{
	const[sem,setSem]=useState<string>("");
	// `hydrated` flips true once we've read localStorage after mount. We start at
	// "" (not the stored value) to avoid an SSR/CSR hydration mismatch, so callers
	// that fetch based on the active semester should wait for `hydrated` to avoid
	// an initial unscoped fetch followed by a scoped refetch.
	const[hydrated,setHydrated]=useState(false);
	useEffect(()=>{
	setSem(read());
	setHydrated(true);
	constonStorage=(e: StorageEvent)=>{
	if(e.key===ACTIVE_SEMESTER_STORAGE_KEY)setSem(read());
	};
	constonCustom=()=>setSem(read());
	window.addEventListener("storage",onStorage);
	window.addEventListener(CHANGE_EVENT,onCustom);
	return()=>{
	window.removeEventListener("storage",onStorage);
	window.removeEventListener(CHANGE_EVENT,onCustom);
	};
	},[]);
	// Stable identity so consumers can safely list it in effect/callback deps.
	constupdate=useCallback((v: string)=>{
	if(typeofwindow==="undefined")return;
	window.localStorage.setItem(ACTIVE_SEMESTER_STORAGE_KEY,v);
	setSem(v);
	window.dispatchEvent(newEvent(CHANGE_EVENT));
	},[]);
	return[sem,update,hydrated];
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[AndresL230]

All three review findings above are fixed in the latest push: (1) the no-retake race is closed by migration 0036's partial unique index on course_offerings (course_id, term_id) WHERE section IS NULL, a 409-retry re-select in resolve_offering, and an in-flight disable on the hub's Add button; (2) CoursesKey now renders the 'Nothing enrolled this semester.' empty-state when an active semester scopes to zero courses; (3) Learn/Quiz/Tree/Study now resolve a default semester via ensureDefaultActiveSemester as soon as they have term labels. Also: the Add flow honors already_existed with an informational toast, the dead duplicate check was removed, first-load double-fetch eliminated, and the orphaned #140 archive helpers were deleted. Backend 1311 passed; frontend 246 passed.

[Darkest-Teddy]

Summary

Adds a semester switcher (a redesigned Courses & Semesters hub) that scopes the learning surfaces to a chosen term, and enforces a no-retake rule. Implements the approved design/plan under docs/superpowers/.

Approach: Path A — read-time filtering, no schema change / no migration. The knowledge graph stays keyed on the abstract course_id; a term filter is applied at the read boundary. Retakes are disallowed, so each course lives in exactly one semester.

Backend

• services/academics.py: term_id_for_label (label → term id, mirrors gradebook) + user_course_ids_for_term (the courses a user is enrolled in for a term).
• services/graph_service.py: get_graph(semester=) and get_recommendations(semester=) filter nodes/edges/stats (and DB-side course_id in (...) for recs) to the term's courses; add_course now rejects re-adding a course enrolled in any term (no-retake), surfacing the existing term.
• routes/graph.py: optional ?semester=<term label> on GET /api/graph/{user} and /recommendations. Absent ⇒ all terms (unchanged).

Frontend

• lib/api.ts: EnrolledCourse.term; optional semester on getGraph/getRecommendations.
• lib/useActiveSemester.ts: persisted active-semester hook ([value, setter, hydrated]) + distinctTerms/resolveActiveSemester helpers.
• Dashboard / Tree / Learn / Quiz / Study scope to the active semester; graph fetches are gated on hydration to avoid an unscoped→scoped double-fetch.
• ManageCoursesModal → Courses & Semesters hub: term tabs (set the active semester), courses grouped by term, "Already taken · " disabled state, disabled "Personal learning — Coming soon" placeholder.

Test Plan

• Backend: python -m pytest tests/ -q → 981 passed, 1 skipped (1 pre-existing unrelated OCR event-loop error).
• Frontend: npm run typecheck clean, npm run lint 0 errors, npm run test 92 passed.
• Manual: open Courses & Semesters, switch term tabs, confirm Tree/Learn/Study/Quiz + dashboard graph scope to that term.
• Manual: search a course taken in a previous term in "Add a course" → shows "Already taken · ", disabled.

Known non-blocking follow-ups

• Recent-session lists (Dashboard/Tree) are not yet term-filtered (spec §1; needs a sessions backend change).
• Stale local course selection can persist if the semester is switched mid-screen (cosmetic; shared across Learn/Tree/Quiz/Study).
• resolveActiveSemester defaults to the most-recently-enrolled term (documented heuristic, not term sort_key).
• term_id_for_label duplicates gradebook's private _term_id_for_semester — a later cleanup could consolidate.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Semester-scoped learning: graph loading and recommendations (and the related learning screens) now optionally filter by a selected semester.
  • Added a persisted “active semester” selector with automatic fallback to the most recent enrolled term.
  • Updated course management to “Courses & Semesters,” including term-aware enrollment and no-retake enforcement across all terms.
  • Improved tutor retrieval with category-aware document chunking, plus stronger academic integrity guidance.

• Bug Fixes

  • Ensured semester-filtered graph, stats, and recommendation results stay consistent.

• Tests

  • Expanded coverage for semester filtering/resolution, term enrollment behavior, API passthrough, and category chunking/indexing.

[coderabbitai]

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f229de7-a3dd-498f-9b5b-3f790de13dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 3369301 and b3d80a6.

📒 Files selected for processing (35)

• backend/db/migrations/0036_offering_null_section_unique.sql
• backend/prompts/preamble.txt
• backend/routes/documents.py
• backend/routes/gradebook.py
• backend/routes/graph.py
• backend/scripts/backfill_document_chunks.py
• backend/services/academics.py
• backend/services/chunker.py
• backend/services/graph_service.py
• backend/tests/test_academics.py
• backend/tests/test_chunker.py
• backend/tests/test_document_indexing.py
• backend/tests/test_graph_service.py
• backend/tests/test_shared_course_context.py
• docs/frontend-testids.md
• docs/superpowers/plans/2026-07-20-per-type-document-chunking.md
• docs/superpowers/plans/2026-07-20-semester-scoped-learning.md
• docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md
• docs/superpowers/specs/2026-07-20-semester-scoped-learning-design.md
• frontend/e2e/semester-scope.spec.ts
• frontend/eslint-suppressions.json
• frontend/src/components/ManageCoursesModal.test.tsx
• frontend/src/components/ManageCoursesModal.tsx
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Tree.tsx
• frontend/src/lib/api.ts
• frontend/src/lib/semesters.test.ts
• frontend/src/lib/semesters.ts
• frontend/src/lib/useActiveSemester.test.ts
• frontend/src/lib/useActiveSemester.ts
• frontend/vitest.setup.ts

📝 Walkthrough

Walkthrough

Adds semester-scoped graph and learning data across backend and frontend, persists the active semester, updates course management UI, enforces cross-term no-retakes, adds category-aware prose chunking, and strengthens tutor academic-integrity prompts.

Changes

Semester-scoped learning

Layer / File(s)	Summary
Semester-scoping contracts docs/superpowers/...	Documents read-time semester filtering, active-semester behavior, no-retake rules, affected surfaces, and verification requirements.
Term resolution and backend enforcement backend/routes/graph.py, backend/services/..., backend/tests/*	Adds term-aware routes and services, filters graphs and recommendations, supports requested enrollment terms, and rejects cross-term duplicate enrollments.
Active-semester state and API frontend/src/lib/api.ts, frontend/src/lib/useActiveSemester.ts, frontend/src/lib/*test*, frontend/eslint-suppressions.json	Adds semester request parameters, course term typing, persisted active-semester state, synchronization, and helper tests.
Dashboard and course hub frontend/src/components/screens/Dashboard.tsx, frontend/src/components/ManageCoursesModal.tsx, frontend/src/components/screens/Dashboard.test.tsx	Scopes dashboard data and redesigns course management with term selection, per-term enrollment display, and no-retake messaging.
Learning surface filters frontend/src/components/screens/{Learn,Quiz,Study,Tree}.tsx, frontend/src/components/DocumentUploadModal.test.tsx	Threads the active semester into graph loading and filters course and concept choices across learning screens.

Category-aware document chunking

Layer / File(s)	Summary
Chunking contract and implementation backend/services/chunker.py, backend/tests/test_chunker.py, docs/superpowers/...	Adds deterministic sentence-window prose chunking and category-based dispatch while retaining block chunking for other categories.
Indexing integration backend/routes/documents.py, backend/scripts/backfill_document_chunks.py, backend/tests/test_document_indexing.py	Passes document categories through live and historical chunk generation and updates indexing tests.

Academic-integrity prompt guidance

Layer / File(s)	Summary
Tutor prompt rule backend/prompts/preamble.txt, backend/tests/test_shared_course_context.py	Adds academic-integrity restrictions and verifies their inclusion in generated prompts.

Estimated code review effort: 4 (Complex) | ~75 minutes

Possibly related issues

• [EPIC] Semesters — view grades & classes by term #142 — Covers adjacent semester-aware course and learning data, including structured semester and grade-related APIs.

Possibly related PRs

• SaplingLearn/Sapling#53 — Modifies the same course-creation route and request model while this change adds term propagation.

Suggested reviewers:andresl230, jose-gael-cruz-lopez

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: semester-scoped learning plus the redesigned Courses & Semesters hub.
Description check	✅ Passed	The description is detailed and covers the summary, backend/frontend changes, testing, and follow-ups, with only minor template sections omitted.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/semester-scoped-learning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	b3d80a6	Commit Preview URL Branch Preview URL	Jul 29 2026, 11:55 AM

[Darkest-Teddy]

Added: per-type document chunking (commits 1a49ebe..c3fcfdf)

Pushed on top of the semester-scoped work. Independent of it — touches only the RAG chunking path.

What & why: the RAG pipeline used one block chunker (\n\n splitting) for every document, which mangles continuous prose (essays, written problem-set work) that lacks blank-line boundaries. This adds a second strategy and routes by the classifier's existing category.

• services/chunker.py: new chunk_prose (sentence-window, ~200-word target, ~40-word overlap, deterministic, capped at _MAX_WORDS) + chunk_for_category(text, category) dispatch. chunk_document unchanged.
• Routing: reading/assignment/study_guide → prose; everything else (incl. unknown) → block chunker.
• Wired into _index_document_chunks (live upload) and scripts/backfill_document_chunks.py. seed_quiz_fixture.py intentionally stays on the block chunker.
• Determinism preserved so content-addressed chunk IDs stay stable.

Spec/plan:docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md, docs/superpowers/plans/2026-07-20-per-type-document-chunking.md

Tests:test_chunker.py (16) + test_document_indexing.py (3) + test_rag_service.py (10) pass; per-task + final whole-branch review clean.

Out of scope (deferred, noted in the spec): a tutor system-prompt rule to never hand students assignment answers — that's prompt behavior, not chunking.

🤖 Generated with Claude Code

[Darkest-Teddy]

Added: tutor academic-integrity rule (commit 168f054)

Follow-up to the chunking work — the deferred behavioral rule.

• backend/prompts/preamble.txt: a non-negotiable ACADEMIC INTEGRITY section in the shared tutor preamble (applies to all modes — socratic/expository/teachback). The tutor must teach toward the answer (hints, steps, analogous examples) and never hand over the completed graded deliverable or reproduce verbatim solution text from uploads/retrieved context. Concepts, definitions, and general worked examples are still fully explained.
• Regression test in test_shared_course_context.py asserts the rule is present in build_system_prompt output. 25 passed, ruff clean.
• Quiz prompt intentionally unchanged — a quiz legitimately contains the marked correct answer (self-test revealed after answering), so the tutor rule doesn't apply there.

🤖 Generated with Claude Code

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

frontend/src/components/screens/Dashboard.tsx (1)

1276-1280: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the semester-empty state reachable.

This branch can never render: CoursesKey returns null at Line 1133 whenever courseProgress.length === 0. Remove or adjust that early return so an active semester with no courses shows this message and still exposes course management.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 1276 - 1280,
Update CoursesKey so it does not return null when courseProgress.length is zero
for an active semester; allow rendering to continue to the “Nothing enrolled
this semester.” state while preserving course management controls.

🧹 Nitpick comments (1)

backend/tests/test_shared_course_context.py (1)

471-478: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover every tutor mode claimed by the test.

The docstring promises the rule is present “regardless of mode,” but this test exercises only expository. Parameterize it over the supported modes so a mode-specific prompt change cannot bypass the integrity rule.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@backend/tests/test_shared_course_context.py` around lines 471 - 478, Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 265-282: Update the dashboard loading flow around the Promise.all
requests so courses and semesters are fetched first, then derive an
effectiveSemester from the stored activeSemester or the existing
courseTermLabels/resolveActiveSemester fallback before requesting graph and
recommendation data. Pass effectiveSemester to getGraph and getRecommendations,
preserving unscoped requests only when no semester can be resolved; ensure the
default path passes “Spring 2026” rather than undefined and persists that
selected semester.
---
Outside diff comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 1276-1280: Update CoursesKey so it does not return null when
courseProgress.length is zero for an active semester; allow rendering to
continue to the “Nothing enrolled this semester.” state while preserving course
management controls.
---
Nitpick comments:
In `@backend/tests/test_shared_course_context.py`:
- Around line 471-478: Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6eedc26e-16af-4a02-b10b-c42176be693d

📥 Commits

Reviewing files that changed from the base of the PR and between c3fcfdf and 3369301.

📒 Files selected for processing (9)

• backend/prompts/preamble.txt
• backend/tests/test_shared_course_context.py
• frontend/eslint-suppressions.json
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/lib/api.ts

💤 Files with no reviewable changes (1)

• frontend/eslint-suppressions.json

🚧 Files skipped from review as they are similar to previous changes (4)

• frontend/src/lib/api.ts
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Learn.tsx

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Resolve the default semester before requesting graph data.

With no stored semester, Lines 266 and 270 request unscoped data, then Line 281 selects and persists a term. This briefly renders unscoped graph/stats/recommendations and performs a second fetch. Fetch courses/semesters first, derive an effectiveSemester, then use it for the graph and recommendations requests.

Also assert the default-path getGraph call receives "Spring 2026" rather than undefined.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 265 - 282, Update
the dashboard loading flow around the Promise.all requests so courses and
semesters are fetched first, then derive an effectiveSemester from the stored
activeSemester or the existing courseTermLabels/resolveActiveSemester fallback
before requesting graph and recommendation data. Pass effectiveSemester to
getGraph and getRecommendations, preserving unscoped requests only when no
semester can be resolved; ensure the default path passes “Spring 2026” rather
than undefined and persists that selected semester.

[AndresL230]

Code review

Found 3 issues:

1. The new cross-term no-retake guard in add_course is check-then-act with no atomic enforcement: course_offerings' UNIQUE(course_id, term_id, section) does not bind for NULL sections and a race that creates two different offering rows slips past enrollments' uniqueness — a double-click on Add for a never-enrolled course can create duplicate enrollments, violating the PR's own invariant. (bug due to backend/services/graph_service.py — read via user_offering_ids_for_course, then resolve_offering(..., create=True) + insert with no constraint backing the NULL-section case)

Sapling/backend/services/graph_service.py

Lines 372 to 396 in a53e809

	# rejected instead of silently creating a second enrollment.)
	existing_offerings=user_offering_ids_for_course(user_id, course_id)
	ifexisting_offerings:
	existing_term=term_for_offering(existing_offerings[0]) or {}
	return {
	"course_id": course_id,
	"already_existed": True,
	"term": existing_term.get("label", ""),
	}
	# Resolve the requested semester label → term id. An unknown label yields
	# None, which resolve_offering treats as "current term".
	term_id=term_id_for_label(term) iftermelseNone
	offering_id=resolve_offering(course_id, term_id=term_id, create=True)
	ifnotoffering_id:
	return {"course_id": course_id, "error": "No term available to enroll into"}
	# Check if already enrolled in this offering
	existing=table("enrollments").select(
	"id",
	filters={"user_id": f"eq.{user_id}", "offering_id": f"eq.{offering_id}"},
	)
	ifexisting:
	return {"course_id": course_id, "already_existed": True}

2. CoursesKey returns null whenever courseProgress is empty, so the "Nothing enrolled this semester." empty-state later in the same component is unreachable — an empty active semester renders nothing at all in that panel. (bug due to frontend/src/components/screens/Dashboard.tsx — early if (courseProgress.length === 0) return null; above the empty-state block)

Sapling/frontend/src/components/screens/Dashboard.tsx

Lines 1129 to 1131 in a53e809

	if(courseProgress.length===0)returnnull;

3. Only Dashboard and the Courses & Semesters hub ever resolve/persist a default active semester; Learn/Quiz/Tree/Study read it but never set one — a user who deep-links to /learn first stays permanently unscoped on those screens, silently defeating the semester-scoping feature there. (bug due to frontend/src/lib/useActiveSemester.ts consumers never resolving a default outside Dashboard)

Sapling/frontend/src/lib/useActiveSemester.ts

Lines 36 to 72 in a53e809

	}
	/** [activeSemester, setActiveSemester, hydrated] — persisted to localStorage, cross-tab + same-tab
	* reactive. `hydrated` is false until the localStorage read completes after mount. */
	exportfunctionuseActiveSemester(): [string,(v: string)=>void,boolean]{
	const[sem,setSem]=useState<string>("");
	// `hydrated` flips true once we've read localStorage after mount. We start at
	// "" (not the stored value) to avoid an SSR/CSR hydration mismatch, so callers
	// that fetch based on the active semester should wait for `hydrated` to avoid
	// an initial unscoped fetch followed by a scoped refetch.
	const[hydrated,setHydrated]=useState(false);
	useEffect(()=>{
	setSem(read());
	setHydrated(true);
	constonStorage=(e: StorageEvent)=>{
	if(e.key===ACTIVE_SEMESTER_STORAGE_KEY)setSem(read());
	};
	constonCustom=()=>setSem(read());
	window.addEventListener("storage",onStorage);
	window.addEventListener(CHANGE_EVENT,onCustom);
	return()=>{
	window.removeEventListener("storage",onStorage);
	window.removeEventListener(CHANGE_EVENT,onCustom);
	};
	},[]);
	// Stable identity so consumers can safely list it in effect/callback deps.
	constupdate=useCallback((v: string)=>{
	if(typeofwindow==="undefined")return;
	window.localStorage.setItem(ACTIVE_SEMESTER_STORAGE_KEY,v);
	setSem(v);
	window.dispatchEvent(newEvent(CHANGE_EVENT));
	},[]);
	return[sem,update,hydrated];
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[AndresL230]

All three review findings above are fixed in the latest push: (1) the no-retake race is closed by migration 0036's partial unique index on course_offerings (course_id, term_id) WHERE section IS NULL, a 409-retry re-select in resolve_offering, and an in-flight disable on the hub's Add button; (2) CoursesKey now renders the 'Nothing enrolled this semester.' empty-state when an active semester scopes to zero courses; (3) Learn/Quiz/Tree/Study now resolve a default semester via ensureDefaultActiveSemester as soon as they have term labels. Also: the Add flow honors already_existed with an informational toast, the dead duplicate check was removed, first-load double-fetch eliminated, and the orphaned #140 archive helpers were deleted. Backend 1311 passed; frontend 246 passed.

[Darkest-Teddy]

Summary

Adds a semester switcher (a redesigned Courses & Semesters hub) that scopes the learning surfaces to a chosen term, and enforces a no-retake rule. Implements the approved design/plan under docs/superpowers/.

Approach: Path A — read-time filtering, no schema change / no migration. The knowledge graph stays keyed on the abstract course_id; a term filter is applied at the read boundary. Retakes are disallowed, so each course lives in exactly one semester.

Backend

• services/academics.py: term_id_for_label (label → term id, mirrors gradebook) + user_course_ids_for_term (the courses a user is enrolled in for a term).
• services/graph_service.py: get_graph(semester=) and get_recommendations(semester=) filter nodes/edges/stats (and DB-side course_id in (...) for recs) to the term's courses; add_course now rejects re-adding a course enrolled in any term (no-retake), surfacing the existing term.
• routes/graph.py: optional ?semester=<term label> on GET /api/graph/{user} and /recommendations. Absent ⇒ all terms (unchanged).

Frontend

• lib/api.ts: EnrolledCourse.term; optional semester on getGraph/getRecommendations.
• lib/useActiveSemester.ts: persisted active-semester hook ([value, setter, hydrated]) + distinctTerms/resolveActiveSemester helpers.
• Dashboard / Tree / Learn / Quiz / Study scope to the active semester; graph fetches are gated on hydration to avoid an unscoped→scoped double-fetch.
• ManageCoursesModal → Courses & Semesters hub: term tabs (set the active semester), courses grouped by term, "Already taken · " disabled state, disabled "Personal learning — Coming soon" placeholder.

Test Plan

• Backend: python -m pytest tests/ -q → 981 passed, 1 skipped (1 pre-existing unrelated OCR event-loop error).
• Frontend: npm run typecheck clean, npm run lint 0 errors, npm run test 92 passed.
• Manual: open Courses & Semesters, switch term tabs, confirm Tree/Learn/Study/Quiz + dashboard graph scope to that term.
• Manual: search a course taken in a previous term in "Add a course" → shows "Already taken · ", disabled.

Known non-blocking follow-ups

• Recent-session lists (Dashboard/Tree) are not yet term-filtered (spec §1; needs a sessions backend change).
• Stale local course selection can persist if the semester is switched mid-screen (cosmetic; shared across Learn/Tree/Quiz/Study).
• resolveActiveSemester defaults to the most-recently-enrolled term (documented heuristic, not term sort_key).
• term_id_for_label duplicates gradebook's private _term_id_for_semester — a later cleanup could consolidate.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Semester-scoped learning: graph loading and recommendations (and the related learning screens) now optionally filter by a selected semester.
  • Added a persisted “active semester” selector with automatic fallback to the most recent enrolled term.
  • Updated course management to “Courses & Semesters,” including term-aware enrollment and no-retake enforcement across all terms.
  • Improved tutor retrieval with category-aware document chunking, plus stronger academic integrity guidance.

• Bug Fixes

  • Ensured semester-filtered graph, stats, and recommendation results stay consistent.

• Tests

  • Expanded coverage for semester filtering/resolution, term enrollment behavior, API passthrough, and category chunking/indexing.

[coderabbitai]

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f229de7-a3dd-498f-9b5b-3f790de13dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 3369301 and b3d80a6.

📒 Files selected for processing (35)

• backend/db/migrations/0036_offering_null_section_unique.sql
• backend/prompts/preamble.txt
• backend/routes/documents.py
• backend/routes/gradebook.py
• backend/routes/graph.py
• backend/scripts/backfill_document_chunks.py
• backend/services/academics.py
• backend/services/chunker.py
• backend/services/graph_service.py
• backend/tests/test_academics.py
• backend/tests/test_chunker.py
• backend/tests/test_document_indexing.py
• backend/tests/test_graph_service.py
• backend/tests/test_shared_course_context.py
• docs/frontend-testids.md
• docs/superpowers/plans/2026-07-20-per-type-document-chunking.md
• docs/superpowers/plans/2026-07-20-semester-scoped-learning.md
• docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md
• docs/superpowers/specs/2026-07-20-semester-scoped-learning-design.md
• frontend/e2e/semester-scope.spec.ts
• frontend/eslint-suppressions.json
• frontend/src/components/ManageCoursesModal.test.tsx
• frontend/src/components/ManageCoursesModal.tsx
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Tree.tsx
• frontend/src/lib/api.ts
• frontend/src/lib/semesters.test.ts
• frontend/src/lib/semesters.ts
• frontend/src/lib/useActiveSemester.test.ts
• frontend/src/lib/useActiveSemester.ts
• frontend/vitest.setup.ts

📝 Walkthrough

Walkthrough

Adds semester-scoped graph and learning data across backend and frontend, persists the active semester, updates course management UI, enforces cross-term no-retakes, adds category-aware prose chunking, and strengthens tutor academic-integrity prompts.

Changes

Semester-scoped learning

Layer / File(s)	Summary
Semester-scoping contracts docs/superpowers/...	Documents read-time semester filtering, active-semester behavior, no-retake rules, affected surfaces, and verification requirements.
Term resolution and backend enforcement backend/routes/graph.py, backend/services/..., backend/tests/*	Adds term-aware routes and services, filters graphs and recommendations, supports requested enrollment terms, and rejects cross-term duplicate enrollments.
Active-semester state and API frontend/src/lib/api.ts, frontend/src/lib/useActiveSemester.ts, frontend/src/lib/*test*, frontend/eslint-suppressions.json	Adds semester request parameters, course term typing, persisted active-semester state, synchronization, and helper tests.
Dashboard and course hub frontend/src/components/screens/Dashboard.tsx, frontend/src/components/ManageCoursesModal.tsx, frontend/src/components/screens/Dashboard.test.tsx	Scopes dashboard data and redesigns course management with term selection, per-term enrollment display, and no-retake messaging.
Learning surface filters frontend/src/components/screens/{Learn,Quiz,Study,Tree}.tsx, frontend/src/components/DocumentUploadModal.test.tsx	Threads the active semester into graph loading and filters course and concept choices across learning screens.

Category-aware document chunking

Layer / File(s)	Summary
Chunking contract and implementation backend/services/chunker.py, backend/tests/test_chunker.py, docs/superpowers/...	Adds deterministic sentence-window prose chunking and category-based dispatch while retaining block chunking for other categories.
Indexing integration backend/routes/documents.py, backend/scripts/backfill_document_chunks.py, backend/tests/test_document_indexing.py	Passes document categories through live and historical chunk generation and updates indexing tests.

Academic-integrity prompt guidance

Layer / File(s)	Summary
Tutor prompt rule backend/prompts/preamble.txt, backend/tests/test_shared_course_context.py	Adds academic-integrity restrictions and verifies their inclusion in generated prompts.

Estimated code review effort: 4 (Complex) | ~75 minutes

Possibly related issues

• [EPIC] Semesters — view grades & classes by term #142 — Covers adjacent semester-aware course and learning data, including structured semester and grade-related APIs.

Possibly related PRs

• SaplingLearn/Sapling#53 — Modifies the same course-creation route and request model while this change adds term propagation.

Suggested reviewers:andresl230, jose-gael-cruz-lopez

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: semester-scoped learning plus the redesigned Courses & Semesters hub.
Description check	✅ Passed	The description is detailed and covers the summary, backend/frontend changes, testing, and follow-ups, with only minor template sections omitted.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/semester-scoped-learning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	b3d80a6	Commit Preview URL Branch Preview URL	Jul 29 2026, 11:55 AM

[Darkest-Teddy]

Added: per-type document chunking (commits 1a49ebe..c3fcfdf)

Pushed on top of the semester-scoped work. Independent of it — touches only the RAG chunking path.

What & why: the RAG pipeline used one block chunker (\n\n splitting) for every document, which mangles continuous prose (essays, written problem-set work) that lacks blank-line boundaries. This adds a second strategy and routes by the classifier's existing category.

• services/chunker.py: new chunk_prose (sentence-window, ~200-word target, ~40-word overlap, deterministic, capped at _MAX_WORDS) + chunk_for_category(text, category) dispatch. chunk_document unchanged.
• Routing: reading/assignment/study_guide → prose; everything else (incl. unknown) → block chunker.
• Wired into _index_document_chunks (live upload) and scripts/backfill_document_chunks.py. seed_quiz_fixture.py intentionally stays on the block chunker.
• Determinism preserved so content-addressed chunk IDs stay stable.

Spec/plan:docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md, docs/superpowers/plans/2026-07-20-per-type-document-chunking.md

Tests:test_chunker.py (16) + test_document_indexing.py (3) + test_rag_service.py (10) pass; per-task + final whole-branch review clean.

Out of scope (deferred, noted in the spec): a tutor system-prompt rule to never hand students assignment answers — that's prompt behavior, not chunking.

🤖 Generated with Claude Code

[Darkest-Teddy]

Added: tutor academic-integrity rule (commit 168f054)

Follow-up to the chunking work — the deferred behavioral rule.

• backend/prompts/preamble.txt: a non-negotiable ACADEMIC INTEGRITY section in the shared tutor preamble (applies to all modes — socratic/expository/teachback). The tutor must teach toward the answer (hints, steps, analogous examples) and never hand over the completed graded deliverable or reproduce verbatim solution text from uploads/retrieved context. Concepts, definitions, and general worked examples are still fully explained.
• Regression test in test_shared_course_context.py asserts the rule is present in build_system_prompt output. 25 passed, ruff clean.
• Quiz prompt intentionally unchanged — a quiz legitimately contains the marked correct answer (self-test revealed after answering), so the tutor rule doesn't apply there.

🤖 Generated with Claude Code

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

frontend/src/components/screens/Dashboard.tsx (1)

1276-1280: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the semester-empty state reachable.

This branch can never render: CoursesKey returns null at Line 1133 whenever courseProgress.length === 0. Remove or adjust that early return so an active semester with no courses shows this message and still exposes course management.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 1276 - 1280,
Update CoursesKey so it does not return null when courseProgress.length is zero
for an active semester; allow rendering to continue to the “Nothing enrolled
this semester.” state while preserving course management controls.

🧹 Nitpick comments (1)

backend/tests/test_shared_course_context.py (1)

471-478: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover every tutor mode claimed by the test.

The docstring promises the rule is present “regardless of mode,” but this test exercises only expository. Parameterize it over the supported modes so a mode-specific prompt change cannot bypass the integrity rule.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@backend/tests/test_shared_course_context.py` around lines 471 - 478, Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 265-282: Update the dashboard loading flow around the Promise.all
requests so courses and semesters are fetched first, then derive an
effectiveSemester from the stored activeSemester or the existing
courseTermLabels/resolveActiveSemester fallback before requesting graph and
recommendation data. Pass effectiveSemester to getGraph and getRecommendations,
preserving unscoped requests only when no semester can be resolved; ensure the
default path passes “Spring 2026” rather than undefined and persists that
selected semester.
---
Outside diff comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 1276-1280: Update CoursesKey so it does not return null when
courseProgress.length is zero for an active semester; allow rendering to
continue to the “Nothing enrolled this semester.” state while preserving course
management controls.
---
Nitpick comments:
In `@backend/tests/test_shared_course_context.py`:
- Around line 471-478: Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6eedc26e-16af-4a02-b10b-c42176be693d

📥 Commits

Reviewing files that changed from the base of the PR and between c3fcfdf and 3369301.

📒 Files selected for processing (9)

• backend/prompts/preamble.txt
• backend/tests/test_shared_course_context.py
• frontend/eslint-suppressions.json
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/lib/api.ts

💤 Files with no reviewable changes (1)

• frontend/eslint-suppressions.json

🚧 Files skipped from review as they are similar to previous changes (4)

• frontend/src/lib/api.ts
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Learn.tsx

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Resolve the default semester before requesting graph data.

With no stored semester, Lines 266 and 270 request unscoped data, then Line 281 selects and persists a term. This briefly renders unscoped graph/stats/recommendations and performs a second fetch. Fetch courses/semesters first, derive an effectiveSemester, then use it for the graph and recommendations requests.

Also assert the default-path getGraph call receives "Spring 2026" rather than undefined.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 265 - 282, Update
the dashboard loading flow around the Promise.all requests so courses and
semesters are fetched first, then derive an effectiveSemester from the stored
activeSemester or the existing courseTermLabels/resolveActiveSemester fallback
before requesting graph and recommendation data. Pass effectiveSemester to
getGraph and getRecommendations, preserving unscoped requests only when no
semester can be resolved; ensure the default path passes “Spring 2026” rather
than undefined and persists that selected semester.

[AndresL230]

Code review

Found 3 issues:

1. The new cross-term no-retake guard in add_course is check-then-act with no atomic enforcement: course_offerings' UNIQUE(course_id, term_id, section) does not bind for NULL sections and a race that creates two different offering rows slips past enrollments' uniqueness — a double-click on Add for a never-enrolled course can create duplicate enrollments, violating the PR's own invariant. (bug due to backend/services/graph_service.py — read via user_offering_ids_for_course, then resolve_offering(..., create=True) + insert with no constraint backing the NULL-section case)

Sapling/backend/services/graph_service.py

Lines 372 to 396 in a53e809

	# rejected instead of silently creating a second enrollment.)
	existing_offerings=user_offering_ids_for_course(user_id, course_id)
	ifexisting_offerings:
	existing_term=term_for_offering(existing_offerings[0]) or {}
	return {
	"course_id": course_id,
	"already_existed": True,
	"term": existing_term.get("label", ""),
	}
	# Resolve the requested semester label → term id. An unknown label yields
	# None, which resolve_offering treats as "current term".
	term_id=term_id_for_label(term) iftermelseNone
	offering_id=resolve_offering(course_id, term_id=term_id, create=True)
	ifnotoffering_id:
	return {"course_id": course_id, "error": "No term available to enroll into"}
	# Check if already enrolled in this offering
	existing=table("enrollments").select(
	"id",
	filters={"user_id": f"eq.{user_id}", "offering_id": f"eq.{offering_id}"},
	)
	ifexisting:
	return {"course_id": course_id, "already_existed": True}

2. CoursesKey returns null whenever courseProgress is empty, so the "Nothing enrolled this semester." empty-state later in the same component is unreachable — an empty active semester renders nothing at all in that panel. (bug due to frontend/src/components/screens/Dashboard.tsx — early if (courseProgress.length === 0) return null; above the empty-state block)

Sapling/frontend/src/components/screens/Dashboard.tsx

Lines 1129 to 1131 in a53e809

	if(courseProgress.length===0)returnnull;

3. Only Dashboard and the Courses & Semesters hub ever resolve/persist a default active semester; Learn/Quiz/Tree/Study read it but never set one — a user who deep-links to /learn first stays permanently unscoped on those screens, silently defeating the semester-scoping feature there. (bug due to frontend/src/lib/useActiveSemester.ts consumers never resolving a default outside Dashboard)

Sapling/frontend/src/lib/useActiveSemester.ts

Lines 36 to 72 in a53e809

	}
	/** [activeSemester, setActiveSemester, hydrated] — persisted to localStorage, cross-tab + same-tab
	* reactive. `hydrated` is false until the localStorage read completes after mount. */
	exportfunctionuseActiveSemester(): [string,(v: string)=>void,boolean]{
	const[sem,setSem]=useState<string>("");
	// `hydrated` flips true once we've read localStorage after mount. We start at
	// "" (not the stored value) to avoid an SSR/CSR hydration mismatch, so callers
	// that fetch based on the active semester should wait for `hydrated` to avoid
	// an initial unscoped fetch followed by a scoped refetch.
	const[hydrated,setHydrated]=useState(false);
	useEffect(()=>{
	setSem(read());
	setHydrated(true);
	constonStorage=(e: StorageEvent)=>{
	if(e.key===ACTIVE_SEMESTER_STORAGE_KEY)setSem(read());
	};
	constonCustom=()=>setSem(read());
	window.addEventListener("storage",onStorage);
	window.addEventListener(CHANGE_EVENT,onCustom);
	return()=>{
	window.removeEventListener("storage",onStorage);
	window.removeEventListener(CHANGE_EVENT,onCustom);
	};
	},[]);
	// Stable identity so consumers can safely list it in effect/callback deps.
	constupdate=useCallback((v: string)=>{
	if(typeofwindow==="undefined")return;
	window.localStorage.setItem(ACTIVE_SEMESTER_STORAGE_KEY,v);
	setSem(v);
	window.dispatchEvent(newEvent(CHANGE_EVENT));
	},[]);
	return[sem,update,hydrated];
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[AndresL230]

All three review findings above are fixed in the latest push: (1) the no-retake race is closed by migration 0036's partial unique index on course_offerings (course_id, term_id) WHERE section IS NULL, a 409-retry re-select in resolve_offering, and an in-flight disable on the hub's Add button; (2) CoursesKey now renders the 'Nothing enrolled this semester.' empty-state when an active semester scopes to zero courses; (3) Learn/Quiz/Tree/Study now resolve a default semester via ensureDefaultActiveSemester as soon as they have term labels. Also: the Add flow honors already_existed with an informational toast, the dead duplicate check was removed, first-load double-fetch eliminated, and the orphaned #140 archive helpers were deleted. Backend 1311 passed; frontend 246 passed.

[Darkest-Teddy]

Summary

Adds a semester switcher (a redesigned Courses & Semesters hub) that scopes the learning surfaces to a chosen term, and enforces a no-retake rule. Implements the approved design/plan under docs/superpowers/.

Approach: Path A — read-time filtering, no schema change / no migration. The knowledge graph stays keyed on the abstract course_id; a term filter is applied at the read boundary. Retakes are disallowed, so each course lives in exactly one semester.

Backend

• services/academics.py: term_id_for_label (label → term id, mirrors gradebook) + user_course_ids_for_term (the courses a user is enrolled in for a term).
• services/graph_service.py: get_graph(semester=) and get_recommendations(semester=) filter nodes/edges/stats (and DB-side course_id in (...) for recs) to the term's courses; add_course now rejects re-adding a course enrolled in any term (no-retake), surfacing the existing term.
• routes/graph.py: optional ?semester=<term label> on GET /api/graph/{user} and /recommendations. Absent ⇒ all terms (unchanged).

Frontend

• lib/api.ts: EnrolledCourse.term; optional semester on getGraph/getRecommendations.
• lib/useActiveSemester.ts: persisted active-semester hook ([value, setter, hydrated]) + distinctTerms/resolveActiveSemester helpers.
• Dashboard / Tree / Learn / Quiz / Study scope to the active semester; graph fetches are gated on hydration to avoid an unscoped→scoped double-fetch.
• ManageCoursesModal → Courses & Semesters hub: term tabs (set the active semester), courses grouped by term, "Already taken · " disabled state, disabled "Personal learning — Coming soon" placeholder.

Test Plan

• Backend: python -m pytest tests/ -q → 981 passed, 1 skipped (1 pre-existing unrelated OCR event-loop error).
• Frontend: npm run typecheck clean, npm run lint 0 errors, npm run test 92 passed.
• Manual: open Courses & Semesters, switch term tabs, confirm Tree/Learn/Study/Quiz + dashboard graph scope to that term.
• Manual: search a course taken in a previous term in "Add a course" → shows "Already taken · ", disabled.

Known non-blocking follow-ups

• Recent-session lists (Dashboard/Tree) are not yet term-filtered (spec §1; needs a sessions backend change).
• Stale local course selection can persist if the semester is switched mid-screen (cosmetic; shared across Learn/Tree/Quiz/Study).
• resolveActiveSemester defaults to the most-recently-enrolled term (documented heuristic, not term sort_key).
• term_id_for_label duplicates gradebook's private _term_id_for_semester — a later cleanup could consolidate.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Semester-scoped learning: graph loading and recommendations (and the related learning screens) now optionally filter by a selected semester.
  • Added a persisted “active semester” selector with automatic fallback to the most recent enrolled term.
  • Updated course management to “Courses & Semesters,” including term-aware enrollment and no-retake enforcement across all terms.
  • Improved tutor retrieval with category-aware document chunking, plus stronger academic integrity guidance.

• Bug Fixes

  • Ensured semester-filtered graph, stats, and recommendation results stay consistent.

• Tests

  • Expanded coverage for semester filtering/resolution, term enrollment behavior, API passthrough, and category chunking/indexing.

[coderabbitai]

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f229de7-a3dd-498f-9b5b-3f790de13dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 3369301 and b3d80a6.

📒 Files selected for processing (35)

• backend/db/migrations/0036_offering_null_section_unique.sql
• backend/prompts/preamble.txt
• backend/routes/documents.py
• backend/routes/gradebook.py
• backend/routes/graph.py
• backend/scripts/backfill_document_chunks.py
• backend/services/academics.py
• backend/services/chunker.py
• backend/services/graph_service.py
• backend/tests/test_academics.py
• backend/tests/test_chunker.py
• backend/tests/test_document_indexing.py
• backend/tests/test_graph_service.py
• backend/tests/test_shared_course_context.py
• docs/frontend-testids.md
• docs/superpowers/plans/2026-07-20-per-type-document-chunking.md
• docs/superpowers/plans/2026-07-20-semester-scoped-learning.md
• docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md
• docs/superpowers/specs/2026-07-20-semester-scoped-learning-design.md
• frontend/e2e/semester-scope.spec.ts
• frontend/eslint-suppressions.json
• frontend/src/components/ManageCoursesModal.test.tsx
• frontend/src/components/ManageCoursesModal.tsx
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Tree.tsx
• frontend/src/lib/api.ts
• frontend/src/lib/semesters.test.ts
• frontend/src/lib/semesters.ts
• frontend/src/lib/useActiveSemester.test.ts
• frontend/src/lib/useActiveSemester.ts
• frontend/vitest.setup.ts

📝 Walkthrough

Walkthrough

Adds semester-scoped graph and learning data across backend and frontend, persists the active semester, updates course management UI, enforces cross-term no-retakes, adds category-aware prose chunking, and strengthens tutor academic-integrity prompts.

Changes

Semester-scoped learning

Layer / File(s)	Summary
Semester-scoping contracts docs/superpowers/...	Documents read-time semester filtering, active-semester behavior, no-retake rules, affected surfaces, and verification requirements.
Term resolution and backend enforcement backend/routes/graph.py, backend/services/..., backend/tests/*	Adds term-aware routes and services, filters graphs and recommendations, supports requested enrollment terms, and rejects cross-term duplicate enrollments.
Active-semester state and API frontend/src/lib/api.ts, frontend/src/lib/useActiveSemester.ts, frontend/src/lib/*test*, frontend/eslint-suppressions.json	Adds semester request parameters, course term typing, persisted active-semester state, synchronization, and helper tests.
Dashboard and course hub frontend/src/components/screens/Dashboard.tsx, frontend/src/components/ManageCoursesModal.tsx, frontend/src/components/screens/Dashboard.test.tsx	Scopes dashboard data and redesigns course management with term selection, per-term enrollment display, and no-retake messaging.
Learning surface filters frontend/src/components/screens/{Learn,Quiz,Study,Tree}.tsx, frontend/src/components/DocumentUploadModal.test.tsx	Threads the active semester into graph loading and filters course and concept choices across learning screens.

Category-aware document chunking

Layer / File(s)	Summary
Chunking contract and implementation backend/services/chunker.py, backend/tests/test_chunker.py, docs/superpowers/...	Adds deterministic sentence-window prose chunking and category-based dispatch while retaining block chunking for other categories.
Indexing integration backend/routes/documents.py, backend/scripts/backfill_document_chunks.py, backend/tests/test_document_indexing.py	Passes document categories through live and historical chunk generation and updates indexing tests.

Academic-integrity prompt guidance

Layer / File(s)	Summary
Tutor prompt rule backend/prompts/preamble.txt, backend/tests/test_shared_course_context.py	Adds academic-integrity restrictions and verifies their inclusion in generated prompts.

Estimated code review effort: 4 (Complex) | ~75 minutes

Possibly related issues

• [EPIC] Semesters — view grades & classes by term #142 — Covers adjacent semester-aware course and learning data, including structured semester and grade-related APIs.

Possibly related PRs

• SaplingLearn/Sapling#53 — Modifies the same course-creation route and request model while this change adds term propagation.

Suggested reviewers:andresl230, jose-gael-cruz-lopez

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: semester-scoped learning plus the redesigned Courses & Semesters hub.
Description check	✅ Passed	The description is detailed and covers the summary, backend/frontend changes, testing, and follow-ups, with only minor template sections omitted.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/semester-scoped-learning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	b3d80a6	Commit Preview URL Branch Preview URL	Jul 29 2026, 11:55 AM

[Darkest-Teddy]

Added: per-type document chunking (commits 1a49ebe..c3fcfdf)

Pushed on top of the semester-scoped work. Independent of it — touches only the RAG chunking path.

What & why: the RAG pipeline used one block chunker (\n\n splitting) for every document, which mangles continuous prose (essays, written problem-set work) that lacks blank-line boundaries. This adds a second strategy and routes by the classifier's existing category.

• services/chunker.py: new chunk_prose (sentence-window, ~200-word target, ~40-word overlap, deterministic, capped at _MAX_WORDS) + chunk_for_category(text, category) dispatch. chunk_document unchanged.
• Routing: reading/assignment/study_guide → prose; everything else (incl. unknown) → block chunker.
• Wired into _index_document_chunks (live upload) and scripts/backfill_document_chunks.py. seed_quiz_fixture.py intentionally stays on the block chunker.
• Determinism preserved so content-addressed chunk IDs stay stable.

Spec/plan:docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md, docs/superpowers/plans/2026-07-20-per-type-document-chunking.md

Tests:test_chunker.py (16) + test_document_indexing.py (3) + test_rag_service.py (10) pass; per-task + final whole-branch review clean.

Out of scope (deferred, noted in the spec): a tutor system-prompt rule to never hand students assignment answers — that's prompt behavior, not chunking.

🤖 Generated with Claude Code

[Darkest-Teddy]

Added: tutor academic-integrity rule (commit 168f054)

Follow-up to the chunking work — the deferred behavioral rule.

• backend/prompts/preamble.txt: a non-negotiable ACADEMIC INTEGRITY section in the shared tutor preamble (applies to all modes — socratic/expository/teachback). The tutor must teach toward the answer (hints, steps, analogous examples) and never hand over the completed graded deliverable or reproduce verbatim solution text from uploads/retrieved context. Concepts, definitions, and general worked examples are still fully explained.
• Regression test in test_shared_course_context.py asserts the rule is present in build_system_prompt output. 25 passed, ruff clean.
• Quiz prompt intentionally unchanged — a quiz legitimately contains the marked correct answer (self-test revealed after answering), so the tutor rule doesn't apply there.

🤖 Generated with Claude Code

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

frontend/src/components/screens/Dashboard.tsx (1)

1276-1280: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the semester-empty state reachable.

This branch can never render: CoursesKey returns null at Line 1133 whenever courseProgress.length === 0. Remove or adjust that early return so an active semester with no courses shows this message and still exposes course management.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 1276 - 1280,
Update CoursesKey so it does not return null when courseProgress.length is zero
for an active semester; allow rendering to continue to the “Nothing enrolled
this semester.” state while preserving course management controls.

🧹 Nitpick comments (1)

backend/tests/test_shared_course_context.py (1)

471-478: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover every tutor mode claimed by the test.

The docstring promises the rule is present “regardless of mode,” but this test exercises only expository. Parameterize it over the supported modes so a mode-specific prompt change cannot bypass the integrity rule.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@backend/tests/test_shared_course_context.py` around lines 471 - 478, Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 265-282: Update the dashboard loading flow around the Promise.all
requests so courses and semesters are fetched first, then derive an
effectiveSemester from the stored activeSemester or the existing
courseTermLabels/resolveActiveSemester fallback before requesting graph and
recommendation data. Pass effectiveSemester to getGraph and getRecommendations,
preserving unscoped requests only when no semester can be resolved; ensure the
default path passes “Spring 2026” rather than undefined and persists that
selected semester.
---
Outside diff comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 1276-1280: Update CoursesKey so it does not return null when
courseProgress.length is zero for an active semester; allow rendering to
continue to the “Nothing enrolled this semester.” state while preserving course
management controls.
---
Nitpick comments:
In `@backend/tests/test_shared_course_context.py`:
- Around line 471-478: Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6eedc26e-16af-4a02-b10b-c42176be693d

📥 Commits

Reviewing files that changed from the base of the PR and between c3fcfdf and 3369301.

📒 Files selected for processing (9)

• backend/prompts/preamble.txt
• backend/tests/test_shared_course_context.py
• frontend/eslint-suppressions.json
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/lib/api.ts

💤 Files with no reviewable changes (1)

• frontend/eslint-suppressions.json

🚧 Files skipped from review as they are similar to previous changes (4)

• frontend/src/lib/api.ts
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Learn.tsx

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Resolve the default semester before requesting graph data.

With no stored semester, Lines 266 and 270 request unscoped data, then Line 281 selects and persists a term. This briefly renders unscoped graph/stats/recommendations and performs a second fetch. Fetch courses/semesters first, derive an effectiveSemester, then use it for the graph and recommendations requests.

Also assert the default-path getGraph call receives "Spring 2026" rather than undefined.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 265 - 282, Update
the dashboard loading flow around the Promise.all requests so courses and
semesters are fetched first, then derive an effectiveSemester from the stored
activeSemester or the existing courseTermLabels/resolveActiveSemester fallback
before requesting graph and recommendation data. Pass effectiveSemester to
getGraph and getRecommendations, preserving unscoped requests only when no
semester can be resolved; ensure the default path passes “Spring 2026” rather
than undefined and persists that selected semester.

[AndresL230]

Code review

Found 3 issues:

1. The new cross-term no-retake guard in add_course is check-then-act with no atomic enforcement: course_offerings' UNIQUE(course_id, term_id, section) does not bind for NULL sections and a race that creates two different offering rows slips past enrollments' uniqueness — a double-click on Add for a never-enrolled course can create duplicate enrollments, violating the PR's own invariant. (bug due to backend/services/graph_service.py — read via user_offering_ids_for_course, then resolve_offering(..., create=True) + insert with no constraint backing the NULL-section case)

Sapling/backend/services/graph_service.py

Lines 372 to 396 in a53e809

	# rejected instead of silently creating a second enrollment.)
	existing_offerings=user_offering_ids_for_course(user_id, course_id)
	ifexisting_offerings:
	existing_term=term_for_offering(existing_offerings[0]) or {}
	return {
	"course_id": course_id,
	"already_existed": True,
	"term": existing_term.get("label", ""),
	}
	# Resolve the requested semester label → term id. An unknown label yields
	# None, which resolve_offering treats as "current term".
	term_id=term_id_for_label(term) iftermelseNone
	offering_id=resolve_offering(course_id, term_id=term_id, create=True)
	ifnotoffering_id:
	return {"course_id": course_id, "error": "No term available to enroll into"}
	# Check if already enrolled in this offering
	existing=table("enrollments").select(
	"id",
	filters={"user_id": f"eq.{user_id}", "offering_id": f"eq.{offering_id}"},
	)
	ifexisting:
	return {"course_id": course_id, "already_existed": True}

2. CoursesKey returns null whenever courseProgress is empty, so the "Nothing enrolled this semester." empty-state later in the same component is unreachable — an empty active semester renders nothing at all in that panel. (bug due to frontend/src/components/screens/Dashboard.tsx — early if (courseProgress.length === 0) return null; above the empty-state block)

Sapling/frontend/src/components/screens/Dashboard.tsx

Lines 1129 to 1131 in a53e809

	if(courseProgress.length===0)returnnull;

3. Only Dashboard and the Courses & Semesters hub ever resolve/persist a default active semester; Learn/Quiz/Tree/Study read it but never set one — a user who deep-links to /learn first stays permanently unscoped on those screens, silently defeating the semester-scoping feature there. (bug due to frontend/src/lib/useActiveSemester.ts consumers never resolving a default outside Dashboard)

Sapling/frontend/src/lib/useActiveSemester.ts

Lines 36 to 72 in a53e809

	}
	/** [activeSemester, setActiveSemester, hydrated] — persisted to localStorage, cross-tab + same-tab
	* reactive. `hydrated` is false until the localStorage read completes after mount. */
	exportfunctionuseActiveSemester(): [string,(v: string)=>void,boolean]{
	const[sem,setSem]=useState<string>("");
	// `hydrated` flips true once we've read localStorage after mount. We start at
	// "" (not the stored value) to avoid an SSR/CSR hydration mismatch, so callers
	// that fetch based on the active semester should wait for `hydrated` to avoid
	// an initial unscoped fetch followed by a scoped refetch.
	const[hydrated,setHydrated]=useState(false);
	useEffect(()=>{
	setSem(read());
	setHydrated(true);
	constonStorage=(e: StorageEvent)=>{
	if(e.key===ACTIVE_SEMESTER_STORAGE_KEY)setSem(read());
	};
	constonCustom=()=>setSem(read());
	window.addEventListener("storage",onStorage);
	window.addEventListener(CHANGE_EVENT,onCustom);
	return()=>{
	window.removeEventListener("storage",onStorage);
	window.removeEventListener(CHANGE_EVENT,onCustom);
	};
	},[]);
	// Stable identity so consumers can safely list it in effect/callback deps.
	constupdate=useCallback((v: string)=>{
	if(typeofwindow==="undefined")return;
	window.localStorage.setItem(ACTIVE_SEMESTER_STORAGE_KEY,v);
	setSem(v);
	window.dispatchEvent(newEvent(CHANGE_EVENT));
	},[]);
	return[sem,update,hydrated];
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[AndresL230]

All three review findings above are fixed in the latest push: (1) the no-retake race is closed by migration 0036's partial unique index on course_offerings (course_id, term_id) WHERE section IS NULL, a 409-retry re-select in resolve_offering, and an in-flight disable on the hub's Add button; (2) CoursesKey now renders the 'Nothing enrolled this semester.' empty-state when an active semester scopes to zero courses; (3) Learn/Quiz/Tree/Study now resolve a default semester via ensureDefaultActiveSemester as soon as they have term labels. Also: the Add flow honors already_existed with an informational toast, the dead duplicate check was removed, first-load double-fetch eliminated, and the orphaned #140 archive helpers were deleted. Backend 1311 passed; frontend 246 passed.

[Darkest-Teddy]

Summary

Adds a semester switcher (a redesigned Courses & Semesters hub) that scopes the learning surfaces to a chosen term, and enforces a no-retake rule. Implements the approved design/plan under docs/superpowers/.

Approach: Path A — read-time filtering, no schema change / no migration. The knowledge graph stays keyed on the abstract course_id; a term filter is applied at the read boundary. Retakes are disallowed, so each course lives in exactly one semester.

Backend

• services/academics.py: term_id_for_label (label → term id, mirrors gradebook) + user_course_ids_for_term (the courses a user is enrolled in for a term).
• services/graph_service.py: get_graph(semester=) and get_recommendations(semester=) filter nodes/edges/stats (and DB-side course_id in (...) for recs) to the term's courses; add_course now rejects re-adding a course enrolled in any term (no-retake), surfacing the existing term.
• routes/graph.py: optional ?semester=<term label> on GET /api/graph/{user} and /recommendations. Absent ⇒ all terms (unchanged).

Frontend

• lib/api.ts: EnrolledCourse.term; optional semester on getGraph/getRecommendations.
• lib/useActiveSemester.ts: persisted active-semester hook ([value, setter, hydrated]) + distinctTerms/resolveActiveSemester helpers.
• Dashboard / Tree / Learn / Quiz / Study scope to the active semester; graph fetches are gated on hydration to avoid an unscoped→scoped double-fetch.
• ManageCoursesModal → Courses & Semesters hub: term tabs (set the active semester), courses grouped by term, "Already taken · " disabled state, disabled "Personal learning — Coming soon" placeholder.

Test Plan

• Backend: python -m pytest tests/ -q → 981 passed, 1 skipped (1 pre-existing unrelated OCR event-loop error).
• Frontend: npm run typecheck clean, npm run lint 0 errors, npm run test 92 passed.
• Manual: open Courses & Semesters, switch term tabs, confirm Tree/Learn/Study/Quiz + dashboard graph scope to that term.
• Manual: search a course taken in a previous term in "Add a course" → shows "Already taken · ", disabled.

Known non-blocking follow-ups

• Recent-session lists (Dashboard/Tree) are not yet term-filtered (spec §1; needs a sessions backend change).
• Stale local course selection can persist if the semester is switched mid-screen (cosmetic; shared across Learn/Tree/Quiz/Study).
• resolveActiveSemester defaults to the most-recently-enrolled term (documented heuristic, not term sort_key).
• term_id_for_label duplicates gradebook's private _term_id_for_semester — a later cleanup could consolidate.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Semester-scoped learning: graph loading and recommendations (and the related learning screens) now optionally filter by a selected semester.
  • Added a persisted “active semester” selector with automatic fallback to the most recent enrolled term.
  • Updated course management to “Courses & Semesters,” including term-aware enrollment and no-retake enforcement across all terms.
  • Improved tutor retrieval with category-aware document chunking, plus stronger academic integrity guidance.

• Bug Fixes

  • Ensured semester-filtered graph, stats, and recommendation results stay consistent.

• Tests

  • Expanded coverage for semester filtering/resolution, term enrollment behavior, API passthrough, and category chunking/indexing.

[coderabbitai]

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f229de7-a3dd-498f-9b5b-3f790de13dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 3369301 and b3d80a6.

📒 Files selected for processing (35)

• backend/db/migrations/0036_offering_null_section_unique.sql
• backend/prompts/preamble.txt
• backend/routes/documents.py
• backend/routes/gradebook.py
• backend/routes/graph.py
• backend/scripts/backfill_document_chunks.py
• backend/services/academics.py
• backend/services/chunker.py
• backend/services/graph_service.py
• backend/tests/test_academics.py
• backend/tests/test_chunker.py
• backend/tests/test_document_indexing.py
• backend/tests/test_graph_service.py
• backend/tests/test_shared_course_context.py
• docs/frontend-testids.md
• docs/superpowers/plans/2026-07-20-per-type-document-chunking.md
• docs/superpowers/plans/2026-07-20-semester-scoped-learning.md
• docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md
• docs/superpowers/specs/2026-07-20-semester-scoped-learning-design.md
• frontend/e2e/semester-scope.spec.ts
• frontend/eslint-suppressions.json
• frontend/src/components/ManageCoursesModal.test.tsx
• frontend/src/components/ManageCoursesModal.tsx
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Tree.tsx
• frontend/src/lib/api.ts
• frontend/src/lib/semesters.test.ts
• frontend/src/lib/semesters.ts
• frontend/src/lib/useActiveSemester.test.ts
• frontend/src/lib/useActiveSemester.ts
• frontend/vitest.setup.ts

📝 Walkthrough

Walkthrough

Adds semester-scoped graph and learning data across backend and frontend, persists the active semester, updates course management UI, enforces cross-term no-retakes, adds category-aware prose chunking, and strengthens tutor academic-integrity prompts.

Changes

Semester-scoped learning

Layer / File(s)	Summary
Semester-scoping contracts docs/superpowers/...	Documents read-time semester filtering, active-semester behavior, no-retake rules, affected surfaces, and verification requirements.
Term resolution and backend enforcement backend/routes/graph.py, backend/services/..., backend/tests/*	Adds term-aware routes and services, filters graphs and recommendations, supports requested enrollment terms, and rejects cross-term duplicate enrollments.
Active-semester state and API frontend/src/lib/api.ts, frontend/src/lib/useActiveSemester.ts, frontend/src/lib/*test*, frontend/eslint-suppressions.json	Adds semester request parameters, course term typing, persisted active-semester state, synchronization, and helper tests.
Dashboard and course hub frontend/src/components/screens/Dashboard.tsx, frontend/src/components/ManageCoursesModal.tsx, frontend/src/components/screens/Dashboard.test.tsx	Scopes dashboard data and redesigns course management with term selection, per-term enrollment display, and no-retake messaging.
Learning surface filters frontend/src/components/screens/{Learn,Quiz,Study,Tree}.tsx, frontend/src/components/DocumentUploadModal.test.tsx	Threads the active semester into graph loading and filters course and concept choices across learning screens.

Category-aware document chunking

Layer / File(s)	Summary
Chunking contract and implementation backend/services/chunker.py, backend/tests/test_chunker.py, docs/superpowers/...	Adds deterministic sentence-window prose chunking and category-based dispatch while retaining block chunking for other categories.
Indexing integration backend/routes/documents.py, backend/scripts/backfill_document_chunks.py, backend/tests/test_document_indexing.py	Passes document categories through live and historical chunk generation and updates indexing tests.

Academic-integrity prompt guidance

Layer / File(s)	Summary
Tutor prompt rule backend/prompts/preamble.txt, backend/tests/test_shared_course_context.py	Adds academic-integrity restrictions and verifies their inclusion in generated prompts.

Estimated code review effort: 4 (Complex) | ~75 minutes

Possibly related issues

• [EPIC] Semesters — view grades & classes by term #142 — Covers adjacent semester-aware course and learning data, including structured semester and grade-related APIs.

Possibly related PRs

• SaplingLearn/Sapling#53 — Modifies the same course-creation route and request model while this change adds term propagation.

Suggested reviewers:andresl230, jose-gael-cruz-lopez

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: semester-scoped learning plus the redesigned Courses & Semesters hub.
Description check	✅ Passed	The description is detailed and covers the summary, backend/frontend changes, testing, and follow-ups, with only minor template sections omitted.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/semester-scoped-learning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	b3d80a6	Commit Preview URL Branch Preview URL	Jul 29 2026, 11:55 AM

[Darkest-Teddy]

Added: per-type document chunking (commits 1a49ebe..c3fcfdf)

Pushed on top of the semester-scoped work. Independent of it — touches only the RAG chunking path.

What & why: the RAG pipeline used one block chunker (\n\n splitting) for every document, which mangles continuous prose (essays, written problem-set work) that lacks blank-line boundaries. This adds a second strategy and routes by the classifier's existing category.

• services/chunker.py: new chunk_prose (sentence-window, ~200-word target, ~40-word overlap, deterministic, capped at _MAX_WORDS) + chunk_for_category(text, category) dispatch. chunk_document unchanged.
• Routing: reading/assignment/study_guide → prose; everything else (incl. unknown) → block chunker.
• Wired into _index_document_chunks (live upload) and scripts/backfill_document_chunks.py. seed_quiz_fixture.py intentionally stays on the block chunker.
• Determinism preserved so content-addressed chunk IDs stay stable.

Spec/plan:docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md, docs/superpowers/plans/2026-07-20-per-type-document-chunking.md

Tests:test_chunker.py (16) + test_document_indexing.py (3) + test_rag_service.py (10) pass; per-task + final whole-branch review clean.

Out of scope (deferred, noted in the spec): a tutor system-prompt rule to never hand students assignment answers — that's prompt behavior, not chunking.

🤖 Generated with Claude Code

[Darkest-Teddy]

Added: tutor academic-integrity rule (commit 168f054)

Follow-up to the chunking work — the deferred behavioral rule.

• backend/prompts/preamble.txt: a non-negotiable ACADEMIC INTEGRITY section in the shared tutor preamble (applies to all modes — socratic/expository/teachback). The tutor must teach toward the answer (hints, steps, analogous examples) and never hand over the completed graded deliverable or reproduce verbatim solution text from uploads/retrieved context. Concepts, definitions, and general worked examples are still fully explained.
• Regression test in test_shared_course_context.py asserts the rule is present in build_system_prompt output. 25 passed, ruff clean.
• Quiz prompt intentionally unchanged — a quiz legitimately contains the marked correct answer (self-test revealed after answering), so the tutor rule doesn't apply there.

🤖 Generated with Claude Code

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

frontend/src/components/screens/Dashboard.tsx (1)

1276-1280: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the semester-empty state reachable.

This branch can never render: CoursesKey returns null at Line 1133 whenever courseProgress.length === 0. Remove or adjust that early return so an active semester with no courses shows this message and still exposes course management.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 1276 - 1280,
Update CoursesKey so it does not return null when courseProgress.length is zero
for an active semester; allow rendering to continue to the “Nothing enrolled
this semester.” state while preserving course management controls.

🧹 Nitpick comments (1)

backend/tests/test_shared_course_context.py (1)

471-478: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover every tutor mode claimed by the test.

The docstring promises the rule is present “regardless of mode,” but this test exercises only expository. Parameterize it over the supported modes so a mode-specific prompt change cannot bypass the integrity rule.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@backend/tests/test_shared_course_context.py` around lines 471 - 478, Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 265-282: Update the dashboard loading flow around the Promise.all
requests so courses and semesters are fetched first, then derive an
effectiveSemester from the stored activeSemester or the existing
courseTermLabels/resolveActiveSemester fallback before requesting graph and
recommendation data. Pass effectiveSemester to getGraph and getRecommendations,
preserving unscoped requests only when no semester can be resolved; ensure the
default path passes “Spring 2026” rather than undefined and persists that
selected semester.
---
Outside diff comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 1276-1280: Update CoursesKey so it does not return null when
courseProgress.length is zero for an active semester; allow rendering to
continue to the “Nothing enrolled this semester.” state while preserving course
management controls.
---
Nitpick comments:
In `@backend/tests/test_shared_course_context.py`:
- Around line 471-478: Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6eedc26e-16af-4a02-b10b-c42176be693d

📥 Commits

Reviewing files that changed from the base of the PR and between c3fcfdf and 3369301.

📒 Files selected for processing (9)

• backend/prompts/preamble.txt
• backend/tests/test_shared_course_context.py
• frontend/eslint-suppressions.json
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/lib/api.ts

💤 Files with no reviewable changes (1)

• frontend/eslint-suppressions.json

🚧 Files skipped from review as they are similar to previous changes (4)

• frontend/src/lib/api.ts
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Learn.tsx

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Resolve the default semester before requesting graph data.

With no stored semester, Lines 266 and 270 request unscoped data, then Line 281 selects and persists a term. This briefly renders unscoped graph/stats/recommendations and performs a second fetch. Fetch courses/semesters first, derive an effectiveSemester, then use it for the graph and recommendations requests.

Also assert the default-path getGraph call receives "Spring 2026" rather than undefined.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 265 - 282, Update
the dashboard loading flow around the Promise.all requests so courses and
semesters are fetched first, then derive an effectiveSemester from the stored
activeSemester or the existing courseTermLabels/resolveActiveSemester fallback
before requesting graph and recommendation data. Pass effectiveSemester to
getGraph and getRecommendations, preserving unscoped requests only when no
semester can be resolved; ensure the default path passes “Spring 2026” rather
than undefined and persists that selected semester.

[AndresL230]

Code review

Found 3 issues:

1. The new cross-term no-retake guard in add_course is check-then-act with no atomic enforcement: course_offerings' UNIQUE(course_id, term_id, section) does not bind for NULL sections and a race that creates two different offering rows slips past enrollments' uniqueness — a double-click on Add for a never-enrolled course can create duplicate enrollments, violating the PR's own invariant. (bug due to backend/services/graph_service.py — read via user_offering_ids_for_course, then resolve_offering(..., create=True) + insert with no constraint backing the NULL-section case)

Sapling/backend/services/graph_service.py

Lines 372 to 396 in a53e809

	# rejected instead of silently creating a second enrollment.)
	existing_offerings=user_offering_ids_for_course(user_id, course_id)
	ifexisting_offerings:
	existing_term=term_for_offering(existing_offerings[0]) or {}
	return {
	"course_id": course_id,
	"already_existed": True,
	"term": existing_term.get("label", ""),
	}
	# Resolve the requested semester label → term id. An unknown label yields
	# None, which resolve_offering treats as "current term".
	term_id=term_id_for_label(term) iftermelseNone
	offering_id=resolve_offering(course_id, term_id=term_id, create=True)
	ifnotoffering_id:
	return {"course_id": course_id, "error": "No term available to enroll into"}
	# Check if already enrolled in this offering
	existing=table("enrollments").select(
	"id",
	filters={"user_id": f"eq.{user_id}", "offering_id": f"eq.{offering_id}"},
	)
	ifexisting:
	return {"course_id": course_id, "already_existed": True}

2. CoursesKey returns null whenever courseProgress is empty, so the "Nothing enrolled this semester." empty-state later in the same component is unreachable — an empty active semester renders nothing at all in that panel. (bug due to frontend/src/components/screens/Dashboard.tsx — early if (courseProgress.length === 0) return null; above the empty-state block)

Sapling/frontend/src/components/screens/Dashboard.tsx

Lines 1129 to 1131 in a53e809

	if(courseProgress.length===0)returnnull;

3. Only Dashboard and the Courses & Semesters hub ever resolve/persist a default active semester; Learn/Quiz/Tree/Study read it but never set one — a user who deep-links to /learn first stays permanently unscoped on those screens, silently defeating the semester-scoping feature there. (bug due to frontend/src/lib/useActiveSemester.ts consumers never resolving a default outside Dashboard)

Sapling/frontend/src/lib/useActiveSemester.ts

Lines 36 to 72 in a53e809

	}
	/** [activeSemester, setActiveSemester, hydrated] — persisted to localStorage, cross-tab + same-tab
	* reactive. `hydrated` is false until the localStorage read completes after mount. */
	exportfunctionuseActiveSemester(): [string,(v: string)=>void,boolean]{
	const[sem,setSem]=useState<string>("");
	// `hydrated` flips true once we've read localStorage after mount. We start at
	// "" (not the stored value) to avoid an SSR/CSR hydration mismatch, so callers
	// that fetch based on the active semester should wait for `hydrated` to avoid
	// an initial unscoped fetch followed by a scoped refetch.
	const[hydrated,setHydrated]=useState(false);
	useEffect(()=>{
	setSem(read());
	setHydrated(true);
	constonStorage=(e: StorageEvent)=>{
	if(e.key===ACTIVE_SEMESTER_STORAGE_KEY)setSem(read());
	};
	constonCustom=()=>setSem(read());
	window.addEventListener("storage",onStorage);
	window.addEventListener(CHANGE_EVENT,onCustom);
	return()=>{
	window.removeEventListener("storage",onStorage);
	window.removeEventListener(CHANGE_EVENT,onCustom);
	};
	},[]);
	// Stable identity so consumers can safely list it in effect/callback deps.
	constupdate=useCallback((v: string)=>{
	if(typeofwindow==="undefined")return;
	window.localStorage.setItem(ACTIVE_SEMESTER_STORAGE_KEY,v);
	setSem(v);
	window.dispatchEvent(newEvent(CHANGE_EVENT));
	},[]);
	return[sem,update,hydrated];
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[AndresL230]

All three review findings above are fixed in the latest push: (1) the no-retake race is closed by migration 0036's partial unique index on course_offerings (course_id, term_id) WHERE section IS NULL, a 409-retry re-select in resolve_offering, and an in-flight disable on the hub's Add button; (2) CoursesKey now renders the 'Nothing enrolled this semester.' empty-state when an active semester scopes to zero courses; (3) Learn/Quiz/Tree/Study now resolve a default semester via ensureDefaultActiveSemester as soon as they have term labels. Also: the Add flow honors already_existed with an informational toast, the dead duplicate check was removed, first-load double-fetch eliminated, and the orphaned #140 archive helpers were deleted. Backend 1311 passed; frontend 246 passed.

[Darkest-Teddy]

Summary

Adds a semester switcher (a redesigned Courses & Semesters hub) that scopes the learning surfaces to a chosen term, and enforces a no-retake rule. Implements the approved design/plan under docs/superpowers/.

Approach: Path A — read-time filtering, no schema change / no migration. The knowledge graph stays keyed on the abstract course_id; a term filter is applied at the read boundary. Retakes are disallowed, so each course lives in exactly one semester.

Backend

• services/academics.py: term_id_for_label (label → term id, mirrors gradebook) + user_course_ids_for_term (the courses a user is enrolled in for a term).
• services/graph_service.py: get_graph(semester=) and get_recommendations(semester=) filter nodes/edges/stats (and DB-side course_id in (...) for recs) to the term's courses; add_course now rejects re-adding a course enrolled in any term (no-retake), surfacing the existing term.
• routes/graph.py: optional ?semester=<term label> on GET /api/graph/{user} and /recommendations. Absent ⇒ all terms (unchanged).

Frontend

• lib/api.ts: EnrolledCourse.term; optional semester on getGraph/getRecommendations.
• lib/useActiveSemester.ts: persisted active-semester hook ([value, setter, hydrated]) + distinctTerms/resolveActiveSemester helpers.
• Dashboard / Tree / Learn / Quiz / Study scope to the active semester; graph fetches are gated on hydration to avoid an unscoped→scoped double-fetch.
• ManageCoursesModal → Courses & Semesters hub: term tabs (set the active semester), courses grouped by term, "Already taken · " disabled state, disabled "Personal learning — Coming soon" placeholder.

Test Plan

• Backend: python -m pytest tests/ -q → 981 passed, 1 skipped (1 pre-existing unrelated OCR event-loop error).
• Frontend: npm run typecheck clean, npm run lint 0 errors, npm run test 92 passed.
• Manual: open Courses & Semesters, switch term tabs, confirm Tree/Learn/Study/Quiz + dashboard graph scope to that term.
• Manual: search a course taken in a previous term in "Add a course" → shows "Already taken · ", disabled.

Known non-blocking follow-ups

• Recent-session lists (Dashboard/Tree) are not yet term-filtered (spec §1; needs a sessions backend change).
• Stale local course selection can persist if the semester is switched mid-screen (cosmetic; shared across Learn/Tree/Quiz/Study).
• resolveActiveSemester defaults to the most-recently-enrolled term (documented heuristic, not term sort_key).
• term_id_for_label duplicates gradebook's private _term_id_for_semester — a later cleanup could consolidate.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Semester-scoped learning: graph loading and recommendations (and the related learning screens) now optionally filter by a selected semester.
  • Added a persisted “active semester” selector with automatic fallback to the most recent enrolled term.
  • Updated course management to “Courses & Semesters,” including term-aware enrollment and no-retake enforcement across all terms.
  • Improved tutor retrieval with category-aware document chunking, plus stronger academic integrity guidance.

• Bug Fixes

  • Ensured semester-filtered graph, stats, and recommendation results stay consistent.

• Tests

  • Expanded coverage for semester filtering/resolution, term enrollment behavior, API passthrough, and category chunking/indexing.

[coderabbitai]

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f229de7-a3dd-498f-9b5b-3f790de13dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 3369301 and b3d80a6.

📒 Files selected for processing (35)

• backend/db/migrations/0036_offering_null_section_unique.sql
• backend/prompts/preamble.txt
• backend/routes/documents.py
• backend/routes/gradebook.py
• backend/routes/graph.py
• backend/scripts/backfill_document_chunks.py
• backend/services/academics.py
• backend/services/chunker.py
• backend/services/graph_service.py
• backend/tests/test_academics.py
• backend/tests/test_chunker.py
• backend/tests/test_document_indexing.py
• backend/tests/test_graph_service.py
• backend/tests/test_shared_course_context.py
• docs/frontend-testids.md
• docs/superpowers/plans/2026-07-20-per-type-document-chunking.md
• docs/superpowers/plans/2026-07-20-semester-scoped-learning.md
• docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md
• docs/superpowers/specs/2026-07-20-semester-scoped-learning-design.md
• frontend/e2e/semester-scope.spec.ts
• frontend/eslint-suppressions.json
• frontend/src/components/ManageCoursesModal.test.tsx
• frontend/src/components/ManageCoursesModal.tsx
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Tree.tsx
• frontend/src/lib/api.ts
• frontend/src/lib/semesters.test.ts
• frontend/src/lib/semesters.ts
• frontend/src/lib/useActiveSemester.test.ts
• frontend/src/lib/useActiveSemester.ts
• frontend/vitest.setup.ts

📝 Walkthrough

Walkthrough

Adds semester-scoped graph and learning data across backend and frontend, persists the active semester, updates course management UI, enforces cross-term no-retakes, adds category-aware prose chunking, and strengthens tutor academic-integrity prompts.

Changes

Semester-scoped learning

Layer / File(s)	Summary
Semester-scoping contracts docs/superpowers/...	Documents read-time semester filtering, active-semester behavior, no-retake rules, affected surfaces, and verification requirements.
Term resolution and backend enforcement backend/routes/graph.py, backend/services/..., backend/tests/*	Adds term-aware routes and services, filters graphs and recommendations, supports requested enrollment terms, and rejects cross-term duplicate enrollments.
Active-semester state and API frontend/src/lib/api.ts, frontend/src/lib/useActiveSemester.ts, frontend/src/lib/*test*, frontend/eslint-suppressions.json	Adds semester request parameters, course term typing, persisted active-semester state, synchronization, and helper tests.
Dashboard and course hub frontend/src/components/screens/Dashboard.tsx, frontend/src/components/ManageCoursesModal.tsx, frontend/src/components/screens/Dashboard.test.tsx	Scopes dashboard data and redesigns course management with term selection, per-term enrollment display, and no-retake messaging.
Learning surface filters frontend/src/components/screens/{Learn,Quiz,Study,Tree}.tsx, frontend/src/components/DocumentUploadModal.test.tsx	Threads the active semester into graph loading and filters course and concept choices across learning screens.

Category-aware document chunking

Layer / File(s)	Summary
Chunking contract and implementation backend/services/chunker.py, backend/tests/test_chunker.py, docs/superpowers/...	Adds deterministic sentence-window prose chunking and category-based dispatch while retaining block chunking for other categories.
Indexing integration backend/routes/documents.py, backend/scripts/backfill_document_chunks.py, backend/tests/test_document_indexing.py	Passes document categories through live and historical chunk generation and updates indexing tests.

Academic-integrity prompt guidance

Layer / File(s)	Summary
Tutor prompt rule backend/prompts/preamble.txt, backend/tests/test_shared_course_context.py	Adds academic-integrity restrictions and verifies their inclusion in generated prompts.

Estimated code review effort: 4 (Complex) | ~75 minutes

Possibly related issues

• [EPIC] Semesters — view grades & classes by term #142 — Covers adjacent semester-aware course and learning data, including structured semester and grade-related APIs.

Possibly related PRs

• SaplingLearn/Sapling#53 — Modifies the same course-creation route and request model while this change adds term propagation.

Suggested reviewers:andresl230, jose-gael-cruz-lopez

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: semester-scoped learning plus the redesigned Courses & Semesters hub.
Description check	✅ Passed	The description is detailed and covers the summary, backend/frontend changes, testing, and follow-ups, with only minor template sections omitted.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/semester-scoped-learning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	b3d80a6	Commit Preview URL Branch Preview URL	Jul 29 2026, 11:55 AM

[Darkest-Teddy]

Added: per-type document chunking (commits 1a49ebe..c3fcfdf)

Pushed on top of the semester-scoped work. Independent of it — touches only the RAG chunking path.

What & why: the RAG pipeline used one block chunker (\n\n splitting) for every document, which mangles continuous prose (essays, written problem-set work) that lacks blank-line boundaries. This adds a second strategy and routes by the classifier's existing category.

• services/chunker.py: new chunk_prose (sentence-window, ~200-word target, ~40-word overlap, deterministic, capped at _MAX_WORDS) + chunk_for_category(text, category) dispatch. chunk_document unchanged.
• Routing: reading/assignment/study_guide → prose; everything else (incl. unknown) → block chunker.
• Wired into _index_document_chunks (live upload) and scripts/backfill_document_chunks.py. seed_quiz_fixture.py intentionally stays on the block chunker.
• Determinism preserved so content-addressed chunk IDs stay stable.

Spec/plan:docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md, docs/superpowers/plans/2026-07-20-per-type-document-chunking.md

Tests:test_chunker.py (16) + test_document_indexing.py (3) + test_rag_service.py (10) pass; per-task + final whole-branch review clean.

Out of scope (deferred, noted in the spec): a tutor system-prompt rule to never hand students assignment answers — that's prompt behavior, not chunking.

🤖 Generated with Claude Code

[Darkest-Teddy]

Added: tutor academic-integrity rule (commit 168f054)

Follow-up to the chunking work — the deferred behavioral rule.

• backend/prompts/preamble.txt: a non-negotiable ACADEMIC INTEGRITY section in the shared tutor preamble (applies to all modes — socratic/expository/teachback). The tutor must teach toward the answer (hints, steps, analogous examples) and never hand over the completed graded deliverable or reproduce verbatim solution text from uploads/retrieved context. Concepts, definitions, and general worked examples are still fully explained.
• Regression test in test_shared_course_context.py asserts the rule is present in build_system_prompt output. 25 passed, ruff clean.
• Quiz prompt intentionally unchanged — a quiz legitimately contains the marked correct answer (self-test revealed after answering), so the tutor rule doesn't apply there.

🤖 Generated with Claude Code

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

frontend/src/components/screens/Dashboard.tsx (1)

1276-1280: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the semester-empty state reachable.

This branch can never render: CoursesKey returns null at Line 1133 whenever courseProgress.length === 0. Remove or adjust that early return so an active semester with no courses shows this message and still exposes course management.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 1276 - 1280,
Update CoursesKey so it does not return null when courseProgress.length is zero
for an active semester; allow rendering to continue to the “Nothing enrolled
this semester.” state while preserving course management controls.

🧹 Nitpick comments (1)

backend/tests/test_shared_course_context.py (1)

471-478: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover every tutor mode claimed by the test.

The docstring promises the rule is present “regardless of mode,” but this test exercises only expository. Parameterize it over the supported modes so a mode-specific prompt change cannot bypass the integrity rule.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@backend/tests/test_shared_course_context.py` around lines 471 - 478, Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 265-282: Update the dashboard loading flow around the Promise.all
requests so courses and semesters are fetched first, then derive an
effectiveSemester from the stored activeSemester or the existing
courseTermLabels/resolveActiveSemester fallback before requesting graph and
recommendation data. Pass effectiveSemester to getGraph and getRecommendations,
preserving unscoped requests only when no semester can be resolved; ensure the
default path passes “Spring 2026” rather than undefined and persists that
selected semester.
---
Outside diff comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 1276-1280: Update CoursesKey so it does not return null when
courseProgress.length is zero for an active semester; allow rendering to
continue to the “Nothing enrolled this semester.” state while preserving course
management controls.
---
Nitpick comments:
In `@backend/tests/test_shared_course_context.py`:
- Around line 471-478: Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6eedc26e-16af-4a02-b10b-c42176be693d

📥 Commits

Reviewing files that changed from the base of the PR and between c3fcfdf and 3369301.

📒 Files selected for processing (9)

• backend/prompts/preamble.txt
• backend/tests/test_shared_course_context.py
• frontend/eslint-suppressions.json
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/lib/api.ts

💤 Files with no reviewable changes (1)

• frontend/eslint-suppressions.json

🚧 Files skipped from review as they are similar to previous changes (4)

• frontend/src/lib/api.ts
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Learn.tsx

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Resolve the default semester before requesting graph data.

With no stored semester, Lines 266 and 270 request unscoped data, then Line 281 selects and persists a term. This briefly renders unscoped graph/stats/recommendations and performs a second fetch. Fetch courses/semesters first, derive an effectiveSemester, then use it for the graph and recommendations requests.

Also assert the default-path getGraph call receives "Spring 2026" rather than undefined.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 265 - 282, Update
the dashboard loading flow around the Promise.all requests so courses and
semesters are fetched first, then derive an effectiveSemester from the stored
activeSemester or the existing courseTermLabels/resolveActiveSemester fallback
before requesting graph and recommendation data. Pass effectiveSemester to
getGraph and getRecommendations, preserving unscoped requests only when no
semester can be resolved; ensure the default path passes “Spring 2026” rather
than undefined and persists that selected semester.

[AndresL230]

Code review

Found 3 issues:

1. The new cross-term no-retake guard in add_course is check-then-act with no atomic enforcement: course_offerings' UNIQUE(course_id, term_id, section) does not bind for NULL sections and a race that creates two different offering rows slips past enrollments' uniqueness — a double-click on Add for a never-enrolled course can create duplicate enrollments, violating the PR's own invariant. (bug due to backend/services/graph_service.py — read via user_offering_ids_for_course, then resolve_offering(..., create=True) + insert with no constraint backing the NULL-section case)

Sapling/backend/services/graph_service.py

Lines 372 to 396 in a53e809

	# rejected instead of silently creating a second enrollment.)
	existing_offerings=user_offering_ids_for_course(user_id, course_id)
	ifexisting_offerings:
	existing_term=term_for_offering(existing_offerings[0]) or {}
	return {
	"course_id": course_id,
	"already_existed": True,
	"term": existing_term.get("label", ""),
	}
	# Resolve the requested semester label → term id. An unknown label yields
	# None, which resolve_offering treats as "current term".
	term_id=term_id_for_label(term) iftermelseNone
	offering_id=resolve_offering(course_id, term_id=term_id, create=True)
	ifnotoffering_id:
	return {"course_id": course_id, "error": "No term available to enroll into"}
	# Check if already enrolled in this offering
	existing=table("enrollments").select(
	"id",
	filters={"user_id": f"eq.{user_id}", "offering_id": f"eq.{offering_id}"},
	)
	ifexisting:
	return {"course_id": course_id, "already_existed": True}

2. CoursesKey returns null whenever courseProgress is empty, so the "Nothing enrolled this semester." empty-state later in the same component is unreachable — an empty active semester renders nothing at all in that panel. (bug due to frontend/src/components/screens/Dashboard.tsx — early if (courseProgress.length === 0) return null; above the empty-state block)

Sapling/frontend/src/components/screens/Dashboard.tsx

Lines 1129 to 1131 in a53e809

	if(courseProgress.length===0)returnnull;

3. Only Dashboard and the Courses & Semesters hub ever resolve/persist a default active semester; Learn/Quiz/Tree/Study read it but never set one — a user who deep-links to /learn first stays permanently unscoped on those screens, silently defeating the semester-scoping feature there. (bug due to frontend/src/lib/useActiveSemester.ts consumers never resolving a default outside Dashboard)

Sapling/frontend/src/lib/useActiveSemester.ts

Lines 36 to 72 in a53e809

	}
	/** [activeSemester, setActiveSemester, hydrated] — persisted to localStorage, cross-tab + same-tab
	* reactive. `hydrated` is false until the localStorage read completes after mount. */
	exportfunctionuseActiveSemester(): [string,(v: string)=>void,boolean]{
	const[sem,setSem]=useState<string>("");
	// `hydrated` flips true once we've read localStorage after mount. We start at
	// "" (not the stored value) to avoid an SSR/CSR hydration mismatch, so callers
	// that fetch based on the active semester should wait for `hydrated` to avoid
	// an initial unscoped fetch followed by a scoped refetch.
	const[hydrated,setHydrated]=useState(false);
	useEffect(()=>{
	setSem(read());
	setHydrated(true);
	constonStorage=(e: StorageEvent)=>{
	if(e.key===ACTIVE_SEMESTER_STORAGE_KEY)setSem(read());
	};
	constonCustom=()=>setSem(read());
	window.addEventListener("storage",onStorage);
	window.addEventListener(CHANGE_EVENT,onCustom);
	return()=>{
	window.removeEventListener("storage",onStorage);
	window.removeEventListener(CHANGE_EVENT,onCustom);
	};
	},[]);
	// Stable identity so consumers can safely list it in effect/callback deps.
	constupdate=useCallback((v: string)=>{
	if(typeofwindow==="undefined")return;
	window.localStorage.setItem(ACTIVE_SEMESTER_STORAGE_KEY,v);
	setSem(v);
	window.dispatchEvent(newEvent(CHANGE_EVENT));
	},[]);
	return[sem,update,hydrated];
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[AndresL230]

All three review findings above are fixed in the latest push: (1) the no-retake race is closed by migration 0036's partial unique index on course_offerings (course_id, term_id) WHERE section IS NULL, a 409-retry re-select in resolve_offering, and an in-flight disable on the hub's Add button; (2) CoursesKey now renders the 'Nothing enrolled this semester.' empty-state when an active semester scopes to zero courses; (3) Learn/Quiz/Tree/Study now resolve a default semester via ensureDefaultActiveSemester as soon as they have term labels. Also: the Add flow honors already_existed with an informational toast, the dead duplicate check was removed, first-load double-fetch eliminated, and the orphaned #140 archive helpers were deleted. Backend 1311 passed; frontend 246 passed.

[Darkest-Teddy]

Summary

Adds a semester switcher (a redesigned Courses & Semesters hub) that scopes the learning surfaces to a chosen term, and enforces a no-retake rule. Implements the approved design/plan under docs/superpowers/.

Approach: Path A — read-time filtering, no schema change / no migration. The knowledge graph stays keyed on the abstract course_id; a term filter is applied at the read boundary. Retakes are disallowed, so each course lives in exactly one semester.

Backend

• services/academics.py: term_id_for_label (label → term id, mirrors gradebook) + user_course_ids_for_term (the courses a user is enrolled in for a term).
• services/graph_service.py: get_graph(semester=) and get_recommendations(semester=) filter nodes/edges/stats (and DB-side course_id in (...) for recs) to the term's courses; add_course now rejects re-adding a course enrolled in any term (no-retake), surfacing the existing term.
• routes/graph.py: optional ?semester=<term label> on GET /api/graph/{user} and /recommendations. Absent ⇒ all terms (unchanged).

Frontend

• lib/api.ts: EnrolledCourse.term; optional semester on getGraph/getRecommendations.
• lib/useActiveSemester.ts: persisted active-semester hook ([value, setter, hydrated]) + distinctTerms/resolveActiveSemester helpers.
• Dashboard / Tree / Learn / Quiz / Study scope to the active semester; graph fetches are gated on hydration to avoid an unscoped→scoped double-fetch.
• ManageCoursesModal → Courses & Semesters hub: term tabs (set the active semester), courses grouped by term, "Already taken · " disabled state, disabled "Personal learning — Coming soon" placeholder.

Test Plan

• Backend: python -m pytest tests/ -q → 981 passed, 1 skipped (1 pre-existing unrelated OCR event-loop error).
• Frontend: npm run typecheck clean, npm run lint 0 errors, npm run test 92 passed.
• Manual: open Courses & Semesters, switch term tabs, confirm Tree/Learn/Study/Quiz + dashboard graph scope to that term.
• Manual: search a course taken in a previous term in "Add a course" → shows "Already taken · ", disabled.

Known non-blocking follow-ups

• Recent-session lists (Dashboard/Tree) are not yet term-filtered (spec §1; needs a sessions backend change).
• Stale local course selection can persist if the semester is switched mid-screen (cosmetic; shared across Learn/Tree/Quiz/Study).
• resolveActiveSemester defaults to the most-recently-enrolled term (documented heuristic, not term sort_key).
• term_id_for_label duplicates gradebook's private _term_id_for_semester — a later cleanup could consolidate.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Semester-scoped learning: graph loading and recommendations (and the related learning screens) now optionally filter by a selected semester.
  • Added a persisted “active semester” selector with automatic fallback to the most recent enrolled term.
  • Updated course management to “Courses & Semesters,” including term-aware enrollment and no-retake enforcement across all terms.
  • Improved tutor retrieval with category-aware document chunking, plus stronger academic integrity guidance.

• Bug Fixes

  • Ensured semester-filtered graph, stats, and recommendation results stay consistent.

• Tests

  • Expanded coverage for semester filtering/resolution, term enrollment behavior, API passthrough, and category chunking/indexing.

[coderabbitai]

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f229de7-a3dd-498f-9b5b-3f790de13dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 3369301 and b3d80a6.

📒 Files selected for processing (35)

• backend/db/migrations/0036_offering_null_section_unique.sql
• backend/prompts/preamble.txt
• backend/routes/documents.py
• backend/routes/gradebook.py
• backend/routes/graph.py
• backend/scripts/backfill_document_chunks.py
• backend/services/academics.py
• backend/services/chunker.py
• backend/services/graph_service.py
• backend/tests/test_academics.py
• backend/tests/test_chunker.py
• backend/tests/test_document_indexing.py
• backend/tests/test_graph_service.py
• backend/tests/test_shared_course_context.py
• docs/frontend-testids.md
• docs/superpowers/plans/2026-07-20-per-type-document-chunking.md
• docs/superpowers/plans/2026-07-20-semester-scoped-learning.md
• docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md
• docs/superpowers/specs/2026-07-20-semester-scoped-learning-design.md
• frontend/e2e/semester-scope.spec.ts
• frontend/eslint-suppressions.json
• frontend/src/components/ManageCoursesModal.test.tsx
• frontend/src/components/ManageCoursesModal.tsx
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Tree.tsx
• frontend/src/lib/api.ts
• frontend/src/lib/semesters.test.ts
• frontend/src/lib/semesters.ts
• frontend/src/lib/useActiveSemester.test.ts
• frontend/src/lib/useActiveSemester.ts
• frontend/vitest.setup.ts

📝 Walkthrough

Walkthrough

Adds semester-scoped graph and learning data across backend and frontend, persists the active semester, updates course management UI, enforces cross-term no-retakes, adds category-aware prose chunking, and strengthens tutor academic-integrity prompts.

Changes

Semester-scoped learning

Layer / File(s)	Summary
Semester-scoping contracts docs/superpowers/...	Documents read-time semester filtering, active-semester behavior, no-retake rules, affected surfaces, and verification requirements.
Term resolution and backend enforcement backend/routes/graph.py, backend/services/..., backend/tests/*	Adds term-aware routes and services, filters graphs and recommendations, supports requested enrollment terms, and rejects cross-term duplicate enrollments.
Active-semester state and API frontend/src/lib/api.ts, frontend/src/lib/useActiveSemester.ts, frontend/src/lib/*test*, frontend/eslint-suppressions.json	Adds semester request parameters, course term typing, persisted active-semester state, synchronization, and helper tests.
Dashboard and course hub frontend/src/components/screens/Dashboard.tsx, frontend/src/components/ManageCoursesModal.tsx, frontend/src/components/screens/Dashboard.test.tsx	Scopes dashboard data and redesigns course management with term selection, per-term enrollment display, and no-retake messaging.
Learning surface filters frontend/src/components/screens/{Learn,Quiz,Study,Tree}.tsx, frontend/src/components/DocumentUploadModal.test.tsx	Threads the active semester into graph loading and filters course and concept choices across learning screens.

Category-aware document chunking

Layer / File(s)	Summary
Chunking contract and implementation backend/services/chunker.py, backend/tests/test_chunker.py, docs/superpowers/...	Adds deterministic sentence-window prose chunking and category-based dispatch while retaining block chunking for other categories.
Indexing integration backend/routes/documents.py, backend/scripts/backfill_document_chunks.py, backend/tests/test_document_indexing.py	Passes document categories through live and historical chunk generation and updates indexing tests.

Academic-integrity prompt guidance

Layer / File(s)	Summary
Tutor prompt rule backend/prompts/preamble.txt, backend/tests/test_shared_course_context.py	Adds academic-integrity restrictions and verifies their inclusion in generated prompts.

Estimated code review effort: 4 (Complex) | ~75 minutes

Possibly related issues

• [EPIC] Semesters — view grades & classes by term #142 — Covers adjacent semester-aware course and learning data, including structured semester and grade-related APIs.

Possibly related PRs

• SaplingLearn/Sapling#53 — Modifies the same course-creation route and request model while this change adds term propagation.

Suggested reviewers:andresl230, jose-gael-cruz-lopez

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: semester-scoped learning plus the redesigned Courses & Semesters hub.
Description check	✅ Passed	The description is detailed and covers the summary, backend/frontend changes, testing, and follow-ups, with only minor template sections omitted.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/semester-scoped-learning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	b3d80a6	Commit Preview URL Branch Preview URL	Jul 29 2026, 11:55 AM

[Darkest-Teddy]

Added: per-type document chunking (commits 1a49ebe..c3fcfdf)

Pushed on top of the semester-scoped work. Independent of it — touches only the RAG chunking path.

What & why: the RAG pipeline used one block chunker (\n\n splitting) for every document, which mangles continuous prose (essays, written problem-set work) that lacks blank-line boundaries. This adds a second strategy and routes by the classifier's existing category.

• services/chunker.py: new chunk_prose (sentence-window, ~200-word target, ~40-word overlap, deterministic, capped at _MAX_WORDS) + chunk_for_category(text, category) dispatch. chunk_document unchanged.
• Routing: reading/assignment/study_guide → prose; everything else (incl. unknown) → block chunker.
• Wired into _index_document_chunks (live upload) and scripts/backfill_document_chunks.py. seed_quiz_fixture.py intentionally stays on the block chunker.
• Determinism preserved so content-addressed chunk IDs stay stable.

Spec/plan:docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md, docs/superpowers/plans/2026-07-20-per-type-document-chunking.md

Tests:test_chunker.py (16) + test_document_indexing.py (3) + test_rag_service.py (10) pass; per-task + final whole-branch review clean.

Out of scope (deferred, noted in the spec): a tutor system-prompt rule to never hand students assignment answers — that's prompt behavior, not chunking.

🤖 Generated with Claude Code

[Darkest-Teddy]

Added: tutor academic-integrity rule (commit 168f054)

Follow-up to the chunking work — the deferred behavioral rule.

• backend/prompts/preamble.txt: a non-negotiable ACADEMIC INTEGRITY section in the shared tutor preamble (applies to all modes — socratic/expository/teachback). The tutor must teach toward the answer (hints, steps, analogous examples) and never hand over the completed graded deliverable or reproduce verbatim solution text from uploads/retrieved context. Concepts, definitions, and general worked examples are still fully explained.
• Regression test in test_shared_course_context.py asserts the rule is present in build_system_prompt output. 25 passed, ruff clean.
• Quiz prompt intentionally unchanged — a quiz legitimately contains the marked correct answer (self-test revealed after answering), so the tutor rule doesn't apply there.

🤖 Generated with Claude Code

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

frontend/src/components/screens/Dashboard.tsx (1)

1276-1280: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the semester-empty state reachable.

This branch can never render: CoursesKey returns null at Line 1133 whenever courseProgress.length === 0. Remove or adjust that early return so an active semester with no courses shows this message and still exposes course management.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 1276 - 1280,
Update CoursesKey so it does not return null when courseProgress.length is zero
for an active semester; allow rendering to continue to the “Nothing enrolled
this semester.” state while preserving course management controls.

🧹 Nitpick comments (1)

backend/tests/test_shared_course_context.py (1)

471-478: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover every tutor mode claimed by the test.

The docstring promises the rule is present “regardless of mode,” but this test exercises only expository. Parameterize it over the supported modes so a mode-specific prompt change cannot bypass the integrity rule.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@backend/tests/test_shared_course_context.py` around lines 471 - 478, Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 265-282: Update the dashboard loading flow around the Promise.all
requests so courses and semesters are fetched first, then derive an
effectiveSemester from the stored activeSemester or the existing
courseTermLabels/resolveActiveSemester fallback before requesting graph and
recommendation data. Pass effectiveSemester to getGraph and getRecommendations,
preserving unscoped requests only when no semester can be resolved; ensure the
default path passes “Spring 2026” rather than undefined and persists that
selected semester.
---
Outside diff comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 1276-1280: Update CoursesKey so it does not return null when
courseProgress.length is zero for an active semester; allow rendering to
continue to the “Nothing enrolled this semester.” state while preserving course
management controls.
---
Nitpick comments:
In `@backend/tests/test_shared_course_context.py`:
- Around line 471-478: Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6eedc26e-16af-4a02-b10b-c42176be693d

📥 Commits

Reviewing files that changed from the base of the PR and between c3fcfdf and 3369301.

📒 Files selected for processing (9)

• backend/prompts/preamble.txt
• backend/tests/test_shared_course_context.py
• frontend/eslint-suppressions.json
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/lib/api.ts

💤 Files with no reviewable changes (1)

• frontend/eslint-suppressions.json

🚧 Files skipped from review as they are similar to previous changes (4)

• frontend/src/lib/api.ts
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Learn.tsx

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Resolve the default semester before requesting graph data.

With no stored semester, Lines 266 and 270 request unscoped data, then Line 281 selects and persists a term. This briefly renders unscoped graph/stats/recommendations and performs a second fetch. Fetch courses/semesters first, derive an effectiveSemester, then use it for the graph and recommendations requests.

Also assert the default-path getGraph call receives "Spring 2026" rather than undefined.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 265 - 282, Update
the dashboard loading flow around the Promise.all requests so courses and
semesters are fetched first, then derive an effectiveSemester from the stored
activeSemester or the existing courseTermLabels/resolveActiveSemester fallback
before requesting graph and recommendation data. Pass effectiveSemester to
getGraph and getRecommendations, preserving unscoped requests only when no
semester can be resolved; ensure the default path passes “Spring 2026” rather
than undefined and persists that selected semester.

[AndresL230]

Code review

Found 3 issues:

1. The new cross-term no-retake guard in add_course is check-then-act with no atomic enforcement: course_offerings' UNIQUE(course_id, term_id, section) does not bind for NULL sections and a race that creates two different offering rows slips past enrollments' uniqueness — a double-click on Add for a never-enrolled course can create duplicate enrollments, violating the PR's own invariant. (bug due to backend/services/graph_service.py — read via user_offering_ids_for_course, then resolve_offering(..., create=True) + insert with no constraint backing the NULL-section case)

Sapling/backend/services/graph_service.py

Lines 372 to 396 in a53e809

	# rejected instead of silently creating a second enrollment.)
	existing_offerings=user_offering_ids_for_course(user_id, course_id)
	ifexisting_offerings:
	existing_term=term_for_offering(existing_offerings[0]) or {}
	return {
	"course_id": course_id,
	"already_existed": True,
	"term": existing_term.get("label", ""),
	}
	# Resolve the requested semester label → term id. An unknown label yields
	# None, which resolve_offering treats as "current term".
	term_id=term_id_for_label(term) iftermelseNone
	offering_id=resolve_offering(course_id, term_id=term_id, create=True)
	ifnotoffering_id:
	return {"course_id": course_id, "error": "No term available to enroll into"}
	# Check if already enrolled in this offering
	existing=table("enrollments").select(
	"id",
	filters={"user_id": f"eq.{user_id}", "offering_id": f"eq.{offering_id}"},
	)
	ifexisting:
	return {"course_id": course_id, "already_existed": True}

2. CoursesKey returns null whenever courseProgress is empty, so the "Nothing enrolled this semester." empty-state later in the same component is unreachable — an empty active semester renders nothing at all in that panel. (bug due to frontend/src/components/screens/Dashboard.tsx — early if (courseProgress.length === 0) return null; above the empty-state block)

Sapling/frontend/src/components/screens/Dashboard.tsx

Lines 1129 to 1131 in a53e809

	if(courseProgress.length===0)returnnull;

3. Only Dashboard and the Courses & Semesters hub ever resolve/persist a default active semester; Learn/Quiz/Tree/Study read it but never set one — a user who deep-links to /learn first stays permanently unscoped on those screens, silently defeating the semester-scoping feature there. (bug due to frontend/src/lib/useActiveSemester.ts consumers never resolving a default outside Dashboard)

Sapling/frontend/src/lib/useActiveSemester.ts

Lines 36 to 72 in a53e809

	}
	/** [activeSemester, setActiveSemester, hydrated] — persisted to localStorage, cross-tab + same-tab
	* reactive. `hydrated` is false until the localStorage read completes after mount. */
	exportfunctionuseActiveSemester(): [string,(v: string)=>void,boolean]{
	const[sem,setSem]=useState<string>("");
	// `hydrated` flips true once we've read localStorage after mount. We start at
	// "" (not the stored value) to avoid an SSR/CSR hydration mismatch, so callers
	// that fetch based on the active semester should wait for `hydrated` to avoid
	// an initial unscoped fetch followed by a scoped refetch.
	const[hydrated,setHydrated]=useState(false);
	useEffect(()=>{
	setSem(read());
	setHydrated(true);
	constonStorage=(e: StorageEvent)=>{
	if(e.key===ACTIVE_SEMESTER_STORAGE_KEY)setSem(read());
	};
	constonCustom=()=>setSem(read());
	window.addEventListener("storage",onStorage);
	window.addEventListener(CHANGE_EVENT,onCustom);
	return()=>{
	window.removeEventListener("storage",onStorage);
	window.removeEventListener(CHANGE_EVENT,onCustom);
	};
	},[]);
	// Stable identity so consumers can safely list it in effect/callback deps.
	constupdate=useCallback((v: string)=>{
	if(typeofwindow==="undefined")return;
	window.localStorage.setItem(ACTIVE_SEMESTER_STORAGE_KEY,v);
	setSem(v);
	window.dispatchEvent(newEvent(CHANGE_EVENT));
	},[]);
	return[sem,update,hydrated];
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[AndresL230]

All three review findings above are fixed in the latest push: (1) the no-retake race is closed by migration 0036's partial unique index on course_offerings (course_id, term_id) WHERE section IS NULL, a 409-retry re-select in resolve_offering, and an in-flight disable on the hub's Add button; (2) CoursesKey now renders the 'Nothing enrolled this semester.' empty-state when an active semester scopes to zero courses; (3) Learn/Quiz/Tree/Study now resolve a default semester via ensureDefaultActiveSemester as soon as they have term labels. Also: the Add flow honors already_existed with an informational toast, the dead duplicate check was removed, first-load double-fetch eliminated, and the orphaned #140 archive helpers were deleted. Backend 1311 passed; frontend 246 passed.

[Darkest-Teddy]

Summary

Adds a semester switcher (a redesigned Courses & Semesters hub) that scopes the learning surfaces to a chosen term, and enforces a no-retake rule. Implements the approved design/plan under docs/superpowers/.

Approach: Path A — read-time filtering, no schema change / no migration. The knowledge graph stays keyed on the abstract course_id; a term filter is applied at the read boundary. Retakes are disallowed, so each course lives in exactly one semester.

Backend

• services/academics.py: term_id_for_label (label → term id, mirrors gradebook) + user_course_ids_for_term (the courses a user is enrolled in for a term).
• services/graph_service.py: get_graph(semester=) and get_recommendations(semester=) filter nodes/edges/stats (and DB-side course_id in (...) for recs) to the term's courses; add_course now rejects re-adding a course enrolled in any term (no-retake), surfacing the existing term.
• routes/graph.py: optional ?semester=<term label> on GET /api/graph/{user} and /recommendations. Absent ⇒ all terms (unchanged).

Frontend

• lib/api.ts: EnrolledCourse.term; optional semester on getGraph/getRecommendations.
• lib/useActiveSemester.ts: persisted active-semester hook ([value, setter, hydrated]) + distinctTerms/resolveActiveSemester helpers.
• Dashboard / Tree / Learn / Quiz / Study scope to the active semester; graph fetches are gated on hydration to avoid an unscoped→scoped double-fetch.
• ManageCoursesModal → Courses & Semesters hub: term tabs (set the active semester), courses grouped by term, "Already taken · " disabled state, disabled "Personal learning — Coming soon" placeholder.

Test Plan

• Backend: python -m pytest tests/ -q → 981 passed, 1 skipped (1 pre-existing unrelated OCR event-loop error).
• Frontend: npm run typecheck clean, npm run lint 0 errors, npm run test 92 passed.
• Manual: open Courses & Semesters, switch term tabs, confirm Tree/Learn/Study/Quiz + dashboard graph scope to that term.
• Manual: search a course taken in a previous term in "Add a course" → shows "Already taken · ", disabled.

Known non-blocking follow-ups

• Recent-session lists (Dashboard/Tree) are not yet term-filtered (spec §1; needs a sessions backend change).
• Stale local course selection can persist if the semester is switched mid-screen (cosmetic; shared across Learn/Tree/Quiz/Study).
• resolveActiveSemester defaults to the most-recently-enrolled term (documented heuristic, not term sort_key).
• term_id_for_label duplicates gradebook's private _term_id_for_semester — a later cleanup could consolidate.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • Semester-scoped learning: graph loading and recommendations (and the related learning screens) now optionally filter by a selected semester.
  • Added a persisted “active semester” selector with automatic fallback to the most recent enrolled term.
  • Updated course management to “Courses & Semesters,” including term-aware enrollment and no-retake enforcement across all terms.
  • Improved tutor retrieval with category-aware document chunking, plus stronger academic integrity guidance.

• Bug Fixes

  • Ensured semester-filtered graph, stats, and recommendation results stay consistent.

• Tests

  • Expanded coverage for semester filtering/resolution, term enrollment behavior, API passthrough, and category chunking/indexing.

[coderabbitai]

Warning

Review limit reached

@AndresL230, you've reached your PR review limit, so we couldn't start this review.

Next review available in:3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f229de7-a3dd-498f-9b5b-3f790de13dc4

📥 Commits

Reviewing files that changed from the base of the PR and between 3369301 and b3d80a6.

📒 Files selected for processing (35)

• backend/db/migrations/0036_offering_null_section_unique.sql
• backend/prompts/preamble.txt
• backend/routes/documents.py
• backend/routes/gradebook.py
• backend/routes/graph.py
• backend/scripts/backfill_document_chunks.py
• backend/services/academics.py
• backend/services/chunker.py
• backend/services/graph_service.py
• backend/tests/test_academics.py
• backend/tests/test_chunker.py
• backend/tests/test_document_indexing.py
• backend/tests/test_graph_service.py
• backend/tests/test_shared_course_context.py
• docs/frontend-testids.md
• docs/superpowers/plans/2026-07-20-per-type-document-chunking.md
• docs/superpowers/plans/2026-07-20-semester-scoped-learning.md
• docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md
• docs/superpowers/specs/2026-07-20-semester-scoped-learning-design.md
• frontend/e2e/semester-scope.spec.ts
• frontend/eslint-suppressions.json
• frontend/src/components/ManageCoursesModal.test.tsx
• frontend/src/components/ManageCoursesModal.tsx
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Tree.tsx
• frontend/src/lib/api.ts
• frontend/src/lib/semesters.test.ts
• frontend/src/lib/semesters.ts
• frontend/src/lib/useActiveSemester.test.ts
• frontend/src/lib/useActiveSemester.ts
• frontend/vitest.setup.ts

📝 Walkthrough

Walkthrough

Adds semester-scoped graph and learning data across backend and frontend, persists the active semester, updates course management UI, enforces cross-term no-retakes, adds category-aware prose chunking, and strengthens tutor academic-integrity prompts.

Changes

Semester-scoped learning

Layer / File(s)	Summary
Semester-scoping contracts docs/superpowers/...	Documents read-time semester filtering, active-semester behavior, no-retake rules, affected surfaces, and verification requirements.
Term resolution and backend enforcement backend/routes/graph.py, backend/services/..., backend/tests/*	Adds term-aware routes and services, filters graphs and recommendations, supports requested enrollment terms, and rejects cross-term duplicate enrollments.
Active-semester state and API frontend/src/lib/api.ts, frontend/src/lib/useActiveSemester.ts, frontend/src/lib/*test*, frontend/eslint-suppressions.json	Adds semester request parameters, course term typing, persisted active-semester state, synchronization, and helper tests.
Dashboard and course hub frontend/src/components/screens/Dashboard.tsx, frontend/src/components/ManageCoursesModal.tsx, frontend/src/components/screens/Dashboard.test.tsx	Scopes dashboard data and redesigns course management with term selection, per-term enrollment display, and no-retake messaging.
Learning surface filters frontend/src/components/screens/{Learn,Quiz,Study,Tree}.tsx, frontend/src/components/DocumentUploadModal.test.tsx	Threads the active semester into graph loading and filters course and concept choices across learning screens.

Category-aware document chunking

Layer / File(s)	Summary
Chunking contract and implementation backend/services/chunker.py, backend/tests/test_chunker.py, docs/superpowers/...	Adds deterministic sentence-window prose chunking and category-based dispatch while retaining block chunking for other categories.
Indexing integration backend/routes/documents.py, backend/scripts/backfill_document_chunks.py, backend/tests/test_document_indexing.py	Passes document categories through live and historical chunk generation and updates indexing tests.

Academic-integrity prompt guidance

Layer / File(s)	Summary
Tutor prompt rule backend/prompts/preamble.txt, backend/tests/test_shared_course_context.py	Adds academic-integrity restrictions and verifies their inclusion in generated prompts.

Estimated code review effort: 4 (Complex) | ~75 minutes

Possibly related issues

• [EPIC] Semesters — view grades & classes by term #142 — Covers adjacent semester-aware course and learning data, including structured semester and grade-related APIs.

Possibly related PRs

• SaplingLearn/Sapling#53 — Modifies the same course-creation route and request model while this change adds term propagation.

Suggested reviewers:andresl230, jose-gael-cruz-lopez

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is concise and accurately summarizes the main change: semester-scoped learning plus the redesigned Courses & Semesters hub.
Description check	✅ Passed	The description is detailed and covers the summary, backend/frontend changes, testing, and follow-ups, with only minor template sections omitted.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/semester-scoped-learning

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying with Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	frontend-staging	b3d80a6	Commit Preview URL Branch Preview URL	Jul 29 2026, 11:55 AM

[Darkest-Teddy]

Added: per-type document chunking (commits 1a49ebe..c3fcfdf)

Pushed on top of the semester-scoped work. Independent of it — touches only the RAG chunking path.

What & why: the RAG pipeline used one block chunker (\n\n splitting) for every document, which mangles continuous prose (essays, written problem-set work) that lacks blank-line boundaries. This adds a second strategy and routes by the classifier's existing category.

• services/chunker.py: new chunk_prose (sentence-window, ~200-word target, ~40-word overlap, deterministic, capped at _MAX_WORDS) + chunk_for_category(text, category) dispatch. chunk_document unchanged.
• Routing: reading/assignment/study_guide → prose; everything else (incl. unknown) → block chunker.
• Wired into _index_document_chunks (live upload) and scripts/backfill_document_chunks.py. seed_quiz_fixture.py intentionally stays on the block chunker.
• Determinism preserved so content-addressed chunk IDs stay stable.

Spec/plan:docs/superpowers/specs/2026-07-20-per-type-document-chunking-design.md, docs/superpowers/plans/2026-07-20-per-type-document-chunking.md

Tests:test_chunker.py (16) + test_document_indexing.py (3) + test_rag_service.py (10) pass; per-task + final whole-branch review clean.

Out of scope (deferred, noted in the spec): a tutor system-prompt rule to never hand students assignment answers — that's prompt behavior, not chunking.

🤖 Generated with Claude Code

[Darkest-Teddy]

Added: tutor academic-integrity rule (commit 168f054)

Follow-up to the chunking work — the deferred behavioral rule.

• backend/prompts/preamble.txt: a non-negotiable ACADEMIC INTEGRITY section in the shared tutor preamble (applies to all modes — socratic/expository/teachback). The tutor must teach toward the answer (hints, steps, analogous examples) and never hand over the completed graded deliverable or reproduce verbatim solution text from uploads/retrieved context. Concepts, definitions, and general worked examples are still fully explained.
• Regression test in test_shared_course_context.py asserts the rule is present in build_system_prompt output. 25 passed, ruff clean.
• Quiz prompt intentionally unchanged — a quiz legitimately contains the marked correct answer (self-test revealed after answering), so the tutor rule doesn't apply there.

🤖 Generated with Claude Code

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

frontend/src/components/screens/Dashboard.tsx (1)

1276-1280: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Make the semester-empty state reachable.

This branch can never render: CoursesKey returns null at Line 1133 whenever courseProgress.length === 0. Remove or adjust that early return so an active semester with no courses shows this message and still exposes course management.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 1276 - 1280,
Update CoursesKey so it does not return null when courseProgress.length is zero
for an active semester; allow rendering to continue to the “Nothing enrolled
this semester.” state while preserving course management controls.

🧹 Nitpick comments (1)

backend/tests/test_shared_course_context.py (1)

471-478: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Cover every tutor mode claimed by the test.

The docstring promises the rule is present “regardless of mode,” but this test exercises only expository. Parameterize it over the supported modes so a mode-specific prompt change cannot bypass the integrity rule.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@backend/tests/test_shared_course_context.py` around lines 471 - 478, Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 265-282: Update the dashboard loading flow around the Promise.all
requests so courses and semesters are fetched first, then derive an
effectiveSemester from the stored activeSemester or the existing
courseTermLabels/resolveActiveSemester fallback before requesting graph and
recommendation data. Pass effectiveSemester to getGraph and getRecommendations,
preserving unscoped requests only when no semester can be resolved; ensure the
default path passes “Spring 2026” rather than undefined and persists that
selected semester.
---
Outside diff comments:
In `@frontend/src/components/screens/Dashboard.tsx`:
- Around line 1276-1280: Update CoursesKey so it does not return null when
courseProgress.length is zero for an active semester; allow rendering to
continue to the “Nothing enrolled this semester.” state while preserving course
management controls.
---
Nitpick comments:
In `@backend/tests/test_shared_course_context.py`:
- Around line 471-478: Update
test_build_system_prompt_carries_academic_integrity_rule to run across every
supported tutor mode instead of only "expository". Parameterize the test using
the existing test framework conventions, while preserving the prompt
construction and both academic-integrity assertions for each mode.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6eedc26e-16af-4a02-b10b-c42176be693d

📥 Commits

Reviewing files that changed from the base of the PR and between c3fcfdf and 3369301.

📒 Files selected for processing (9)

• backend/prompts/preamble.txt
• backend/tests/test_shared_course_context.py
• frontend/eslint-suppressions.json
• frontend/src/components/screens/Dashboard.test.tsx
• frontend/src/components/screens/Dashboard.tsx
• frontend/src/components/screens/Learn.tsx
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/lib/api.ts

💤 Files with no reviewable changes (1)

• frontend/eslint-suppressions.json

🚧 Files skipped from review as they are similar to previous changes (4)

• frontend/src/lib/api.ts
• frontend/src/components/screens/Quiz.tsx
• frontend/src/components/screens/Study.tsx
• frontend/src/components/screens/Learn.tsx

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Resolve the default semester before requesting graph data.

With no stored semester, Lines 266 and 270 request unscoped data, then Line 281 selects and persists a term. This briefly renders unscoped graph/stats/recommendations and performs a second fetch. Fetch courses/semesters first, derive an effectiveSemester, then use it for the graph and recommendations requests.

Also assert the default-path getGraph call receives "Spring 2026" rather than undefined.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@frontend/src/components/screens/Dashboard.tsx` around lines 265 - 282, Update
the dashboard loading flow around the Promise.all requests so courses and
semesters are fetched first, then derive an effectiveSemester from the stored
activeSemester or the existing courseTermLabels/resolveActiveSemester fallback
before requesting graph and recommendation data. Pass effectiveSemester to
getGraph and getRecommendations, preserving unscoped requests only when no
semester can be resolved; ensure the default path passes “Spring 2026” rather
than undefined and persists that selected semester.

[AndresL230]

Code review

Found 3 issues:

1. The new cross-term no-retake guard in add_course is check-then-act with no atomic enforcement: course_offerings' UNIQUE(course_id, term_id, section) does not bind for NULL sections and a race that creates two different offering rows slips past enrollments' uniqueness — a double-click on Add for a never-enrolled course can create duplicate enrollments, violating the PR's own invariant. (bug due to backend/services/graph_service.py — read via user_offering_ids_for_course, then resolve_offering(..., create=True) + insert with no constraint backing the NULL-section case)

Sapling/backend/services/graph_service.py

Lines 372 to 396 in a53e809

	# rejected instead of silently creating a second enrollment.)
	existing_offerings=user_offering_ids_for_course(user_id, course_id)
	ifexisting_offerings:
	existing_term=term_for_offering(existing_offerings[0]) or {}
	return {
	"course_id": course_id,
	"already_existed": True,
	"term": existing_term.get("label", ""),
	}
	# Resolve the requested semester label → term id. An unknown label yields
	# None, which resolve_offering treats as "current term".
	term_id=term_id_for_label(term) iftermelseNone
	offering_id=resolve_offering(course_id, term_id=term_id, create=True)
	ifnotoffering_id:
	return {"course_id": course_id, "error": "No term available to enroll into"}
	# Check if already enrolled in this offering
	existing=table("enrollments").select(
	"id",
	filters={"user_id": f"eq.{user_id}", "offering_id": f"eq.{offering_id}"},
	)
	ifexisting:
	return {"course_id": course_id, "already_existed": True}

2. CoursesKey returns null whenever courseProgress is empty, so the "Nothing enrolled this semester." empty-state later in the same component is unreachable — an empty active semester renders nothing at all in that panel. (bug due to frontend/src/components/screens/Dashboard.tsx — early if (courseProgress.length === 0) return null; above the empty-state block)

Sapling/frontend/src/components/screens/Dashboard.tsx

Lines 1129 to 1131 in a53e809

	if(courseProgress.length===0)returnnull;

3. Only Dashboard and the Courses & Semesters hub ever resolve/persist a default active semester; Learn/Quiz/Tree/Study read it but never set one — a user who deep-links to /learn first stays permanently unscoped on those screens, silently defeating the semester-scoping feature there. (bug due to frontend/src/lib/useActiveSemester.ts consumers never resolving a default outside Dashboard)

Sapling/frontend/src/lib/useActiveSemester.ts

Lines 36 to 72 in a53e809

	}
	/** [activeSemester, setActiveSemester, hydrated] — persisted to localStorage, cross-tab + same-tab
	* reactive. `hydrated` is false until the localStorage read completes after mount. */
	exportfunctionuseActiveSemester(): [string,(v: string)=>void,boolean]{
	const[sem,setSem]=useState<string>("");
	// `hydrated` flips true once we've read localStorage after mount. We start at
	// "" (not the stored value) to avoid an SSR/CSR hydration mismatch, so callers
	// that fetch based on the active semester should wait for `hydrated` to avoid
	// an initial unscoped fetch followed by a scoped refetch.
	const[hydrated,setHydrated]=useState(false);
	useEffect(()=>{
	setSem(read());
	setHydrated(true);
	constonStorage=(e: StorageEvent)=>{
	if(e.key===ACTIVE_SEMESTER_STORAGE_KEY)setSem(read());
	};
	constonCustom=()=>setSem(read());
	window.addEventListener("storage",onStorage);
	window.addEventListener(CHANGE_EVENT,onCustom);
	return()=>{
	window.removeEventListener("storage",onStorage);
	window.removeEventListener(CHANGE_EVENT,onCustom);
	};
	},[]);
	// Stable identity so consumers can safely list it in effect/callback deps.
	constupdate=useCallback((v: string)=>{
	if(typeofwindow==="undefined")return;
	window.localStorage.setItem(ACTIVE_SEMESTER_STORAGE_KEY,v);
	setSem(v);
	window.dispatchEvent(newEvent(CHANGE_EVENT));
	},[]);
	return[sem,update,hydrated];
	}

🤖 Generated with Claude Code

_{- If this code review was useful, please react with 👍. Otherwise, react with 👎.}

[AndresL230]

All three review findings above are fixed in the latest push: (1) the no-retake race is closed by migration 0036's partial unique index on course_offerings (course_id, term_id) WHERE section IS NULL, a 409-retry re-select in resolve_offering, and an in-flight disable on the hub's Add button; (2) CoursesKey now renders the 'Nothing enrolled this semester.' empty-state when an active semester scopes to zero courses; (3) Learn/Quiz/Tree/Study now resolve a default semester via ensureDefaultActiveSemester as soon as they have term labels. Also: the Add flow honors already_existed with an informational toast, the dead duplicate check was removed, first-load double-fetch eliminated, and the orphaned #140 archive helpers were deleted. Backend 1311 passed; frontend 246 passed.