Uh oh!
There was an error while loading. Please reload this page.
fix(tree): don't seed course name as quiz topic on course-node click (#319) - #370
fix(tree): don't seed course name as quiz topic on course-node click (#319)#370Darkest-Teddy wants to merge 1 commit into
Conversation
…319) Follow-up to the tutor fix. The Tree detail panel's "Quick quiz" button ran onQuiz for any node, including subject-root (course) nodes, passing `topic=<course name>`. Unlike the tutor, the Quiz screen resolves `topic` against concepts (roots excluded) so the course name never actually became the quiz topic — but the param was dead and misleading. Guard onQuiz so course nodes open the quiz picker with no seeded topic (mirrors the tutor behavior). Also drop the `course_id` query param: the Quiz screen only reads `topic`/`concept`, so it was dead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Free Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
Deploying with |
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs | frontend-staging | bf3496f | Jul 21 2026, 04:20 AM |
# Conflicts: # frontend/src/components/screens/Tree.tsx
Follow-up to #369 (the AI-Tutor fix for #319), on a separate branch.
Context
The Tree detail panel's "Quick quiz" button ran
onQuizfor any node, including subject-root (course) nodes, passingtopic=<course name>.Unlike the tutor, the Quiz screen resolves
topicagainst the concept list with subject-roots excluded (Quiz.tsx), andQuizPanelonly ever uses the resolvedinitialConceptId— it never reads the raw topic string. So the course name never actually became the quiz topic. This is hygiene, not a user-facing leak: the param was dead and misleading.Change (
Tree.tsxonly)onQuizso a course node opens the quiz picker with no seeded topic (mirrors the tutor behavior); concept nodes keeptopic=name.course_idquery param — the Quiz screen only readstopic/concept, so it was dead.Verification
tsc --noEmitandeslint src/components/screens/Tree.tsx: clean.styleTextincompatibility, unrelated.)Base
Stacked on
feat/semester-scoped-learning(PR #360), same base as #369, since theonQuizhandler only exists on that branch.🤖 Generated with Claude Code