Skip to content

Lint changes from a specific branch - #97

Open
mlhamel wants to merge 4 commits into
adds-support-for-devfrom
lint-with-branch
Open

Lint changes from a specific branch#97
mlhamel wants to merge 4 commits into
adds-support-for-devfrom
lint-with-branch

Conversation

@mlhamel

Copy link
Copy Markdown
Contributor

Description

Sometime your changes should not be compared with master but with a specific branch. This PR let you compare your changes with any branch, master by default.

@mlhamel
mlhamel changed the base branch from master to adds-support-for-devApril 18, 2018 16:11
@mlhamelmlhamel changed the title Lint with branchLint changes from a specific branchApr 18, 2018
@mlhamel
mlhamel requested a review from shardulbeeApril 20, 2018 15:52

@JasonMWhiteJasonMWhite left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test on a non-master branch, e.g. where master passes the linter but non-master doesn't.

main_repo.create_head('foo').checkout()
main_repo.index.add([python_file, python_script])
main_repo.index.commit("adding python files")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the deletion?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. Gonna remove this

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mlhamel@cfournie@JasonMWhite