Uh oh!
There was an error while loading. Please reload this page.
Add support for Stringified NBT objects - #92
Conversation
57a5e3b to
7591f25CompareCodecov Report
@@ Coverage Diff @@## master #92 +/- ##
============================================
- Coverage 20.39% 20.31% -0.08% - Complexity 111 133 +22
============================================
Files 63 71 +8 Lines 2859 3012 +153 Branches 381 402 +21 ============================================
+ Hits 583 612 +29 - Misses 2261 2379 +118 - Partials 15 21 +6
Continue to review full report at Codecov.
|
7591f25 to
ad30a23Compare
kokumaji
left a comment
There was a problem hiding this comment.
PR looks fine to me, except for the class names and some method names, would suggest reading up on Java's naming conventions (or we should agree on naming rules in the next meeting?).
Waiting on other admins to comment on this PR.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
aakatz3
commented
Feb 13, 2021
I used |
jcxldn
commented
Feb 13, 2021
I wonder if something like |
aakatz3
commented
Feb 13, 2021
Sure! we good for StringNBT then? |
jcxldn
commented
Feb 13, 2021
src: https://google.github.io/styleguide/javaguide.html#s5.2.2-class-names (UpperCamelCase class naming) |
kaylendog
commented
Feb 13, 2021
Merging on hold until after module refactor. |
1a29f3b to
72fc012CompareCodeQL
|
Cool new system to make building NBT strings easy and not awful