(major/non-breaking?) Modules Refactor by jcxldn · Pull Request #97 · SolteraGG/StickyAPI

jcxldn · 2021-03-03T17:08:26Z

Notes

CodeQL alerts will all be reset, since the source code paths have changed.
Javadocs (both global ones and ones for each module) are now built during the build stage, so do we still need the javadoc-check ci job?

Partial(?) changelog from previous tagged release

StickyAPI v3 Changelog

Upgrade Notes

Module support (dependency resolution change)
- com.dumbdogdiner:stickyapi is still available, but is not recommended
  Please use com.dumbdogdiner:stickyapi-(module) instead.
breaking: Config rewrite (Rewrite the configuration package (very basic for now) #98)

Internal (ci)

Added support for signed docs deployment
Added GitHub CodeQL support

Internal

Added private constructors to never instanciated classes

Dependencies

net.nemerosa.versioning: 2.8.2 -> 2.14.0
classgraph: 4.8.98 -> 4.8.100

New Features

Build Info in com.dumbdogdiner.stickyapi.StickyAPI (Feat/jcx/buildinfo #77)
Added support for Stringified NBT Objects (Add support for Stringified NBT objects #92)
Added Book Text Utils (Book Text Utils #72)
NotNull annotations for VoidGenerator

Deprecations

getRandomNumber
com.dumbdogdiner.stickyapi.bukkit.nms

… plugin in root repo

kaylendog

Some minor formatting complaints that I will fix in a second - pls see comments on the build files.

codecov · 2021-03-03T17:24:01Z

Codecov Report

Merging #97 (44baa18) into master (5d56a8a) will increase coverage by 11.20%.
The diff coverage is 73.33%.

@@ Coverage Diff @@## master #97 +/- ##
=============================================
+ Coverage 23.19% 34.39% +11.20% 
=============================================
Files 73 63 -10 Lines 3126 2532 -594 Branches 426 286 -140 =============================================
+ Hits 725 871 +146 + Misses 2355 1597 -758 - Partials 46 64 +18

Impacted Files	Coverage Δ	Complexity Δ
...ogdiner/stickyapi/bukkit/command/AsyncCommand.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...stickyapi/bukkit/command/BukkitCommandBuilder.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...umbdogdiner/stickyapi/bukkit/command/ExitCode.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...gdiner/stickyapi/bukkit/command/PluginCommand.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...iner/stickyapi/bukkit/generator/VoidGenerator.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...mbdogdiner/stickyapi/bukkit/gui/ClickableSlot.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...ava/com/dumbdogdiner/stickyapi/bukkit/gui/GUI.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...com/dumbdogdiner/stickyapi/bukkit/gui/GUISlot.java	`0.00% <ø> (ø)`	`0.00 <0.00> (?)`
...ner/stickyapi/bukkit/item/BookAndQuillBuilder.java	`28.57% <ø> (ø)`	`0.00 <0.00> (?)`
...iner/stickyapi/bukkit/item/WrittenBookBuilder.java	`33.87% <ø> (ø)`	`0.00 <0.00> (?)`
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d56a8a...44baa18. Read the comment docs.

kaylendog

Fixed formatting comments.

kaylendog

LGTM - some formatting thingies.

kaylendog · 2021-03-21T18:05:59Z

@@ -5,8 +5,11 @@
 package com.dumbdogdiner.stickyapi.bungeecord.util;


This looks very similar to the Bukkit startup util - perhaps some de-dupe here?

kaylendog · 2021-03-21T18:07:57Z

+ // Generate dumper options
+ DumperOptions options = new DumperOptions();
+ options.setDefaultFlowStyle(DumperOptions.FlowStyle.BLOCK);
+ options.setIndent(2);


4 tab indentation hhhhh - vlad will complain but idc >:3

* Add browseJavadoc, allow frames support * update gradle * Fix javadoc issue * Generate javadoc for private * Switch back to gradle 6.7 * Don't duplicate allprojects directive; remove extra encoding option * Add trailing newline Co-authored-by: James <jcahill773@gmail.com> Co-authored-by: Andrew Katz <aakatz3@gmail.com>

kaylendog

LGTM

kaylendog · 2021-03-24T20:15:48Z

+/*
+ * Copyright (c) 2020-$YEAR DumbDogDiner <dumbdogdiner.com>. All rights reserved.
+ * Licensed under the MIT license, see LICENSE for more information...
+ */


Suggested change
*/
*/

jcxldn added 19 commits February 28, 2021 15:10

Initial move
55bb636

Use shadow to create an uber jar, create uber sources, don't run java…
c2586e0
… plugin in root repo

Add project-wide reporting for test completion and coverage
8298897

Add project-wide javadocs
2b8cc4d

Don't use shadow for root uberjar building for now
ddc7a8b

Ignore md and mockmaker for license formatter
090ac31

Clean up build.gradle comments
c26072c

Create initial allprojects and subprojects
8fa1a4f

Remove sources task back to subprojects
5194f2a

Initial subproject publishing support
2dba8de

Add local testing maven repo
dc02136

Try setting UTF8 for agregateJavadoc
3ec2a1a

Try running javadoc instead of aggregateJavadoc
ed2707c

Javadoc fixes, part 3!
8c7fc4a

Move repositories to allprojects
3d11785

Create a libs-all folder for all jars
adc439b

Simplify copyJars by just copying modules into existing uber libs folder
fd4410a

(ci): Publish to local testing repo, artifact and display output
d712d49

Deprecate bukkit.nms; pending removal
65ca953

jcxldn added feature New feature or request help wanted Extra attention is needed ci/cd labels Mar 3, 2021

jcxldn requested a review from kaylendog March 3, 2021 17:08

jcxldn self-assigned this Mar 3, 2021

kaylendog reviewed Mar 3, 2021
View reviewed changes

fix skye formatting complaints
57419ee

kaylendog added 2 commits March 3, 2021 17:30

consistent quoting
3d2ca6b

make bracketing consistent
10d514d

kaylendog reviewed Mar 3, 2021
View reviewed changes

jcxldn added 4 commits March 21, 2021 11:28

Add :common:serverversion to common jar and sources output
cbbcadb

Move the config rewrite to it's own project
4e46e35

Rename configuration package to config
c811cfe

Remove unused imports, don't use wildcard imports
5abc3f0

jcxldn requested a review from kaylendog March 21, 2021 13:14

Bump version to 3.0
1c3bcae

kaylendog reviewed Mar 21, 2021
View reviewed changes

jcxldn added 4 commits March 21, 2021 18:14

Improve code style
06bb9c8

Add custom configuration for resources
eff08bd

gradle 7 prep - migrate away from using compile
8e9c86e

Add spotless for license headers
04094c0

kaylendog linked an issue Mar 23, 2021 that may be closed by this pull request
Gradle module refactor #94
Closed

jcxldn added 5 commits March 23, 2021 18:37

Adjust gprSubprojects debug output
1ea61fc

Edit aggregate-javadoc comment
6418bba

Update since annotations from#77
1bdf593

Add since annotations to#92
959e7f7

Add since annotations to#72
cd4402f

jcxldn linked an issue Mar 23, 2021 that may be closed by this pull request
next (any) release to-do list #82
Closed
3 tasks

aakatz3and others added 2 commits March 23, 2021 19:49

Bump classgraph to 4.8.103
53fd378

kaylendog self-requested a review March 24, 2021 18:14

kaylendog approved these changes Mar 24, 2021
View reviewed changes

jcxldn added 3 commits March 29, 2021 08:30

Use semver for versioning
5a0d96e

Add extra newline
f02fdf4

Ignore :common:serverversion when publishing
264b703

jcxldn added this to the v3.0 (next) milestone Mar 29, 2021

Bump classgraph to 4.8.104
44baa18

jcxldn merged commit c4d9c88 into masterMar 29, 2021

jcxldn mentioned this pull request Mar 29, 2021
Gradle 7 / Java 16 build support #109
Merged

jcxldn deleted the feat/jcx/major/modules-def branch March 30, 2021 21:49

		@@ -5,8 +5,11 @@
		package com.dumbdogdiner.stickyapi.bungeecord.util;

Uh oh!

Conversation

jcxldn commented Mar 3, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes

Partial(?) changelog from previous tagged release

StickyAPI v3 Changelog

Uh oh!

kaylendog left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecovBot commented Mar 3, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kaylendog left a comment

Choose a reason for hiding this comment

Uh oh!

kaylendog left a comment

Choose a reason for hiding this comment

Uh oh!

kaylendogMar 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kaylendogMar 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kaylendog left a comment

Choose a reason for hiding this comment

Uh oh!

kaylendogMar 24, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jcxldn commented Mar 3, 2021•
edited
Loading

codecovBot commented Mar 3, 2021•
edited
Loading