Fix to drop before first child by ChaituVR · Pull Request #1961 · SortableJS/Sortable

ChaituVR · 2020-11-19T08:02:29Z

Closes#1942

When child elements are aligned to the center or to right or to the end, unable to drop the element to start
previously we only have the ability to add only to the last element or nearby element,
with this PR user can add before the first element also

Issue: https://codepen.io/jjeff/pen/PozoJVQ
Fix: https://codepen.io/ChaituVR/pen/wvWbMXB

…ortableJS#1875) * deps: install dev-deps for ts, tests and friends * tests: replace test.js with test.ts and fp * change compat tests * ci: replace tests to use npm as per usual

…1878) The doc was missing the case of keeping the default insertion point based on the direction.

* refactor(tests): move HTML fixtures into own dir * refactor(tests): separate e2e tests into folders * refactor(deps): packagejson reformat * refactor(deps): remove cypress from dev deps * refactor(ci): add description to circleci

* refactor(tests): move HTML fixtures into own dir * refactor(tests): separate e2e tests into folders * refactor(deps): packagejson reformat * refactor(deps): remove cypress from dev deps * refactor(ci): add description to circleci * build: bundles with rollup ^2.14 and typescript * dist: create new dist files * chore: bump minor version * build(refactor): removes unused babel plugin

* build: upgrade to 1.11.0 * tests(fix): emit exit code 1 on fail

* build: upgrade to 1.11.0 * tests(fix): emit exit code 1 on fail * refactor: microbundle and typescript * ci: ensure lerna is globally available * build: use yarn and workspaces * use lerna * build: add private to sortbale repo * v1.11.1 * ci: use yarn and lerna together * fix ci * tests: fix tests

…S#1914) * refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template

…-links Readme invalid hyperlinks corrected

…ableJS#1921) * refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template * fix(build): build dist/sortablejs, was missing prior * build(deps): yarn upgrade * v1.11.2-alpha.4

* refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template * fix(build): build dist/sortablejs, was missing prior * build(deps): yarn upgrade * v1.11.2-alpha.4

* refactor: remove code formattings config files * docs: add more detail to contribution guidelines * docs: remove custom templates * docs: update bug report issue * docs: add discussion template * docs: update featue template * fix(build): build dist/sortablejs, was missing prior * build(deps): yarn upgrade * v1.11.2-alpha.4 * fix(build): exports modules correctly This was broken, visible, and closesSortableJS#1891.

closesSortableJS#1891

Fix/no modules

* Create composer.json * Change project name in composer.json * Fix authors listed in composer.json * Update repo source in composer.json Co-authored-by: Wayne Van Son <waynevanson@gmail.com> * Update "issues" link in composer.json Co-authored-by: Wayne Van Son <waynevanson@gmail.com> * Update homepage link in composer.json Co-authored-by: Wayne Van Son <waynevanson@gmail.com> * Update package name in composer.json Co-authored-by: Wayne Van Son <waynevanson@gmail.com> * Remove legacy file from composer.json files list Co-authored-by: Derek DeRaps <derekderaps@users.noreply.github.com> Co-authored-by: Wayne Van Son <waynevanson@gmail.com>

closesSortableJS#1581

Fix IE11 "SCRIPT16389: Unspecified error." when dragging element Could not pull in SortableJS#1904 due to merge errors, so this PR was created instead.

fix: (IE11 "SCRIPT16389)

Update some minor typos

Fix demo link

@waynevanson

@waynevanson renamed the repo form `Sortable` to `sortablejs` so users don't get confused on which package to install

Removed Dead Link

jjeff · 2020-11-29T18:28:31Z

I've tested this and it works.

jjeff · 2020-12-16T14:12:00Z

Giving this a nudge. It would be great if @RubaXa, @owen-m1, @waynevanson, or one of the other core people signed off on this so we can get this fixed in the next version of Sortable.

Thanks!

jjeff · 2021-01-08T15:48:53Z

Just tested with Sortable 1.13.0 and while a similar issue has been fixed, it looks like this one has not.

owen-m1 · 2021-01-08T16:33:43Z

@jjeff Yes I am still looking at this one... it isn't an issue as it is the intended to only work for the last in the list, but I will add this one for the next version

jjeff · 2021-01-08T16:42:49Z

@jjeff Yes I am still looking at this one... it isn't an issue as it is the intended to only work for the last in the list, but I will add this one for the next version

Thanks @owen-m1!

FWIW, here is the original issue with a GIF animation illustrating the problem.

owen-m1 · 2021-02-07T02:39:08Z

@ChaituVR Would you like to rebase this or redo this PR with the current master branch? A lot of commits were rolled back. Or I could just copy and paste your code and add it myself if you are okay with that

owen-m1 · 2021-02-10T03:40:11Z

nvm, it requires some modifications so I will do it

owen-m1 · 2021-05-02T15:16:16Z

Added in this commit: 77e0481

waynevansonand others added 30 commits August 7, 2020 15:27

tests,ci: replace yarn ci with npm ci, use typescript to run tests (S…
51e73bc
…ortableJS#1875) * deps: install dev-deps for ts, tests and friends * tests: replace test.js with test.ts and fp * change compat tests * ci: replace tests to use npm as per usual

docs: adds true and void return values to options.onMove (SortableJS#…
340e8a2
…1878) The doc was missing the case of keeping the default insertion point based on the direction.

build: upgrade to 1.11.0 (SortableJS#1884)
d53f85e
* build: upgrade to 1.11.0 * tests(fix): emit exit code 1 on fail

Update CONTRIBUTING.md
aa19cf3

v1.11.2-alpha.0
2aa3309

docs: add line
9fac640

v1.11.2-alpha.1
be69093

build: add prepublishOnly to sortablejs
cd03c6c

v1.11.2-alpha.2
6cd93be

build: ensure modular is bundled on deploy
608ee74

v1.11.2-alpha.3
a798fcf

Readme invalid hyperlinks corrected
650cd1c

Merge pull requestSortableJS#1919from YogeshSinghChouhan/fix-readme…
62b3492
…-links Readme invalid hyperlinks corrected

v1.12.0
e4dc8b0

chore(*): uses@SortableJSinstead of@Sortable
5d8d44d

fix(exports): remove packagejson#module
d7af518
closesSortableJS#1891

Merge pull requestSortableJS#1927from waynevanson/fix/no_modules
9a08465
Fix/no modules

v1.13.0
f74d678

chore(core): renames sortable to core in json
592deff

fix(plugins): ignore moutning duplicate plugins
6e3ac78
closesSortableJS#1581

fix(util): Fix IE11 "SCRIPT16389"
8d50d58
Fix IE11 "SCRIPT16389: Unspecified error." when dragging element Could not pull in SortableJS#1904 due to merge errors, so this PR was created instead.

Merge pull requestSortableJS#1932from waynevanson/master
87c3575
fix: (IE11 "SCRIPT16389)

CyrilKrylatovand others added 6 commits September 25, 2020 02:29

docs(readme): fix typo (SortableJS#1934)
663a466
Update some minor typos

Fix demo link
4c9db86
Fix demo link

docs(readme): fix link to demo page (SortableJS#1939)
22b80e3
@waynevanson renamed the repo form `Sortable` to `sortablejs` so users don't get confused on which package to install

Removed Dead Link
2ad95c4

Merge pull requestSortableJS#1950from joshgtb/patch-1
6d47ac3
Removed Dead Link

Drop before first element
78fc9f7

waynevanson force-pushed the master branch from 6d47ac3 to 88838bfCompare December 24, 2020 03:16

owen-m1 closed this May 2, 2021

snyk-bot mentioned this pull request Sep 10, 2021
[Snyk] Security upgrade testcafe from 0.16.2 to 0.18.5 procore/Sortable#1
Open

Navigation Menu

Uh oh!

Fix to drop before first child - #1961

Fix to drop before first child#1961
ChaituVR wants to merge 36 commits into
SortableJS:masterfrom
ChaituVR:fix-drag-drop-to-front

ChaituVR commented Nov 19, 2020

Uh oh!

jjeff commented Nov 29, 2020

Uh oh!

jjeff commented Dec 16, 2020

Uh oh!

jjeff commented Jan 8, 2021

Uh oh!

owen-m1 commented Jan 8, 2021

Uh oh!

jjeff commented Jan 8, 2021

Uh oh!

owen-m1 commented Feb 7, 2021

Uh oh!

owen-m1 commented Feb 10, 2021

Uh oh!

owen-m1 commented May 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

ChaituVR commented Nov 19, 2020

Uh oh!

jjeff commented Nov 29, 2020

Uh oh!

jjeff commented Dec 16, 2020

Uh oh!

jjeff commented Jan 8, 2021

Uh oh!

owen-m1 commented Jan 8, 2021

Uh oh!

jjeff commented Jan 8, 2021

Uh oh!

owen-m1 commented Feb 7, 2021

Uh oh!

owen-m1 commented Feb 10, 2021

Uh oh!

owen-m1 commented May 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants