test(angular-query): replace 'toBeDefined' with exact-value assertion by sukvvon · Pull Request #11121 · TanStack/query

sukvvon · 2026-07-26T15:46:42Z

🎯 Changes

Continues the recent test-quality series (e.g. #11105, #11093) by converting the toBeDefined() assertion in angular-query-experimental tests to an exact assertion:

inject-mutation.test.ts — the redundant expect(mutation).toBeDefined() existence check is removed; the next line already asserts ?.options.mutationKey on the same value via optional chaining, which fails on undefined either way.

After this, grep -rE 'toBeTruthy\(\)|toBeFalsy\(\)|toBeDefined\(\)' packages/angular-query-experimental/src returns no matches.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally.

Local verification detail: vitest run on the edited file — 28 tests passed, no type errors.

🚀 Release Impact

This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Improved test assertion handling for required signal inputs without changing user-facing functionality.

nx-cloud · 2026-07-26T15:47:15Z

View your CI Pipeline Execution ↗ for commit 5654990

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	5m 20s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	9s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-26 15:53:25 UTC

github-actions · 2026-07-26T15:47:42Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-07-26T15:48:34Z

📝 Walkthrough

Walkthrough

The required signal inputs test now directly checks the optional mutation key with strict equality, removing the preceding definedness assertion and non-null access.

Changes

Mutation test assertion

Layer / File(s)	Summary
Update mutation key assertion `packages/angular-query-experimental/src/__tests__/inject-mutation.test.ts`	The test compares `mutation?.options.mutationKey` directly with `['fake', 'value']`.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the test-only assertion change in angular-query-experimental.
Description check	✅ Passed	The description matches the template and includes changes, checklist items, local verification, and release impact.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/angular-query-exact-assertions

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-07-26T15:50:35Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11121

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11121

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11121

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11121

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11121

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11121

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11121

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11121

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11121

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11121

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11121

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11121

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11121

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11121

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11121

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11121

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11121

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11121

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11121

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11121

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11121

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11121

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11121

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11121

commit: 5654990

github-actions · 2026-07-26T15:50:58Z

size-limit report 📦

Path	Size
react full	12.15 KB (0%)
react minimal	9.1 KB (0%)

test(angular-query): assert exact values instead of loose matchers
5654990

sukvvon changed the title ~~test(angular-query): assert exact values instead of loose matchers~~test(angular-query): replace 'toBeDefined()' with exact-value assertionJul 26, 2026

sukvvon changed the title ~~test(angular-query): replace 'toBeDefined()' with exact-value assertion~~test(angular-query): replace 'toBeDefined' with exact-value assertionJul 26, 2026

sukvvon self-assigned this Jul 26, 2026

sukvvon merged commit e330cee into mainJul 26, 2026
9 checks passed

sukvvon deleted the test/angular-query-exact-assertions branch July 26, 2026 15:56

Navigation Menu

Uh oh!

Uh oh!

test(angular-query): replace 'toBeDefined' with exact-value assertion - #11121

test(angular-query): replace 'toBeDefined' with exact-value assertion#11121
sukvvon merged 1 commit into
mainfrom
test/angular-query-exact-assertions

sukvvon commented Jul 26, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

nx-cloudBot commented Jul 26, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Jul 26, 2026

Uh oh!

coderabbitaiBot commented Jul 26, 2026•
edited
Loading

Walkthrough

Changes

Uh oh!

pkg-pr-newBot commented Jul 26, 2026

Uh oh!

github-actionsBot commented Jul 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Jul 26, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloudBot commented Jul 26, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Jul 26, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitaiBot commented Jul 26, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

pkg-pr-newBot commented Jul 26, 2026

Uh oh!

github-actionsBot commented Jul 26, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Jul 26, 2026•
edited by coderabbitai Bot
Loading

nx-cloudBot commented Jul 26, 2026•
edited
Loading

coderabbitaiBot commented Jul 26, 2026•
edited
Loading