test(solid-query): assert exact values instead of loose matchers by reizam · Pull Request #11105 · TanStack/query

reizam · 2026-07-22T07:25:17Z

🎯 Changes

Continues the recent test-quality series (e.g. #11057, #11093) by converting the toBeTruthy() / toBeFalsy() / toBeDefined() assertions in solid-query tests to exact assertions:

QueryClientProvider — cache presence checks now assert the exact cached value (?.state.data) produced by the test's queryFn, and the cross-cache absence checks in the partitioning test use toBeUndefined() instead of not.toBeDefined(). One redundant existence check was removed where the next line already asserts ?.options.gcTime on the same query (it fails on undefined either way).
suspense — the cache absence check before mount uses toBeUndefined() instead of toBeFalsy().
useQuery — after the first fetch in the client-switch test, the presence check on queryClient1's cache now asserts the exact cached value.
mutationOptions — removed expect(lastSnapshot[1]).toBeFalsy(): the preceding expect(lastSnapshot.length).toEqual(1) already guarantees there is no second entry.

One toBeDefined() is intentionally left in place: in useQuery → "should refetch query when queryClient changes", tightening the queryClient2 cache check to ?.state.data fails. After setClient(queryClient2), the second queryFn call actually lands in queryClient1's cache (its dataUpdateCount goes to 2) while the entry in queryClient2's cache stays status: 'pending' / fetchStatus: 'idle' and never fetches. This looks like an observer re-subscription ordering issue in useBaseQuery (in the on(client, ...) computed, createClientSubscriber() is called before setObserver(newObserver), so the subscription attaches to the old observer). I'd rather report and fix that separately than encode the current behavior into an exact assertion here.

After this, grep -rE 'toBeTruthy\(\)|toBeFalsy\(\)|toBeDefined\(\)' packages/solid-query/src only matches the site described above.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally.

Local verification detail: vitest run on the four edited files — 162 tests passed, no type errors; test:eslint and prettier clean; full-suite failure set identical to main in the same environment.

🚀 Release Impact

This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Strengthened cache validation to confirm stored query data and correct separation across caches.
- Improved mutation state assertions to verify returned successful data.
- Clarified unmount behavior by checking that removed queries are absent.
- Tightened refetch validation to confirm expected cached results.

coderabbitai · 2026-07-22T07:25:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8087fcbe-ade6-42f8-b190-ad0704c60128

📥 Commits

Reviewing files that changed from the base of the PR and between 86bb8a6 and cc8615f.

📒 Files selected for processing (4)

packages/solid-query/src/__tests__/QueryClientProvider.test.tsx
packages/solid-query/src/__tests__/mutationOptions.test.tsx
packages/solid-query/src/__tests__/suspense.test.tsx
packages/solid-query/src/__tests__/useQuery.test.tsx

💤 Files with no reviewable changes (1)

packages/solid-query/src/tests/mutationOptions.test.tsx

📝 Walkthrough

Walkthrough

Tests tighten Solid Query cache and mutation assertions by validating stored data values, cache isolation, explicit undefined results, and filtered mutation output.

Changes

Solid Query test assertions

Layer / File(s)	Summary
Query cache state and isolation assertions `packages/solid-query/src/__tests__/QueryClientProvider.test.tsx`, `packages/solid-query/src/__tests__/useQuery.test.tsx`, `packages/solid-query/src/__tests__/suspense.test.tsx`	Cache tests now verify resolved `state.data`, partition-specific entries, and explicit `undefined` results while retaining default-option validation.
Filtered mutation data assertion `packages/solid-query/src/__tests__/mutationOptions.test.tsx`	The filtered mutation-state test now verifies the matching mutation’s data is `data1`.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers:sukvvon

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: tightening solid-query tests to exact-value assertions.
Description check	✅ Passed	The description follows the template and includes changes, checklist, and release-impact sections with the required details.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-07-26T05:15:11Z

View your CI Pipeline Execution ↗ for commit cc8615f

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 12s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-26 05:26:17 UTC

pkg-pr-new · 2026-07-26T05:18:39Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11105

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11105

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11105

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11105

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11105

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11105

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11105

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11105

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11105

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11105

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11105

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11105

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11105

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11105

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11105

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11105

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11105

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11105

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11105

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11105

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11105

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11105

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11105

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11105

commit: 54369b4

test(solid-query): assert exact values instead of loose matchers
cc8615f

reizam mentioned this pull request Jul 22, 2026
solid-query: switching the queryClient accessor strands the new client's cache (subscription stays on the old observer) #11106
Open

coderabbitaiBot mentioned this pull request Jul 23, 2026
fix(solid-query): subscribe to new observer when queryClient accessor switches #11111
Open
4 tasks

Merge branch 'main' into test/solid-query-exact-assertions
54369b4

sukvvon approved these changes Jul 26, 2026
View reviewed changes

sukvvon merged commit f320db5 into TanStack:mainJul 26, 2026
9 checks passed

aken-you mentioned this pull request Jul 27, 2026
test(svelte-query/createQuery): replace 'toBeDefined' with exact-value assertion #11126
Merged
4 tasks

coderabbitaiBot mentioned this pull request Aug 18, 2026
fix(solid-query): don't re-trigger Suspense on background refetches #11230
Open

Navigation Menu

Uh oh!

Uh oh!

test(solid-query): assert exact values instead of loose matchers - #11105

test(solid-query): assert exact values instead of loose matchers#11105
sukvvon merged 2 commits into
TanStack:mainfrom
reizam:test/solid-query-exact-assertions

reizam commented Jul 22, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

coderabbitaiBot commented Jul 22, 2026•
edited
Loading

Walkthrough

Changes

Uh oh!

nx-cloudBot commented Jul 26, 2026•
edited
Loading

Uh oh!

pkg-pr-newBot commented Jul 26, 2026•
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

reizam commented Jul 22, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitaiBot commented Jul 22, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

nx-cloudBot commented Jul 26, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-newBot commented Jul 26, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

reizam commented Jul 22, 2026•
edited by coderabbitai Bot
Loading

coderabbitaiBot commented Jul 22, 2026•
edited
Loading

nx-cloudBot commented Jul 26, 2026•
edited
Loading

pkg-pr-newBot commented Jul 26, 2026•
edited
Loading