test(svelte-query): replace 'toBeDefined' with exact-value assertion by sukvvon · Pull Request #11124 · TanStack/query

sukvvon · 2026-07-26T15:48:03Z

🎯 Changes

Continues the recent test-quality series (e.g. #11105, #11093) by converting the toBeDefined() assertion in svelte-query tests to an exact assertion:

QueryClientProvider.svelte.test.ts — the cache presence check now asserts the exact cached value (?.state.data) produced by the test's queryFn, confirmed by the rendered Data: test text.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested this code locally.

Local verification detail: vitest run on the full package — 168 tests passed, no type errors.

🚀 Release Impact

This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Strengthened validation of cached query data to confirm it contains the expected value.

nx-cloud · 2026-07-26T15:48:28Z

View your CI Pipeline Execution ↗ for commit 09aa511

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 54s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-07-26 15:53:10 UTC

github-actions · 2026-07-26T15:49:05Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-07-26T15:50:09Z

📝 Walkthrough

Walkthrough

The QueryClientProvider test now verifies that the cached ['hello'] query contains 'test', rather than only confirming that the cache entry exists.

Changes

QueryClientProvider cache validation

Layer / File(s)	Summary
Strengthen cached data assertion `packages/svelte-query/tests/QueryClientProvider/QueryClientProvider.svelte.test.ts`	The cache assertion now checks that the query’s `state.data` equals `'test'`.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the test assertion change in svelte-query.
Description check	✅ Passed	The description follows the template and includes changes, checklist status, and release impact with useful verification details.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch test/svelte-query-exact-assertions

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-07-26T15:51:54Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11124

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11124

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11124

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11124

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11124

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11124

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11124

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11124

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11124

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11124

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11124

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11124

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11124

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11124

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11124

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11124

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11124

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11124

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11124

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11124

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11124

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11124

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11124

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11124

commit: 09aa511

github-actions · 2026-07-26T15:52:08Z

size-limit report 📦

Path	Size
react full	12.15 KB (0%)
react minimal	9.1 KB (0%)

test(svelte-query): assert exact values instead of loose matchers
09aa511

sukvvon changed the title ~~test(svelte-query): assert exact values instead of loose matchers~~test(svelte-query): replace 'toBeDefined()' with exact-value assertionJul 26, 2026

sukvvon changed the title ~~test(svelte-query): replace 'toBeDefined()' with exact-value assertion~~test(svelte-query): replace 'toBeDefined' with exact-value assertionJul 26, 2026

sukvvon self-assigned this Jul 26, 2026

sukvvon merged commit 5972ae6 into mainJul 26, 2026
9 checks passed

sukvvon deleted the test/svelte-query-exact-assertions branch July 26, 2026 15:58

aken-you mentioned this pull request Jul 27, 2026
test(svelte-query/createQuery): replace 'toBeDefined' with exact-value assertion #11126
Merged
4 tasks

Navigation Menu

Uh oh!

Uh oh!

test(svelte-query): replace 'toBeDefined' with exact-value assertion - #11124

test(svelte-query): replace 'toBeDefined' with exact-value assertion#11124
sukvvon merged 1 commit into
mainfrom
test/svelte-query-exact-assertions

sukvvon commented Jul 26, 2026•
edited by coderabbitai Bot
Loading

Uh oh!

nx-cloudBot commented Jul 26, 2026•
edited
Loading

Uh oh!

github-actionsBot commented Jul 26, 2026

Uh oh!

coderabbitaiBot commented Jul 26, 2026•
edited
Loading

Walkthrough

Changes

Uh oh!

pkg-pr-newBot commented Jul 26, 2026

Uh oh!

github-actionsBot commented Jul 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

sukvvon commented Jul 26, 2026• edited by coderabbitai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloudBot commented Jul 26, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actionsBot commented Jul 26, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitaiBot commented Jul 26, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

pkg-pr-newBot commented Jul 26, 2026

Uh oh!

github-actionsBot commented Jul 26, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Jul 26, 2026•
edited by coderabbitai Bot
Loading

nx-cloudBot commented Jul 26, 2026•
edited
Loading

coderabbitaiBot commented Jul 26, 2026•
edited
Loading