perf: compact private bundle boundaries

[Sheraff]

Summary

• compact closure-local history actions and router matching results
• flatten private Solid and Vue component/helper boundaries
• remove a one-use Start fetch-body wrapper without changing wire behavior

All public options, callbacks, component props, browser history state, and serialized HTTP formats remain unchanged.

Bundle size

Measured against main at 697ebb6ddbd433d052b6b4707938a5c595865d58:

• all 17 scenarios improve gzip by 21–125 B
• all 17 initial-load gzip measurements improve by 23–126 B
• all 17 raw measurements improve by 108–425 B
• Brotli ranges from -158 B to +52 B; 12 of 17 scenarios improve

The isolated measurements and full matrix are in RESULT-optimization-compact-private-boundaries.md.

Performance

The retained lightweight-match tuple was effectively flat in repeated buildLocation benchmarks: cached and uncached results stayed within 0.8% with benchmark error around 3%.

An additional LRU tuple experiment saved 9 B gzip but slowed eviction-heavy churn by roughly 24%, so it was rejected and is not part of this PR.

Validation

• history: 29 unit tests
• router-core: 1,523 passing unit tests plus 3 expected failures
• Solid Router: 841 passing client/server tests plus 1 skip
• Vue Router: 814 passing tests plus 1 skip
• Start client core: 80 passing tests
• type tests for all five affected packages and configured TypeScript versions
• ESLint for all five affected packages
• React Start E2E app build and 5 focused server-function Playwright tests
• complete 17-scenario bundle build
• five independent semantic, performance, lifecycle, tree-shaking, and adversarial reviews

Summary by CodeRabbit

• Bug Fixes

  • Improved browser history batching and flushing for more predictable navigation updates.
  • Preserved push navigation correctly when subsequent replace operations occur.
  • Improved handling of server-request payloads, including JSON and form submissions.

• Refactor

  • Streamlined route matching, match context, link handling, script rendering, and navigation internals without changing their intended behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR replaces selected internal object-shaped values and helper parameters with tuples or positional arguments. It updates browser history batching, route matching, Solid nearest-match context, server-function request bodies, Vue script rendering, and Vue link helpers. Browser history tests cover queue coalescing and flushing.

Changes

Browser history batching

Layer / File(s)	Summary
Queue representation and flush behavior packages/history/src/index.ts	Pending actions use tuples. Flush logic clears the queued action and preserves push semantics across updates.
Browser history batching tests packages/history/tests/createBrowserHistory.test.ts	Tests cover replace coalescing, action promotion, push preservation, and explicit flushing.

Lightweight route matching

Layer / File(s)	Summary
Lightweight match tuple flow packages/router-core/src/router.ts	Lightweight matching, validation, and location construction read the four-element result tuple by index.

Solid nearest-match context

Layer / File(s)	Summary
Nearest-match tuple contract and consumers packages/solid-router/src/matchContext.tsx, packages/solid-router/src/Match.tsx, packages/solid-router/src/Matches.tsx, packages/solid-router/src/useMatch.tsx	The nearest-match context stores route ID and match accessors in a readonly tuple. Consumers read the tuple positions.

Server function request bodies

Layer / File(s)	Summary
Direct POST body handling packages/start-client-core/src/client-rpc/serverFnFetcher.ts	POST body construction returns FormData or serialized payloads directly. JSON content type assignment occurs when the body is a string.

Vue router rendering helpers

Layer / File(s)	Summary
Script rendering argument flow packages/vue-router/src/Scripts.tsx	Scripts passes script data, mount state, and nonce positionally to renderScripts.
Link helper signatures and call sites packages/vue-router/src/link.tsx	SSR and reactive link code uses positional arguments for href, active-state, and style helpers.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• TanStack/router#7805: Both PRs modify Solid router match-rendering code, including MatchInner and Outlet.
• TanStack/router#7966: Both PRs modify lightweight route-matching data in packages/router-core/src/router.ts.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the PR's primary optimization: compacting private bundle boundaries.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/compact-private-boundaries

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ba8e35b

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	5m 10s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	28s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-06 07:24:49 UTC

[github-actions]

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
@tanstack/react-router	1.170.20 → 1.170.21	Changeset
@tanstack/router-core	1.171.17 → 1.171.18	Changeset
@tanstack/solid-router	1.170.20 → 1.170.21	Changeset
@tanstack/start-server-core	1.169.20 → 1.169.21	Changeset
@tanstack/vue-router	1.170.19 → 1.170.20	Changeset
@tanstack/react-start	1.168.37 → 1.168.38	Dependent
@tanstack/react-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/react-start-rsc	0.1.36 → 0.1.37	Dependent
@tanstack/react-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/router-cli	1.167.23 → 1.167.24	Dependent
@tanstack/router-generator	1.167.23 → 1.167.24	Dependent
@tanstack/router-plugin	1.168.25 → 1.168.26	Dependent
@tanstack/router-vite-plugin	1.167.25 → 1.167.26	Dependent
@tanstack/solid-start	1.168.36 → 1.168.37	Dependent
@tanstack/solid-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/solid-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/start-client-core	1.170.16 → 1.170.17	Dependent
@tanstack/start-plugin-core	1.171.28 → 1.171.29	Dependent
@tanstack/start-static-server-functions	1.167.21 → 1.167.22	Dependent
@tanstack/start-storage-context	1.167.19 → 1.167.20	Dependent
@tanstack/vue-start	1.168.35 → 1.168.36	Dependent
@tanstack/vue-start-client	1.167.21 → 1.167.22	Dependent
@tanstack/vue-start-server	1.167.25 → 1.167.26	Dependent

[github-actions]

Bundle Size Benchmarks

• Commit: bfb30996c193
• Measured at: 2026-08-06T07:20:48.840Z
• Baseline source: history:697ebb6ddbd4
• Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
react-router.minimal	87.07 KiB	-38 B (-0.04%)	86.94 KiB	269.02 KiB	75.85 KiB	████▂▂▂▂▂▁▂▁
react-router.full	90.88 KiB	-21 B (-0.02%)	90.74 KiB	280.98 KiB	79.08 KiB	████▂▂▂▂▂▁▂▁
solid-router.minimal	34.77 KiB	-27 B (-0.08%)	34.65 KiB	99.80 KiB	31.41 KiB	████▂▂▂▂▂▁▁▁
solid-router.full	39.86 KiB	-41 B (-0.10%)	39.74 KiB	114.97 KiB	35.86 KiB	████▂▂▂▂▂▁▁▁
vue-router.minimal	52.03 KiB	-64 B (-0.12%)	51.90 KiB	142.85 KiB	46.87 KiB	████▂▂▂▂▂▁▁▁
vue-router.full	57.96 KiB	-88 B (-0.15%)	57.83 KiB	161.43 KiB	52.05 KiB	████▂▂▂▂▂▂▂▁
react-start.minimal	100.54 KiB	-60 B (-0.06%)	100.40 KiB	312.13 KiB	87.31 KiB	███████▁▁▁▁▁
react-start.deferred-hydration	101.26 KiB	-78 B (-0.08%)	100.41 KiB	313.50 KiB	87.99 KiB	███████▁▁▁▁▁
react-start.full	103.88 KiB	-45 B (-0.04%)	103.74 KiB	322.08 KiB	90.21 KiB	███████▁▁▁▁▁
react-start.rsbuild.minimal	100.16 KiB	-80 B (-0.08%)	99.99 KiB	316.63 KiB	86.39 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.minimal-iife	100.57 KiB	-77 B (-0.07%)	100.40 KiB	317.56 KiB	86.62 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.full	103.48 KiB	-86 B (-0.08%)	103.31 KiB	326.72 KiB	89.10 KiB	▁▁▁▁▃▃▃████▇
solid-start.minimal	48.13 KiB	-51 B (-0.10%)	48.00 KiB	141.89 KiB	42.77 KiB	███████▁▁▁▁▁
solid-start.deferred-hydration	51.40 KiB	-49 B (-0.09%)	48.06 KiB	149.93 KiB	45.75 KiB	███████▁▁▁▁▁
solid-start.full	53.38 KiB	-56 B (-0.10%)	53.25 KiB	157.61 KiB	47.35 KiB	████▆▆▆▁▁▁▁▁
vue-start.minimal	68.85 KiB	-125 B (-0.18%)	68.72 KiB	194.70 KiB	61.33 KiB	████▆▆▆▂▂▁▁▁
vue-start.full	72.82 KiB	-112 B (-0.15%)	72.69 KiB	207.21 KiB	64.71 KiB	████▆▆▆▂▂▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

[pkg-pr-new]

More templates

• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc
• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsbuild
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-example-rscs
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7975

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7975

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7975

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7975

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7975

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7975

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7975

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7975

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7975

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7975

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7975

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7975

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7975

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7975

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7975

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7975

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7975

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7975

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7975

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7975

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7975

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7975

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7975

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7975

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7975

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7975

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7975

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7975

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7975

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7975

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7975

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7975

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7975

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7975

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7975

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7975

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7975

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7975

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7975

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7975

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7975

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7975

commit: ba8e35b

[codspeed-hq]

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 4 (👁 4) regressed benchmarks
✅ 166 untouched benchmarks

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Memory	mem server server-fn-churn (vue)	4,147.3 KB	265.2 KB	×16
⚡	Memory	mem server error-paths unmatched (vue)	2,142.1 KB	479.6 KB	×4.5
⚡	Memory	mem server peak-large-page (react)	1,737.5 KB	952.1 KB	+82.48%
⚡	Memory	mem server error-paths redirect (solid)	388 KB	282.6 KB	+37.3%
⚡	Memory	mem server error-paths redirect (vue)	338.6 KB	295.8 KB	+14.48%
⚡	Memory	mem client navigation-churn (vue)	1.3 MB	1.2 MB	+4.6%
⚡	Simulation	client-head navigation loop (react)	76.2 ms	73.2 ms	+4.02%
⚡	Simulation	client-head navigation loop (vue)	94.3 ms	90.9 ms	+3.64%
⚡	Memory	mem server aborted-requests (solid)	930.4 KB	901 KB	+3.26%
⚡	Simulation	ssr control-flow unmatched 404 (react)	58.1 ms	56.4 ms	+3%
👁	Simulation	ssr request loop (solid)	156.5 ms	161.4 ms	-3.01%
👁	Memory	mem server error-paths not-found (solid)	415.1 KB	848.3 KB	-51.07%
👁	Memory	mem server peak-large-page (solid)	811.5 KB	842.2 KB	-3.64%
👁	Memory	mem client unique-location-churn (solid)	341.2 KB	564.6 KB	-39.57%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing codex/compact-private-boundaries (ba8e35b) with main (697ebb6)}

[coderabbitai]

🧹 Nitpick comments (1)

packages/vue-router/src/link.tsx (1)

628-641: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Preserve the search type in getIsActive.

Lines 631 and 636 use search: any. This removes type checking from the active-state comparison. Replace both inline location shapes with a shared ParsedLocation-derived or generic type that preserves the router search schema.

Proposed type-safe shape

+type LinkMatchLocation = Pick<+ ParsedLocation,+ 'pathname' | 'search' | 'hash'+>+
function getIsActive(
- loc: { pathname: string; search: any; hash: string },- nextLoc: { pathname: string; search: any; hash: string },+ loc: LinkMatchLocation,+ nextLoc: LinkMatchLocation,

Please confirm that the selected type remains assignable to router locations for all search schemas.

As per coding guidelines, TypeScript files must use strict mode with extensive type safety.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/vue-router/src/link.tsx` around lines 628 - 641, Update getIsActive
so both loc and nextLoc use a shared ParsedLocation-derived or generic location
type instead of inline search: any shapes, preserving the router’s search schema
and remaining assignable to router locations across all search schemas. Keep
pathname and hash typing intact while restoring strict type checking for search
comparisons.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/vue-router/src/link.tsx`:
- Around line 628-641: Update getIsActive so both loc and nextLoc use a shared
ParsedLocation-derived or generic location type instead of inline search: any
shapes, preserving the router’s search schema and remaining assignable to router
locations across all search schemas. Keep pathname and hash typing intact while
restoring strict type checking for search comparisons.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6aa90a02-72d0-4ef1-b441-9f732d08f0dd

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and ba8e35b.

📒 Files selected for processing (10)

• packages/history/src/index.ts
• packages/history/tests/createBrowserHistory.test.ts
• packages/router-core/src/router.ts
• packages/solid-router/src/Match.tsx
• packages/solid-router/src/Matches.tsx
• packages/solid-router/src/matchContext.tsx
• packages/solid-router/src/useMatch.tsx
• packages/start-client-core/src/client-rpc/serverFnFetcher.ts
• packages/vue-router/src/Scripts.tsx
• packages/vue-router/src/link.tsx

[Sheraff]

Summary

• compact closure-local history actions and router matching results
• flatten private Solid and Vue component/helper boundaries
• remove a one-use Start fetch-body wrapper without changing wire behavior

All public options, callbacks, component props, browser history state, and serialized HTTP formats remain unchanged.

Bundle size

Measured against main at 697ebb6ddbd433d052b6b4707938a5c595865d58:

• all 17 scenarios improve gzip by 21–125 B
• all 17 initial-load gzip measurements improve by 23–126 B
• all 17 raw measurements improve by 108–425 B
• Brotli ranges from -158 B to +52 B; 12 of 17 scenarios improve

The isolated measurements and full matrix are in RESULT-optimization-compact-private-boundaries.md.

Performance

The retained lightweight-match tuple was effectively flat in repeated buildLocation benchmarks: cached and uncached results stayed within 0.8% with benchmark error around 3%.

An additional LRU tuple experiment saved 9 B gzip but slowed eviction-heavy churn by roughly 24%, so it was rejected and is not part of this PR.

Validation

• history: 29 unit tests
• router-core: 1,523 passing unit tests plus 3 expected failures
• Solid Router: 841 passing client/server tests plus 1 skip
• Vue Router: 814 passing tests plus 1 skip
• Start client core: 80 passing tests
• type tests for all five affected packages and configured TypeScript versions
• ESLint for all five affected packages
• React Start E2E app build and 5 focused server-function Playwright tests
• complete 17-scenario bundle build
• five independent semantic, performance, lifecycle, tree-shaking, and adversarial reviews

Summary by CodeRabbit

• Bug Fixes

  • Improved browser history batching and flushing for more predictable navigation updates.
  • Preserved push navigation correctly when subsequent replace operations occur.
  • Improved handling of server-request payloads, including JSON and form submissions.

• Refactor

  • Streamlined route matching, match context, link handling, script rendering, and navigation internals without changing their intended behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR replaces selected internal object-shaped values and helper parameters with tuples or positional arguments. It updates browser history batching, route matching, Solid nearest-match context, server-function request bodies, Vue script rendering, and Vue link helpers. Browser history tests cover queue coalescing and flushing.

Changes

Browser history batching

Layer / File(s)	Summary
Queue representation and flush behavior packages/history/src/index.ts	Pending actions use tuples. Flush logic clears the queued action and preserves push semantics across updates.
Browser history batching tests packages/history/tests/createBrowserHistory.test.ts	Tests cover replace coalescing, action promotion, push preservation, and explicit flushing.

Lightweight route matching

Layer / File(s)	Summary
Lightweight match tuple flow packages/router-core/src/router.ts	Lightweight matching, validation, and location construction read the four-element result tuple by index.

Solid nearest-match context

Layer / File(s)	Summary
Nearest-match tuple contract and consumers packages/solid-router/src/matchContext.tsx, packages/solid-router/src/Match.tsx, packages/solid-router/src/Matches.tsx, packages/solid-router/src/useMatch.tsx	The nearest-match context stores route ID and match accessors in a readonly tuple. Consumers read the tuple positions.

Server function request bodies

Layer / File(s)	Summary
Direct POST body handling packages/start-client-core/src/client-rpc/serverFnFetcher.ts	POST body construction returns FormData or serialized payloads directly. JSON content type assignment occurs when the body is a string.

Vue router rendering helpers

Layer / File(s)	Summary
Script rendering argument flow packages/vue-router/src/Scripts.tsx	Scripts passes script data, mount state, and nonce positionally to renderScripts.
Link helper signatures and call sites packages/vue-router/src/link.tsx	SSR and reactive link code uses positional arguments for href, active-state, and style helpers.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• TanStack/router#7805: Both PRs modify Solid router match-rendering code, including MatchInner and Outlet.
• TanStack/router#7966: Both PRs modify lightweight route-matching data in packages/router-core/src/router.ts.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the PR's primary optimization: compacting private bundle boundaries.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/compact-private-boundaries

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ba8e35b

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	5m 10s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	28s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-06 07:24:49 UTC

[github-actions]

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
@tanstack/react-router	1.170.20 → 1.170.21	Changeset
@tanstack/router-core	1.171.17 → 1.171.18	Changeset
@tanstack/solid-router	1.170.20 → 1.170.21	Changeset
@tanstack/start-server-core	1.169.20 → 1.169.21	Changeset
@tanstack/vue-router	1.170.19 → 1.170.20	Changeset
@tanstack/react-start	1.168.37 → 1.168.38	Dependent
@tanstack/react-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/react-start-rsc	0.1.36 → 0.1.37	Dependent
@tanstack/react-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/router-cli	1.167.23 → 1.167.24	Dependent
@tanstack/router-generator	1.167.23 → 1.167.24	Dependent
@tanstack/router-plugin	1.168.25 → 1.168.26	Dependent
@tanstack/router-vite-plugin	1.167.25 → 1.167.26	Dependent
@tanstack/solid-start	1.168.36 → 1.168.37	Dependent
@tanstack/solid-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/solid-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/start-client-core	1.170.16 → 1.170.17	Dependent
@tanstack/start-plugin-core	1.171.28 → 1.171.29	Dependent
@tanstack/start-static-server-functions	1.167.21 → 1.167.22	Dependent
@tanstack/start-storage-context	1.167.19 → 1.167.20	Dependent
@tanstack/vue-start	1.168.35 → 1.168.36	Dependent
@tanstack/vue-start-client	1.167.21 → 1.167.22	Dependent
@tanstack/vue-start-server	1.167.25 → 1.167.26	Dependent

[github-actions]

Bundle Size Benchmarks

• Commit: bfb30996c193
• Measured at: 2026-08-06T07:20:48.840Z
• Baseline source: history:697ebb6ddbd4
• Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
react-router.minimal	87.07 KiB	-38 B (-0.04%)	86.94 KiB	269.02 KiB	75.85 KiB	████▂▂▂▂▂▁▂▁
react-router.full	90.88 KiB	-21 B (-0.02%)	90.74 KiB	280.98 KiB	79.08 KiB	████▂▂▂▂▂▁▂▁
solid-router.minimal	34.77 KiB	-27 B (-0.08%)	34.65 KiB	99.80 KiB	31.41 KiB	████▂▂▂▂▂▁▁▁
solid-router.full	39.86 KiB	-41 B (-0.10%)	39.74 KiB	114.97 KiB	35.86 KiB	████▂▂▂▂▂▁▁▁
vue-router.minimal	52.03 KiB	-64 B (-0.12%)	51.90 KiB	142.85 KiB	46.87 KiB	████▂▂▂▂▂▁▁▁
vue-router.full	57.96 KiB	-88 B (-0.15%)	57.83 KiB	161.43 KiB	52.05 KiB	████▂▂▂▂▂▂▂▁
react-start.minimal	100.54 KiB	-60 B (-0.06%)	100.40 KiB	312.13 KiB	87.31 KiB	███████▁▁▁▁▁
react-start.deferred-hydration	101.26 KiB	-78 B (-0.08%)	100.41 KiB	313.50 KiB	87.99 KiB	███████▁▁▁▁▁
react-start.full	103.88 KiB	-45 B (-0.04%)	103.74 KiB	322.08 KiB	90.21 KiB	███████▁▁▁▁▁
react-start.rsbuild.minimal	100.16 KiB	-80 B (-0.08%)	99.99 KiB	316.63 KiB	86.39 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.minimal-iife	100.57 KiB	-77 B (-0.07%)	100.40 KiB	317.56 KiB	86.62 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.full	103.48 KiB	-86 B (-0.08%)	103.31 KiB	326.72 KiB	89.10 KiB	▁▁▁▁▃▃▃████▇
solid-start.minimal	48.13 KiB	-51 B (-0.10%)	48.00 KiB	141.89 KiB	42.77 KiB	███████▁▁▁▁▁
solid-start.deferred-hydration	51.40 KiB	-49 B (-0.09%)	48.06 KiB	149.93 KiB	45.75 KiB	███████▁▁▁▁▁
solid-start.full	53.38 KiB	-56 B (-0.10%)	53.25 KiB	157.61 KiB	47.35 KiB	████▆▆▆▁▁▁▁▁
vue-start.minimal	68.85 KiB	-125 B (-0.18%)	68.72 KiB	194.70 KiB	61.33 KiB	████▆▆▆▂▂▁▁▁
vue-start.full	72.82 KiB	-112 B (-0.15%)	72.69 KiB	207.21 KiB	64.71 KiB	████▆▆▆▂▂▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

[pkg-pr-new]

More templates

• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc
• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsbuild
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-example-rscs
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7975

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7975

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7975

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7975

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7975

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7975

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7975

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7975

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7975

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7975

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7975

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7975

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7975

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7975

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7975

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7975

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7975

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7975

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7975

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7975

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7975

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7975

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7975

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7975

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7975

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7975

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7975

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7975

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7975

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7975

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7975

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7975

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7975

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7975

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7975

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7975

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7975

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7975

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7975

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7975

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7975

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7975

commit: ba8e35b

[codspeed-hq]

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 4 (👁 4) regressed benchmarks
✅ 166 untouched benchmarks

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Memory	mem server server-fn-churn (vue)	4,147.3 KB	265.2 KB	×16
⚡	Memory	mem server error-paths unmatched (vue)	2,142.1 KB	479.6 KB	×4.5
⚡	Memory	mem server peak-large-page (react)	1,737.5 KB	952.1 KB	+82.48%
⚡	Memory	mem server error-paths redirect (solid)	388 KB	282.6 KB	+37.3%
⚡	Memory	mem server error-paths redirect (vue)	338.6 KB	295.8 KB	+14.48%
⚡	Memory	mem client navigation-churn (vue)	1.3 MB	1.2 MB	+4.6%
⚡	Simulation	client-head navigation loop (react)	76.2 ms	73.2 ms	+4.02%
⚡	Simulation	client-head navigation loop (vue)	94.3 ms	90.9 ms	+3.64%
⚡	Memory	mem server aborted-requests (solid)	930.4 KB	901 KB	+3.26%
⚡	Simulation	ssr control-flow unmatched 404 (react)	58.1 ms	56.4 ms	+3%
👁	Simulation	ssr request loop (solid)	156.5 ms	161.4 ms	-3.01%
👁	Memory	mem server error-paths not-found (solid)	415.1 KB	848.3 KB	-51.07%
👁	Memory	mem server peak-large-page (solid)	811.5 KB	842.2 KB	-3.64%
👁	Memory	mem client unique-location-churn (solid)	341.2 KB	564.6 KB	-39.57%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing codex/compact-private-boundaries (ba8e35b) with main (697ebb6)}

[coderabbitai]

🧹 Nitpick comments (1)

packages/vue-router/src/link.tsx (1)

628-641: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Preserve the search type in getIsActive.

Lines 631 and 636 use search: any. This removes type checking from the active-state comparison. Replace both inline location shapes with a shared ParsedLocation-derived or generic type that preserves the router search schema.

Proposed type-safe shape

+type LinkMatchLocation = Pick<+ ParsedLocation,+ 'pathname' | 'search' | 'hash'+>+
function getIsActive(
- loc: { pathname: string; search: any; hash: string },- nextLoc: { pathname: string; search: any; hash: string },+ loc: LinkMatchLocation,+ nextLoc: LinkMatchLocation,

Please confirm that the selected type remains assignable to router locations for all search schemas.

As per coding guidelines, TypeScript files must use strict mode with extensive type safety.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/vue-router/src/link.tsx` around lines 628 - 641, Update getIsActive
so both loc and nextLoc use a shared ParsedLocation-derived or generic location
type instead of inline search: any shapes, preserving the router’s search schema
and remaining assignable to router locations across all search schemas. Keep
pathname and hash typing intact while restoring strict type checking for search
comparisons.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/vue-router/src/link.tsx`:
- Around line 628-641: Update getIsActive so both loc and nextLoc use a shared
ParsedLocation-derived or generic location type instead of inline search: any
shapes, preserving the router’s search schema and remaining assignable to router
locations across all search schemas. Keep pathname and hash typing intact while
restoring strict type checking for search comparisons.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6aa90a02-72d0-4ef1-b441-9f732d08f0dd

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and ba8e35b.

📒 Files selected for processing (10)

• packages/history/src/index.ts
• packages/history/tests/createBrowserHistory.test.ts
• packages/router-core/src/router.ts
• packages/solid-router/src/Match.tsx
• packages/solid-router/src/Matches.tsx
• packages/solid-router/src/matchContext.tsx
• packages/solid-router/src/useMatch.tsx
• packages/start-client-core/src/client-rpc/serverFnFetcher.ts
• packages/vue-router/src/Scripts.tsx
• packages/vue-router/src/link.tsx

[Sheraff]

Summary

• compact closure-local history actions and router matching results
• flatten private Solid and Vue component/helper boundaries
• remove a one-use Start fetch-body wrapper without changing wire behavior

All public options, callbacks, component props, browser history state, and serialized HTTP formats remain unchanged.

Bundle size

Measured against main at 697ebb6ddbd433d052b6b4707938a5c595865d58:

• all 17 scenarios improve gzip by 21–125 B
• all 17 initial-load gzip measurements improve by 23–126 B
• all 17 raw measurements improve by 108–425 B
• Brotli ranges from -158 B to +52 B; 12 of 17 scenarios improve

The isolated measurements and full matrix are in RESULT-optimization-compact-private-boundaries.md.

Performance

The retained lightweight-match tuple was effectively flat in repeated buildLocation benchmarks: cached and uncached results stayed within 0.8% with benchmark error around 3%.

An additional LRU tuple experiment saved 9 B gzip but slowed eviction-heavy churn by roughly 24%, so it was rejected and is not part of this PR.

Validation

• history: 29 unit tests
• router-core: 1,523 passing unit tests plus 3 expected failures
• Solid Router: 841 passing client/server tests plus 1 skip
• Vue Router: 814 passing tests plus 1 skip
• Start client core: 80 passing tests
• type tests for all five affected packages and configured TypeScript versions
• ESLint for all five affected packages
• React Start E2E app build and 5 focused server-function Playwright tests
• complete 17-scenario bundle build
• five independent semantic, performance, lifecycle, tree-shaking, and adversarial reviews

Summary by CodeRabbit

• Bug Fixes

  • Improved browser history batching and flushing for more predictable navigation updates.
  • Preserved push navigation correctly when subsequent replace operations occur.
  • Improved handling of server-request payloads, including JSON and form submissions.

• Refactor

  • Streamlined route matching, match context, link handling, script rendering, and navigation internals without changing their intended behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR replaces selected internal object-shaped values and helper parameters with tuples or positional arguments. It updates browser history batching, route matching, Solid nearest-match context, server-function request bodies, Vue script rendering, and Vue link helpers. Browser history tests cover queue coalescing and flushing.

Changes

Browser history batching

Layer / File(s)	Summary
Queue representation and flush behavior packages/history/src/index.ts	Pending actions use tuples. Flush logic clears the queued action and preserves push semantics across updates.
Browser history batching tests packages/history/tests/createBrowserHistory.test.ts	Tests cover replace coalescing, action promotion, push preservation, and explicit flushing.

Lightweight route matching

Layer / File(s)	Summary
Lightweight match tuple flow packages/router-core/src/router.ts	Lightweight matching, validation, and location construction read the four-element result tuple by index.

Solid nearest-match context

Layer / File(s)	Summary
Nearest-match tuple contract and consumers packages/solid-router/src/matchContext.tsx, packages/solid-router/src/Match.tsx, packages/solid-router/src/Matches.tsx, packages/solid-router/src/useMatch.tsx	The nearest-match context stores route ID and match accessors in a readonly tuple. Consumers read the tuple positions.

Server function request bodies

Layer / File(s)	Summary
Direct POST body handling packages/start-client-core/src/client-rpc/serverFnFetcher.ts	POST body construction returns FormData or serialized payloads directly. JSON content type assignment occurs when the body is a string.

Vue router rendering helpers

Layer / File(s)	Summary
Script rendering argument flow packages/vue-router/src/Scripts.tsx	Scripts passes script data, mount state, and nonce positionally to renderScripts.
Link helper signatures and call sites packages/vue-router/src/link.tsx	SSR and reactive link code uses positional arguments for href, active-state, and style helpers.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• TanStack/router#7805: Both PRs modify Solid router match-rendering code, including MatchInner and Outlet.
• TanStack/router#7966: Both PRs modify lightweight route-matching data in packages/router-core/src/router.ts.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the PR's primary optimization: compacting private bundle boundaries.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/compact-private-boundaries

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ba8e35b

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	5m 10s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	28s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-06 07:24:49 UTC

[github-actions]

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
@tanstack/react-router	1.170.20 → 1.170.21	Changeset
@tanstack/router-core	1.171.17 → 1.171.18	Changeset
@tanstack/solid-router	1.170.20 → 1.170.21	Changeset
@tanstack/start-server-core	1.169.20 → 1.169.21	Changeset
@tanstack/vue-router	1.170.19 → 1.170.20	Changeset
@tanstack/react-start	1.168.37 → 1.168.38	Dependent
@tanstack/react-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/react-start-rsc	0.1.36 → 0.1.37	Dependent
@tanstack/react-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/router-cli	1.167.23 → 1.167.24	Dependent
@tanstack/router-generator	1.167.23 → 1.167.24	Dependent
@tanstack/router-plugin	1.168.25 → 1.168.26	Dependent
@tanstack/router-vite-plugin	1.167.25 → 1.167.26	Dependent
@tanstack/solid-start	1.168.36 → 1.168.37	Dependent
@tanstack/solid-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/solid-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/start-client-core	1.170.16 → 1.170.17	Dependent
@tanstack/start-plugin-core	1.171.28 → 1.171.29	Dependent
@tanstack/start-static-server-functions	1.167.21 → 1.167.22	Dependent
@tanstack/start-storage-context	1.167.19 → 1.167.20	Dependent
@tanstack/vue-start	1.168.35 → 1.168.36	Dependent
@tanstack/vue-start-client	1.167.21 → 1.167.22	Dependent
@tanstack/vue-start-server	1.167.25 → 1.167.26	Dependent

[github-actions]

Bundle Size Benchmarks

• Commit: bfb30996c193
• Measured at: 2026-08-06T07:20:48.840Z
• Baseline source: history:697ebb6ddbd4
• Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
react-router.minimal	87.07 KiB	-38 B (-0.04%)	86.94 KiB	269.02 KiB	75.85 KiB	████▂▂▂▂▂▁▂▁
react-router.full	90.88 KiB	-21 B (-0.02%)	90.74 KiB	280.98 KiB	79.08 KiB	████▂▂▂▂▂▁▂▁
solid-router.minimal	34.77 KiB	-27 B (-0.08%)	34.65 KiB	99.80 KiB	31.41 KiB	████▂▂▂▂▂▁▁▁
solid-router.full	39.86 KiB	-41 B (-0.10%)	39.74 KiB	114.97 KiB	35.86 KiB	████▂▂▂▂▂▁▁▁
vue-router.minimal	52.03 KiB	-64 B (-0.12%)	51.90 KiB	142.85 KiB	46.87 KiB	████▂▂▂▂▂▁▁▁
vue-router.full	57.96 KiB	-88 B (-0.15%)	57.83 KiB	161.43 KiB	52.05 KiB	████▂▂▂▂▂▂▂▁
react-start.minimal	100.54 KiB	-60 B (-0.06%)	100.40 KiB	312.13 KiB	87.31 KiB	███████▁▁▁▁▁
react-start.deferred-hydration	101.26 KiB	-78 B (-0.08%)	100.41 KiB	313.50 KiB	87.99 KiB	███████▁▁▁▁▁
react-start.full	103.88 KiB	-45 B (-0.04%)	103.74 KiB	322.08 KiB	90.21 KiB	███████▁▁▁▁▁
react-start.rsbuild.minimal	100.16 KiB	-80 B (-0.08%)	99.99 KiB	316.63 KiB	86.39 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.minimal-iife	100.57 KiB	-77 B (-0.07%)	100.40 KiB	317.56 KiB	86.62 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.full	103.48 KiB	-86 B (-0.08%)	103.31 KiB	326.72 KiB	89.10 KiB	▁▁▁▁▃▃▃████▇
solid-start.minimal	48.13 KiB	-51 B (-0.10%)	48.00 KiB	141.89 KiB	42.77 KiB	███████▁▁▁▁▁
solid-start.deferred-hydration	51.40 KiB	-49 B (-0.09%)	48.06 KiB	149.93 KiB	45.75 KiB	███████▁▁▁▁▁
solid-start.full	53.38 KiB	-56 B (-0.10%)	53.25 KiB	157.61 KiB	47.35 KiB	████▆▆▆▁▁▁▁▁
vue-start.minimal	68.85 KiB	-125 B (-0.18%)	68.72 KiB	194.70 KiB	61.33 KiB	████▆▆▆▂▂▁▁▁
vue-start.full	72.82 KiB	-112 B (-0.15%)	72.69 KiB	207.21 KiB	64.71 KiB	████▆▆▆▂▂▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

[pkg-pr-new]

More templates

• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc
• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsbuild
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-example-rscs
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7975

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7975

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7975

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7975

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7975

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7975

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7975

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7975

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7975

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7975

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7975

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7975

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7975

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7975

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7975

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7975

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7975

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7975

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7975

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7975

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7975

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7975

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7975

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7975

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7975

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7975

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7975

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7975

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7975

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7975

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7975

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7975

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7975

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7975

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7975

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7975

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7975

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7975

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7975

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7975

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7975

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7975

commit: ba8e35b

[codspeed-hq]

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 4 (👁 4) regressed benchmarks
✅ 166 untouched benchmarks

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Memory	mem server server-fn-churn (vue)	4,147.3 KB	265.2 KB	×16
⚡	Memory	mem server error-paths unmatched (vue)	2,142.1 KB	479.6 KB	×4.5
⚡	Memory	mem server peak-large-page (react)	1,737.5 KB	952.1 KB	+82.48%
⚡	Memory	mem server error-paths redirect (solid)	388 KB	282.6 KB	+37.3%
⚡	Memory	mem server error-paths redirect (vue)	338.6 KB	295.8 KB	+14.48%
⚡	Memory	mem client navigation-churn (vue)	1.3 MB	1.2 MB	+4.6%
⚡	Simulation	client-head navigation loop (react)	76.2 ms	73.2 ms	+4.02%
⚡	Simulation	client-head navigation loop (vue)	94.3 ms	90.9 ms	+3.64%
⚡	Memory	mem server aborted-requests (solid)	930.4 KB	901 KB	+3.26%
⚡	Simulation	ssr control-flow unmatched 404 (react)	58.1 ms	56.4 ms	+3%
👁	Simulation	ssr request loop (solid)	156.5 ms	161.4 ms	-3.01%
👁	Memory	mem server error-paths not-found (solid)	415.1 KB	848.3 KB	-51.07%
👁	Memory	mem server peak-large-page (solid)	811.5 KB	842.2 KB	-3.64%
👁	Memory	mem client unique-location-churn (solid)	341.2 KB	564.6 KB	-39.57%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing codex/compact-private-boundaries (ba8e35b) with main (697ebb6)}

[coderabbitai]

🧹 Nitpick comments (1)

packages/vue-router/src/link.tsx (1)

628-641: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Preserve the search type in getIsActive.

Lines 631 and 636 use search: any. This removes type checking from the active-state comparison. Replace both inline location shapes with a shared ParsedLocation-derived or generic type that preserves the router search schema.

Proposed type-safe shape

+type LinkMatchLocation = Pick<+ ParsedLocation,+ 'pathname' | 'search' | 'hash'+>+
function getIsActive(
- loc: { pathname: string; search: any; hash: string },- nextLoc: { pathname: string; search: any; hash: string },+ loc: LinkMatchLocation,+ nextLoc: LinkMatchLocation,

Please confirm that the selected type remains assignable to router locations for all search schemas.

As per coding guidelines, TypeScript files must use strict mode with extensive type safety.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/vue-router/src/link.tsx` around lines 628 - 641, Update getIsActive
so both loc and nextLoc use a shared ParsedLocation-derived or generic location
type instead of inline search: any shapes, preserving the router’s search schema
and remaining assignable to router locations across all search schemas. Keep
pathname and hash typing intact while restoring strict type checking for search
comparisons.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/vue-router/src/link.tsx`:
- Around line 628-641: Update getIsActive so both loc and nextLoc use a shared
ParsedLocation-derived or generic location type instead of inline search: any
shapes, preserving the router’s search schema and remaining assignable to router
locations across all search schemas. Keep pathname and hash typing intact while
restoring strict type checking for search comparisons.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6aa90a02-72d0-4ef1-b441-9f732d08f0dd

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and ba8e35b.

📒 Files selected for processing (10)

• packages/history/src/index.ts
• packages/history/tests/createBrowserHistory.test.ts
• packages/router-core/src/router.ts
• packages/solid-router/src/Match.tsx
• packages/solid-router/src/Matches.tsx
• packages/solid-router/src/matchContext.tsx
• packages/solid-router/src/useMatch.tsx
• packages/start-client-core/src/client-rpc/serverFnFetcher.ts
• packages/vue-router/src/Scripts.tsx
• packages/vue-router/src/link.tsx

[Sheraff]

Summary

• compact closure-local history actions and router matching results
• flatten private Solid and Vue component/helper boundaries
• remove a one-use Start fetch-body wrapper without changing wire behavior

All public options, callbacks, component props, browser history state, and serialized HTTP formats remain unchanged.

Bundle size

Measured against main at 697ebb6ddbd433d052b6b4707938a5c595865d58:

• all 17 scenarios improve gzip by 21–125 B
• all 17 initial-load gzip measurements improve by 23–126 B
• all 17 raw measurements improve by 108–425 B
• Brotli ranges from -158 B to +52 B; 12 of 17 scenarios improve

The isolated measurements and full matrix are in RESULT-optimization-compact-private-boundaries.md.

Performance

The retained lightweight-match tuple was effectively flat in repeated buildLocation benchmarks: cached and uncached results stayed within 0.8% with benchmark error around 3%.

An additional LRU tuple experiment saved 9 B gzip but slowed eviction-heavy churn by roughly 24%, so it was rejected and is not part of this PR.

Validation

• history: 29 unit tests
• router-core: 1,523 passing unit tests plus 3 expected failures
• Solid Router: 841 passing client/server tests plus 1 skip
• Vue Router: 814 passing tests plus 1 skip
• Start client core: 80 passing tests
• type tests for all five affected packages and configured TypeScript versions
• ESLint for all five affected packages
• React Start E2E app build and 5 focused server-function Playwright tests
• complete 17-scenario bundle build
• five independent semantic, performance, lifecycle, tree-shaking, and adversarial reviews

Summary by CodeRabbit

• Bug Fixes

  • Improved browser history batching and flushing for more predictable navigation updates.
  • Preserved push navigation correctly when subsequent replace operations occur.
  • Improved handling of server-request payloads, including JSON and form submissions.

• Refactor

  • Streamlined route matching, match context, link handling, script rendering, and navigation internals without changing their intended behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR replaces selected internal object-shaped values and helper parameters with tuples or positional arguments. It updates browser history batching, route matching, Solid nearest-match context, server-function request bodies, Vue script rendering, and Vue link helpers. Browser history tests cover queue coalescing and flushing.

Changes

Browser history batching

Layer / File(s)	Summary
Queue representation and flush behavior packages/history/src/index.ts	Pending actions use tuples. Flush logic clears the queued action and preserves push semantics across updates.
Browser history batching tests packages/history/tests/createBrowserHistory.test.ts	Tests cover replace coalescing, action promotion, push preservation, and explicit flushing.

Lightweight route matching

Layer / File(s)	Summary
Lightweight match tuple flow packages/router-core/src/router.ts	Lightweight matching, validation, and location construction read the four-element result tuple by index.

Solid nearest-match context

Layer / File(s)	Summary
Nearest-match tuple contract and consumers packages/solid-router/src/matchContext.tsx, packages/solid-router/src/Match.tsx, packages/solid-router/src/Matches.tsx, packages/solid-router/src/useMatch.tsx	The nearest-match context stores route ID and match accessors in a readonly tuple. Consumers read the tuple positions.

Server function request bodies

Layer / File(s)	Summary
Direct POST body handling packages/start-client-core/src/client-rpc/serverFnFetcher.ts	POST body construction returns FormData or serialized payloads directly. JSON content type assignment occurs when the body is a string.

Vue router rendering helpers

Layer / File(s)	Summary
Script rendering argument flow packages/vue-router/src/Scripts.tsx	Scripts passes script data, mount state, and nonce positionally to renderScripts.
Link helper signatures and call sites packages/vue-router/src/link.tsx	SSR and reactive link code uses positional arguments for href, active-state, and style helpers.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• TanStack/router#7805: Both PRs modify Solid router match-rendering code, including MatchInner and Outlet.
• TanStack/router#7966: Both PRs modify lightweight route-matching data in packages/router-core/src/router.ts.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the PR's primary optimization: compacting private bundle boundaries.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/compact-private-boundaries

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ba8e35b

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	5m 10s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	28s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-06 07:24:49 UTC

[github-actions]

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
@tanstack/react-router	1.170.20 → 1.170.21	Changeset
@tanstack/router-core	1.171.17 → 1.171.18	Changeset
@tanstack/solid-router	1.170.20 → 1.170.21	Changeset
@tanstack/start-server-core	1.169.20 → 1.169.21	Changeset
@tanstack/vue-router	1.170.19 → 1.170.20	Changeset
@tanstack/react-start	1.168.37 → 1.168.38	Dependent
@tanstack/react-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/react-start-rsc	0.1.36 → 0.1.37	Dependent
@tanstack/react-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/router-cli	1.167.23 → 1.167.24	Dependent
@tanstack/router-generator	1.167.23 → 1.167.24	Dependent
@tanstack/router-plugin	1.168.25 → 1.168.26	Dependent
@tanstack/router-vite-plugin	1.167.25 → 1.167.26	Dependent
@tanstack/solid-start	1.168.36 → 1.168.37	Dependent
@tanstack/solid-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/solid-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/start-client-core	1.170.16 → 1.170.17	Dependent
@tanstack/start-plugin-core	1.171.28 → 1.171.29	Dependent
@tanstack/start-static-server-functions	1.167.21 → 1.167.22	Dependent
@tanstack/start-storage-context	1.167.19 → 1.167.20	Dependent
@tanstack/vue-start	1.168.35 → 1.168.36	Dependent
@tanstack/vue-start-client	1.167.21 → 1.167.22	Dependent
@tanstack/vue-start-server	1.167.25 → 1.167.26	Dependent

[github-actions]

Bundle Size Benchmarks

• Commit: bfb30996c193
• Measured at: 2026-08-06T07:20:48.840Z
• Baseline source: history:697ebb6ddbd4
• Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
react-router.minimal	87.07 KiB	-38 B (-0.04%)	86.94 KiB	269.02 KiB	75.85 KiB	████▂▂▂▂▂▁▂▁
react-router.full	90.88 KiB	-21 B (-0.02%)	90.74 KiB	280.98 KiB	79.08 KiB	████▂▂▂▂▂▁▂▁
solid-router.minimal	34.77 KiB	-27 B (-0.08%)	34.65 KiB	99.80 KiB	31.41 KiB	████▂▂▂▂▂▁▁▁
solid-router.full	39.86 KiB	-41 B (-0.10%)	39.74 KiB	114.97 KiB	35.86 KiB	████▂▂▂▂▂▁▁▁
vue-router.minimal	52.03 KiB	-64 B (-0.12%)	51.90 KiB	142.85 KiB	46.87 KiB	████▂▂▂▂▂▁▁▁
vue-router.full	57.96 KiB	-88 B (-0.15%)	57.83 KiB	161.43 KiB	52.05 KiB	████▂▂▂▂▂▂▂▁
react-start.minimal	100.54 KiB	-60 B (-0.06%)	100.40 KiB	312.13 KiB	87.31 KiB	███████▁▁▁▁▁
react-start.deferred-hydration	101.26 KiB	-78 B (-0.08%)	100.41 KiB	313.50 KiB	87.99 KiB	███████▁▁▁▁▁
react-start.full	103.88 KiB	-45 B (-0.04%)	103.74 KiB	322.08 KiB	90.21 KiB	███████▁▁▁▁▁
react-start.rsbuild.minimal	100.16 KiB	-80 B (-0.08%)	99.99 KiB	316.63 KiB	86.39 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.minimal-iife	100.57 KiB	-77 B (-0.07%)	100.40 KiB	317.56 KiB	86.62 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.full	103.48 KiB	-86 B (-0.08%)	103.31 KiB	326.72 KiB	89.10 KiB	▁▁▁▁▃▃▃████▇
solid-start.minimal	48.13 KiB	-51 B (-0.10%)	48.00 KiB	141.89 KiB	42.77 KiB	███████▁▁▁▁▁
solid-start.deferred-hydration	51.40 KiB	-49 B (-0.09%)	48.06 KiB	149.93 KiB	45.75 KiB	███████▁▁▁▁▁
solid-start.full	53.38 KiB	-56 B (-0.10%)	53.25 KiB	157.61 KiB	47.35 KiB	████▆▆▆▁▁▁▁▁
vue-start.minimal	68.85 KiB	-125 B (-0.18%)	68.72 KiB	194.70 KiB	61.33 KiB	████▆▆▆▂▂▁▁▁
vue-start.full	72.82 KiB	-112 B (-0.15%)	72.69 KiB	207.21 KiB	64.71 KiB	████▆▆▆▂▂▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

[pkg-pr-new]

More templates

• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc
• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsbuild
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-example-rscs
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7975

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7975

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7975

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7975

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7975

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7975

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7975

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7975

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7975

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7975

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7975

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7975

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7975

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7975

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7975

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7975

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7975

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7975

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7975

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7975

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7975

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7975

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7975

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7975

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7975

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7975

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7975

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7975

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7975

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7975

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7975

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7975

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7975

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7975

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7975

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7975

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7975

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7975

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7975

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7975

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7975

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7975

commit: ba8e35b

[codspeed-hq]

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 4 (👁 4) regressed benchmarks
✅ 166 untouched benchmarks

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Memory	mem server server-fn-churn (vue)	4,147.3 KB	265.2 KB	×16
⚡	Memory	mem server error-paths unmatched (vue)	2,142.1 KB	479.6 KB	×4.5
⚡	Memory	mem server peak-large-page (react)	1,737.5 KB	952.1 KB	+82.48%
⚡	Memory	mem server error-paths redirect (solid)	388 KB	282.6 KB	+37.3%
⚡	Memory	mem server error-paths redirect (vue)	338.6 KB	295.8 KB	+14.48%
⚡	Memory	mem client navigation-churn (vue)	1.3 MB	1.2 MB	+4.6%
⚡	Simulation	client-head navigation loop (react)	76.2 ms	73.2 ms	+4.02%
⚡	Simulation	client-head navigation loop (vue)	94.3 ms	90.9 ms	+3.64%
⚡	Memory	mem server aborted-requests (solid)	930.4 KB	901 KB	+3.26%
⚡	Simulation	ssr control-flow unmatched 404 (react)	58.1 ms	56.4 ms	+3%
👁	Simulation	ssr request loop (solid)	156.5 ms	161.4 ms	-3.01%
👁	Memory	mem server error-paths not-found (solid)	415.1 KB	848.3 KB	-51.07%
👁	Memory	mem server peak-large-page (solid)	811.5 KB	842.2 KB	-3.64%
👁	Memory	mem client unique-location-churn (solid)	341.2 KB	564.6 KB	-39.57%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing codex/compact-private-boundaries (ba8e35b) with main (697ebb6)}

[coderabbitai]

🧹 Nitpick comments (1)

packages/vue-router/src/link.tsx (1)

628-641: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Preserve the search type in getIsActive.

Lines 631 and 636 use search: any. This removes type checking from the active-state comparison. Replace both inline location shapes with a shared ParsedLocation-derived or generic type that preserves the router search schema.

Proposed type-safe shape

+type LinkMatchLocation = Pick<+ ParsedLocation,+ 'pathname' | 'search' | 'hash'+>+
function getIsActive(
- loc: { pathname: string; search: any; hash: string },- nextLoc: { pathname: string; search: any; hash: string },+ loc: LinkMatchLocation,+ nextLoc: LinkMatchLocation,

Please confirm that the selected type remains assignable to router locations for all search schemas.

As per coding guidelines, TypeScript files must use strict mode with extensive type safety.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/vue-router/src/link.tsx` around lines 628 - 641, Update getIsActive
so both loc and nextLoc use a shared ParsedLocation-derived or generic location
type instead of inline search: any shapes, preserving the router’s search schema
and remaining assignable to router locations across all search schemas. Keep
pathname and hash typing intact while restoring strict type checking for search
comparisons.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/vue-router/src/link.tsx`:
- Around line 628-641: Update getIsActive so both loc and nextLoc use a shared
ParsedLocation-derived or generic location type instead of inline search: any
shapes, preserving the router’s search schema and remaining assignable to router
locations across all search schemas. Keep pathname and hash typing intact while
restoring strict type checking for search comparisons.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6aa90a02-72d0-4ef1-b441-9f732d08f0dd

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and ba8e35b.

📒 Files selected for processing (10)

• packages/history/src/index.ts
• packages/history/tests/createBrowserHistory.test.ts
• packages/router-core/src/router.ts
• packages/solid-router/src/Match.tsx
• packages/solid-router/src/Matches.tsx
• packages/solid-router/src/matchContext.tsx
• packages/solid-router/src/useMatch.tsx
• packages/start-client-core/src/client-rpc/serverFnFetcher.ts
• packages/vue-router/src/Scripts.tsx
• packages/vue-router/src/link.tsx

[Sheraff]

Summary

• compact closure-local history actions and router matching results
• flatten private Solid and Vue component/helper boundaries
• remove a one-use Start fetch-body wrapper without changing wire behavior

All public options, callbacks, component props, browser history state, and serialized HTTP formats remain unchanged.

Bundle size

Measured against main at 697ebb6ddbd433d052b6b4707938a5c595865d58:

• all 17 scenarios improve gzip by 21–125 B
• all 17 initial-load gzip measurements improve by 23–126 B
• all 17 raw measurements improve by 108–425 B
• Brotli ranges from -158 B to +52 B; 12 of 17 scenarios improve

The isolated measurements and full matrix are in RESULT-optimization-compact-private-boundaries.md.

Performance

The retained lightweight-match tuple was effectively flat in repeated buildLocation benchmarks: cached and uncached results stayed within 0.8% with benchmark error around 3%.

An additional LRU tuple experiment saved 9 B gzip but slowed eviction-heavy churn by roughly 24%, so it was rejected and is not part of this PR.

Validation

• history: 29 unit tests
• router-core: 1,523 passing unit tests plus 3 expected failures
• Solid Router: 841 passing client/server tests plus 1 skip
• Vue Router: 814 passing tests plus 1 skip
• Start client core: 80 passing tests
• type tests for all five affected packages and configured TypeScript versions
• ESLint for all five affected packages
• React Start E2E app build and 5 focused server-function Playwright tests
• complete 17-scenario bundle build
• five independent semantic, performance, lifecycle, tree-shaking, and adversarial reviews

Summary by CodeRabbit

• Bug Fixes

  • Improved browser history batching and flushing for more predictable navigation updates.
  • Preserved push navigation correctly when subsequent replace operations occur.
  • Improved handling of server-request payloads, including JSON and form submissions.

• Refactor

  • Streamlined route matching, match context, link handling, script rendering, and navigation internals without changing their intended behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR replaces selected internal object-shaped values and helper parameters with tuples or positional arguments. It updates browser history batching, route matching, Solid nearest-match context, server-function request bodies, Vue script rendering, and Vue link helpers. Browser history tests cover queue coalescing and flushing.

Changes

Browser history batching

Layer / File(s)	Summary
Queue representation and flush behavior packages/history/src/index.ts	Pending actions use tuples. Flush logic clears the queued action and preserves push semantics across updates.
Browser history batching tests packages/history/tests/createBrowserHistory.test.ts	Tests cover replace coalescing, action promotion, push preservation, and explicit flushing.

Lightweight route matching

Layer / File(s)	Summary
Lightweight match tuple flow packages/router-core/src/router.ts	Lightweight matching, validation, and location construction read the four-element result tuple by index.

Solid nearest-match context

Layer / File(s)	Summary
Nearest-match tuple contract and consumers packages/solid-router/src/matchContext.tsx, packages/solid-router/src/Match.tsx, packages/solid-router/src/Matches.tsx, packages/solid-router/src/useMatch.tsx	The nearest-match context stores route ID and match accessors in a readonly tuple. Consumers read the tuple positions.

Server function request bodies

Layer / File(s)	Summary
Direct POST body handling packages/start-client-core/src/client-rpc/serverFnFetcher.ts	POST body construction returns FormData or serialized payloads directly. JSON content type assignment occurs when the body is a string.

Vue router rendering helpers

Layer / File(s)	Summary
Script rendering argument flow packages/vue-router/src/Scripts.tsx	Scripts passes script data, mount state, and nonce positionally to renderScripts.
Link helper signatures and call sites packages/vue-router/src/link.tsx	SSR and reactive link code uses positional arguments for href, active-state, and style helpers.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• TanStack/router#7805: Both PRs modify Solid router match-rendering code, including MatchInner and Outlet.
• TanStack/router#7966: Both PRs modify lightweight route-matching data in packages/router-core/src/router.ts.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the PR's primary optimization: compacting private bundle boundaries.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/compact-private-boundaries

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ba8e35b

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	5m 10s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	28s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-06 07:24:49 UTC

[github-actions]

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
@tanstack/react-router	1.170.20 → 1.170.21	Changeset
@tanstack/router-core	1.171.17 → 1.171.18	Changeset
@tanstack/solid-router	1.170.20 → 1.170.21	Changeset
@tanstack/start-server-core	1.169.20 → 1.169.21	Changeset
@tanstack/vue-router	1.170.19 → 1.170.20	Changeset
@tanstack/react-start	1.168.37 → 1.168.38	Dependent
@tanstack/react-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/react-start-rsc	0.1.36 → 0.1.37	Dependent
@tanstack/react-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/router-cli	1.167.23 → 1.167.24	Dependent
@tanstack/router-generator	1.167.23 → 1.167.24	Dependent
@tanstack/router-plugin	1.168.25 → 1.168.26	Dependent
@tanstack/router-vite-plugin	1.167.25 → 1.167.26	Dependent
@tanstack/solid-start	1.168.36 → 1.168.37	Dependent
@tanstack/solid-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/solid-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/start-client-core	1.170.16 → 1.170.17	Dependent
@tanstack/start-plugin-core	1.171.28 → 1.171.29	Dependent
@tanstack/start-static-server-functions	1.167.21 → 1.167.22	Dependent
@tanstack/start-storage-context	1.167.19 → 1.167.20	Dependent
@tanstack/vue-start	1.168.35 → 1.168.36	Dependent
@tanstack/vue-start-client	1.167.21 → 1.167.22	Dependent
@tanstack/vue-start-server	1.167.25 → 1.167.26	Dependent

[github-actions]

Bundle Size Benchmarks

• Commit: bfb30996c193
• Measured at: 2026-08-06T07:20:48.840Z
• Baseline source: history:697ebb6ddbd4
• Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
react-router.minimal	87.07 KiB	-38 B (-0.04%)	86.94 KiB	269.02 KiB	75.85 KiB	████▂▂▂▂▂▁▂▁
react-router.full	90.88 KiB	-21 B (-0.02%)	90.74 KiB	280.98 KiB	79.08 KiB	████▂▂▂▂▂▁▂▁
solid-router.minimal	34.77 KiB	-27 B (-0.08%)	34.65 KiB	99.80 KiB	31.41 KiB	████▂▂▂▂▂▁▁▁
solid-router.full	39.86 KiB	-41 B (-0.10%)	39.74 KiB	114.97 KiB	35.86 KiB	████▂▂▂▂▂▁▁▁
vue-router.minimal	52.03 KiB	-64 B (-0.12%)	51.90 KiB	142.85 KiB	46.87 KiB	████▂▂▂▂▂▁▁▁
vue-router.full	57.96 KiB	-88 B (-0.15%)	57.83 KiB	161.43 KiB	52.05 KiB	████▂▂▂▂▂▂▂▁
react-start.minimal	100.54 KiB	-60 B (-0.06%)	100.40 KiB	312.13 KiB	87.31 KiB	███████▁▁▁▁▁
react-start.deferred-hydration	101.26 KiB	-78 B (-0.08%)	100.41 KiB	313.50 KiB	87.99 KiB	███████▁▁▁▁▁
react-start.full	103.88 KiB	-45 B (-0.04%)	103.74 KiB	322.08 KiB	90.21 KiB	███████▁▁▁▁▁
react-start.rsbuild.minimal	100.16 KiB	-80 B (-0.08%)	99.99 KiB	316.63 KiB	86.39 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.minimal-iife	100.57 KiB	-77 B (-0.07%)	100.40 KiB	317.56 KiB	86.62 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.full	103.48 KiB	-86 B (-0.08%)	103.31 KiB	326.72 KiB	89.10 KiB	▁▁▁▁▃▃▃████▇
solid-start.minimal	48.13 KiB	-51 B (-0.10%)	48.00 KiB	141.89 KiB	42.77 KiB	███████▁▁▁▁▁
solid-start.deferred-hydration	51.40 KiB	-49 B (-0.09%)	48.06 KiB	149.93 KiB	45.75 KiB	███████▁▁▁▁▁
solid-start.full	53.38 KiB	-56 B (-0.10%)	53.25 KiB	157.61 KiB	47.35 KiB	████▆▆▆▁▁▁▁▁
vue-start.minimal	68.85 KiB	-125 B (-0.18%)	68.72 KiB	194.70 KiB	61.33 KiB	████▆▆▆▂▂▁▁▁
vue-start.full	72.82 KiB	-112 B (-0.15%)	72.69 KiB	207.21 KiB	64.71 KiB	████▆▆▆▂▂▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

[pkg-pr-new]

More templates

• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc
• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsbuild
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-example-rscs
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7975

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7975

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7975

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7975

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7975

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7975

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7975

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7975

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7975

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7975

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7975

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7975

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7975

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7975

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7975

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7975

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7975

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7975

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7975

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7975

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7975

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7975

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7975

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7975

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7975

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7975

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7975

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7975

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7975

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7975

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7975

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7975

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7975

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7975

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7975

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7975

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7975

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7975

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7975

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7975

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7975

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7975

commit: ba8e35b

[codspeed-hq]

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 4 (👁 4) regressed benchmarks
✅ 166 untouched benchmarks

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Memory	mem server server-fn-churn (vue)	4,147.3 KB	265.2 KB	×16
⚡	Memory	mem server error-paths unmatched (vue)	2,142.1 KB	479.6 KB	×4.5
⚡	Memory	mem server peak-large-page (react)	1,737.5 KB	952.1 KB	+82.48%
⚡	Memory	mem server error-paths redirect (solid)	388 KB	282.6 KB	+37.3%
⚡	Memory	mem server error-paths redirect (vue)	338.6 KB	295.8 KB	+14.48%
⚡	Memory	mem client navigation-churn (vue)	1.3 MB	1.2 MB	+4.6%
⚡	Simulation	client-head navigation loop (react)	76.2 ms	73.2 ms	+4.02%
⚡	Simulation	client-head navigation loop (vue)	94.3 ms	90.9 ms	+3.64%
⚡	Memory	mem server aborted-requests (solid)	930.4 KB	901 KB	+3.26%
⚡	Simulation	ssr control-flow unmatched 404 (react)	58.1 ms	56.4 ms	+3%
👁	Simulation	ssr request loop (solid)	156.5 ms	161.4 ms	-3.01%
👁	Memory	mem server error-paths not-found (solid)	415.1 KB	848.3 KB	-51.07%
👁	Memory	mem server peak-large-page (solid)	811.5 KB	842.2 KB	-3.64%
👁	Memory	mem client unique-location-churn (solid)	341.2 KB	564.6 KB	-39.57%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing codex/compact-private-boundaries (ba8e35b) with main (697ebb6)}

[coderabbitai]

🧹 Nitpick comments (1)

packages/vue-router/src/link.tsx (1)

628-641: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Preserve the search type in getIsActive.

Lines 631 and 636 use search: any. This removes type checking from the active-state comparison. Replace both inline location shapes with a shared ParsedLocation-derived or generic type that preserves the router search schema.

Proposed type-safe shape

+type LinkMatchLocation = Pick<+ ParsedLocation,+ 'pathname' | 'search' | 'hash'+>+
function getIsActive(
- loc: { pathname: string; search: any; hash: string },- nextLoc: { pathname: string; search: any; hash: string },+ loc: LinkMatchLocation,+ nextLoc: LinkMatchLocation,

Please confirm that the selected type remains assignable to router locations for all search schemas.

As per coding guidelines, TypeScript files must use strict mode with extensive type safety.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/vue-router/src/link.tsx` around lines 628 - 641, Update getIsActive
so both loc and nextLoc use a shared ParsedLocation-derived or generic location
type instead of inline search: any shapes, preserving the router’s search schema
and remaining assignable to router locations across all search schemas. Keep
pathname and hash typing intact while restoring strict type checking for search
comparisons.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/vue-router/src/link.tsx`:
- Around line 628-641: Update getIsActive so both loc and nextLoc use a shared
ParsedLocation-derived or generic location type instead of inline search: any
shapes, preserving the router’s search schema and remaining assignable to router
locations across all search schemas. Keep pathname and hash typing intact while
restoring strict type checking for search comparisons.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6aa90a02-72d0-4ef1-b441-9f732d08f0dd

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and ba8e35b.

📒 Files selected for processing (10)

• packages/history/src/index.ts
• packages/history/tests/createBrowserHistory.test.ts
• packages/router-core/src/router.ts
• packages/solid-router/src/Match.tsx
• packages/solid-router/src/Matches.tsx
• packages/solid-router/src/matchContext.tsx
• packages/solid-router/src/useMatch.tsx
• packages/start-client-core/src/client-rpc/serverFnFetcher.ts
• packages/vue-router/src/Scripts.tsx
• packages/vue-router/src/link.tsx

[Sheraff]

Summary

• compact closure-local history actions and router matching results
• flatten private Solid and Vue component/helper boundaries
• remove a one-use Start fetch-body wrapper without changing wire behavior

All public options, callbacks, component props, browser history state, and serialized HTTP formats remain unchanged.

Bundle size

Measured against main at 697ebb6ddbd433d052b6b4707938a5c595865d58:

• all 17 scenarios improve gzip by 21–125 B
• all 17 initial-load gzip measurements improve by 23–126 B
• all 17 raw measurements improve by 108–425 B
• Brotli ranges from -158 B to +52 B; 12 of 17 scenarios improve

The isolated measurements and full matrix are in RESULT-optimization-compact-private-boundaries.md.

Performance

The retained lightweight-match tuple was effectively flat in repeated buildLocation benchmarks: cached and uncached results stayed within 0.8% with benchmark error around 3%.

An additional LRU tuple experiment saved 9 B gzip but slowed eviction-heavy churn by roughly 24%, so it was rejected and is not part of this PR.

Validation

• history: 29 unit tests
• router-core: 1,523 passing unit tests plus 3 expected failures
• Solid Router: 841 passing client/server tests plus 1 skip
• Vue Router: 814 passing tests plus 1 skip
• Start client core: 80 passing tests
• type tests for all five affected packages and configured TypeScript versions
• ESLint for all five affected packages
• React Start E2E app build and 5 focused server-function Playwright tests
• complete 17-scenario bundle build
• five independent semantic, performance, lifecycle, tree-shaking, and adversarial reviews

Summary by CodeRabbit

• Bug Fixes

  • Improved browser history batching and flushing for more predictable navigation updates.
  • Preserved push navigation correctly when subsequent replace operations occur.
  • Improved handling of server-request payloads, including JSON and form submissions.

• Refactor

  • Streamlined route matching, match context, link handling, script rendering, and navigation internals without changing their intended behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR replaces selected internal object-shaped values and helper parameters with tuples or positional arguments. It updates browser history batching, route matching, Solid nearest-match context, server-function request bodies, Vue script rendering, and Vue link helpers. Browser history tests cover queue coalescing and flushing.

Changes

Browser history batching

Layer / File(s)	Summary
Queue representation and flush behavior packages/history/src/index.ts	Pending actions use tuples. Flush logic clears the queued action and preserves push semantics across updates.
Browser history batching tests packages/history/tests/createBrowserHistory.test.ts	Tests cover replace coalescing, action promotion, push preservation, and explicit flushing.

Lightweight route matching

Layer / File(s)	Summary
Lightweight match tuple flow packages/router-core/src/router.ts	Lightweight matching, validation, and location construction read the four-element result tuple by index.

Solid nearest-match context

Layer / File(s)	Summary
Nearest-match tuple contract and consumers packages/solid-router/src/matchContext.tsx, packages/solid-router/src/Match.tsx, packages/solid-router/src/Matches.tsx, packages/solid-router/src/useMatch.tsx	The nearest-match context stores route ID and match accessors in a readonly tuple. Consumers read the tuple positions.

Server function request bodies

Layer / File(s)	Summary
Direct POST body handling packages/start-client-core/src/client-rpc/serverFnFetcher.ts	POST body construction returns FormData or serialized payloads directly. JSON content type assignment occurs when the body is a string.

Vue router rendering helpers

Layer / File(s)	Summary
Script rendering argument flow packages/vue-router/src/Scripts.tsx	Scripts passes script data, mount state, and nonce positionally to renderScripts.
Link helper signatures and call sites packages/vue-router/src/link.tsx	SSR and reactive link code uses positional arguments for href, active-state, and style helpers.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• TanStack/router#7805: Both PRs modify Solid router match-rendering code, including MatchInner and Outlet.
• TanStack/router#7966: Both PRs modify lightweight route-matching data in packages/router-core/src/router.ts.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the PR's primary optimization: compacting private bundle boundaries.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/compact-private-boundaries

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ba8e35b

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	5m 10s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	28s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-06 07:24:49 UTC

[github-actions]

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
@tanstack/react-router	1.170.20 → 1.170.21	Changeset
@tanstack/router-core	1.171.17 → 1.171.18	Changeset
@tanstack/solid-router	1.170.20 → 1.170.21	Changeset
@tanstack/start-server-core	1.169.20 → 1.169.21	Changeset
@tanstack/vue-router	1.170.19 → 1.170.20	Changeset
@tanstack/react-start	1.168.37 → 1.168.38	Dependent
@tanstack/react-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/react-start-rsc	0.1.36 → 0.1.37	Dependent
@tanstack/react-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/router-cli	1.167.23 → 1.167.24	Dependent
@tanstack/router-generator	1.167.23 → 1.167.24	Dependent
@tanstack/router-plugin	1.168.25 → 1.168.26	Dependent
@tanstack/router-vite-plugin	1.167.25 → 1.167.26	Dependent
@tanstack/solid-start	1.168.36 → 1.168.37	Dependent
@tanstack/solid-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/solid-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/start-client-core	1.170.16 → 1.170.17	Dependent
@tanstack/start-plugin-core	1.171.28 → 1.171.29	Dependent
@tanstack/start-static-server-functions	1.167.21 → 1.167.22	Dependent
@tanstack/start-storage-context	1.167.19 → 1.167.20	Dependent
@tanstack/vue-start	1.168.35 → 1.168.36	Dependent
@tanstack/vue-start-client	1.167.21 → 1.167.22	Dependent
@tanstack/vue-start-server	1.167.25 → 1.167.26	Dependent

[github-actions]

Bundle Size Benchmarks

• Commit: bfb30996c193
• Measured at: 2026-08-06T07:20:48.840Z
• Baseline source: history:697ebb6ddbd4
• Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
react-router.minimal	87.07 KiB	-38 B (-0.04%)	86.94 KiB	269.02 KiB	75.85 KiB	████▂▂▂▂▂▁▂▁
react-router.full	90.88 KiB	-21 B (-0.02%)	90.74 KiB	280.98 KiB	79.08 KiB	████▂▂▂▂▂▁▂▁
solid-router.minimal	34.77 KiB	-27 B (-0.08%)	34.65 KiB	99.80 KiB	31.41 KiB	████▂▂▂▂▂▁▁▁
solid-router.full	39.86 KiB	-41 B (-0.10%)	39.74 KiB	114.97 KiB	35.86 KiB	████▂▂▂▂▂▁▁▁
vue-router.minimal	52.03 KiB	-64 B (-0.12%)	51.90 KiB	142.85 KiB	46.87 KiB	████▂▂▂▂▂▁▁▁
vue-router.full	57.96 KiB	-88 B (-0.15%)	57.83 KiB	161.43 KiB	52.05 KiB	████▂▂▂▂▂▂▂▁
react-start.minimal	100.54 KiB	-60 B (-0.06%)	100.40 KiB	312.13 KiB	87.31 KiB	███████▁▁▁▁▁
react-start.deferred-hydration	101.26 KiB	-78 B (-0.08%)	100.41 KiB	313.50 KiB	87.99 KiB	███████▁▁▁▁▁
react-start.full	103.88 KiB	-45 B (-0.04%)	103.74 KiB	322.08 KiB	90.21 KiB	███████▁▁▁▁▁
react-start.rsbuild.minimal	100.16 KiB	-80 B (-0.08%)	99.99 KiB	316.63 KiB	86.39 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.minimal-iife	100.57 KiB	-77 B (-0.07%)	100.40 KiB	317.56 KiB	86.62 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.full	103.48 KiB	-86 B (-0.08%)	103.31 KiB	326.72 KiB	89.10 KiB	▁▁▁▁▃▃▃████▇
solid-start.minimal	48.13 KiB	-51 B (-0.10%)	48.00 KiB	141.89 KiB	42.77 KiB	███████▁▁▁▁▁
solid-start.deferred-hydration	51.40 KiB	-49 B (-0.09%)	48.06 KiB	149.93 KiB	45.75 KiB	███████▁▁▁▁▁
solid-start.full	53.38 KiB	-56 B (-0.10%)	53.25 KiB	157.61 KiB	47.35 KiB	████▆▆▆▁▁▁▁▁
vue-start.minimal	68.85 KiB	-125 B (-0.18%)	68.72 KiB	194.70 KiB	61.33 KiB	████▆▆▆▂▂▁▁▁
vue-start.full	72.82 KiB	-112 B (-0.15%)	72.69 KiB	207.21 KiB	64.71 KiB	████▆▆▆▂▂▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

[pkg-pr-new]

More templates

• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc
• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsbuild
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-example-rscs
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7975

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7975

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7975

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7975

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7975

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7975

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7975

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7975

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7975

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7975

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7975

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7975

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7975

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7975

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7975

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7975

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7975

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7975

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7975

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7975

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7975

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7975

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7975

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7975

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7975

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7975

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7975

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7975

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7975

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7975

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7975

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7975

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7975

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7975

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7975

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7975

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7975

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7975

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7975

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7975

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7975

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7975

commit: ba8e35b

[codspeed-hq]

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 4 (👁 4) regressed benchmarks
✅ 166 untouched benchmarks

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Memory	mem server server-fn-churn (vue)	4,147.3 KB	265.2 KB	×16
⚡	Memory	mem server error-paths unmatched (vue)	2,142.1 KB	479.6 KB	×4.5
⚡	Memory	mem server peak-large-page (react)	1,737.5 KB	952.1 KB	+82.48%
⚡	Memory	mem server error-paths redirect (solid)	388 KB	282.6 KB	+37.3%
⚡	Memory	mem server error-paths redirect (vue)	338.6 KB	295.8 KB	+14.48%
⚡	Memory	mem client navigation-churn (vue)	1.3 MB	1.2 MB	+4.6%
⚡	Simulation	client-head navigation loop (react)	76.2 ms	73.2 ms	+4.02%
⚡	Simulation	client-head navigation loop (vue)	94.3 ms	90.9 ms	+3.64%
⚡	Memory	mem server aborted-requests (solid)	930.4 KB	901 KB	+3.26%
⚡	Simulation	ssr control-flow unmatched 404 (react)	58.1 ms	56.4 ms	+3%
👁	Simulation	ssr request loop (solid)	156.5 ms	161.4 ms	-3.01%
👁	Memory	mem server error-paths not-found (solid)	415.1 KB	848.3 KB	-51.07%
👁	Memory	mem server peak-large-page (solid)	811.5 KB	842.2 KB	-3.64%
👁	Memory	mem client unique-location-churn (solid)	341.2 KB	564.6 KB	-39.57%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing codex/compact-private-boundaries (ba8e35b) with main (697ebb6)}

[coderabbitai]

🧹 Nitpick comments (1)

packages/vue-router/src/link.tsx (1)

628-641: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Preserve the search type in getIsActive.

Lines 631 and 636 use search: any. This removes type checking from the active-state comparison. Replace both inline location shapes with a shared ParsedLocation-derived or generic type that preserves the router search schema.

Proposed type-safe shape

+type LinkMatchLocation = Pick<+ ParsedLocation,+ 'pathname' | 'search' | 'hash'+>+
function getIsActive(
- loc: { pathname: string; search: any; hash: string },- nextLoc: { pathname: string; search: any; hash: string },+ loc: LinkMatchLocation,+ nextLoc: LinkMatchLocation,

Please confirm that the selected type remains assignable to router locations for all search schemas.

As per coding guidelines, TypeScript files must use strict mode with extensive type safety.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/vue-router/src/link.tsx` around lines 628 - 641, Update getIsActive
so both loc and nextLoc use a shared ParsedLocation-derived or generic location
type instead of inline search: any shapes, preserving the router’s search schema
and remaining assignable to router locations across all search schemas. Keep
pathname and hash typing intact while restoring strict type checking for search
comparisons.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/vue-router/src/link.tsx`:
- Around line 628-641: Update getIsActive so both loc and nextLoc use a shared
ParsedLocation-derived or generic location type instead of inline search: any
shapes, preserving the router’s search schema and remaining assignable to router
locations across all search schemas. Keep pathname and hash typing intact while
restoring strict type checking for search comparisons.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6aa90a02-72d0-4ef1-b441-9f732d08f0dd

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and ba8e35b.

📒 Files selected for processing (10)

• packages/history/src/index.ts
• packages/history/tests/createBrowserHistory.test.ts
• packages/router-core/src/router.ts
• packages/solid-router/src/Match.tsx
• packages/solid-router/src/Matches.tsx
• packages/solid-router/src/matchContext.tsx
• packages/solid-router/src/useMatch.tsx
• packages/start-client-core/src/client-rpc/serverFnFetcher.ts
• packages/vue-router/src/Scripts.tsx
• packages/vue-router/src/link.tsx

[Sheraff]

Summary

• compact closure-local history actions and router matching results
• flatten private Solid and Vue component/helper boundaries
• remove a one-use Start fetch-body wrapper without changing wire behavior

All public options, callbacks, component props, browser history state, and serialized HTTP formats remain unchanged.

Bundle size

Measured against main at 697ebb6ddbd433d052b6b4707938a5c595865d58:

• all 17 scenarios improve gzip by 21–125 B
• all 17 initial-load gzip measurements improve by 23–126 B
• all 17 raw measurements improve by 108–425 B
• Brotli ranges from -158 B to +52 B; 12 of 17 scenarios improve

The isolated measurements and full matrix are in RESULT-optimization-compact-private-boundaries.md.

Performance

The retained lightweight-match tuple was effectively flat in repeated buildLocation benchmarks: cached and uncached results stayed within 0.8% with benchmark error around 3%.

An additional LRU tuple experiment saved 9 B gzip but slowed eviction-heavy churn by roughly 24%, so it was rejected and is not part of this PR.

Validation

• history: 29 unit tests
• router-core: 1,523 passing unit tests plus 3 expected failures
• Solid Router: 841 passing client/server tests plus 1 skip
• Vue Router: 814 passing tests plus 1 skip
• Start client core: 80 passing tests
• type tests for all five affected packages and configured TypeScript versions
• ESLint for all five affected packages
• React Start E2E app build and 5 focused server-function Playwright tests
• complete 17-scenario bundle build
• five independent semantic, performance, lifecycle, tree-shaking, and adversarial reviews

Summary by CodeRabbit

• Bug Fixes

  • Improved browser history batching and flushing for more predictable navigation updates.
  • Preserved push navigation correctly when subsequent replace operations occur.
  • Improved handling of server-request payloads, including JSON and form submissions.

• Refactor

  • Streamlined route matching, match context, link handling, script rendering, and navigation internals without changing their intended behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR replaces selected internal object-shaped values and helper parameters with tuples or positional arguments. It updates browser history batching, route matching, Solid nearest-match context, server-function request bodies, Vue script rendering, and Vue link helpers. Browser history tests cover queue coalescing and flushing.

Changes

Browser history batching

Layer / File(s)	Summary
Queue representation and flush behavior packages/history/src/index.ts	Pending actions use tuples. Flush logic clears the queued action and preserves push semantics across updates.
Browser history batching tests packages/history/tests/createBrowserHistory.test.ts	Tests cover replace coalescing, action promotion, push preservation, and explicit flushing.

Lightweight route matching

Layer / File(s)	Summary
Lightweight match tuple flow packages/router-core/src/router.ts	Lightweight matching, validation, and location construction read the four-element result tuple by index.

Solid nearest-match context

Layer / File(s)	Summary
Nearest-match tuple contract and consumers packages/solid-router/src/matchContext.tsx, packages/solid-router/src/Match.tsx, packages/solid-router/src/Matches.tsx, packages/solid-router/src/useMatch.tsx	The nearest-match context stores route ID and match accessors in a readonly tuple. Consumers read the tuple positions.

Server function request bodies

Layer / File(s)	Summary
Direct POST body handling packages/start-client-core/src/client-rpc/serverFnFetcher.ts	POST body construction returns FormData or serialized payloads directly. JSON content type assignment occurs when the body is a string.

Vue router rendering helpers

Layer / File(s)	Summary
Script rendering argument flow packages/vue-router/src/Scripts.tsx	Scripts passes script data, mount state, and nonce positionally to renderScripts.
Link helper signatures and call sites packages/vue-router/src/link.tsx	SSR and reactive link code uses positional arguments for href, active-state, and style helpers.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• TanStack/router#7805: Both PRs modify Solid router match-rendering code, including MatchInner and Outlet.
• TanStack/router#7966: Both PRs modify lightweight route-matching data in packages/router-core/src/router.ts.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the PR's primary optimization: compacting private bundle boundaries.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/compact-private-boundaries

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ba8e35b

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	5m 10s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	28s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-06 07:24:49 UTC

[github-actions]

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
@tanstack/react-router	1.170.20 → 1.170.21	Changeset
@tanstack/router-core	1.171.17 → 1.171.18	Changeset
@tanstack/solid-router	1.170.20 → 1.170.21	Changeset
@tanstack/start-server-core	1.169.20 → 1.169.21	Changeset
@tanstack/vue-router	1.170.19 → 1.170.20	Changeset
@tanstack/react-start	1.168.37 → 1.168.38	Dependent
@tanstack/react-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/react-start-rsc	0.1.36 → 0.1.37	Dependent
@tanstack/react-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/router-cli	1.167.23 → 1.167.24	Dependent
@tanstack/router-generator	1.167.23 → 1.167.24	Dependent
@tanstack/router-plugin	1.168.25 → 1.168.26	Dependent
@tanstack/router-vite-plugin	1.167.25 → 1.167.26	Dependent
@tanstack/solid-start	1.168.36 → 1.168.37	Dependent
@tanstack/solid-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/solid-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/start-client-core	1.170.16 → 1.170.17	Dependent
@tanstack/start-plugin-core	1.171.28 → 1.171.29	Dependent
@tanstack/start-static-server-functions	1.167.21 → 1.167.22	Dependent
@tanstack/start-storage-context	1.167.19 → 1.167.20	Dependent
@tanstack/vue-start	1.168.35 → 1.168.36	Dependent
@tanstack/vue-start-client	1.167.21 → 1.167.22	Dependent
@tanstack/vue-start-server	1.167.25 → 1.167.26	Dependent

[github-actions]

Bundle Size Benchmarks

• Commit: bfb30996c193
• Measured at: 2026-08-06T07:20:48.840Z
• Baseline source: history:697ebb6ddbd4
• Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
react-router.minimal	87.07 KiB	-38 B (-0.04%)	86.94 KiB	269.02 KiB	75.85 KiB	████▂▂▂▂▂▁▂▁
react-router.full	90.88 KiB	-21 B (-0.02%)	90.74 KiB	280.98 KiB	79.08 KiB	████▂▂▂▂▂▁▂▁
solid-router.minimal	34.77 KiB	-27 B (-0.08%)	34.65 KiB	99.80 KiB	31.41 KiB	████▂▂▂▂▂▁▁▁
solid-router.full	39.86 KiB	-41 B (-0.10%)	39.74 KiB	114.97 KiB	35.86 KiB	████▂▂▂▂▂▁▁▁
vue-router.minimal	52.03 KiB	-64 B (-0.12%)	51.90 KiB	142.85 KiB	46.87 KiB	████▂▂▂▂▂▁▁▁
vue-router.full	57.96 KiB	-88 B (-0.15%)	57.83 KiB	161.43 KiB	52.05 KiB	████▂▂▂▂▂▂▂▁
react-start.minimal	100.54 KiB	-60 B (-0.06%)	100.40 KiB	312.13 KiB	87.31 KiB	███████▁▁▁▁▁
react-start.deferred-hydration	101.26 KiB	-78 B (-0.08%)	100.41 KiB	313.50 KiB	87.99 KiB	███████▁▁▁▁▁
react-start.full	103.88 KiB	-45 B (-0.04%)	103.74 KiB	322.08 KiB	90.21 KiB	███████▁▁▁▁▁
react-start.rsbuild.minimal	100.16 KiB	-80 B (-0.08%)	99.99 KiB	316.63 KiB	86.39 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.minimal-iife	100.57 KiB	-77 B (-0.07%)	100.40 KiB	317.56 KiB	86.62 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.full	103.48 KiB	-86 B (-0.08%)	103.31 KiB	326.72 KiB	89.10 KiB	▁▁▁▁▃▃▃████▇
solid-start.minimal	48.13 KiB	-51 B (-0.10%)	48.00 KiB	141.89 KiB	42.77 KiB	███████▁▁▁▁▁
solid-start.deferred-hydration	51.40 KiB	-49 B (-0.09%)	48.06 KiB	149.93 KiB	45.75 KiB	███████▁▁▁▁▁
solid-start.full	53.38 KiB	-56 B (-0.10%)	53.25 KiB	157.61 KiB	47.35 KiB	████▆▆▆▁▁▁▁▁
vue-start.minimal	68.85 KiB	-125 B (-0.18%)	68.72 KiB	194.70 KiB	61.33 KiB	████▆▆▆▂▂▁▁▁
vue-start.full	72.82 KiB	-112 B (-0.15%)	72.69 KiB	207.21 KiB	64.71 KiB	████▆▆▆▂▂▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

[pkg-pr-new]

More templates

• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc
• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsbuild
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-example-rscs
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7975

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7975

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7975

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7975

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7975

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7975

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7975

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7975

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7975

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7975

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7975

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7975

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7975

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7975

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7975

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7975

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7975

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7975

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7975

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7975

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7975

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7975

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7975

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7975

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7975

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7975

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7975

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7975

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7975

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7975

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7975

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7975

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7975

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7975

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7975

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7975

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7975

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7975

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7975

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7975

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7975

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7975

commit: ba8e35b

[codspeed-hq]

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 4 (👁 4) regressed benchmarks
✅ 166 untouched benchmarks

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Memory	mem server server-fn-churn (vue)	4,147.3 KB	265.2 KB	×16
⚡	Memory	mem server error-paths unmatched (vue)	2,142.1 KB	479.6 KB	×4.5
⚡	Memory	mem server peak-large-page (react)	1,737.5 KB	952.1 KB	+82.48%
⚡	Memory	mem server error-paths redirect (solid)	388 KB	282.6 KB	+37.3%
⚡	Memory	mem server error-paths redirect (vue)	338.6 KB	295.8 KB	+14.48%
⚡	Memory	mem client navigation-churn (vue)	1.3 MB	1.2 MB	+4.6%
⚡	Simulation	client-head navigation loop (react)	76.2 ms	73.2 ms	+4.02%
⚡	Simulation	client-head navigation loop (vue)	94.3 ms	90.9 ms	+3.64%
⚡	Memory	mem server aborted-requests (solid)	930.4 KB	901 KB	+3.26%
⚡	Simulation	ssr control-flow unmatched 404 (react)	58.1 ms	56.4 ms	+3%
👁	Simulation	ssr request loop (solid)	156.5 ms	161.4 ms	-3.01%
👁	Memory	mem server error-paths not-found (solid)	415.1 KB	848.3 KB	-51.07%
👁	Memory	mem server peak-large-page (solid)	811.5 KB	842.2 KB	-3.64%
👁	Memory	mem client unique-location-churn (solid)	341.2 KB	564.6 KB	-39.57%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing codex/compact-private-boundaries (ba8e35b) with main (697ebb6)}

[coderabbitai]

🧹 Nitpick comments (1)

packages/vue-router/src/link.tsx (1)

628-641: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Preserve the search type in getIsActive.

Lines 631 and 636 use search: any. This removes type checking from the active-state comparison. Replace both inline location shapes with a shared ParsedLocation-derived or generic type that preserves the router search schema.

Proposed type-safe shape

+type LinkMatchLocation = Pick<+ ParsedLocation,+ 'pathname' | 'search' | 'hash'+>+
function getIsActive(
- loc: { pathname: string; search: any; hash: string },- nextLoc: { pathname: string; search: any; hash: string },+ loc: LinkMatchLocation,+ nextLoc: LinkMatchLocation,

Please confirm that the selected type remains assignable to router locations for all search schemas.

As per coding guidelines, TypeScript files must use strict mode with extensive type safety.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/vue-router/src/link.tsx` around lines 628 - 641, Update getIsActive
so both loc and nextLoc use a shared ParsedLocation-derived or generic location
type instead of inline search: any shapes, preserving the router’s search schema
and remaining assignable to router locations across all search schemas. Keep
pathname and hash typing intact while restoring strict type checking for search
comparisons.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/vue-router/src/link.tsx`:
- Around line 628-641: Update getIsActive so both loc and nextLoc use a shared
ParsedLocation-derived or generic location type instead of inline search: any
shapes, preserving the router’s search schema and remaining assignable to router
locations across all search schemas. Keep pathname and hash typing intact while
restoring strict type checking for search comparisons.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6aa90a02-72d0-4ef1-b441-9f732d08f0dd

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and ba8e35b.

📒 Files selected for processing (10)

• packages/history/src/index.ts
• packages/history/tests/createBrowserHistory.test.ts
• packages/router-core/src/router.ts
• packages/solid-router/src/Match.tsx
• packages/solid-router/src/Matches.tsx
• packages/solid-router/src/matchContext.tsx
• packages/solid-router/src/useMatch.tsx
• packages/start-client-core/src/client-rpc/serverFnFetcher.ts
• packages/vue-router/src/Scripts.tsx
• packages/vue-router/src/link.tsx

[Sheraff]

Summary

• compact closure-local history actions and router matching results
• flatten private Solid and Vue component/helper boundaries
• remove a one-use Start fetch-body wrapper without changing wire behavior

All public options, callbacks, component props, browser history state, and serialized HTTP formats remain unchanged.

Bundle size

Measured against main at 697ebb6ddbd433d052b6b4707938a5c595865d58:

• all 17 scenarios improve gzip by 21–125 B
• all 17 initial-load gzip measurements improve by 23–126 B
• all 17 raw measurements improve by 108–425 B
• Brotli ranges from -158 B to +52 B; 12 of 17 scenarios improve

The isolated measurements and full matrix are in RESULT-optimization-compact-private-boundaries.md.

Performance

The retained lightweight-match tuple was effectively flat in repeated buildLocation benchmarks: cached and uncached results stayed within 0.8% with benchmark error around 3%.

An additional LRU tuple experiment saved 9 B gzip but slowed eviction-heavy churn by roughly 24%, so it was rejected and is not part of this PR.

Validation

• history: 29 unit tests
• router-core: 1,523 passing unit tests plus 3 expected failures
• Solid Router: 841 passing client/server tests plus 1 skip
• Vue Router: 814 passing tests plus 1 skip
• Start client core: 80 passing tests
• type tests for all five affected packages and configured TypeScript versions
• ESLint for all five affected packages
• React Start E2E app build and 5 focused server-function Playwright tests
• complete 17-scenario bundle build
• five independent semantic, performance, lifecycle, tree-shaking, and adversarial reviews

Summary by CodeRabbit

• Bug Fixes

  • Improved browser history batching and flushing for more predictable navigation updates.
  • Preserved push navigation correctly when subsequent replace operations occur.
  • Improved handling of server-request payloads, including JSON and form submissions.

• Refactor

  • Streamlined route matching, match context, link handling, script rendering, and navigation internals without changing their intended behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR replaces selected internal object-shaped values and helper parameters with tuples or positional arguments. It updates browser history batching, route matching, Solid nearest-match context, server-function request bodies, Vue script rendering, and Vue link helpers. Browser history tests cover queue coalescing and flushing.

Changes

Browser history batching

Layer / File(s)	Summary
Queue representation and flush behavior packages/history/src/index.ts	Pending actions use tuples. Flush logic clears the queued action and preserves push semantics across updates.
Browser history batching tests packages/history/tests/createBrowserHistory.test.ts	Tests cover replace coalescing, action promotion, push preservation, and explicit flushing.

Lightweight route matching

Layer / File(s)	Summary
Lightweight match tuple flow packages/router-core/src/router.ts	Lightweight matching, validation, and location construction read the four-element result tuple by index.

Solid nearest-match context

Layer / File(s)	Summary
Nearest-match tuple contract and consumers packages/solid-router/src/matchContext.tsx, packages/solid-router/src/Match.tsx, packages/solid-router/src/Matches.tsx, packages/solid-router/src/useMatch.tsx	The nearest-match context stores route ID and match accessors in a readonly tuple. Consumers read the tuple positions.

Server function request bodies

Layer / File(s)	Summary
Direct POST body handling packages/start-client-core/src/client-rpc/serverFnFetcher.ts	POST body construction returns FormData or serialized payloads directly. JSON content type assignment occurs when the body is a string.

Vue router rendering helpers

Layer / File(s)	Summary
Script rendering argument flow packages/vue-router/src/Scripts.tsx	Scripts passes script data, mount state, and nonce positionally to renderScripts.
Link helper signatures and call sites packages/vue-router/src/link.tsx	SSR and reactive link code uses positional arguments for href, active-state, and style helpers.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• TanStack/router#7805: Both PRs modify Solid router match-rendering code, including MatchInner and Outlet.
• TanStack/router#7966: Both PRs modify lightweight route-matching data in packages/router-core/src/router.ts.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 12.50% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the PR's primary optimization: compacting private bundle boundaries.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/compact-private-boundaries

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

View your CI Pipeline Execution ↗ for commit ba8e35b

Command	Status	Duration	Result
nx affected --targets=test:eslint,test:unit,tes...	✅ Succeeded	5m 10s	View ↗
nx run-many --target=build --exclude=examples/*...	✅ Succeeded	28s	View ↗

---

☁️ Nx Cloud last updated this comment at 2026-08-06 07:24:49 UTC

[github-actions]

🚀 Changeset Version Preview

5 package(s) bumped directly, 18 bumped as dependents.

🟩 Patch bumps

Package	Version	Reason
@tanstack/react-router	1.170.20 → 1.170.21	Changeset
@tanstack/router-core	1.171.17 → 1.171.18	Changeset
@tanstack/solid-router	1.170.20 → 1.170.21	Changeset
@tanstack/start-server-core	1.169.20 → 1.169.21	Changeset
@tanstack/vue-router	1.170.19 → 1.170.20	Changeset
@tanstack/react-start	1.168.37 → 1.168.38	Dependent
@tanstack/react-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/react-start-rsc	0.1.36 → 0.1.37	Dependent
@tanstack/react-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/router-cli	1.167.23 → 1.167.24	Dependent
@tanstack/router-generator	1.167.23 → 1.167.24	Dependent
@tanstack/router-plugin	1.168.25 → 1.168.26	Dependent
@tanstack/router-vite-plugin	1.167.25 → 1.167.26	Dependent
@tanstack/solid-start	1.168.36 → 1.168.37	Dependent
@tanstack/solid-start-client	1.168.18 → 1.168.19	Dependent
@tanstack/solid-start-server	1.167.25 → 1.167.26	Dependent
@tanstack/start-client-core	1.170.16 → 1.170.17	Dependent
@tanstack/start-plugin-core	1.171.28 → 1.171.29	Dependent
@tanstack/start-static-server-functions	1.167.21 → 1.167.22	Dependent
@tanstack/start-storage-context	1.167.19 → 1.167.20	Dependent
@tanstack/vue-start	1.168.35 → 1.168.36	Dependent
@tanstack/vue-start-client	1.167.21 → 1.167.22	Dependent
@tanstack/vue-start-server	1.167.25 → 1.167.26	Dependent

[github-actions]

Bundle Size Benchmarks

• Commit: bfb30996c193
• Measured at: 2026-08-06T07:20:48.840Z
• Baseline source: history:697ebb6ddbd4
• Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

Scenario	Current (gzip)	Delta vs baseline	Initial gzip	Raw	Brotli	Trend
react-router.minimal	87.07 KiB	-38 B (-0.04%)	86.94 KiB	269.02 KiB	75.85 KiB	████▂▂▂▂▂▁▂▁
react-router.full	90.88 KiB	-21 B (-0.02%)	90.74 KiB	280.98 KiB	79.08 KiB	████▂▂▂▂▂▁▂▁
solid-router.minimal	34.77 KiB	-27 B (-0.08%)	34.65 KiB	99.80 KiB	31.41 KiB	████▂▂▂▂▂▁▁▁
solid-router.full	39.86 KiB	-41 B (-0.10%)	39.74 KiB	114.97 KiB	35.86 KiB	████▂▂▂▂▂▁▁▁
vue-router.minimal	52.03 KiB	-64 B (-0.12%)	51.90 KiB	142.85 KiB	46.87 KiB	████▂▂▂▂▂▁▁▁
vue-router.full	57.96 KiB	-88 B (-0.15%)	57.83 KiB	161.43 KiB	52.05 KiB	████▂▂▂▂▂▂▂▁
react-start.minimal	100.54 KiB	-60 B (-0.06%)	100.40 KiB	312.13 KiB	87.31 KiB	███████▁▁▁▁▁
react-start.deferred-hydration	101.26 KiB	-78 B (-0.08%)	100.41 KiB	313.50 KiB	87.99 KiB	███████▁▁▁▁▁
react-start.full	103.88 KiB	-45 B (-0.04%)	103.74 KiB	322.08 KiB	90.21 KiB	███████▁▁▁▁▁
react-start.rsbuild.minimal	100.16 KiB	-80 B (-0.08%)	99.99 KiB	316.63 KiB	86.39 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.minimal-iife	100.57 KiB	-77 B (-0.07%)	100.40 KiB	317.56 KiB	86.62 KiB	▁▁▁▁▂▂▂████▇
react-start.rsbuild.full	103.48 KiB	-86 B (-0.08%)	103.31 KiB	326.72 KiB	89.10 KiB	▁▁▁▁▃▃▃████▇
solid-start.minimal	48.13 KiB	-51 B (-0.10%)	48.00 KiB	141.89 KiB	42.77 KiB	███████▁▁▁▁▁
solid-start.deferred-hydration	51.40 KiB	-49 B (-0.09%)	48.06 KiB	149.93 KiB	45.75 KiB	███████▁▁▁▁▁
solid-start.full	53.38 KiB	-56 B (-0.10%)	53.25 KiB	157.61 KiB	47.35 KiB	████▆▆▆▁▁▁▁▁
vue-start.minimal	68.85 KiB	-125 B (-0.18%)	68.72 KiB	194.70 KiB	61.33 KiB	████▆▆▆▂▂▁▁▁
vue-start.full	72.82 KiB	-112 B (-0.15%)	72.69 KiB	207.21 KiB	64.71 KiB	████▆▆▆▂▂▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

[pkg-pr-new]

More templates

• tanstack-router-vue-example-basic-jsx
• tanstack-router-vue-example-basic-file-based-jsx
• tanstack-router-vue-example-basic-file-based-sfc
• tanstack-router-solid-example-authenticated-routes
• tanstack-router-solid-example-authenticated-routes-firebase
• tanstack-router-solid-example-basic
• tanstack-router-solid-example-basic-default-search-params
• tanstack-router-solid-example-basic-devtools-panel
• tanstack-router-solid-example-basic-file-based
• tanstack-router-solid-example-basic-non-nested-devtools
• tanstack-router-solid-example-basic-solid-query
• tanstack-router-solid-example-basic-solid-query-file-based
• tanstack-router-solid-example-basic-ssr-file-based
• tanstack-router-solid-example-basic-ssr-streaming-file-based
• tanstack-router-solid-example-basic-virtual-file-based
• tanstack-router-solid-example-basic-virtual-inside-file-based
• tanstack-router-solid-example-deferred-data
• tanstack-router-solid-i18n-paraglide
• tanstack-router-solid-example-kitchen-sink
• tanstack-router-solid-example-kitchen-sink-file-based
• tanstack-router-solid-example-kitchen-sink-solid-query
• tanstack-router-solid-example-kitchen-sink-solid-query-file-based
• tanstack-router-solid-example-large-file-based
• tanstack-router-solid-example-location-masking
• tanstack-router-solid-example-navigation-blocking
• tanstack-router-solid-example-quickstart
• tanstack-router-solid-example-quickstart-esbuild-file-based
• tanstack-router-solid-example-quickstart-file-based
• tanstack-router-solid-example-quickstart-rspack-file-based
• tanstack-router-solid-example-quickstart-webpack-file-based
• @tanstack/router-solid-mono-simple
• router-solid-mono-simple-lazy
• router-solid-monorepo-solid-query
• tanstack-router-solid-example-scroll-restoration
• tanstack-solid-router-search-validator-adapters
• tanstack-solid-start-example-basic
• tanstack-solid-start-example-basic-auth
• tanstack-solid-start-example-basic-authjs
• tanstack-solid-start-example-basic-cloudflare
• tanstack-solid-start-example-basic-netlify
• tanstack-solid-start-example-basic-nitro
• tanstack-start-example-basic-solid-query
• tanstack-solid-start-example-basic-static
• tanstack-solid-start-bun-hosting
• tanstack-solid-start-example-convex-better-auth
• tanstack-solid-start-example-counter
• tanstack-solid-start-i18n-paraglide
• tanstack-solid-start-example-large
• tanstack-solid-start-streaming-data-from-server-functions
• tanstack-solid-start-example-supabase-basic
• tanstack-solid-start-tailwind-v4
• tanstack-router-solid-example-view-transitions
• tanstack-router-solid-example-with-framer-motion
• tanstack-router-solid-example-with-trpc
• tanstack-router-react-example-authenticated-routes
• tanstack-router-react-example-authenticated-routes-firebase
• tanstack-router-react-example-basic
• tanstack-router-react-example-basic-default-search-params
• tanstack-router-react-example-basic-devtools-panel
• tanstack-router-react-example-basic-file-based
• tanstack-router-react-example-basic-non-nested-devtools
• tanstack-router-react-example-react-query
• tanstack-router-react-example-basic-react-query-file-based
• tanstack-router-react-example-basic-ssr-file-based
• tanstack-router-react-example-basic-ssr-streaming-file-based
• tanstack-router-react-example-basic-virtual-file-based
• tanstack-router-react-example-basic-virtual-inside-file-based
• tanstack-router-react-example-deferred-data
• tanstack-router-i18n-paraglide
• tanstack-router-react-example-kitchen-sink
• tanstack-router-react-example-kitchen-sink-file-based
• tanstack-router-react-example-kitchen-sink-react-query
• tanstack-router-react-example-kitchen-sink-react-query-file-based
• tanstack-router-react-example-large-file-based
• tanstack-router-react-example-location-masking
• tanstack-router-react-example-navigation-blocking
• tanstack-router-react-example-quickstart
• tanstack-router-react-example-quickstart-esbuild-file-based
• tanstack-router-react-example-quickstart-file-based
• tanstack-router-react-example-quickstart-rspack-file-based
• tanstack-router-react-example-quickstart-webpack-file-based
• router-monorepo-react-query
• router-mono-simple
• router-mono-simple-lazy
• tanstack-router-react-example-scroll-restoration
• tanstack-search-validator-adapters
• tanstack-start-example-bare
• tanstack-start-example-basic
• tanstack-start-example-basic-auth
• tanstack-router-react-example-basic-authjs
• tanstack-start-example-basic-cloudflare
• tanstack-start-example-basic-react-query
• tanstack-start-example-basic-rsbuild
• tanstack-start-example-basic-static
• tanstack-start-bun-hosting
• tanstack-start-example-clerk-basic
• tanstack-start-example-convex-trellaux
• tanstack-start-example-counter
• tanstack-start-i18n-paraglide
• tanstack-start-example-large
• tanstack-start-example-material-ui
• tanstack-start-example-rscs
• tanstack-start-streaming-data-from-server-functions
• tanstack-start-example-supabase-basic
• tanstack-start-tailwind-v4
• tanstack-start-example-trellaux
• tanstack-start-example-workos
• tanstack-router-react-example-view-transitions
• tanstack-router-react-example-with-framer-motion
• tanstack-router-react-example-with-trpc
• tanstack-router-react-example-with-trpc-react-query

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7975

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7975

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7975

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7975

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7975

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7975

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7975

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7975

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7975

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7975

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7975

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7975

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7975

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7975

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7975

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7975

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7975

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7975

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7975

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7975

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7975

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7975

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7975

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7975

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7975

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7975

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7975

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7975

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7975

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7975

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7975

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7975

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7975

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7975

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7975

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7975

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7975

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7975

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7975

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7975

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7975

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7975

commit: ba8e35b

[codspeed-hq]

Merging this PR will regress 0 benchmarks

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 10 improved benchmarks
❌ 4 (👁 4) regressed benchmarks
✅ 166 untouched benchmarks

Performance Changes

	Mode	Benchmark	BASE	HEAD	Efficiency
⚡	Memory	mem server server-fn-churn (vue)	4,147.3 KB	265.2 KB	×16
⚡	Memory	mem server error-paths unmatched (vue)	2,142.1 KB	479.6 KB	×4.5
⚡	Memory	mem server peak-large-page (react)	1,737.5 KB	952.1 KB	+82.48%
⚡	Memory	mem server error-paths redirect (solid)	388 KB	282.6 KB	+37.3%
⚡	Memory	mem server error-paths redirect (vue)	338.6 KB	295.8 KB	+14.48%
⚡	Memory	mem client navigation-churn (vue)	1.3 MB	1.2 MB	+4.6%
⚡	Simulation	client-head navigation loop (react)	76.2 ms	73.2 ms	+4.02%
⚡	Simulation	client-head navigation loop (vue)	94.3 ms	90.9 ms	+3.64%
⚡	Memory	mem server aborted-requests (solid)	930.4 KB	901 KB	+3.26%
⚡	Simulation	ssr control-flow unmatched 404 (react)	58.1 ms	56.4 ms	+3%
👁	Simulation	ssr request loop (solid)	156.5 ms	161.4 ms	-3.01%
👁	Memory	mem server error-paths not-found (solid)	415.1 KB	848.3 KB	-51.07%
👁	Memory	mem server peak-large-page (solid)	811.5 KB	842.2 KB	-3.64%
👁	Memory	mem client unique-location-churn (solid)	341.2 KB	564.6 KB	-39.57%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

---

_{Comparing codex/compact-private-boundaries (ba8e35b) with main (697ebb6)}

[coderabbitai]

🧹 Nitpick comments (1)

packages/vue-router/src/link.tsx (1)

628-641: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Preserve the search type in getIsActive.

Lines 631 and 636 use search: any. This removes type checking from the active-state comparison. Replace both inline location shapes with a shared ParsedLocation-derived or generic type that preserves the router search schema.

Proposed type-safe shape

+type LinkMatchLocation = Pick<+ ParsedLocation,+ 'pathname' | 'search' | 'hash'+>+
function getIsActive(
- loc: { pathname: string; search: any; hash: string },- nextLoc: { pathname: string; search: any; hash: string },+ loc: LinkMatchLocation,+ nextLoc: LinkMatchLocation,

Please confirm that the selected type remains assignable to router locations for all search schemas.

As per coding guidelines, TypeScript files must use strict mode with extensive type safety.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@packages/vue-router/src/link.tsx` around lines 628 - 641, Update getIsActive
so both loc and nextLoc use a shared ParsedLocation-derived or generic location
type instead of inline search: any shapes, preserving the router’s search schema
and remaining assignable to router locations across all search schemas. Keep
pathname and hash typing intact while restoring strict type checking for search
comparisons.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/vue-router/src/link.tsx`:
- Around line 628-641: Update getIsActive so both loc and nextLoc use a shared
ParsedLocation-derived or generic location type instead of inline search: any
shapes, preserving the router’s search schema and remaining assignable to router
locations across all search schemas. Keep pathname and hash typing intact while
restoring strict type checking for search comparisons.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6aa90a02-72d0-4ef1-b441-9f732d08f0dd

📥 Commits

Reviewing files that changed from the base of the PR and between 697ebb6 and ba8e35b.

📒 Files selected for processing (10)

• packages/history/src/index.ts
• packages/history/tests/createBrowserHistory.test.ts
• packages/router-core/src/router.ts
• packages/solid-router/src/Match.tsx
• packages/solid-router/src/Matches.tsx
• packages/solid-router/src/matchContext.tsx
• packages/solid-router/src/useMatch.tsx
• packages/start-client-core/src/client-rpc/serverFnFetcher.ts
• packages/vue-router/src/Scripts.tsx
• packages/vue-router/src/link.tsx