fix(router): preserve raw params for match identity - #7966

Merged
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params
Aug 5, 2026
Merged

fix(router): preserve raw params for match identity#7966
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Keep URL-derived route params in their raw string form throughout route matching and interpolation.
  • Carry parsed ancestor params separately when constructing or reusing matches.
  • Return getMatchedRoutes as a labeled tuple and name the unparsed value rawParams throughout its consumers.
  • Add public-API regression coverage for React Router and Solid Router that verifies the URL, rendered params, and loader data across cached navigation.

Root cause

matchRoutesInternal reused the same object for raw URL params and parsed params. A structured params.parse result could therefore replace a path-param string with an object before a descendant route was interpolated. That produced an incorrect match ID (for example, [object Object]), allowing a cached match to restore stale parsed params and loader data.

The fix preserves raw params for match identity while maintaining a separate parsed-param snapshot. It still calls interpolatePath once per route and does not require stringifying params without route context. The tuple contract removes repeated object keys and the rawParams label documents the invariant at each internal consumer.

Validation

  • Affected test:unit: 30 projects passed
  • Affected test:types: 40 projects passed across supported TypeScript versions
  • Affected test:eslint: 32 projects passed
  • SSR adjacent A/B benchmark: effectively flat (+0.16%)
  • Loader-heavy client benchmark: effectively flat
  • Structured-param fix nested-client benchmark: low-single-digit variance (~3%)
  • Tuple-only nested-client A/B: 74.92 -> 77.46 ops/s (+3.4%, within low-single-digit error margins)
  • Structured-param fix bundle delta: aggregate gzip -108 B, raw -627 B, Brotli -26 B
  • Tuple-only bundle delta: all 17 scenarios improved; aggregate gzip -623 B, initial gzip -619 B, raw -2,886 B, Brotli -664 B

Fixes#7964, Fixes#7731

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where revisiting routes with structured parameters could retain stale parsed parameters or loader data.
    • Ensured route URLs, parsed parameters, and loader results refresh correctly when navigating between different parameter values.
    • Improved route matching and navigation state handling across supported router integrations.
  • Tests

    • Added regression coverage for structured parameter parsing, navigation, and loader data refreshes across React and Solid Router.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The route matcher now separates raw URL parameters from parsed parameters and preserves parsed values across reused matches. Matching callers use the new tuple result. React and Solid tests verify refreshed parameters and loader data after revisiting routes.

Changes

Parsed parameter refresh

Layer / File(s)Summary
Route matching parameter propagation
packages/router-core/src/router.ts
matchRoutesInternal accumulates parsed parameters without mutating raw URL parameters. Matching results now return [matchedRoutes, rawParams, foundRoute].
Matching result integration
packages/react-router/src/useBlocker.tsx, packages/solid-router/src/useBlocker.tsx, packages/vue-router/src/useBlocker.tsx, packages/start-server-core/src/createStartHandler.ts, packages/router-core/src/router.ts, packages/router-plugin/tests/handle-route-update.test.ts
Blocker resolution, server middleware context, destination resolution, path validation, and route-update assertions use tuple-based matching results.
Repeated navigation regression coverage
packages/react-router/tests/issue-7964-param-parsing-loader.test.tsx, packages/solid-router/tests/issue-7964-param-parsing-loader.test.tsx
Tests verify structured parameter parsing, stringification, loader results, and refreshed values after revisiting routes with different parameters.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
participant User
participant Router
participant RouteLoader
participant View
User->>Router: Navigate with new URL parameters
Router->>Router: Match routes and parse parameters
Router->>RouteLoader: Load data with parsed parameters
RouteLoader-->>Router: Return refreshed loader data
Router-->>View: Render parsed parameters and loader data
Loading

Possibly related PRs

  • TanStack/router#7805: Both changes modify route-matching behavior in packages/router-core/src/router.ts, while that PR focuses on lane loading.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedThe changes preserve raw parameters, refresh parsed parameters and loader data, and add regression tests for issue #7964.
Out of Scope Changes check✅ PassedThe tuple refactor, framework updates, and regression tests support the linked issue and stated route-matching objectives.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main change: preserving raw parameters to maintain route match identity.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-7964-structured-params

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 1ad6a52

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 41sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 13sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 18:57:08 UTC

@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 393cefdb931d
  • Measured at: 2026-08-05T18:47:05.742Z
  • Baseline source: history:790e06282030
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.08 KiB-22 B (-0.02%)86.95 KiB269.10 KiB75.84 KiB██████▂▂▂▂▂▁
react-router.full90.88 KiB-39 B (-0.04%)90.74 KiB281.06 KiB79.11 KiB██████▂▂▂▂▂▁
solid-router.minimal34.80 KiB-58 B (-0.16%)34.67 KiB99.97 KiB31.39 KiB██████▂▂▂▂▂▁
solid-router.full39.90 KiB-52 B (-0.13%)39.77 KiB115.14 KiB35.92 KiB██████▂▂▂▂▂▁
vue-router.minimal52.10 KiB-50 B (-0.09%)51.96 KiB143.12 KiB46.88 KiB██████▁▁▁▁▁▁
vue-router.full58.05 KiB-47 B (-0.08%)57.92 KiB161.79 KiB52.08 KiB██████▁▁▁▁▁▁
react-start.minimal100.58 KiB-40 B (-0.04%)100.45 KiB312.26 KiB87.34 KiB█████████▁▁▁
react-start.deferred-hydration101.32 KiB-34 B (-0.03%)100.47 KiB313.63 KiB88.06 KiB█████████▁▁▁
react-start.full103.90 KiB-48 B (-0.05%)103.76 KiB322.21 KiB90.29 KiB█████████▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.76 KiB86.41 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.minimal-iife100.62 KiB-33 B (-0.03%)100.46 KiB317.69 KiB86.73 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.full103.55 KiB-41 B (-0.04%)103.38 KiB326.85 KiB89.05 KiB▁▁▁▁▁▁▃▃▃███
solid-start.minimal48.18 KiB-42 B (-0.09%)48.05 KiB142.11 KiB42.75 KiB█████████▁▁▁
solid-start.deferred-hydration51.44 KiB-39 B (-0.07%)48.11 KiB150.15 KiB45.87 KiB█████████▁▁▁
solid-start.full53.43 KiB-52 B (-0.09%)53.30 KiB157.84 KiB47.39 KiB██████▆▆▆▁▁▁
vue-start.minimal68.97 KiB-47 B (-0.07%)68.84 KiB195.12 KiB61.27 KiB██████▆▆▆▁▁▁
vue-start.full72.93 KiB-57 B (-0.08%)72.80 KiB207.62 KiB64.74 KiB██████▆▆▆▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7966

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7966

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7966

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7966

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7966

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7966

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7966

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7966

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7966

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7966

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7966

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7966

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7966

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7966

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7966

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7966

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7966

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7966

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7966

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7966

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7966

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7966

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7966

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7966

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7966

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7966

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7966

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7966

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7966

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7966

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7966

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7966

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7966

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7966

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7966

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7966

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7966

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7966

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7966

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7966

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7966

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7966

commit: e408463

@codspeed-hq

codspeed-hqBot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 0.83%

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 12 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 163 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem client navigation-churn (solid)617.6 KB536.4 KB+15.14%
Simulationssr assets linked-css control (solid)71.9 ms68 ms+5.78%
Simulationssr loaders (react)64.6 ms61.4 ms+5.2%
Memorymem server error-paths redirect (vue)965.1 KB918.2 KB+5.11%
Simulationssr control-flow unmatched 404 (react)59.7 ms56.9 ms+4.86%
Memorymem server server-fn-churn (react)276.2 KB263.5 KB+4.8%
Simulationclient-control-flow navigation loop (vue)58 ms55.5 ms+4.52%
Simulationssr loaders (solid)75.4 ms72.3 ms+4.33%
Memorymem server error-paths redirect (react)203.7 KB196.6 KB+3.62%
Simulationclient-side navigation loop (vue)72.7 ms70.2 ms+3.6%
Simulationssr control-flow unmatched 404 (solid)70.4 ms68 ms+3.53%
Memorymem server error-paths not-found (vue)331.8 KB321.6 KB+3.17%
👁Simulationssr control-flow route headers (solid)71.5 ms73.8 ms-3.04%
👁Simulationclient-search-params navigation loop (react)75.4 ms79.2 ms-4.79%
👁Memorymem server error-paths unmatched (react)318.5 KB564.3 KB-43.56%
👁Simulationclient-history navigation loop (vue)44 ms46.9 ms-6.25%
👁Simulationclient-search-params navigation loop (vue)91.4 ms95.1 ms-3.9%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fix-7964-structured-params (e408463) with main (790e062)

Open in CodSpeed

@Sheraff
Sheraff merged commit 07a3d10 into mainAug 5, 2026
26 checks passed
@Sheraff
Sheraff deleted the codex/fix-7964-structured-params branch August 5, 2026 19:41
@SheraffSheraff mentioned this pull request Aug 5, 2026
Sheraff added a commit that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(router): preserve raw params for match identity - #7966

Merged
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params
Aug 5, 2026
Merged

fix(router): preserve raw params for match identity#7966
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Keep URL-derived route params in their raw string form throughout route matching and interpolation.
  • Carry parsed ancestor params separately when constructing or reusing matches.
  • Return getMatchedRoutes as a labeled tuple and name the unparsed value rawParams throughout its consumers.
  • Add public-API regression coverage for React Router and Solid Router that verifies the URL, rendered params, and loader data across cached navigation.

Root cause

matchRoutesInternal reused the same object for raw URL params and parsed params. A structured params.parse result could therefore replace a path-param string with an object before a descendant route was interpolated. That produced an incorrect match ID (for example, [object Object]), allowing a cached match to restore stale parsed params and loader data.

The fix preserves raw params for match identity while maintaining a separate parsed-param snapshot. It still calls interpolatePath once per route and does not require stringifying params without route context. The tuple contract removes repeated object keys and the rawParams label documents the invariant at each internal consumer.

Validation

  • Affected test:unit: 30 projects passed
  • Affected test:types: 40 projects passed across supported TypeScript versions
  • Affected test:eslint: 32 projects passed
  • SSR adjacent A/B benchmark: effectively flat (+0.16%)
  • Loader-heavy client benchmark: effectively flat
  • Structured-param fix nested-client benchmark: low-single-digit variance (~3%)
  • Tuple-only nested-client A/B: 74.92 -> 77.46 ops/s (+3.4%, within low-single-digit error margins)
  • Structured-param fix bundle delta: aggregate gzip -108 B, raw -627 B, Brotli -26 B
  • Tuple-only bundle delta: all 17 scenarios improved; aggregate gzip -623 B, initial gzip -619 B, raw -2,886 B, Brotli -664 B

Fixes#7964, Fixes#7731

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where revisiting routes with structured parameters could retain stale parsed parameters or loader data.
    • Ensured route URLs, parsed parameters, and loader results refresh correctly when navigating between different parameter values.
    • Improved route matching and navigation state handling across supported router integrations.
  • Tests

    • Added regression coverage for structured parameter parsing, navigation, and loader data refreshes across React and Solid Router.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The route matcher now separates raw URL parameters from parsed parameters and preserves parsed values across reused matches. Matching callers use the new tuple result. React and Solid tests verify refreshed parameters and loader data after revisiting routes.

Changes

Parsed parameter refresh

Layer / File(s)Summary
Route matching parameter propagation
packages/router-core/src/router.ts
matchRoutesInternal accumulates parsed parameters without mutating raw URL parameters. Matching results now return [matchedRoutes, rawParams, foundRoute].
Matching result integration
packages/react-router/src/useBlocker.tsx, packages/solid-router/src/useBlocker.tsx, packages/vue-router/src/useBlocker.tsx, packages/start-server-core/src/createStartHandler.ts, packages/router-core/src/router.ts, packages/router-plugin/tests/handle-route-update.test.ts
Blocker resolution, server middleware context, destination resolution, path validation, and route-update assertions use tuple-based matching results.
Repeated navigation regression coverage
packages/react-router/tests/issue-7964-param-parsing-loader.test.tsx, packages/solid-router/tests/issue-7964-param-parsing-loader.test.tsx
Tests verify structured parameter parsing, stringification, loader results, and refreshed values after revisiting routes with different parameters.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
participant User
participant Router
participant RouteLoader
participant View
User->>Router: Navigate with new URL parameters
Router->>Router: Match routes and parse parameters
Router->>RouteLoader: Load data with parsed parameters
RouteLoader-->>Router: Return refreshed loader data
Router-->>View: Render parsed parameters and loader data
Loading

Possibly related PRs

  • TanStack/router#7805: Both changes modify route-matching behavior in packages/router-core/src/router.ts, while that PR focuses on lane loading.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedThe changes preserve raw parameters, refresh parsed parameters and loader data, and add regression tests for issue #7964.
Out of Scope Changes check✅ PassedThe tuple refactor, framework updates, and regression tests support the linked issue and stated route-matching objectives.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main change: preserving raw parameters to maintain route match identity.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-7964-structured-params

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 1ad6a52

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 41sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 13sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 18:57:08 UTC

@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 393cefdb931d
  • Measured at: 2026-08-05T18:47:05.742Z
  • Baseline source: history:790e06282030
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.08 KiB-22 B (-0.02%)86.95 KiB269.10 KiB75.84 KiB██████▂▂▂▂▂▁
react-router.full90.88 KiB-39 B (-0.04%)90.74 KiB281.06 KiB79.11 KiB██████▂▂▂▂▂▁
solid-router.minimal34.80 KiB-58 B (-0.16%)34.67 KiB99.97 KiB31.39 KiB██████▂▂▂▂▂▁
solid-router.full39.90 KiB-52 B (-0.13%)39.77 KiB115.14 KiB35.92 KiB██████▂▂▂▂▂▁
vue-router.minimal52.10 KiB-50 B (-0.09%)51.96 KiB143.12 KiB46.88 KiB██████▁▁▁▁▁▁
vue-router.full58.05 KiB-47 B (-0.08%)57.92 KiB161.79 KiB52.08 KiB██████▁▁▁▁▁▁
react-start.minimal100.58 KiB-40 B (-0.04%)100.45 KiB312.26 KiB87.34 KiB█████████▁▁▁
react-start.deferred-hydration101.32 KiB-34 B (-0.03%)100.47 KiB313.63 KiB88.06 KiB█████████▁▁▁
react-start.full103.90 KiB-48 B (-0.05%)103.76 KiB322.21 KiB90.29 KiB█████████▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.76 KiB86.41 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.minimal-iife100.62 KiB-33 B (-0.03%)100.46 KiB317.69 KiB86.73 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.full103.55 KiB-41 B (-0.04%)103.38 KiB326.85 KiB89.05 KiB▁▁▁▁▁▁▃▃▃███
solid-start.minimal48.18 KiB-42 B (-0.09%)48.05 KiB142.11 KiB42.75 KiB█████████▁▁▁
solid-start.deferred-hydration51.44 KiB-39 B (-0.07%)48.11 KiB150.15 KiB45.87 KiB█████████▁▁▁
solid-start.full53.43 KiB-52 B (-0.09%)53.30 KiB157.84 KiB47.39 KiB██████▆▆▆▁▁▁
vue-start.minimal68.97 KiB-47 B (-0.07%)68.84 KiB195.12 KiB61.27 KiB██████▆▆▆▁▁▁
vue-start.full72.93 KiB-57 B (-0.08%)72.80 KiB207.62 KiB64.74 KiB██████▆▆▆▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7966

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7966

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7966

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7966

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7966

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7966

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7966

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7966

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7966

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7966

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7966

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7966

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7966

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7966

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7966

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7966

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7966

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7966

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7966

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7966

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7966

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7966

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7966

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7966

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7966

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7966

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7966

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7966

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7966

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7966

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7966

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7966

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7966

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7966

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7966

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7966

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7966

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7966

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7966

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7966

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7966

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7966

commit: e408463

@codspeed-hq

codspeed-hqBot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 0.83%

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 12 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 163 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem client navigation-churn (solid)617.6 KB536.4 KB+15.14%
Simulationssr assets linked-css control (solid)71.9 ms68 ms+5.78%
Simulationssr loaders (react)64.6 ms61.4 ms+5.2%
Memorymem server error-paths redirect (vue)965.1 KB918.2 KB+5.11%
Simulationssr control-flow unmatched 404 (react)59.7 ms56.9 ms+4.86%
Memorymem server server-fn-churn (react)276.2 KB263.5 KB+4.8%
Simulationclient-control-flow navigation loop (vue)58 ms55.5 ms+4.52%
Simulationssr loaders (solid)75.4 ms72.3 ms+4.33%
Memorymem server error-paths redirect (react)203.7 KB196.6 KB+3.62%
Simulationclient-side navigation loop (vue)72.7 ms70.2 ms+3.6%
Simulationssr control-flow unmatched 404 (solid)70.4 ms68 ms+3.53%
Memorymem server error-paths not-found (vue)331.8 KB321.6 KB+3.17%
👁Simulationssr control-flow route headers (solid)71.5 ms73.8 ms-3.04%
👁Simulationclient-search-params navigation loop (react)75.4 ms79.2 ms-4.79%
👁Memorymem server error-paths unmatched (react)318.5 KB564.3 KB-43.56%
👁Simulationclient-history navigation loop (vue)44 ms46.9 ms-6.25%
👁Simulationclient-search-params navigation loop (vue)91.4 ms95.1 ms-3.9%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fix-7964-structured-params (e408463) with main (790e062)

Open in CodSpeed

@Sheraff
Sheraff merged commit 07a3d10 into mainAug 5, 2026
26 checks passed
@Sheraff
Sheraff deleted the codex/fix-7964-structured-params branch August 5, 2026 19:41
@SheraffSheraff mentioned this pull request Aug 5, 2026
Sheraff added a commit that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(router): preserve raw params for match identity - #7966

Merged
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params
Aug 5, 2026
Merged

fix(router): preserve raw params for match identity#7966
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Keep URL-derived route params in their raw string form throughout route matching and interpolation.
  • Carry parsed ancestor params separately when constructing or reusing matches.
  • Return getMatchedRoutes as a labeled tuple and name the unparsed value rawParams throughout its consumers.
  • Add public-API regression coverage for React Router and Solid Router that verifies the URL, rendered params, and loader data across cached navigation.

Root cause

matchRoutesInternal reused the same object for raw URL params and parsed params. A structured params.parse result could therefore replace a path-param string with an object before a descendant route was interpolated. That produced an incorrect match ID (for example, [object Object]), allowing a cached match to restore stale parsed params and loader data.

The fix preserves raw params for match identity while maintaining a separate parsed-param snapshot. It still calls interpolatePath once per route and does not require stringifying params without route context. The tuple contract removes repeated object keys and the rawParams label documents the invariant at each internal consumer.

Validation

  • Affected test:unit: 30 projects passed
  • Affected test:types: 40 projects passed across supported TypeScript versions
  • Affected test:eslint: 32 projects passed
  • SSR adjacent A/B benchmark: effectively flat (+0.16%)
  • Loader-heavy client benchmark: effectively flat
  • Structured-param fix nested-client benchmark: low-single-digit variance (~3%)
  • Tuple-only nested-client A/B: 74.92 -> 77.46 ops/s (+3.4%, within low-single-digit error margins)
  • Structured-param fix bundle delta: aggregate gzip -108 B, raw -627 B, Brotli -26 B
  • Tuple-only bundle delta: all 17 scenarios improved; aggregate gzip -623 B, initial gzip -619 B, raw -2,886 B, Brotli -664 B

Fixes#7964, Fixes#7731

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where revisiting routes with structured parameters could retain stale parsed parameters or loader data.
    • Ensured route URLs, parsed parameters, and loader results refresh correctly when navigating between different parameter values.
    • Improved route matching and navigation state handling across supported router integrations.
  • Tests

    • Added regression coverage for structured parameter parsing, navigation, and loader data refreshes across React and Solid Router.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The route matcher now separates raw URL parameters from parsed parameters and preserves parsed values across reused matches. Matching callers use the new tuple result. React and Solid tests verify refreshed parameters and loader data after revisiting routes.

Changes

Parsed parameter refresh

Layer / File(s)Summary
Route matching parameter propagation
packages/router-core/src/router.ts
matchRoutesInternal accumulates parsed parameters without mutating raw URL parameters. Matching results now return [matchedRoutes, rawParams, foundRoute].
Matching result integration
packages/react-router/src/useBlocker.tsx, packages/solid-router/src/useBlocker.tsx, packages/vue-router/src/useBlocker.tsx, packages/start-server-core/src/createStartHandler.ts, packages/router-core/src/router.ts, packages/router-plugin/tests/handle-route-update.test.ts
Blocker resolution, server middleware context, destination resolution, path validation, and route-update assertions use tuple-based matching results.
Repeated navigation regression coverage
packages/react-router/tests/issue-7964-param-parsing-loader.test.tsx, packages/solid-router/tests/issue-7964-param-parsing-loader.test.tsx
Tests verify structured parameter parsing, stringification, loader results, and refreshed values after revisiting routes with different parameters.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
participant User
participant Router
participant RouteLoader
participant View
User->>Router: Navigate with new URL parameters
Router->>Router: Match routes and parse parameters
Router->>RouteLoader: Load data with parsed parameters
RouteLoader-->>Router: Return refreshed loader data
Router-->>View: Render parsed parameters and loader data
Loading

Possibly related PRs

  • TanStack/router#7805: Both changes modify route-matching behavior in packages/router-core/src/router.ts, while that PR focuses on lane loading.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedThe changes preserve raw parameters, refresh parsed parameters and loader data, and add regression tests for issue #7964.
Out of Scope Changes check✅ PassedThe tuple refactor, framework updates, and regression tests support the linked issue and stated route-matching objectives.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main change: preserving raw parameters to maintain route match identity.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-7964-structured-params

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 1ad6a52

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 41sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 13sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 18:57:08 UTC

@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 393cefdb931d
  • Measured at: 2026-08-05T18:47:05.742Z
  • Baseline source: history:790e06282030
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.08 KiB-22 B (-0.02%)86.95 KiB269.10 KiB75.84 KiB██████▂▂▂▂▂▁
react-router.full90.88 KiB-39 B (-0.04%)90.74 KiB281.06 KiB79.11 KiB██████▂▂▂▂▂▁
solid-router.minimal34.80 KiB-58 B (-0.16%)34.67 KiB99.97 KiB31.39 KiB██████▂▂▂▂▂▁
solid-router.full39.90 KiB-52 B (-0.13%)39.77 KiB115.14 KiB35.92 KiB██████▂▂▂▂▂▁
vue-router.minimal52.10 KiB-50 B (-0.09%)51.96 KiB143.12 KiB46.88 KiB██████▁▁▁▁▁▁
vue-router.full58.05 KiB-47 B (-0.08%)57.92 KiB161.79 KiB52.08 KiB██████▁▁▁▁▁▁
react-start.minimal100.58 KiB-40 B (-0.04%)100.45 KiB312.26 KiB87.34 KiB█████████▁▁▁
react-start.deferred-hydration101.32 KiB-34 B (-0.03%)100.47 KiB313.63 KiB88.06 KiB█████████▁▁▁
react-start.full103.90 KiB-48 B (-0.05%)103.76 KiB322.21 KiB90.29 KiB█████████▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.76 KiB86.41 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.minimal-iife100.62 KiB-33 B (-0.03%)100.46 KiB317.69 KiB86.73 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.full103.55 KiB-41 B (-0.04%)103.38 KiB326.85 KiB89.05 KiB▁▁▁▁▁▁▃▃▃███
solid-start.minimal48.18 KiB-42 B (-0.09%)48.05 KiB142.11 KiB42.75 KiB█████████▁▁▁
solid-start.deferred-hydration51.44 KiB-39 B (-0.07%)48.11 KiB150.15 KiB45.87 KiB█████████▁▁▁
solid-start.full53.43 KiB-52 B (-0.09%)53.30 KiB157.84 KiB47.39 KiB██████▆▆▆▁▁▁
vue-start.minimal68.97 KiB-47 B (-0.07%)68.84 KiB195.12 KiB61.27 KiB██████▆▆▆▁▁▁
vue-start.full72.93 KiB-57 B (-0.08%)72.80 KiB207.62 KiB64.74 KiB██████▆▆▆▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7966

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7966

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7966

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7966

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7966

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7966

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7966

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7966

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7966

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7966

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7966

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7966

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7966

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7966

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7966

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7966

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7966

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7966

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7966

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7966

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7966

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7966

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7966

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7966

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7966

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7966

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7966

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7966

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7966

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7966

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7966

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7966

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7966

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7966

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7966

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7966

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7966

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7966

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7966

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7966

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7966

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7966

commit: e408463

@codspeed-hq

codspeed-hqBot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 0.83%

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 12 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 163 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem client navigation-churn (solid)617.6 KB536.4 KB+15.14%
Simulationssr assets linked-css control (solid)71.9 ms68 ms+5.78%
Simulationssr loaders (react)64.6 ms61.4 ms+5.2%
Memorymem server error-paths redirect (vue)965.1 KB918.2 KB+5.11%
Simulationssr control-flow unmatched 404 (react)59.7 ms56.9 ms+4.86%
Memorymem server server-fn-churn (react)276.2 KB263.5 KB+4.8%
Simulationclient-control-flow navigation loop (vue)58 ms55.5 ms+4.52%
Simulationssr loaders (solid)75.4 ms72.3 ms+4.33%
Memorymem server error-paths redirect (react)203.7 KB196.6 KB+3.62%
Simulationclient-side navigation loop (vue)72.7 ms70.2 ms+3.6%
Simulationssr control-flow unmatched 404 (solid)70.4 ms68 ms+3.53%
Memorymem server error-paths not-found (vue)331.8 KB321.6 KB+3.17%
👁Simulationssr control-flow route headers (solid)71.5 ms73.8 ms-3.04%
👁Simulationclient-search-params navigation loop (react)75.4 ms79.2 ms-4.79%
👁Memorymem server error-paths unmatched (react)318.5 KB564.3 KB-43.56%
👁Simulationclient-history navigation loop (vue)44 ms46.9 ms-6.25%
👁Simulationclient-search-params navigation loop (vue)91.4 ms95.1 ms-3.9%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fix-7964-structured-params (e408463) with main (790e062)

Open in CodSpeed

@Sheraff
Sheraff merged commit 07a3d10 into mainAug 5, 2026
26 checks passed
@Sheraff
Sheraff deleted the codex/fix-7964-structured-params branch August 5, 2026 19:41
@SheraffSheraff mentioned this pull request Aug 5, 2026
Sheraff added a commit that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(router): preserve raw params for match identity - #7966

Merged
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params
Aug 5, 2026
Merged

fix(router): preserve raw params for match identity#7966
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Keep URL-derived route params in their raw string form throughout route matching and interpolation.
  • Carry parsed ancestor params separately when constructing or reusing matches.
  • Return getMatchedRoutes as a labeled tuple and name the unparsed value rawParams throughout its consumers.
  • Add public-API regression coverage for React Router and Solid Router that verifies the URL, rendered params, and loader data across cached navigation.

Root cause

matchRoutesInternal reused the same object for raw URL params and parsed params. A structured params.parse result could therefore replace a path-param string with an object before a descendant route was interpolated. That produced an incorrect match ID (for example, [object Object]), allowing a cached match to restore stale parsed params and loader data.

The fix preserves raw params for match identity while maintaining a separate parsed-param snapshot. It still calls interpolatePath once per route and does not require stringifying params without route context. The tuple contract removes repeated object keys and the rawParams label documents the invariant at each internal consumer.

Validation

  • Affected test:unit: 30 projects passed
  • Affected test:types: 40 projects passed across supported TypeScript versions
  • Affected test:eslint: 32 projects passed
  • SSR adjacent A/B benchmark: effectively flat (+0.16%)
  • Loader-heavy client benchmark: effectively flat
  • Structured-param fix nested-client benchmark: low-single-digit variance (~3%)
  • Tuple-only nested-client A/B: 74.92 -> 77.46 ops/s (+3.4%, within low-single-digit error margins)
  • Structured-param fix bundle delta: aggregate gzip -108 B, raw -627 B, Brotli -26 B
  • Tuple-only bundle delta: all 17 scenarios improved; aggregate gzip -623 B, initial gzip -619 B, raw -2,886 B, Brotli -664 B

Fixes#7964, Fixes#7731

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where revisiting routes with structured parameters could retain stale parsed parameters or loader data.
    • Ensured route URLs, parsed parameters, and loader results refresh correctly when navigating between different parameter values.
    • Improved route matching and navigation state handling across supported router integrations.
  • Tests

    • Added regression coverage for structured parameter parsing, navigation, and loader data refreshes across React and Solid Router.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The route matcher now separates raw URL parameters from parsed parameters and preserves parsed values across reused matches. Matching callers use the new tuple result. React and Solid tests verify refreshed parameters and loader data after revisiting routes.

Changes

Parsed parameter refresh

Layer / File(s)Summary
Route matching parameter propagation
packages/router-core/src/router.ts
matchRoutesInternal accumulates parsed parameters without mutating raw URL parameters. Matching results now return [matchedRoutes, rawParams, foundRoute].
Matching result integration
packages/react-router/src/useBlocker.tsx, packages/solid-router/src/useBlocker.tsx, packages/vue-router/src/useBlocker.tsx, packages/start-server-core/src/createStartHandler.ts, packages/router-core/src/router.ts, packages/router-plugin/tests/handle-route-update.test.ts
Blocker resolution, server middleware context, destination resolution, path validation, and route-update assertions use tuple-based matching results.
Repeated navigation regression coverage
packages/react-router/tests/issue-7964-param-parsing-loader.test.tsx, packages/solid-router/tests/issue-7964-param-parsing-loader.test.tsx
Tests verify structured parameter parsing, stringification, loader results, and refreshed values after revisiting routes with different parameters.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
participant User
participant Router
participant RouteLoader
participant View
User->>Router: Navigate with new URL parameters
Router->>Router: Match routes and parse parameters
Router->>RouteLoader: Load data with parsed parameters
RouteLoader-->>Router: Return refreshed loader data
Router-->>View: Render parsed parameters and loader data
Loading

Possibly related PRs

  • TanStack/router#7805: Both changes modify route-matching behavior in packages/router-core/src/router.ts, while that PR focuses on lane loading.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedThe changes preserve raw parameters, refresh parsed parameters and loader data, and add regression tests for issue #7964.
Out of Scope Changes check✅ PassedThe tuple refactor, framework updates, and regression tests support the linked issue and stated route-matching objectives.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main change: preserving raw parameters to maintain route match identity.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-7964-structured-params

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 1ad6a52

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 41sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 13sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 18:57:08 UTC

@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 393cefdb931d
  • Measured at: 2026-08-05T18:47:05.742Z
  • Baseline source: history:790e06282030
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.08 KiB-22 B (-0.02%)86.95 KiB269.10 KiB75.84 KiB██████▂▂▂▂▂▁
react-router.full90.88 KiB-39 B (-0.04%)90.74 KiB281.06 KiB79.11 KiB██████▂▂▂▂▂▁
solid-router.minimal34.80 KiB-58 B (-0.16%)34.67 KiB99.97 KiB31.39 KiB██████▂▂▂▂▂▁
solid-router.full39.90 KiB-52 B (-0.13%)39.77 KiB115.14 KiB35.92 KiB██████▂▂▂▂▂▁
vue-router.minimal52.10 KiB-50 B (-0.09%)51.96 KiB143.12 KiB46.88 KiB██████▁▁▁▁▁▁
vue-router.full58.05 KiB-47 B (-0.08%)57.92 KiB161.79 KiB52.08 KiB██████▁▁▁▁▁▁
react-start.minimal100.58 KiB-40 B (-0.04%)100.45 KiB312.26 KiB87.34 KiB█████████▁▁▁
react-start.deferred-hydration101.32 KiB-34 B (-0.03%)100.47 KiB313.63 KiB88.06 KiB█████████▁▁▁
react-start.full103.90 KiB-48 B (-0.05%)103.76 KiB322.21 KiB90.29 KiB█████████▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.76 KiB86.41 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.minimal-iife100.62 KiB-33 B (-0.03%)100.46 KiB317.69 KiB86.73 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.full103.55 KiB-41 B (-0.04%)103.38 KiB326.85 KiB89.05 KiB▁▁▁▁▁▁▃▃▃███
solid-start.minimal48.18 KiB-42 B (-0.09%)48.05 KiB142.11 KiB42.75 KiB█████████▁▁▁
solid-start.deferred-hydration51.44 KiB-39 B (-0.07%)48.11 KiB150.15 KiB45.87 KiB█████████▁▁▁
solid-start.full53.43 KiB-52 B (-0.09%)53.30 KiB157.84 KiB47.39 KiB██████▆▆▆▁▁▁
vue-start.minimal68.97 KiB-47 B (-0.07%)68.84 KiB195.12 KiB61.27 KiB██████▆▆▆▁▁▁
vue-start.full72.93 KiB-57 B (-0.08%)72.80 KiB207.62 KiB64.74 KiB██████▆▆▆▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7966

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7966

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7966

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7966

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7966

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7966

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7966

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7966

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7966

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7966

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7966

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7966

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7966

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7966

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7966

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7966

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7966

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7966

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7966

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7966

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7966

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7966

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7966

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7966

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7966

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7966

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7966

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7966

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7966

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7966

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7966

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7966

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7966

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7966

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7966

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7966

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7966

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7966

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7966

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7966

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7966

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7966

commit: e408463

@codspeed-hq

codspeed-hqBot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 0.83%

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 12 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 163 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem client navigation-churn (solid)617.6 KB536.4 KB+15.14%
Simulationssr assets linked-css control (solid)71.9 ms68 ms+5.78%
Simulationssr loaders (react)64.6 ms61.4 ms+5.2%
Memorymem server error-paths redirect (vue)965.1 KB918.2 KB+5.11%
Simulationssr control-flow unmatched 404 (react)59.7 ms56.9 ms+4.86%
Memorymem server server-fn-churn (react)276.2 KB263.5 KB+4.8%
Simulationclient-control-flow navigation loop (vue)58 ms55.5 ms+4.52%
Simulationssr loaders (solid)75.4 ms72.3 ms+4.33%
Memorymem server error-paths redirect (react)203.7 KB196.6 KB+3.62%
Simulationclient-side navigation loop (vue)72.7 ms70.2 ms+3.6%
Simulationssr control-flow unmatched 404 (solid)70.4 ms68 ms+3.53%
Memorymem server error-paths not-found (vue)331.8 KB321.6 KB+3.17%
👁Simulationssr control-flow route headers (solid)71.5 ms73.8 ms-3.04%
👁Simulationclient-search-params navigation loop (react)75.4 ms79.2 ms-4.79%
👁Memorymem server error-paths unmatched (react)318.5 KB564.3 KB-43.56%
👁Simulationclient-history navigation loop (vue)44 ms46.9 ms-6.25%
👁Simulationclient-search-params navigation loop (vue)91.4 ms95.1 ms-3.9%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fix-7964-structured-params (e408463) with main (790e062)

Open in CodSpeed

@Sheraff
Sheraff merged commit 07a3d10 into mainAug 5, 2026
26 checks passed
@Sheraff
Sheraff deleted the codex/fix-7964-structured-params branch August 5, 2026 19:41
@SheraffSheraff mentioned this pull request Aug 5, 2026
Sheraff added a commit that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(router): preserve raw params for match identity - #7966

Merged
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params
Aug 5, 2026
Merged

fix(router): preserve raw params for match identity#7966
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Keep URL-derived route params in their raw string form throughout route matching and interpolation.
  • Carry parsed ancestor params separately when constructing or reusing matches.
  • Return getMatchedRoutes as a labeled tuple and name the unparsed value rawParams throughout its consumers.
  • Add public-API regression coverage for React Router and Solid Router that verifies the URL, rendered params, and loader data across cached navigation.

Root cause

matchRoutesInternal reused the same object for raw URL params and parsed params. A structured params.parse result could therefore replace a path-param string with an object before a descendant route was interpolated. That produced an incorrect match ID (for example, [object Object]), allowing a cached match to restore stale parsed params and loader data.

The fix preserves raw params for match identity while maintaining a separate parsed-param snapshot. It still calls interpolatePath once per route and does not require stringifying params without route context. The tuple contract removes repeated object keys and the rawParams label documents the invariant at each internal consumer.

Validation

  • Affected test:unit: 30 projects passed
  • Affected test:types: 40 projects passed across supported TypeScript versions
  • Affected test:eslint: 32 projects passed
  • SSR adjacent A/B benchmark: effectively flat (+0.16%)
  • Loader-heavy client benchmark: effectively flat
  • Structured-param fix nested-client benchmark: low-single-digit variance (~3%)
  • Tuple-only nested-client A/B: 74.92 -> 77.46 ops/s (+3.4%, within low-single-digit error margins)
  • Structured-param fix bundle delta: aggregate gzip -108 B, raw -627 B, Brotli -26 B
  • Tuple-only bundle delta: all 17 scenarios improved; aggregate gzip -623 B, initial gzip -619 B, raw -2,886 B, Brotli -664 B

Fixes#7964, Fixes#7731

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where revisiting routes with structured parameters could retain stale parsed parameters or loader data.
    • Ensured route URLs, parsed parameters, and loader results refresh correctly when navigating between different parameter values.
    • Improved route matching and navigation state handling across supported router integrations.
  • Tests

    • Added regression coverage for structured parameter parsing, navigation, and loader data refreshes across React and Solid Router.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The route matcher now separates raw URL parameters from parsed parameters and preserves parsed values across reused matches. Matching callers use the new tuple result. React and Solid tests verify refreshed parameters and loader data after revisiting routes.

Changes

Parsed parameter refresh

Layer / File(s)Summary
Route matching parameter propagation
packages/router-core/src/router.ts
matchRoutesInternal accumulates parsed parameters without mutating raw URL parameters. Matching results now return [matchedRoutes, rawParams, foundRoute].
Matching result integration
packages/react-router/src/useBlocker.tsx, packages/solid-router/src/useBlocker.tsx, packages/vue-router/src/useBlocker.tsx, packages/start-server-core/src/createStartHandler.ts, packages/router-core/src/router.ts, packages/router-plugin/tests/handle-route-update.test.ts
Blocker resolution, server middleware context, destination resolution, path validation, and route-update assertions use tuple-based matching results.
Repeated navigation regression coverage
packages/react-router/tests/issue-7964-param-parsing-loader.test.tsx, packages/solid-router/tests/issue-7964-param-parsing-loader.test.tsx
Tests verify structured parameter parsing, stringification, loader results, and refreshed values after revisiting routes with different parameters.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
participant User
participant Router
participant RouteLoader
participant View
User->>Router: Navigate with new URL parameters
Router->>Router: Match routes and parse parameters
Router->>RouteLoader: Load data with parsed parameters
RouteLoader-->>Router: Return refreshed loader data
Router-->>View: Render parsed parameters and loader data
Loading

Possibly related PRs

  • TanStack/router#7805: Both changes modify route-matching behavior in packages/router-core/src/router.ts, while that PR focuses on lane loading.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedThe changes preserve raw parameters, refresh parsed parameters and loader data, and add regression tests for issue #7964.
Out of Scope Changes check✅ PassedThe tuple refactor, framework updates, and regression tests support the linked issue and stated route-matching objectives.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main change: preserving raw parameters to maintain route match identity.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-7964-structured-params

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 1ad6a52

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 41sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 13sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 18:57:08 UTC

@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 393cefdb931d
  • Measured at: 2026-08-05T18:47:05.742Z
  • Baseline source: history:790e06282030
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.08 KiB-22 B (-0.02%)86.95 KiB269.10 KiB75.84 KiB██████▂▂▂▂▂▁
react-router.full90.88 KiB-39 B (-0.04%)90.74 KiB281.06 KiB79.11 KiB██████▂▂▂▂▂▁
solid-router.minimal34.80 KiB-58 B (-0.16%)34.67 KiB99.97 KiB31.39 KiB██████▂▂▂▂▂▁
solid-router.full39.90 KiB-52 B (-0.13%)39.77 KiB115.14 KiB35.92 KiB██████▂▂▂▂▂▁
vue-router.minimal52.10 KiB-50 B (-0.09%)51.96 KiB143.12 KiB46.88 KiB██████▁▁▁▁▁▁
vue-router.full58.05 KiB-47 B (-0.08%)57.92 KiB161.79 KiB52.08 KiB██████▁▁▁▁▁▁
react-start.minimal100.58 KiB-40 B (-0.04%)100.45 KiB312.26 KiB87.34 KiB█████████▁▁▁
react-start.deferred-hydration101.32 KiB-34 B (-0.03%)100.47 KiB313.63 KiB88.06 KiB█████████▁▁▁
react-start.full103.90 KiB-48 B (-0.05%)103.76 KiB322.21 KiB90.29 KiB█████████▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.76 KiB86.41 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.minimal-iife100.62 KiB-33 B (-0.03%)100.46 KiB317.69 KiB86.73 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.full103.55 KiB-41 B (-0.04%)103.38 KiB326.85 KiB89.05 KiB▁▁▁▁▁▁▃▃▃███
solid-start.minimal48.18 KiB-42 B (-0.09%)48.05 KiB142.11 KiB42.75 KiB█████████▁▁▁
solid-start.deferred-hydration51.44 KiB-39 B (-0.07%)48.11 KiB150.15 KiB45.87 KiB█████████▁▁▁
solid-start.full53.43 KiB-52 B (-0.09%)53.30 KiB157.84 KiB47.39 KiB██████▆▆▆▁▁▁
vue-start.minimal68.97 KiB-47 B (-0.07%)68.84 KiB195.12 KiB61.27 KiB██████▆▆▆▁▁▁
vue-start.full72.93 KiB-57 B (-0.08%)72.80 KiB207.62 KiB64.74 KiB██████▆▆▆▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7966

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7966

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7966

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7966

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7966

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7966

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7966

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7966

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7966

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7966

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7966

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7966

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7966

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7966

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7966

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7966

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7966

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7966

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7966

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7966

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7966

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7966

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7966

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7966

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7966

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7966

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7966

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7966

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7966

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7966

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7966

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7966

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7966

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7966

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7966

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7966

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7966

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7966

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7966

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7966

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7966

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7966

commit: e408463

@codspeed-hq

codspeed-hqBot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 0.83%

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 12 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 163 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem client navigation-churn (solid)617.6 KB536.4 KB+15.14%
Simulationssr assets linked-css control (solid)71.9 ms68 ms+5.78%
Simulationssr loaders (react)64.6 ms61.4 ms+5.2%
Memorymem server error-paths redirect (vue)965.1 KB918.2 KB+5.11%
Simulationssr control-flow unmatched 404 (react)59.7 ms56.9 ms+4.86%
Memorymem server server-fn-churn (react)276.2 KB263.5 KB+4.8%
Simulationclient-control-flow navigation loop (vue)58 ms55.5 ms+4.52%
Simulationssr loaders (solid)75.4 ms72.3 ms+4.33%
Memorymem server error-paths redirect (react)203.7 KB196.6 KB+3.62%
Simulationclient-side navigation loop (vue)72.7 ms70.2 ms+3.6%
Simulationssr control-flow unmatched 404 (solid)70.4 ms68 ms+3.53%
Memorymem server error-paths not-found (vue)331.8 KB321.6 KB+3.17%
👁Simulationssr control-flow route headers (solid)71.5 ms73.8 ms-3.04%
👁Simulationclient-search-params navigation loop (react)75.4 ms79.2 ms-4.79%
👁Memorymem server error-paths unmatched (react)318.5 KB564.3 KB-43.56%
👁Simulationclient-history navigation loop (vue)44 ms46.9 ms-6.25%
👁Simulationclient-search-params navigation loop (vue)91.4 ms95.1 ms-3.9%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fix-7964-structured-params (e408463) with main (790e062)

Open in CodSpeed

@Sheraff
Sheraff merged commit 07a3d10 into mainAug 5, 2026
26 checks passed
@Sheraff
Sheraff deleted the codex/fix-7964-structured-params branch August 5, 2026 19:41
@SheraffSheraff mentioned this pull request Aug 5, 2026
Sheraff added a commit that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(router): preserve raw params for match identity - #7966

Merged
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params
Aug 5, 2026
Merged

fix(router): preserve raw params for match identity#7966
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Keep URL-derived route params in their raw string form throughout route matching and interpolation.
  • Carry parsed ancestor params separately when constructing or reusing matches.
  • Return getMatchedRoutes as a labeled tuple and name the unparsed value rawParams throughout its consumers.
  • Add public-API regression coverage for React Router and Solid Router that verifies the URL, rendered params, and loader data across cached navigation.

Root cause

matchRoutesInternal reused the same object for raw URL params and parsed params. A structured params.parse result could therefore replace a path-param string with an object before a descendant route was interpolated. That produced an incorrect match ID (for example, [object Object]), allowing a cached match to restore stale parsed params and loader data.

The fix preserves raw params for match identity while maintaining a separate parsed-param snapshot. It still calls interpolatePath once per route and does not require stringifying params without route context. The tuple contract removes repeated object keys and the rawParams label documents the invariant at each internal consumer.

Validation

  • Affected test:unit: 30 projects passed
  • Affected test:types: 40 projects passed across supported TypeScript versions
  • Affected test:eslint: 32 projects passed
  • SSR adjacent A/B benchmark: effectively flat (+0.16%)
  • Loader-heavy client benchmark: effectively flat
  • Structured-param fix nested-client benchmark: low-single-digit variance (~3%)
  • Tuple-only nested-client A/B: 74.92 -> 77.46 ops/s (+3.4%, within low-single-digit error margins)
  • Structured-param fix bundle delta: aggregate gzip -108 B, raw -627 B, Brotli -26 B
  • Tuple-only bundle delta: all 17 scenarios improved; aggregate gzip -623 B, initial gzip -619 B, raw -2,886 B, Brotli -664 B

Fixes#7964, Fixes#7731

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where revisiting routes with structured parameters could retain stale parsed parameters or loader data.
    • Ensured route URLs, parsed parameters, and loader results refresh correctly when navigating between different parameter values.
    • Improved route matching and navigation state handling across supported router integrations.
  • Tests

    • Added regression coverage for structured parameter parsing, navigation, and loader data refreshes across React and Solid Router.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The route matcher now separates raw URL parameters from parsed parameters and preserves parsed values across reused matches. Matching callers use the new tuple result. React and Solid tests verify refreshed parameters and loader data after revisiting routes.

Changes

Parsed parameter refresh

Layer / File(s)Summary
Route matching parameter propagation
packages/router-core/src/router.ts
matchRoutesInternal accumulates parsed parameters without mutating raw URL parameters. Matching results now return [matchedRoutes, rawParams, foundRoute].
Matching result integration
packages/react-router/src/useBlocker.tsx, packages/solid-router/src/useBlocker.tsx, packages/vue-router/src/useBlocker.tsx, packages/start-server-core/src/createStartHandler.ts, packages/router-core/src/router.ts, packages/router-plugin/tests/handle-route-update.test.ts
Blocker resolution, server middleware context, destination resolution, path validation, and route-update assertions use tuple-based matching results.
Repeated navigation regression coverage
packages/react-router/tests/issue-7964-param-parsing-loader.test.tsx, packages/solid-router/tests/issue-7964-param-parsing-loader.test.tsx
Tests verify structured parameter parsing, stringification, loader results, and refreshed values after revisiting routes with different parameters.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
participant User
participant Router
participant RouteLoader
participant View
User->>Router: Navigate with new URL parameters
Router->>Router: Match routes and parse parameters
Router->>RouteLoader: Load data with parsed parameters
RouteLoader-->>Router: Return refreshed loader data
Router-->>View: Render parsed parameters and loader data
Loading

Possibly related PRs

  • TanStack/router#7805: Both changes modify route-matching behavior in packages/router-core/src/router.ts, while that PR focuses on lane loading.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedThe changes preserve raw parameters, refresh parsed parameters and loader data, and add regression tests for issue #7964.
Out of Scope Changes check✅ PassedThe tuple refactor, framework updates, and regression tests support the linked issue and stated route-matching objectives.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main change: preserving raw parameters to maintain route match identity.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-7964-structured-params

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 1ad6a52

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 41sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 13sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 18:57:08 UTC

@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 393cefdb931d
  • Measured at: 2026-08-05T18:47:05.742Z
  • Baseline source: history:790e06282030
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.08 KiB-22 B (-0.02%)86.95 KiB269.10 KiB75.84 KiB██████▂▂▂▂▂▁
react-router.full90.88 KiB-39 B (-0.04%)90.74 KiB281.06 KiB79.11 KiB██████▂▂▂▂▂▁
solid-router.minimal34.80 KiB-58 B (-0.16%)34.67 KiB99.97 KiB31.39 KiB██████▂▂▂▂▂▁
solid-router.full39.90 KiB-52 B (-0.13%)39.77 KiB115.14 KiB35.92 KiB██████▂▂▂▂▂▁
vue-router.minimal52.10 KiB-50 B (-0.09%)51.96 KiB143.12 KiB46.88 KiB██████▁▁▁▁▁▁
vue-router.full58.05 KiB-47 B (-0.08%)57.92 KiB161.79 KiB52.08 KiB██████▁▁▁▁▁▁
react-start.minimal100.58 KiB-40 B (-0.04%)100.45 KiB312.26 KiB87.34 KiB█████████▁▁▁
react-start.deferred-hydration101.32 KiB-34 B (-0.03%)100.47 KiB313.63 KiB88.06 KiB█████████▁▁▁
react-start.full103.90 KiB-48 B (-0.05%)103.76 KiB322.21 KiB90.29 KiB█████████▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.76 KiB86.41 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.minimal-iife100.62 KiB-33 B (-0.03%)100.46 KiB317.69 KiB86.73 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.full103.55 KiB-41 B (-0.04%)103.38 KiB326.85 KiB89.05 KiB▁▁▁▁▁▁▃▃▃███
solid-start.minimal48.18 KiB-42 B (-0.09%)48.05 KiB142.11 KiB42.75 KiB█████████▁▁▁
solid-start.deferred-hydration51.44 KiB-39 B (-0.07%)48.11 KiB150.15 KiB45.87 KiB█████████▁▁▁
solid-start.full53.43 KiB-52 B (-0.09%)53.30 KiB157.84 KiB47.39 KiB██████▆▆▆▁▁▁
vue-start.minimal68.97 KiB-47 B (-0.07%)68.84 KiB195.12 KiB61.27 KiB██████▆▆▆▁▁▁
vue-start.full72.93 KiB-57 B (-0.08%)72.80 KiB207.62 KiB64.74 KiB██████▆▆▆▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7966

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7966

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7966

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7966

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7966

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7966

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7966

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7966

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7966

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7966

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7966

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7966

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7966

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7966

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7966

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7966

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7966

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7966

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7966

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7966

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7966

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7966

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7966

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7966

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7966

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7966

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7966

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7966

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7966

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7966

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7966

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7966

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7966

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7966

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7966

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7966

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7966

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7966

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7966

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7966

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7966

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7966

commit: e408463

@codspeed-hq

codspeed-hqBot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 0.83%

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 12 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 163 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem client navigation-churn (solid)617.6 KB536.4 KB+15.14%
Simulationssr assets linked-css control (solid)71.9 ms68 ms+5.78%
Simulationssr loaders (react)64.6 ms61.4 ms+5.2%
Memorymem server error-paths redirect (vue)965.1 KB918.2 KB+5.11%
Simulationssr control-flow unmatched 404 (react)59.7 ms56.9 ms+4.86%
Memorymem server server-fn-churn (react)276.2 KB263.5 KB+4.8%
Simulationclient-control-flow navigation loop (vue)58 ms55.5 ms+4.52%
Simulationssr loaders (solid)75.4 ms72.3 ms+4.33%
Memorymem server error-paths redirect (react)203.7 KB196.6 KB+3.62%
Simulationclient-side navigation loop (vue)72.7 ms70.2 ms+3.6%
Simulationssr control-flow unmatched 404 (solid)70.4 ms68 ms+3.53%
Memorymem server error-paths not-found (vue)331.8 KB321.6 KB+3.17%
👁Simulationssr control-flow route headers (solid)71.5 ms73.8 ms-3.04%
👁Simulationclient-search-params navigation loop (react)75.4 ms79.2 ms-4.79%
👁Memorymem server error-paths unmatched (react)318.5 KB564.3 KB-43.56%
👁Simulationclient-history navigation loop (vue)44 ms46.9 ms-6.25%
👁Simulationclient-search-params navigation loop (vue)91.4 ms95.1 ms-3.9%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fix-7964-structured-params (e408463) with main (790e062)

Open in CodSpeed

@Sheraff
Sheraff merged commit 07a3d10 into mainAug 5, 2026
26 checks passed
@Sheraff
Sheraff deleted the codex/fix-7964-structured-params branch August 5, 2026 19:41
@SheraffSheraff mentioned this pull request Aug 5, 2026
Sheraff added a commit that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(router): preserve raw params for match identity - #7966

Merged
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params
Aug 5, 2026
Merged

fix(router): preserve raw params for match identity#7966
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Keep URL-derived route params in their raw string form throughout route matching and interpolation.
  • Carry parsed ancestor params separately when constructing or reusing matches.
  • Return getMatchedRoutes as a labeled tuple and name the unparsed value rawParams throughout its consumers.
  • Add public-API regression coverage for React Router and Solid Router that verifies the URL, rendered params, and loader data across cached navigation.

Root cause

matchRoutesInternal reused the same object for raw URL params and parsed params. A structured params.parse result could therefore replace a path-param string with an object before a descendant route was interpolated. That produced an incorrect match ID (for example, [object Object]), allowing a cached match to restore stale parsed params and loader data.

The fix preserves raw params for match identity while maintaining a separate parsed-param snapshot. It still calls interpolatePath once per route and does not require stringifying params without route context. The tuple contract removes repeated object keys and the rawParams label documents the invariant at each internal consumer.

Validation

  • Affected test:unit: 30 projects passed
  • Affected test:types: 40 projects passed across supported TypeScript versions
  • Affected test:eslint: 32 projects passed
  • SSR adjacent A/B benchmark: effectively flat (+0.16%)
  • Loader-heavy client benchmark: effectively flat
  • Structured-param fix nested-client benchmark: low-single-digit variance (~3%)
  • Tuple-only nested-client A/B: 74.92 -> 77.46 ops/s (+3.4%, within low-single-digit error margins)
  • Structured-param fix bundle delta: aggregate gzip -108 B, raw -627 B, Brotli -26 B
  • Tuple-only bundle delta: all 17 scenarios improved; aggregate gzip -623 B, initial gzip -619 B, raw -2,886 B, Brotli -664 B

Fixes#7964, Fixes#7731

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where revisiting routes with structured parameters could retain stale parsed parameters or loader data.
    • Ensured route URLs, parsed parameters, and loader results refresh correctly when navigating between different parameter values.
    • Improved route matching and navigation state handling across supported router integrations.
  • Tests

    • Added regression coverage for structured parameter parsing, navigation, and loader data refreshes across React and Solid Router.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The route matcher now separates raw URL parameters from parsed parameters and preserves parsed values across reused matches. Matching callers use the new tuple result. React and Solid tests verify refreshed parameters and loader data after revisiting routes.

Changes

Parsed parameter refresh

Layer / File(s)Summary
Route matching parameter propagation
packages/router-core/src/router.ts
matchRoutesInternal accumulates parsed parameters without mutating raw URL parameters. Matching results now return [matchedRoutes, rawParams, foundRoute].
Matching result integration
packages/react-router/src/useBlocker.tsx, packages/solid-router/src/useBlocker.tsx, packages/vue-router/src/useBlocker.tsx, packages/start-server-core/src/createStartHandler.ts, packages/router-core/src/router.ts, packages/router-plugin/tests/handle-route-update.test.ts
Blocker resolution, server middleware context, destination resolution, path validation, and route-update assertions use tuple-based matching results.
Repeated navigation regression coverage
packages/react-router/tests/issue-7964-param-parsing-loader.test.tsx, packages/solid-router/tests/issue-7964-param-parsing-loader.test.tsx
Tests verify structured parameter parsing, stringification, loader results, and refreshed values after revisiting routes with different parameters.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
participant User
participant Router
participant RouteLoader
participant View
User->>Router: Navigate with new URL parameters
Router->>Router: Match routes and parse parameters
Router->>RouteLoader: Load data with parsed parameters
RouteLoader-->>Router: Return refreshed loader data
Router-->>View: Render parsed parameters and loader data
Loading

Possibly related PRs

  • TanStack/router#7805: Both changes modify route-matching behavior in packages/router-core/src/router.ts, while that PR focuses on lane loading.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedThe changes preserve raw parameters, refresh parsed parameters and loader data, and add regression tests for issue #7964.
Out of Scope Changes check✅ PassedThe tuple refactor, framework updates, and regression tests support the linked issue and stated route-matching objectives.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main change: preserving raw parameters to maintain route match identity.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-7964-structured-params

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 1ad6a52

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 41sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 13sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 18:57:08 UTC

@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 393cefdb931d
  • Measured at: 2026-08-05T18:47:05.742Z
  • Baseline source: history:790e06282030
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.08 KiB-22 B (-0.02%)86.95 KiB269.10 KiB75.84 KiB██████▂▂▂▂▂▁
react-router.full90.88 KiB-39 B (-0.04%)90.74 KiB281.06 KiB79.11 KiB██████▂▂▂▂▂▁
solid-router.minimal34.80 KiB-58 B (-0.16%)34.67 KiB99.97 KiB31.39 KiB██████▂▂▂▂▂▁
solid-router.full39.90 KiB-52 B (-0.13%)39.77 KiB115.14 KiB35.92 KiB██████▂▂▂▂▂▁
vue-router.minimal52.10 KiB-50 B (-0.09%)51.96 KiB143.12 KiB46.88 KiB██████▁▁▁▁▁▁
vue-router.full58.05 KiB-47 B (-0.08%)57.92 KiB161.79 KiB52.08 KiB██████▁▁▁▁▁▁
react-start.minimal100.58 KiB-40 B (-0.04%)100.45 KiB312.26 KiB87.34 KiB█████████▁▁▁
react-start.deferred-hydration101.32 KiB-34 B (-0.03%)100.47 KiB313.63 KiB88.06 KiB█████████▁▁▁
react-start.full103.90 KiB-48 B (-0.05%)103.76 KiB322.21 KiB90.29 KiB█████████▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.76 KiB86.41 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.minimal-iife100.62 KiB-33 B (-0.03%)100.46 KiB317.69 KiB86.73 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.full103.55 KiB-41 B (-0.04%)103.38 KiB326.85 KiB89.05 KiB▁▁▁▁▁▁▃▃▃███
solid-start.minimal48.18 KiB-42 B (-0.09%)48.05 KiB142.11 KiB42.75 KiB█████████▁▁▁
solid-start.deferred-hydration51.44 KiB-39 B (-0.07%)48.11 KiB150.15 KiB45.87 KiB█████████▁▁▁
solid-start.full53.43 KiB-52 B (-0.09%)53.30 KiB157.84 KiB47.39 KiB██████▆▆▆▁▁▁
vue-start.minimal68.97 KiB-47 B (-0.07%)68.84 KiB195.12 KiB61.27 KiB██████▆▆▆▁▁▁
vue-start.full72.93 KiB-57 B (-0.08%)72.80 KiB207.62 KiB64.74 KiB██████▆▆▆▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7966

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7966

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7966

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7966

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7966

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7966

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7966

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7966

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7966

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7966

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7966

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7966

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7966

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7966

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7966

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7966

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7966

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7966

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7966

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7966

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7966

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7966

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7966

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7966

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7966

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7966

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7966

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7966

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7966

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7966

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7966

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7966

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7966

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7966

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7966

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7966

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7966

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7966

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7966

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7966

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7966

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7966

commit: e408463

@codspeed-hq

codspeed-hqBot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 0.83%

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 12 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 163 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem client navigation-churn (solid)617.6 KB536.4 KB+15.14%
Simulationssr assets linked-css control (solid)71.9 ms68 ms+5.78%
Simulationssr loaders (react)64.6 ms61.4 ms+5.2%
Memorymem server error-paths redirect (vue)965.1 KB918.2 KB+5.11%
Simulationssr control-flow unmatched 404 (react)59.7 ms56.9 ms+4.86%
Memorymem server server-fn-churn (react)276.2 KB263.5 KB+4.8%
Simulationclient-control-flow navigation loop (vue)58 ms55.5 ms+4.52%
Simulationssr loaders (solid)75.4 ms72.3 ms+4.33%
Memorymem server error-paths redirect (react)203.7 KB196.6 KB+3.62%
Simulationclient-side navigation loop (vue)72.7 ms70.2 ms+3.6%
Simulationssr control-flow unmatched 404 (solid)70.4 ms68 ms+3.53%
Memorymem server error-paths not-found (vue)331.8 KB321.6 KB+3.17%
👁Simulationssr control-flow route headers (solid)71.5 ms73.8 ms-3.04%
👁Simulationclient-search-params navigation loop (react)75.4 ms79.2 ms-4.79%
👁Memorymem server error-paths unmatched (react)318.5 KB564.3 KB-43.56%
👁Simulationclient-history navigation loop (vue)44 ms46.9 ms-6.25%
👁Simulationclient-search-params navigation loop (vue)91.4 ms95.1 ms-3.9%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fix-7964-structured-params (e408463) with main (790e062)

Open in CodSpeed

@Sheraff
Sheraff merged commit 07a3d10 into mainAug 5, 2026
26 checks passed
@Sheraff
Sheraff deleted the codex/fix-7964-structured-params branch August 5, 2026 19:41
@SheraffSheraff mentioned this pull request Aug 5, 2026
Sheraff added a commit that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant

@Sheraff
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(router): preserve raw params for match identity - #7966

Merged
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params
Aug 5, 2026
Merged

fix(router): preserve raw params for match identity#7966
Sheraff merged 3 commits into
mainfrom
codex/fix-7964-structured-params

Conversation

@Sheraff

@SheraffSheraff commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Keep URL-derived route params in their raw string form throughout route matching and interpolation.
  • Carry parsed ancestor params separately when constructing or reusing matches.
  • Return getMatchedRoutes as a labeled tuple and name the unparsed value rawParams throughout its consumers.
  • Add public-API regression coverage for React Router and Solid Router that verifies the URL, rendered params, and loader data across cached navigation.

Root cause

matchRoutesInternal reused the same object for raw URL params and parsed params. A structured params.parse result could therefore replace a path-param string with an object before a descendant route was interpolated. That produced an incorrect match ID (for example, [object Object]), allowing a cached match to restore stale parsed params and loader data.

The fix preserves raw params for match identity while maintaining a separate parsed-param snapshot. It still calls interpolatePath once per route and does not require stringifying params without route context. The tuple contract removes repeated object keys and the rawParams label documents the invariant at each internal consumer.

Validation

  • Affected test:unit: 30 projects passed
  • Affected test:types: 40 projects passed across supported TypeScript versions
  • Affected test:eslint: 32 projects passed
  • SSR adjacent A/B benchmark: effectively flat (+0.16%)
  • Loader-heavy client benchmark: effectively flat
  • Structured-param fix nested-client benchmark: low-single-digit variance (~3%)
  • Tuple-only nested-client A/B: 74.92 -> 77.46 ops/s (+3.4%, within low-single-digit error margins)
  • Structured-param fix bundle delta: aggregate gzip -108 B, raw -627 B, Brotli -26 B
  • Tuple-only bundle delta: all 17 scenarios improved; aggregate gzip -623 B, initial gzip -619 B, raw -2,886 B, Brotli -664 B

Fixes#7964, Fixes#7731

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an issue where revisiting routes with structured parameters could retain stale parsed parameters or loader data.
    • Ensured route URLs, parsed parameters, and loader results refresh correctly when navigating between different parameter values.
    • Improved route matching and navigation state handling across supported router integrations.
  • Tests

    • Added regression coverage for structured parameter parsing, navigation, and loader data refreshes across React and Solid Router.

@coderabbitai

coderabbitaiBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The route matcher now separates raw URL parameters from parsed parameters and preserves parsed values across reused matches. Matching callers use the new tuple result. React and Solid tests verify refreshed parameters and loader data after revisiting routes.

Changes

Parsed parameter refresh

Layer / File(s)Summary
Route matching parameter propagation
packages/router-core/src/router.ts
matchRoutesInternal accumulates parsed parameters without mutating raw URL parameters. Matching results now return [matchedRoutes, rawParams, foundRoute].
Matching result integration
packages/react-router/src/useBlocker.tsx, packages/solid-router/src/useBlocker.tsx, packages/vue-router/src/useBlocker.tsx, packages/start-server-core/src/createStartHandler.ts, packages/router-core/src/router.ts, packages/router-plugin/tests/handle-route-update.test.ts
Blocker resolution, server middleware context, destination resolution, path validation, and route-update assertions use tuple-based matching results.
Repeated navigation regression coverage
packages/react-router/tests/issue-7964-param-parsing-loader.test.tsx, packages/solid-router/tests/issue-7964-param-parsing-loader.test.tsx
Tests verify structured parameter parsing, stringification, loader results, and refreshed values after revisiting routes with different parameters.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
participant User
participant Router
participant RouteLoader
participant View
User->>Router: Navigate with new URL parameters
Router->>Router: Match routes and parse parameters
Router->>RouteLoader: Load data with parsed parameters
RouteLoader-->>Router: Return refreshed loader data
Router-->>View: Render parsed parameters and loader data
Loading

Possibly related PRs

  • TanStack/router#7805: Both changes modify route-matching behavior in packages/router-core/src/router.ts, while that PR focuses on lane loading.

Suggested reviewers:schiller-manuel

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Linked Issues check✅ PassedThe changes preserve raw parameters, refresh parsed parameters and loader data, and add regression tests for issue #7964.
Out of Scope Changes check✅ PassedThe tuple refactor, framework updates, and regression tests support the linked issue and stated route-matching objectives.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly summarizes the main change: preserving raw parameters to maintain route match identity.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-7964-structured-params

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@nx-cloud

nx-cloudBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 1ad6a52

CommandStatusDurationResult
nx affected --targets=test:eslint,test:unit,tes...✅ Succeeded10m 41sView ↗
nx run-many --target=build --exclude=examples/*...✅ Succeeded2m 13sView ↗

☁️ Nx Cloud last updated this comment at 2026-08-05 18:57:08 UTC

@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 393cefdb931d
  • Measured at: 2026-08-05T18:47:05.742Z
  • Baseline source: history:790e06282030
  • Dashboard: bundle-size history

The following scenarios have bundle-size changes compared with the baseline:

ScenarioCurrent (gzip)Delta vs baselineInitial gzipRawBrotliTrend
react-router.minimal87.08 KiB-22 B (-0.02%)86.95 KiB269.10 KiB75.84 KiB██████▂▂▂▂▂▁
react-router.full90.88 KiB-39 B (-0.04%)90.74 KiB281.06 KiB79.11 KiB██████▂▂▂▂▂▁
solid-router.minimal34.80 KiB-58 B (-0.16%)34.67 KiB99.97 KiB31.39 KiB██████▂▂▂▂▂▁
solid-router.full39.90 KiB-52 B (-0.13%)39.77 KiB115.14 KiB35.92 KiB██████▂▂▂▂▂▁
vue-router.minimal52.10 KiB-50 B (-0.09%)51.96 KiB143.12 KiB46.88 KiB██████▁▁▁▁▁▁
vue-router.full58.05 KiB-47 B (-0.08%)57.92 KiB161.79 KiB52.08 KiB██████▁▁▁▁▁▁
react-start.minimal100.58 KiB-40 B (-0.04%)100.45 KiB312.26 KiB87.34 KiB█████████▁▁▁
react-start.deferred-hydration101.32 KiB-34 B (-0.03%)100.47 KiB313.63 KiB88.06 KiB█████████▁▁▁
react-start.full103.90 KiB-48 B (-0.05%)103.76 KiB322.21 KiB90.29 KiB█████████▁▁▁
react-start.rsbuild.minimal100.21 KiB-30 B (-0.03%)100.04 KiB316.76 KiB86.41 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.minimal-iife100.62 KiB-33 B (-0.03%)100.46 KiB317.69 KiB86.73 KiB▁▁▁▁▁▁▂▂▂███
react-start.rsbuild.full103.55 KiB-41 B (-0.04%)103.38 KiB326.85 KiB89.05 KiB▁▁▁▁▁▁▃▃▃███
solid-start.minimal48.18 KiB-42 B (-0.09%)48.05 KiB142.11 KiB42.75 KiB█████████▁▁▁
solid-start.deferred-hydration51.44 KiB-39 B (-0.07%)48.11 KiB150.15 KiB45.87 KiB█████████▁▁▁
solid-start.full53.43 KiB-52 B (-0.09%)53.30 KiB157.84 KiB47.39 KiB██████▆▆▆▁▁▁
vue-start.minimal68.97 KiB-47 B (-0.07%)68.84 KiB195.12 KiB61.27 KiB██████▆▆▆▁▁▁
vue-start.full72.93 KiB-57 B (-0.08%)72.80 KiB207.62 KiB64.74 KiB██████▆▆▆▁▁▁

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-newBot commented Aug 5, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7966

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7966

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7966

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7966

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7966

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7966

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7966

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7966

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7966

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7966

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7966

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7966

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7966

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7966

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7966

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7966

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7966

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7966

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7966

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7966

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7966

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7966

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7966

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7966

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7966

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7966

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7966

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7966

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7966

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7966

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7966

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7966

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7966

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7966

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7966

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7966

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7966

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7966

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7966

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7966

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7966

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7966

commit: e408463

@codspeed-hq

codspeed-hqBot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 0.83%

⚠️Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 12 improved benchmarks
❌ 5 (👁 5) regressed benchmarks
✅ 163 untouched benchmarks

Performance Changes

ModeBenchmarkBASEHEADEfficiency
Memorymem client navigation-churn (solid)617.6 KB536.4 KB+15.14%
Simulationssr assets linked-css control (solid)71.9 ms68 ms+5.78%
Simulationssr loaders (react)64.6 ms61.4 ms+5.2%
Memorymem server error-paths redirect (vue)965.1 KB918.2 KB+5.11%
Simulationssr control-flow unmatched 404 (react)59.7 ms56.9 ms+4.86%
Memorymem server server-fn-churn (react)276.2 KB263.5 KB+4.8%
Simulationclient-control-flow navigation loop (vue)58 ms55.5 ms+4.52%
Simulationssr loaders (solid)75.4 ms72.3 ms+4.33%
Memorymem server error-paths redirect (react)203.7 KB196.6 KB+3.62%
Simulationclient-side navigation loop (vue)72.7 ms70.2 ms+3.6%
Simulationssr control-flow unmatched 404 (solid)70.4 ms68 ms+3.53%
Memorymem server error-paths not-found (vue)331.8 KB321.6 KB+3.17%
👁Simulationssr control-flow route headers (solid)71.5 ms73.8 ms-3.04%
👁Simulationclient-search-params navigation loop (react)75.4 ms79.2 ms-4.79%
👁Memorymem server error-paths unmatched (react)318.5 KB564.3 KB-43.56%
👁Simulationclient-history navigation loop (vue)44 ms46.9 ms-6.25%
👁Simulationclient-search-params navigation loop (vue)91.4 ms95.1 ms-3.9%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing codex/fix-7964-structured-params (e408463) with main (790e062)

Open in CodSpeed

@Sheraff
Sheraff merged commit 07a3d10 into mainAug 5, 2026
26 checks passed
@Sheraff
Sheraff deleted the codex/fix-7964-structured-params branch August 5, 2026 19:41
@SheraffSheraff mentioned this pull request Aug 5, 2026
Sheraff added a commit that referenced this pull request Aug 5, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant

@Sheraff