Uh oh!
There was an error while loading. Please reload this page.
refactor: extract ACL related functionality - #913
Conversation
vbreuss
commented
Nov 15, 2022
@fgreinacher : |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Peter Baumann <peter.baumann@gmail.com>
Co-authored-by: Peter Baumann <peter.baumann@gmail.com>
fgreinacher
commented
Nov 20, 2022
I'll have a deeper look at this by the middle of the week. @siprbaum Do you want to do another pass? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Replace IFileSystemExtensibility with IFileSystemAclSupport
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vbreuss
commented
Nov 27, 2022
@fgreinacher : |
fgreinacher
commented
Nov 28, 2022
@vbreuss I'd like to push out a clean v18 first. We can then just bump major again for this change, no problem :) |
vbreuss
commented
Nov 28, 2022
@fgreinacher: I merged the latest changes from |
fgreinacher
left a comment
There was a problem hiding this comment.
Thanks for your rework @vbreuss - I like it a lot know.
I have a few small suggestions/questions and then we're good to go 🚀
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
It will break people that are currently mocking the methods on the interface level, so I'd rather bump major to not surprise folks :) Could you bump |
vbreuss
commented
Dec 2, 2022
@fgreinacher : |
fgreinacher
left a comment
There was a problem hiding this comment.
LGTM, thanks @vbreuss 🎉
This is addressed in release v19.0.1. |
This is addressed in release v19.0.1. |
Remove the ACL-Features from the interfaces and instead implement them as extension methods implemented in "TestableIO.System.IO.Abstractions.Wrappers".
This removes the dependency on
System.IO.FileSystem.AccessControlfrom the interface project.This is part of the approach discussed in #883
BREAKING CHANGE: This refactoring removes ACL-related methods from the interface project and replaces them with extension methods in
TestableIO.System.IO.Abstractions.Wrappers.