Uh oh!
There was an error while loading. Please reload this page.
refactor: restructure packages to improve extensibility - #919
Conversation
87b7fce to
4639cf8Compare4639cf8 to
69928d1Comparefgreinacher
commented
Nov 28, 2022
@vbreuss Could you have a quick look at this? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
vbreuss
commented
Nov 28, 2022
@fgreinacher : I finished my review :-) |
ac854ef to
3d47f3bCompareUh oh!
There was an error while loading. Please reload this page.
This change splits the System.IO.Abstractions package into TestableIO.System.IO.Abstractions and TestableIO.System.IO.Abstractions.Wrappers. The former contains just the interfaces and the latter the default wrapper implementations. The package System.IO.Abstractions still exists as meta package to reduce impact on existing users. The same applies to TestableIO.System.IO.Abstractions.TestingHelpers. BREAKING CHANGE: This refactoring moves all types to the TestableIO.System.IO.Abstractions library. Users might need to recompile their libraries. Co-authored-by: Valentin Breuß <vbreuss@gmail.com>
3d47f3b to
2f0122dComparefgreinacher
commented
Nov 28, 2022
Thanks for your comments @vbreuss, ready for round 2️⃣ |
vbreuss
left a comment
There was a problem hiding this comment.
@fgreinacher : Looks good!
What is the Benchmarks project?
Should it also have the "TestableIO" prefix?
It seems I can't resolve conversations or did I just not find the corresponding button?
fgreinacher
commented
Nov 28, 2022
Thanks for the quick review @vbreuss!
It contains some performance benchmarks. I will also add the prefix there!
I guess that's because you're not member of the organization. If you're interested helping out here, just say so and I'll add you as collaborator. |
vbreuss
commented
Nov 28, 2022
@fgreinacher : I would be happy to help out! |
fgreinacher
commented
Dec 1, 2022
Cool thanks, I added you to the project! |
This change splits the System.IO.Abstractions package into TestableIO.System.IO.Abstractions and TestableIO.System.IO.Abstractions.Wrappers. The former contains just the interfaces and the latter the default wrapper implementations. The package System.IO.Abstractions still exists as meta package to reduce impact on existing users. The same applies to TestableIO.System.IO.Abstractions.TestingHelpers.
BREAKING CHANGE: This refactoring moves all types to the TestableIO.System.IO.Abstractions library. Users might need to recompile their libraries.