Uh oh!
There was an error while loading. Please reload this page.
fix(): dep mismatch - #774
Merged
Merged
Conversation
ShaMan123
commented
Jul 24, 2026
| const fragments = this.components.get(FragmentsManager); | ||
| const model = fragments.list.get(result.modelId); | ||
| if (!model) return null; | ||
| const localIds = await (model as any).getLocalIdsFromItemIds([ |
ContributorAuthor
There was a problem hiding this comment.
was masking the bug - lint would have caught this
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes raycaster bug due to version mismtach (
getLocalIdsFromItemIdsnot on frags v3.4.3)related to #737#747#773 - not confirmed as the sole fix
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following:
feat(examples): add hello-world example).fixes #123).