Skip to content

fix(): dep mismatch#774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agviegas merged 1 commit into from
Jul 24, 2026
Merged

fix(): dep mismatch #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -37,7 +37,7 @@
"access": "public"
},
"devDependencies": {
"@thatopen/fragments": "~3.4.3",
"@thatopen/fragments": "~3.4.7",
"@thatopen/ui": "~3.4.0",
"@types/convert-units": "2.3.11",
"@types/three": "0.184.0",
Expand All@@ -52,7 +52,7 @@
"three-mesh-bvh": "0.9.9"
},
"peerDependencies": {
"@thatopen/fragments": "~3.4.0",
"@thatopen/fragments": "~3.4.7",
"camera-controls": ">=3.1.2",
"three": ">=0.182.0",
"web-ifc": ">=0.0.77"
Expand Down
4 changes: 1 addition & 3 deletions packages/core/src/core/FastModelPicker/src/fast-model-picker.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -186,9 +186,7 @@ export class FastModelPicker implements Disposable {
const fragments = this.components.get(FragmentsManager);
const model = fragments.list.get(result.modelId);
if (!model) return null;
const localIds = await (model as any).getLocalIdsFromItemIds([

@ShaMan123ShaMan123Jul 24, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was masking the bug - lint would have caught this

result.itemId,
]);
const localIds = await model.getLocalIdsFromItemIds([result.itemId]);
const localId = localIds?.[0];
if (localId === undefined || localId === null) return null;
return { modelId: result.modelId, localId, itemId: result.itemId };
Expand Down
6 changes: 3 additions & 3 deletions packages/front/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,12 +33,12 @@
"publish-repo": "npm publish"
},
"peerDependencies": {
"@thatopen/fragments": "~3.4.0",
"@thatopen/fragments": "~3.4.7",
"three": ">=0.182.0",
"web-ifc": ">=0.0.77"
},
"devDependencies": {
"@thatopen/fragments": "~3.4.3",
"@thatopen/fragments": "~3.4.7",
"@thatopen/ui": "~3.4.0",
"@thatopen/ui-obc": "~3.4.0",
"@types/convert-units": "2.3.11",
Expand All@@ -48,7 +48,7 @@
"web-ifc": "0.0.77"
},
"dependencies": {
"@thatopen/components": "~3.4.0",
"@thatopen/components": "~3.4.7",
"earcut": "^3.0.1"
}
}
20 changes: 10 additions & 10 deletions yarn.lock
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -737,8 +737,8 @@ __metadata:
version: 0.0.0-use.local
resolution: "@thatopen/components-front@workspace:packages/front"
dependencies:
"@thatopen/components": ~3.4.0
"@thatopen/fragments": ~3.4.3
"@thatopen/components": ~3.4.7
"@thatopen/fragments": ~3.4.7
"@thatopen/ui": ~3.4.0
"@thatopen/ui-obc": ~3.4.0
"@types/convert-units": 2.3.11
Expand All@@ -748,17 +748,17 @@ __metadata:
three: 0.184.0
web-ifc: 0.0.77
peerDependencies:
"@thatopen/fragments": ~3.4.0
"@thatopen/fragments": ~3.4.7
three: ">=0.182.0"
web-ifc: ">=0.0.77"
languageName: unknown
linkType: soft

"@thatopen/components@workspace:packages/core, @thatopen/components@~3.4.0":
"@thatopen/components@workspace:packages/core, @thatopen/components@~3.4.7":
version: 0.0.0-use.local
resolution: "@thatopen/components@workspace:packages/core"
dependencies:
"@thatopen/fragments": ~3.4.3
"@thatopen/fragments": ~3.4.7
"@thatopen/ui": ~3.4.0
"@types/convert-units": 2.3.11
"@types/three": 0.184.0
Expand All@@ -770,16 +770,16 @@ __metadata:
three-mesh-bvh: 0.9.9
web-ifc: 0.0.77
peerDependencies:
"@thatopen/fragments": ~3.4.0
"@thatopen/fragments": ~3.4.7
camera-controls: ">=3.1.2"
three: ">=0.182.0"
web-ifc: ">=0.0.77"
languageName: unknown
linkType: soft

"@thatopen/fragments@npm:~3.4.3":
version: 3.4.3
resolution: "@thatopen/fragments@npm:3.4.3"
"@thatopen/fragments@npm:~3.4.7":
version: 3.4.7
resolution: "@thatopen/fragments@npm:3.4.7"
dependencies:
earcut: ^3.0.1
flatbuffers: 25.2.10
Expand All@@ -788,7 +788,7 @@ __metadata:
peerDependencies:
three: ">=0.182.0"
web-ifc: ">=0.0.77"
checksum: 2e899c2986f6720dacafd41a2a708bd69d720de0e200cdbebddb4ed142ef69c7d77dbb7af37b71d7b1b4b627a56f696174984de0b3d1548d538993ed38066f28
checksum: 66ef8422afcee492d083c5aa4f0003b2847f853f84cea367f3851720202c974dcacf81f26b803f89399f9e1797c73421a2183e7dd18e7858bff458144df60e20
languageName: node
linkType: hard

Expand Down