Skip to content

Add DocTests to diffie.py - #10156

Merged
cclauss merged 4 commits into
TheAlgorithms:masterfrom
SaiHarshaK:u/skottapalli/diffie
Oct 9, 2023
Merged

Add DocTests to diffie.py#10156
cclauss merged 4 commits into
TheAlgorithms:masterfrom
SaiHarshaK:u/skottapalli/diffie

Conversation

@SaiHarshaK

@SaiHarshaKSaiHarshaK commented Oct 9, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

This PR adds DocTests to the functions in diffie.py to increase its codecoverage from 0% to 46%.
Tested this change locally and can verify that they are passing.

Ref #9943

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 9, 2023
@SaiHarshaKSaiHarshaK mentioned this pull request Oct 9, 2023
Comment threadciphers/diffie.py Outdated
Comment threadciphers/diffie.py
@algorithms-keeperalgorithms-keeperBot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Oct 9, 2023
@algorithms-keeperalgorithms-keeperBot added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 9, 2023

@cclausscclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 9, 2023
@cclauss
cclauss merged commit c0da015 into TheAlgorithms:masterOct 9, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementThis PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@SaiHarshaK@cclauss