Skip to content

Consolidate binary exponentiation files - #10742

Merged
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom
tianyizheng02:main
Oct 21, 2023
Merged

Consolidate binary exponentiation files#10742
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom
tianyizheng02:main

Conversation

@tianyizheng02

@tianyizheng02tianyizheng02 commented Oct 21, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

Contributes to #8098

Consolidated implementations of binary (modular) exponentiation into just binary_exponentiation.py

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeperalgorithms-keeperBot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 21, 2023
cclauss
cclauss reviewed Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py

def binary_exp_recursive(base: int, exponent: int) -> int:
"""
Compute a number raised by some quantity

@cclausscclaussOct 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this? exp is a bit cryptic in the function name and a line of documentation here is useful.

cclauss
cclauss reviewed Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
"""
Compute a number raised by some quantity
>>> binary_exponentiation(-1, 3)
>>> binary_exp_recursive(3, 5)

@cclausscclaussOct 21, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about tests for a=big number and n=big number, a=float, n=float?

@tianyizheng02tianyizheng02Oct 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, but the n=float case won't work because the algorithm can only compute integer powers

@cclausscclaussOct 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it won’t work but I wanted to see how it fails. Does it raise a ValueError? Does it behave like pow() does. Testing how things work if half the battle. Watching them fail is just as cool.

cclauss
cclauss reviewed Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py Outdated
RESULT = binary_exponentiation(BASE, POWER)
print(f"{BASE}^({POWER}): {RESULT}")
RESULT = binary_exp_recursive(BASE, POWER)
print(f"{BASE}^({POWER}): {RESULT}")

@cclausscclaussOct 21, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPTIONAL: Adding a timeit benchmark would be a nice addition. Visitors love to see the side-by-side bakeoff.

@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 21, 2023
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Oct 21, 2023
@tianyizheng02
tianyizheng02 merged commit 06edc0e into TheAlgorithms:masterOct 21, 2023
@algorithms-keeperalgorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Oct 21, 2023
@isidroasisidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

enhancementThis PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tianyizheng02@cclauss
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Consolidate binary exponentiation files by tianyizheng02 · Pull Request #10742 · TheAlgorithms/Python · GitHub
Skip to content
Consolidate binary exponentiation files - #10742
Merged
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Oct 21, 2023
Merged
Consolidate binary exponentiation files#10742
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Oct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
Contributes to #8098
Consolidated implementations of binary (modular) exponentiation into just binary_exponentiation.py
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 21, 2023
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py

def binary_exp_recursive(base: int, exponent: int) -> int:
 """
 Compute a number raised by some quantity
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this? exp is a bit cryptic in the function name and a line of documentation here is useful.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
 """
 Compute a number raised by some quantity
 >>> binary_exponentiation(-1, 3)
 >>> binary_exp_recursive(3, 5)
@cclausscclaussOct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about tests for a=big number and n=big number, a=float, n=float?
@tianyizheng02tianyizheng02Oct 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, but the n=float case won't work because the algorithm can only compute integer powers
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it won’t work but I wanted to see how it fails. Does it raise a ValueError? Does it behave like pow() does. Testing how things work if half the battle. Watching them fail is just as cool.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
Outdated

 RESULT = binary_exponentiation(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
 RESULT = binary_exp_recursive(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPTIONAL: Adding a timeit benchmark would be a nice addition. Visitors love to see the side-by-side bakeoff.
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@tianyizheng02
tianyizheng02
merged commit 06edc0e
into
TheAlgorithms:masterOct 21, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tianyizheng02@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Consolidate binary exponentiation files by tianyizheng02 · Pull Request #10742 · TheAlgorithms/Python · GitHub
Skip to content
Consolidate binary exponentiation files - #10742
Merged
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Oct 21, 2023
Merged
Consolidate binary exponentiation files#10742
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Oct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
Contributes to #8098
Consolidated implementations of binary (modular) exponentiation into just binary_exponentiation.py
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 21, 2023
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py

def binary_exp_recursive(base: int, exponent: int) -> int:
 """
 Compute a number raised by some quantity
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this? exp is a bit cryptic in the function name and a line of documentation here is useful.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
 """
 Compute a number raised by some quantity
 >>> binary_exponentiation(-1, 3)
 >>> binary_exp_recursive(3, 5)
@cclausscclaussOct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about tests for a=big number and n=big number, a=float, n=float?
@tianyizheng02tianyizheng02Oct 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, but the n=float case won't work because the algorithm can only compute integer powers
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it won’t work but I wanted to see how it fails. Does it raise a ValueError? Does it behave like pow() does. Testing how things work if half the battle. Watching them fail is just as cool.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
Outdated

 RESULT = binary_exponentiation(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
 RESULT = binary_exp_recursive(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPTIONAL: Adding a timeit benchmark would be a nice addition. Visitors love to see the side-by-side bakeoff.
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@tianyizheng02
tianyizheng02
merged commit 06edc0e
into
TheAlgorithms:masterOct 21, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tianyizheng02@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Consolidate binary exponentiation files by tianyizheng02 · Pull Request #10742 · TheAlgorithms/Python · GitHub
Skip to content
Consolidate binary exponentiation files - #10742
Merged
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Oct 21, 2023
Merged
Consolidate binary exponentiation files#10742
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Oct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
Contributes to #8098
Consolidated implementations of binary (modular) exponentiation into just binary_exponentiation.py
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 21, 2023
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py

def binary_exp_recursive(base: int, exponent: int) -> int:
 """
 Compute a number raised by some quantity
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this? exp is a bit cryptic in the function name and a line of documentation here is useful.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
 """
 Compute a number raised by some quantity
 >>> binary_exponentiation(-1, 3)
 >>> binary_exp_recursive(3, 5)
@cclausscclaussOct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about tests for a=big number and n=big number, a=float, n=float?
@tianyizheng02tianyizheng02Oct 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, but the n=float case won't work because the algorithm can only compute integer powers
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it won’t work but I wanted to see how it fails. Does it raise a ValueError? Does it behave like pow() does. Testing how things work if half the battle. Watching them fail is just as cool.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
Outdated

 RESULT = binary_exponentiation(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
 RESULT = binary_exp_recursive(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPTIONAL: Adding a timeit benchmark would be a nice addition. Visitors love to see the side-by-side bakeoff.
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@tianyizheng02
tianyizheng02
merged commit 06edc0e
into
TheAlgorithms:masterOct 21, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tianyizheng02@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Consolidate binary exponentiation files by tianyizheng02 · Pull Request #10742 · TheAlgorithms/Python · GitHub
Skip to content
Consolidate binary exponentiation files - #10742
Merged
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Oct 21, 2023
Merged
Consolidate binary exponentiation files#10742
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Oct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
Contributes to #8098
Consolidated implementations of binary (modular) exponentiation into just binary_exponentiation.py
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 21, 2023
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py

def binary_exp_recursive(base: int, exponent: int) -> int:
 """
 Compute a number raised by some quantity
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this? exp is a bit cryptic in the function name and a line of documentation here is useful.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
 """
 Compute a number raised by some quantity
 >>> binary_exponentiation(-1, 3)
 >>> binary_exp_recursive(3, 5)
@cclausscclaussOct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about tests for a=big number and n=big number, a=float, n=float?
@tianyizheng02tianyizheng02Oct 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, but the n=float case won't work because the algorithm can only compute integer powers
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it won’t work but I wanted to see how it fails. Does it raise a ValueError? Does it behave like pow() does. Testing how things work if half the battle. Watching them fail is just as cool.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
Outdated

 RESULT = binary_exponentiation(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
 RESULT = binary_exp_recursive(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPTIONAL: Adding a timeit benchmark would be a nice addition. Visitors love to see the side-by-side bakeoff.
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@tianyizheng02
tianyizheng02
merged commit 06edc0e
into
TheAlgorithms:masterOct 21, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tianyizheng02@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Consolidate binary exponentiation files by tianyizheng02 · Pull Request #10742 · TheAlgorithms/Python · GitHub
Skip to content
Consolidate binary exponentiation files - #10742
Merged
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Oct 21, 2023
Merged
Consolidate binary exponentiation files#10742
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Oct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
Contributes to #8098
Consolidated implementations of binary (modular) exponentiation into just binary_exponentiation.py
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 21, 2023
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py

def binary_exp_recursive(base: int, exponent: int) -> int:
 """
 Compute a number raised by some quantity
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this? exp is a bit cryptic in the function name and a line of documentation here is useful.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
 """
 Compute a number raised by some quantity
 >>> binary_exponentiation(-1, 3)
 >>> binary_exp_recursive(3, 5)
@cclausscclaussOct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about tests for a=big number and n=big number, a=float, n=float?
@tianyizheng02tianyizheng02Oct 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, but the n=float case won't work because the algorithm can only compute integer powers
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it won’t work but I wanted to see how it fails. Does it raise a ValueError? Does it behave like pow() does. Testing how things work if half the battle. Watching them fail is just as cool.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
Outdated

 RESULT = binary_exponentiation(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
 RESULT = binary_exp_recursive(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPTIONAL: Adding a timeit benchmark would be a nice addition. Visitors love to see the side-by-side bakeoff.
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@tianyizheng02
tianyizheng02
merged commit 06edc0e
into
TheAlgorithms:masterOct 21, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tianyizheng02@cclauss

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Consolidate binary exponentiation files by tianyizheng02 · Pull Request #10742 · TheAlgorithms/Python · GitHub
Skip to content
Consolidate binary exponentiation files - #10742
Merged
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Oct 21, 2023
Merged
Consolidate binary exponentiation files#10742
tianyizheng02 merged 6 commits into
TheAlgorithms:masterfrom 
tianyizheng02:main
Conversation
@tianyizheng02
@tianyizheng02tianyizheng02
commented
Oct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
Contributes to #8098
Consolidated implementations of binary (modular) exponentiation into just binary_exponentiation.py
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@algorithms-keeperalgorithms-keeperBot
added

enhancement
This PR modified some existing files
awaiting reviews
This PR is ready to be reviewed
labels
Oct 21, 2023
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py

def binary_exp_recursive(base: int, exponent: int) -> int:
 """
 Compute a number raised by some quantity
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this? exp is a bit cryptic in the function name and a line of documentation here is useful.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
 """
 Compute a number raised by some quantity
 >>> binary_exponentiation(-1, 3)
 >>> binary_exp_recursive(3, 5)
@cclausscclaussOct 21, 2023•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about tests for a=big number and n=big number, a=float, n=float?
@tianyizheng02tianyizheng02Oct 21, 2023

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can do, but the n=float case won't work because the algorithm can only compute integer powers
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it won’t work but I wanted to see how it fails. Does it raise a ValueError? Does it behave like pow() does. Testing how things work if half the battle. Watching them fail is just as cool.
cclauss
cclauss
reviewed
Oct 21, 2023
View reviewed changes
Comment threadmaths/binary_exponentiation.py
Outdated

 RESULT = binary_exponentiation(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
 RESULT = binary_exp_recursive(BASE, POWER)
 print(f"{BASE}^({POWER}): {RESULT}")
@cclausscclaussOct 21, 2023

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OPTIONAL: Adding a timeit benchmark would be a nice addition. Visitors love to see the side-by-side bakeoff.
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@tianyizheng02
tianyizheng02
merged commit 06edc0e
into
TheAlgorithms:masterOct 21, 2023
@algorithms-keeperalgorithms-keeperBot
removed
the 
awaiting reviews
This PR is ready to be reviewed
label
Oct 21, 2023
@isidroasisidroas
mentioned this pull request
Jan 25, 2025
 Closed

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels

enhancementThis PR modified some existing files

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tianyizheng02@cclauss