Skip to content

fixing error - #1964

Closed
itsvinayak wants to merge 3 commits into
TheAlgorithms:masterfrom
itsvinayak:master
Closed

fixing error#1964
itsvinayak wants to merge 3 commits into
TheAlgorithms:masterfrom
itsvinayak:master

Conversation

@itsvinayak

@itsvinayakitsvinayak commented May 9, 2020

Copy link
Copy Markdown
Member

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@itsvinayak
itsvinayak requested a review from cclaussMay 9, 2020 20:01
@itsvinayak

Copy link
Copy Markdown
MemberAuthor

@cclauss there was an error in maths/kadanes_algorithm.py now solved

@itsvinayak
itsvinayak requested a review from poyeaMay 10, 2020 04:38
@cclauss

Copy link
Copy Markdown
Member

Closing in favor of #1966 which fixes single character variable names.

@cclausscclauss closed this May 10, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@itsvinayak@cclauss