Added Coulomb_Law by gudlu1925 · Pull Request #8714 · TheAlgorithms/Python

gudlu1925 · 2023-05-07T08:35:59Z

Describe your change:

I have added a Coulomb law python code under physics to calculate force between two charges.

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

for more information, see https://pre-commit.ci

rohan472000 · 2023-05-07T14:30:18Z

@@ -0,0 +1,63 @@
+"""
+Description : The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges is directly proportional


use ruff . then ruff . --fix to fix ruff and pre-commit issues

tianyizheng02

I feel that the header docstring is too verbose and some parts, such as the paragraph about Coulomb discovering the formula, are either a bit repetitive or not particularly important to include. Instead of directly quoting the cited article for most of the documentation, consider briefly summarizing what the formula calculates and discussing the intuition behind it

tianyizheng02 · 2023-05-09T05:46:13Z

Consider changing the file name from coulomb_law.py to coulombs_law.py, since the name is "Coulomb's Law"

tianyizheng02 · 2023-05-09T05:49:45Z

+Charles-Augustin de Coulomb, a French physicist in 1784, measured the force between two point charges and he came up with
+the theory that the force is inversely proportional to the square of the distance between the charges.
+He also found that this force is directly proportional to the product of charges (magnitudes only).


Suggested change
Charles-AugustindeCoulomb, aFrenchphysicistin1784, measuredtheforcebetweentwopointchargesandhecameupwith
thetheorythattheforceisinverselyproportionaltothesquareofthedistancebetweenthecharges.
Healsofoundthatthisforceisdirectlyproportionaltotheproductofcharges (magnitudesonly).
The history of the formula isn't particularly important to understanding the formula itself, imo

tianyizheng02 · 2023-05-09T05:51:22Z

+
+def coulombs_law(q1: float, q2: float, radius: float) -> float:
+ """
+ The Electrostatic Force formula is given as: (k*q1*q2)/(r**2)


Specifying the units of q1, q2, radius, and the output would be helpful

tianyizheng02 · 2023-05-09T05:55:18Z

+Where, F is the Electrostatic force,q1 q2 are the intensity of two charges respecticvely ,
+r is the radius and k is coulombs constant and its value is 9×10^9 N⋅m^2⋅C^−2 .


Suggested change
Where,FistheElectrostaticforce,q1q2aretheintensityoftwochargesrespecticvely,
ristheradiusandkiscoulombsconstantanditsvalueis9×10^9N⋅m^2⋅C^−2.
whereFistheelectrostaticforce,q1andq2arethemagnitudesofthetwochargesrespectively,
ristheradiusandk=9×10^9N⋅m^2/C^2isCoulomb'sconstant.

tianyizheng02 · 2023-05-09T05:59:20Z

+
+where k is proportionality constant and equals to 1/4πε0.
+
+Here, ε0 is the epsilon naught and it signifies permittivity of a vacuum. The value of k comes 9 × 10^9 Nm^2/ C^2


9 x 10^9 N * m^2 / C^2 is only an approximation for Coulomb's constant. Wikipedia gives a much more precise value of 8.9875517923 x 10^9 N * m^2 / C^2

tianyizheng02 · 2023-05-09T06:01:20Z

+
+ if radius <= 0:
+ raise ValueError("The radius is always a positive non zero integer")
+ return ((9 * 10**9) * q1 * q2) / (radius**2)


Suggested change
return ((9*10**9) *q1*q2) / (radius**2)
k=8.9875517923*10**9
return (k*q1*q2) / (radius**2)
Updated code with more precise value of Coulomb's constant

for more information, see https://pre-commit.ci

rohan472000 · 2023-05-09T09:29:57Z

@@ -0,0 +1,37 @@
+"""
+The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges


Line no.2,3,5 should be break into multiple as it is long ....use 'ruff . --fix'

tianyizheng02 · 2023-05-09T09:29:47Z

@@ -0,0 +1,37 @@
+"""
+The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges


Suggested change
Thelawstatesthatthemagnitudeoftheelectrostaticforceofattractionorrepulsionbetweentwopointcharges
Coulomb'slawstatesthatthemagnitudeoftheelectrostaticforceofattractionorrepulsionbetweentwopointcharges
For clarity

tianyizheng02 · 2023-05-09T09:30:21Z

+
+Coulomb studied the repulsive force between bodies having electrical charges of the same sign.
+
+F = k*q1*q2/ r^2


Suggested change
F=k*q1*q2/r^2
F=k*q1*q2/r^2
Spacing

tianyizheng02 · 2023-05-09T09:36:59Z

+
+F = k*q1*q2/ r^2
+
+k is proportionality constant and equals 1/4πε0.


Suggested change
kisproportionalityconstantandequals1/4πε0.
kistheCoulombconstantandequals1/(4π*ε0).
According to Wikipedia, $k$ is called the Coulomb constant
Added parentheses for clarity, because otherwise it looks like $\frac{1}{4} \pi \varepsilon_0$ and not $\frac{1}{4 \pi \varepsilon_0}$

chriso345 · 2023-05-12T02:32:09Z

+F = k*q1*q2/r^2
+
+k is Coulomb's constant and equals 1/(4π*ε0).
+q1 is charge of first body (C)
+q2 is charge of second body (C)
+r is distance between two charged bodies (m)
+"""
+
+
+def coulombs_law(q1: float, q2: float, radius: float) -> float:
+ """


Suggested change
F=k*q1*q2/r^2
kisCoulomb'sconstantandequals1/(4π*ε0).
q1ischargeoffirstbody (C)
q2ischargeofsecondbody (C)
risdistancebetweentwochargedbodies (m)
"""
defcoulombs_law(q1: float, q2: float, radius: float) ->float:
"""
F=k*q1*q2/r^2
kisCoulomb'sconstantandequals=1/(4π*ε0).
"""
defcoulombs_law(q1: float, q2: float, radius: float) ->float:
"""
:paramfloatq1: chargeoffirstbody (C)
:paramfloatq2: chargeofsecondbody (C)
:paramfloatr: distancebetweenthetwobodies

for more information, see https://pre-commit.ci

gudlu1925 · 2023-05-12T11:24:49Z

Will you please guide me with ruff checking?
I have done ruff. and ruff. --fix is working fine in my system but still the same error is showing in here.

stale · 2023-06-18T13:57:48Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

tianyizheng02 · 2023-05-10T04:10:53Z

@@ -0,0 +1,37 @@
+"""
+Coulombs law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges


Suggested change
Coulombslawstatesthatthemagnitudeoftheelectrostaticforceofattractionorrepulsionbetweentwopointcharges
Coulomb'slawstatesthatthemagnitudeoftheelectrostaticforceofattractionorrepulsionbetweentwopointcharges
Small grammar fix. Other than that, it looks good to go 👍

gudlu1925and others added 4 commits May 7, 2023 13:56

Create coulomb_law.py
770e2f4

Update coulomb_law.py
8466f25

Update coulomb_law.py
07f24ca

[pre-commit.ci] auto fixes from pre-commit.com hooks
112b1f9
for more information, see https://pre-commit.ci

algorithms-keeperBot added the tests are failing Do not merge until tests pass label May 7, 2023

rohan472000 suggested changes May 7, 2023
View reviewed changes

tianyizheng02 requested changes May 9, 2023
View reviewed changes

gudlu1925and others added 3 commits May 9, 2023 14:25

Update and rename coulomb_law.py to coulombs_law.py
fdd4eff

[pre-commit.ci] auto fixes from pre-commit.com hooks
43bd954
for more information, see https://pre-commit.ci

Update coulombs_law.py
2387620

algorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label May 9, 2023

[pre-commit.ci] auto fixes from pre-commit.com hooks
d7d6517
for more information, see https://pre-commit.ci

rohan472000 suggested changes May 9, 2023
View reviewed changes

tianyizheng02 requested changes May 9, 2023
View reviewed changes

Update coulombs_law.py
64fceb5

chriso345 reviewed May 12, 2023
View reviewed changes

gudlu1925and others added 4 commits May 12, 2023 16:28

Update coulombs_law.py
c78a384

[pre-commit.ci] auto fixes from pre-commit.com hooks
ce65ffb
for more information, see https://pre-commit.ci

Update coulombs_law.py
1a32040

[pre-commit.ci] auto fixes from pre-commit.com hooks
ed46580
for more information, see https://pre-commit.ci

staleBot added the stale Used to mark an issue or pull request stale. label Jun 18, 2023

tianyizheng02 reviewed Aug 14, 2023
View reviewed changes

staleBot removed stale Used to mark an issue or pull request stale. labels Aug 14, 2023

Update coulombs_law.py
a8bd7cc

algorithms-keeperBot removed the tests are failing Do not merge until tests pass label Sep 27, 2023

tianyizheng02 approved these changes Sep 27, 2023
View reviewed changes

tianyizheng02 merged commit eace4ce into TheAlgorithms:masterSep 27, 2023

algorithms-keeperBot removed the awaiting reviews This PR is ready to be reviewed label Sep 27, 2023

isidroas mentioned this pull request Jan 25, 2025
dh isidroas/Python#1
Closed
14 tasks

		@@ -0,0 +1,63 @@
		"""
		Description : The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges is directly proportional

	Charles-AugustindeCoulomb, aFrenchphysicistin1784, measuredtheforcebetweentwopointchargesandhecameupwith
	thetheorythattheforceisinverselyproportionaltothesquareofthedistancebetweenthecharges.
	Healsofoundthatthisforceisdirectlyproportionaltotheproductofcharges (magnitudesonly).

		Where, F is the Electrostatic force,q1 q2 are the intensity of two charges respecticvely ,
		r is the radius and k is coulombs constant and its value is 9×10^9 N⋅m^2⋅C^−2 .

-Where,FistheElectrostaticforce,q1q2aretheintensityoftwochargesrespecticvely,
-ristheradiusandkiscoulombsconstantanditsvalueis9×10^9N⋅m^2⋅C^−2.
+whereFistheelectrostaticforce,q1andq2arethemagnitudesofthetwochargesrespectively,
+ristheradiusandk=9×10^9N⋅m^2/C^2isCoulomb'sconstant.


		where k is proportionality constant and equals to 1/4πε0.

		Here, ε0 is the epsilon naught and it signifies permittivity of a vacuum. The value of k comes 9 × 10^9 Nm^2/ C^2

	return ((9109) q1q2) / (radius*2)
	k=8.987551792310*9
	return (kq1q2) / (radius**2)

		@@ -0,0 +1,37 @@
		"""
		The law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges

	Thelawstatesthatthemagnitudeoftheelectrostaticforceofattractionorrepulsionbetweentwopointcharges
	Coulomb'slawstatesthatthemagnitudeoftheelectrostaticforceofattractionorrepulsionbetweentwopointcharges


		Coulomb studied the repulsive force between bodies having electrical charges of the same sign.

		F = kq1q2/ r^2


		F = kq1q2/ r^2

		k is proportionality constant and equals 1/4πε0.

	kisproportionalityconstantandequals1/4πε0.
	kistheCoulombconstantandequals1/(4π*ε0).

-F=k*q1*q2/r^2
-kisCoulomb'sconstantandequals1/(4π*ε0).
-q1ischargeoffirstbody (C)
-q2ischargeofsecondbody (C)
-risdistancebetweentwochargedbodies (m)
-"""
-defcoulombs_law(q1: float, q2: float, radius: float) ->float:
- """
+F=k*q1*q2/r^2
+kisCoulomb'sconstantandequals=1/(4π*ε0).
+"""
+defcoulombs_law(q1: float, q2: float, radius: float) ->float:
+ """
+ :paramfloatq1: chargeoffirstbody (C)
+ :paramfloatq2: chargeofsecondbody (C)
+ :paramfloatr: distancebetweenthetwobodies

		@@ -0,0 +1,37 @@
		"""
		Coulombs law states that the magnitude of the electrostatic force of attraction or repulsion between two point charges

	Coulombslawstatesthatthemagnitudeoftheelectrostaticforceofattractionorrepulsionbetweentwopointcharges
	Coulomb'slawstatesthatthemagnitudeoftheelectrostaticforceofattractionorrepulsionbetweentwopointcharges

Uh oh!

Uh oh!

Conversation

gudlu1925 commented May 7, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your change:

Checklist:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tianyizheng02 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gudlu1925 commented May 12, 2023

Uh oh!

staleBot commented Jun 18, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gudlu1925 commented May 7, 2023•
edited
Loading