[UPDATED]rat_in_maze.py - #9087

Closed
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom
Muhammadummerr:new_branch
Closed

[UPDATED]rat_in_maze.py#9087
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom
Muhammadummerr:new_branch

Conversation

@Muhammadummerr

@MuhammadummerrMuhammadummerr commented Sep 24, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

FIXES#9066
I have made updates to the rat_in_maze.py file to enhance code clarity.
These updates include:
1.Adding more descriptive comments to explain the logic and steps of the maze-solving algorithm.
2.Introducing variables that allow for easy customization of the source and destination cells within the maze.
3.Refactor path representation in solution:

  • Previously, in solution paths were represented as 1s, but I have updated it to use 0s to align with the standard convention where 0s represent paths and 1s represent walls.
  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@MuhammadummerrMuhammadummerr changed the title New branch[UPDATED]#9066 rat_in_maze.pySep 24, 2023
@rohan472000

rohan472000 commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

Kindly tick the checkboxes while raising PR, don't delete them.

@Muhammadummerr

Muhammadummerr commented Sep 25, 2023

Copy link
Copy Markdown
ContributorAuthor

Kindly tick the checkboxes while raising PR, don't delete them.

Ok, but now how to tick checkboxes when PR is raised?

@rohan472000

rohan472000 commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

Replace • [ ] to • [x]

@Muhammadummerr

Muhammadummerr commented Sep 25, 2023

Copy link
Copy Markdown
ContributorAuthor

Sorry, but where?

@rohan472000

rohan472000 commented Sep 25, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

While creating PR, you will get a box to describe the change, below in the box there are multiple checkboxes to tick.

https://github.com/TheAlgorithms/Python/blob/master/.github/pull_request_template.md

@Muhammadummerr

Muhammadummerr commented Sep 25, 2023

Copy link
Copy Markdown
ContributorAuthor

should I delete this PR now, and create another one and tick checkboxes?

@rohan472000

rohan472000 commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

No...copy from that link which I provided, and paste it in description box above, then tick required checkboxes.

@rohan472000

rohan472000 commented Sep 25, 2023

Copy link
Copy Markdown
Contributor

Also revise the PR title, don't include 9066, this should be in description box, see contributing guidelines beforehand.

@MuhammadummerrMuhammadummerr changed the title [UPDATED]#9066 rat_in_maze.py[UPDATED]rat_in_maze.pySep 25, 2023
@Muhammadummerr

Muhammadummerr commented Sep 25, 2023

Copy link
Copy Markdown
ContributorAuthor

Thanks a lot, your guidance meant a lot to me:)

dlesnoff
dlesnoff reviewed Sep 26, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py Outdated
@Muhammadummerr@dlesnoff
Update backtracking/rat_in_maze.py
8ff2d65
Co-authored-by: dlesnoff <54949944+dlesnoff@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot added the awaiting reviews This PR is ready to be reviewed label Sep 26, 2023
Muhammadummerr
Muhammadummerr commented Sep 26, 2023
View reviewed changes

@MuhammadummerrMuhammadummerr left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the correction.

@dlesnoff

dlesnoff commented Sep 27, 2023

Copy link
Copy Markdown

I am not familiar with the Python repository, but I think that you should reflect the changes in the unittest.
What happens if I change the starting cell and the end cell?
An example in the docstring with this new feature would be welcome too.

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Sep 28, 2023
rohan472000
rohan472000 suggested changes Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py Outdated
Comment threadbacktracking/rat_in_maze.py Outdated
Comment threadbacktracking/rat_in_maze.py Outdated
@rohan472000

rohan472000 commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.

I have suggested change, commit that and see if it resolves the issue or not.

@Muhammadummerr@rohan472000
Update backtracking/rat_in_maze.py
553d1f0
Co-authored-by: Rohan Anand <96521078+rohan472000@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Sep 29, 2023
@rohan472000

rohan472000 commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

None would be better.

@algorithms-keeperalgorithms-keeperBot added the tests are failing Do not merge until tests pass label Sep 29, 2023
@rohan472000

rohan472000 commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

Use ruff . then ruff . --fix to rectify ruff issues.

@Muhammadummerr

Muhammadummerr commented Sep 29, 2023

Copy link
Copy Markdown
ContributorAuthor

Use ruff . then ruff . --fix to rectify ruff issues.

3 errors found ,then how should I resolve them without using ruff --fix .
On running the file it showing error of whitespaces ====== ,How it can be resolved?

@rohan472000

rohan472000 commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

run : ruff . --fix

@Muhammadummerr

Muhammadummerr commented Sep 29, 2023

Copy link
Copy Markdown
ContributorAuthor

run : ruff . --fix

still 3 errors found
Desktop\Python\backtracking\rat_in_maze.py:35:89: E501 Line too long (93 > 88 characters)
Desktop\Python\backtracking\rat_in_maze.py:82:89: E501 Line too long (93 > 88 characters)
Desktop\Python\backtracking\rat_in_maze.py:105:89: E501 Line too long (216 > 88 characters)

@Muhammadummerr

Muhammadummerr commented Sep 29, 2023

Copy link
Copy Markdown
ContributorAuthor

run : ruff . --fix

using black . showing All done but ruff . --fix showing 3 erros found

@Muhammadummerr

Muhammadummerr commented Sep 29, 2023

Copy link
Copy Markdown
ContributorAuthor

I understand what the problem is. The output of solve_maze is a 2D array written in the docstring as [[0, 1, 1], [0, 0, 1], [0, 0, 1]], but it exceeds the 88-character word limit. Now, when I format the line, the expected output does not match the obtained output. Can you help me in how to approach this issue now?

@algorithms-keeperalgorithms-keeperBot removed the tests are failing Do not merge until tests pass label Sep 29, 2023
rohan472000
rohan472000 suggested changes Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py Outdated
rohan472000
rohan472000 suggested changes Sep 29, 2023
View reviewed changes

@rohan472000rohan472000 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove print statement as it is returning None.

Comment threadbacktracking/rat_in_maze.py Outdated
size = len(maze)
# Check if source and destination coordinates are Invalid.
if not (0 <= source_row <= size - 1 and 0 <= source_column <= size - 1):
print("Invalid source coordinates")

@rohan472000rohan472000Sep 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print("Invalid source coordinates")

Comment threadbacktracking/rat_in_maze.py Outdated
print("Invalid source coordinates")
return None
elif not (0 <= destination_row <= size - 1 and 0 <= destination_column <= size - 1):
print("Invalid destination coordinates")

@rohan472000rohan472000Sep 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print("Invalid destination coordinates")

Comment threadbacktracking/rat_in_maze.py Outdated
print("\n".join(str(row) for row in solutions))
return solutions
else:
print("No solution exists!")

@rohan472000rohan472000Sep 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
print("No solution exists!")

@tianyizheng02

tianyizheng02 commented Sep 30, 2023

Copy link
Copy Markdown
Contributor

Thank you for your contribution, but unfortunately we're not accepting new PRs at the moment. We're currently trying to clear our backlog of existing PRs in preparation for Hacktoberfest. If you want to contribute, please wait until after October 1 to do so. See this discussion for more info.

@Muhammadummerr
Muhammadummerr deleted the new_branch branch September 30, 2023 16:24
@dlesnoff

dlesnoff commented Oct 1, 2023•
edited
Loading

Copy link
Copy Markdown

At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.

I have suggested change, commit that and see if it resolves the issue or not.

The '>>>>>>>' and '======' stuff comes from the git merge. When there is a conflict (a file being changed in the two original branches), git modify the file and let the two code versions in the same file separated by <<<<<<<, ========== and >>>>>>. See the Git documentation.

@Muhammadummerr Muhammadummerr deleted the new_branch branch

Why did you deleted the branch? It is a temporary closed PR. A link to the new PR would have been welcomed!

@dlesnoffdlesnoff mentioned this pull request Oct 3, 2023
Merged
14 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dlesnoffdlesnoffAwaiting requested review from dlesnoff
@rohan472000rohan472000Awaiting requested review from rohan472000

Assignees

No one assigned

Labels

awaiting reviewsThis PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Backtracking/Rat Maze

4 participants

@Muhammadummerr@rohan472000@dlesnoff@tianyizheng02
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[UPDATED]rat_in_maze.py - #9087
Closed
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Closed
[UPDATED]rat_in_maze.py#9087
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Conversation
@Muhammadummerr
@MuhammadummerrMuhammadummerr
commented
Sep 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
FIXES#9066

I have made updates to the rat_in_maze.py file to enhance code clarity.

These updates include:

1.Adding more descriptive comments to explain the logic and steps of the maze-solving algorithm.

2.Introducing variables that allow for easy customization of the source and destination cells within the maze.

3.Refactor path representation in solution:
  • Previously, in solution paths were represented as 1s, but I have updated it to use 0s to align with the standard convention where 0s represent paths and 1s represent walls.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@MuhammadummerrMuhammadummerr
changed the title
New branch[UPDATED]#9066 rat_in_maze.pySep 24, 2023
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Kindly tick the checkboxes while raising PR, don't delete them.
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Kindly tick the checkboxes while raising PR, don't delete them.
Ok, but now how to tick checkboxes when PR is raised?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Replace • [ ] to • [x]
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Sorry, but where?
@rohan472000
rohan472000
commented
Sep 25, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
While creating PR, you will get a box to describe the change, below in the box there are multiple checkboxes to tick.
https://github.com/TheAlgorithms/Python/blob/master/.github/pull_request_template.md
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
should I delete this PR now, and create another one and tick checkboxes?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
No...copy from that link which I provided, and paste it in description box above, then tick required checkboxes.
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Also revise the PR title, don't include 9066, this should be in description box, see contributing guidelines beforehand.
@MuhammadummerrMuhammadummerr
changed the title
[UPDATED]#9066 rat_in_maze.py[UPDATED]rat_in_maze.pySep 25, 2023
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot, your guidance meant a lot to me:)
dlesnoff
dlesnoff
reviewed
Sep 26, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

@Muhammadummerr@dlesnoff
Update backtracking/rat_in_maze.py
8ff2d65
Co-authored-by: dlesnoff <54949944+dlesnoff@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Sep 26, 2023
Muhammadummerr
Muhammadummerr
commented
Sep 26, 2023
View reviewed changes
@MuhammadummerrMuhammadummerr
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the correction.
@dlesnoff
dlesnoff
commented
Sep 27, 2023

Copy link


Copy Markdown

I am not familiar with the Python repository, but I think that you should reflect the changes in the unittest.

What happens if I change the starting cell and the end cell?

An example in the docstring with this new feature would be welcome too.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 28, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
@Muhammadummerr@rohan472000
Update backtracking/rat_in_maze.py
553d1f0
Co-authored-by: Rohan Anand <96521078+rohan472000@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
None would be better.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Use ruff . then ruff . --fix to rectify ruff issues.
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Use ruff . then ruff . --fix to rectify ruff issues.
3 errors found ,then how should I resolve them without using ruff --fix .

On running the file it showing error of whitespaces ====== ,How it can be resolved?
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
run : ruff . --fix
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
still 3 errors found

Desktop\Python\backtracking\rat_in_maze.py:35:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:82:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:105:89: E501 Line too long (216 > 88 characters)
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
using black . showing All done but ruff . --fix showing 3 erros found
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
I understand what the problem is. The output of solve_maze is a 2D array written in the docstring as [[0, 1, 1], [0, 0, 1], [0, 0, 1]], but it exceeds the 88-character word limit. Now, when I format the line, the expected output does not match the obtained output. Can you help me in how to approach this issue now?
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
@rohan472000rohan472000
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove print statement as it is returning None.
Comment threadbacktracking/rat_in_maze.py
Outdated

 size = len(maze)
 # Check if source and destination coordinates are Invalid.
 if not (0 <= source_row <= size - 1 and 0 <= source_column <= size - 1):
 print("Invalid source coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid source coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

 print("Invalid source coordinates")
 return None
 elif not (0 <= destination_row <= size - 1 and 0 <= destination_column <= size - 1):
 print("Invalid destination coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid destination coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

print("\n".join(str(row) for row in solutions))
return solutions
 else:
 print("No solution exists!")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("No solution exists!")
@tianyizheng02
tianyizheng02
commented
Sep 30, 2023

Copy link


Copy Markdown

Contributor
Thank you for your contribution, but unfortunately we're not accepting new PRs at the moment. We're currently trying to clear our backlog of existing PRs in preparation for Hacktoberfest. If you want to contribute, please wait until after October 1 to do so. See this discussion for more info.
@Muhammadummerr
Muhammadummerr
deleted the

new_branch

branch
September 30, 2023 16:24
@dlesnoff
dlesnoff
commented
Oct 1, 2023•

edited

Loading

Copy link


Copy Markdown

At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
The '>>>>>>>' and '======' stuff comes from the git merge. When there is a conflict (a file being changed in the two original branches), git modify the file and let the two code versions in the same file separated by <<<<<<<, ========== and >>>>>>. See the Git documentation.
@Muhammadummerr Muhammadummerr deleted the new_branch branch
Why did you deleted the branch? It is a temporary closed PR. A link to the new PR would have been welcomed!
@dlesnoffdlesnoff
mentioned this pull request
Oct 3, 2023
 Merged

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dlesnoffdlesnoffAwaiting requested review from dlesnoff
@rohan472000rohan472000Awaiting requested review from rohan472000

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Backtracking/Rat Maze


4 participants

@Muhammadummerr@rohan472000@dlesnoff@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[UPDATED]rat_in_maze.py - #9087
Closed
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Closed
[UPDATED]rat_in_maze.py#9087
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Conversation
@Muhammadummerr
@MuhammadummerrMuhammadummerr
commented
Sep 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
FIXES#9066

I have made updates to the rat_in_maze.py file to enhance code clarity.

These updates include:

1.Adding more descriptive comments to explain the logic and steps of the maze-solving algorithm.

2.Introducing variables that allow for easy customization of the source and destination cells within the maze.

3.Refactor path representation in solution:
  • Previously, in solution paths were represented as 1s, but I have updated it to use 0s to align with the standard convention where 0s represent paths and 1s represent walls.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@MuhammadummerrMuhammadummerr
changed the title
New branch[UPDATED]#9066 rat_in_maze.pySep 24, 2023
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Kindly tick the checkboxes while raising PR, don't delete them.
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Kindly tick the checkboxes while raising PR, don't delete them.
Ok, but now how to tick checkboxes when PR is raised?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Replace • [ ] to • [x]
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Sorry, but where?
@rohan472000
rohan472000
commented
Sep 25, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
While creating PR, you will get a box to describe the change, below in the box there are multiple checkboxes to tick.
https://github.com/TheAlgorithms/Python/blob/master/.github/pull_request_template.md
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
should I delete this PR now, and create another one and tick checkboxes?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
No...copy from that link which I provided, and paste it in description box above, then tick required checkboxes.
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Also revise the PR title, don't include 9066, this should be in description box, see contributing guidelines beforehand.
@MuhammadummerrMuhammadummerr
changed the title
[UPDATED]#9066 rat_in_maze.py[UPDATED]rat_in_maze.pySep 25, 2023
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot, your guidance meant a lot to me:)
dlesnoff
dlesnoff
reviewed
Sep 26, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

@Muhammadummerr@dlesnoff
Update backtracking/rat_in_maze.py
8ff2d65
Co-authored-by: dlesnoff <54949944+dlesnoff@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Sep 26, 2023
Muhammadummerr
Muhammadummerr
commented
Sep 26, 2023
View reviewed changes
@MuhammadummerrMuhammadummerr
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the correction.
@dlesnoff
dlesnoff
commented
Sep 27, 2023

Copy link


Copy Markdown

I am not familiar with the Python repository, but I think that you should reflect the changes in the unittest.

What happens if I change the starting cell and the end cell?

An example in the docstring with this new feature would be welcome too.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 28, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
@Muhammadummerr@rohan472000
Update backtracking/rat_in_maze.py
553d1f0
Co-authored-by: Rohan Anand <96521078+rohan472000@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
None would be better.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Use ruff . then ruff . --fix to rectify ruff issues.
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Use ruff . then ruff . --fix to rectify ruff issues.
3 errors found ,then how should I resolve them without using ruff --fix .

On running the file it showing error of whitespaces ====== ,How it can be resolved?
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
run : ruff . --fix
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
still 3 errors found

Desktop\Python\backtracking\rat_in_maze.py:35:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:82:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:105:89: E501 Line too long (216 > 88 characters)
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
using black . showing All done but ruff . --fix showing 3 erros found
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
I understand what the problem is. The output of solve_maze is a 2D array written in the docstring as [[0, 1, 1], [0, 0, 1], [0, 0, 1]], but it exceeds the 88-character word limit. Now, when I format the line, the expected output does not match the obtained output. Can you help me in how to approach this issue now?
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
@rohan472000rohan472000
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove print statement as it is returning None.
Comment threadbacktracking/rat_in_maze.py
Outdated

 size = len(maze)
 # Check if source and destination coordinates are Invalid.
 if not (0 <= source_row <= size - 1 and 0 <= source_column <= size - 1):
 print("Invalid source coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid source coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

 print("Invalid source coordinates")
 return None
 elif not (0 <= destination_row <= size - 1 and 0 <= destination_column <= size - 1):
 print("Invalid destination coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid destination coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

print("\n".join(str(row) for row in solutions))
return solutions
 else:
 print("No solution exists!")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("No solution exists!")
@tianyizheng02
tianyizheng02
commented
Sep 30, 2023

Copy link


Copy Markdown

Contributor
Thank you for your contribution, but unfortunately we're not accepting new PRs at the moment. We're currently trying to clear our backlog of existing PRs in preparation for Hacktoberfest. If you want to contribute, please wait until after October 1 to do so. See this discussion for more info.
@Muhammadummerr
Muhammadummerr
deleted the

new_branch

branch
September 30, 2023 16:24
@dlesnoff
dlesnoff
commented
Oct 1, 2023•

edited

Loading

Copy link


Copy Markdown

At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
The '>>>>>>>' and '======' stuff comes from the git merge. When there is a conflict (a file being changed in the two original branches), git modify the file and let the two code versions in the same file separated by <<<<<<<, ========== and >>>>>>. See the Git documentation.
@Muhammadummerr Muhammadummerr deleted the new_branch branch
Why did you deleted the branch? It is a temporary closed PR. A link to the new PR would have been welcomed!
@dlesnoffdlesnoff
mentioned this pull request
Oct 3, 2023
 Merged

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dlesnoffdlesnoffAwaiting requested review from dlesnoff
@rohan472000rohan472000Awaiting requested review from rohan472000

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Backtracking/Rat Maze


4 participants

@Muhammadummerr@rohan472000@dlesnoff@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[UPDATED]rat_in_maze.py - #9087
Closed
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Closed
[UPDATED]rat_in_maze.py#9087
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Conversation
@Muhammadummerr
@MuhammadummerrMuhammadummerr
commented
Sep 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
FIXES#9066

I have made updates to the rat_in_maze.py file to enhance code clarity.

These updates include:

1.Adding more descriptive comments to explain the logic and steps of the maze-solving algorithm.

2.Introducing variables that allow for easy customization of the source and destination cells within the maze.

3.Refactor path representation in solution:
  • Previously, in solution paths were represented as 1s, but I have updated it to use 0s to align with the standard convention where 0s represent paths and 1s represent walls.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@MuhammadummerrMuhammadummerr
changed the title
New branch[UPDATED]#9066 rat_in_maze.pySep 24, 2023
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Kindly tick the checkboxes while raising PR, don't delete them.
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Kindly tick the checkboxes while raising PR, don't delete them.
Ok, but now how to tick checkboxes when PR is raised?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Replace • [ ] to • [x]
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Sorry, but where?
@rohan472000
rohan472000
commented
Sep 25, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
While creating PR, you will get a box to describe the change, below in the box there are multiple checkboxes to tick.
https://github.com/TheAlgorithms/Python/blob/master/.github/pull_request_template.md
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
should I delete this PR now, and create another one and tick checkboxes?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
No...copy from that link which I provided, and paste it in description box above, then tick required checkboxes.
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Also revise the PR title, don't include 9066, this should be in description box, see contributing guidelines beforehand.
@MuhammadummerrMuhammadummerr
changed the title
[UPDATED]#9066 rat_in_maze.py[UPDATED]rat_in_maze.pySep 25, 2023
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot, your guidance meant a lot to me:)
dlesnoff
dlesnoff
reviewed
Sep 26, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

@Muhammadummerr@dlesnoff
Update backtracking/rat_in_maze.py
8ff2d65
Co-authored-by: dlesnoff <54949944+dlesnoff@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Sep 26, 2023
Muhammadummerr
Muhammadummerr
commented
Sep 26, 2023
View reviewed changes
@MuhammadummerrMuhammadummerr
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the correction.
@dlesnoff
dlesnoff
commented
Sep 27, 2023

Copy link


Copy Markdown

I am not familiar with the Python repository, but I think that you should reflect the changes in the unittest.

What happens if I change the starting cell and the end cell?

An example in the docstring with this new feature would be welcome too.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 28, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
@Muhammadummerr@rohan472000
Update backtracking/rat_in_maze.py
553d1f0
Co-authored-by: Rohan Anand <96521078+rohan472000@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
None would be better.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Use ruff . then ruff . --fix to rectify ruff issues.
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Use ruff . then ruff . --fix to rectify ruff issues.
3 errors found ,then how should I resolve them without using ruff --fix .

On running the file it showing error of whitespaces ====== ,How it can be resolved?
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
run : ruff . --fix
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
still 3 errors found

Desktop\Python\backtracking\rat_in_maze.py:35:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:82:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:105:89: E501 Line too long (216 > 88 characters)
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
using black . showing All done but ruff . --fix showing 3 erros found
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
I understand what the problem is. The output of solve_maze is a 2D array written in the docstring as [[0, 1, 1], [0, 0, 1], [0, 0, 1]], but it exceeds the 88-character word limit. Now, when I format the line, the expected output does not match the obtained output. Can you help me in how to approach this issue now?
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
@rohan472000rohan472000
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove print statement as it is returning None.
Comment threadbacktracking/rat_in_maze.py
Outdated

 size = len(maze)
 # Check if source and destination coordinates are Invalid.
 if not (0 <= source_row <= size - 1 and 0 <= source_column <= size - 1):
 print("Invalid source coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid source coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

 print("Invalid source coordinates")
 return None
 elif not (0 <= destination_row <= size - 1 and 0 <= destination_column <= size - 1):
 print("Invalid destination coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid destination coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

print("\n".join(str(row) for row in solutions))
return solutions
 else:
 print("No solution exists!")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("No solution exists!")
@tianyizheng02
tianyizheng02
commented
Sep 30, 2023

Copy link


Copy Markdown

Contributor
Thank you for your contribution, but unfortunately we're not accepting new PRs at the moment. We're currently trying to clear our backlog of existing PRs in preparation for Hacktoberfest. If you want to contribute, please wait until after October 1 to do so. See this discussion for more info.
@Muhammadummerr
Muhammadummerr
deleted the

new_branch

branch
September 30, 2023 16:24
@dlesnoff
dlesnoff
commented
Oct 1, 2023•

edited

Loading

Copy link


Copy Markdown

At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
The '>>>>>>>' and '======' stuff comes from the git merge. When there is a conflict (a file being changed in the two original branches), git modify the file and let the two code versions in the same file separated by <<<<<<<, ========== and >>>>>>. See the Git documentation.
@Muhammadummerr Muhammadummerr deleted the new_branch branch
Why did you deleted the branch? It is a temporary closed PR. A link to the new PR would have been welcomed!
@dlesnoffdlesnoff
mentioned this pull request
Oct 3, 2023
 Merged

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dlesnoffdlesnoffAwaiting requested review from dlesnoff
@rohan472000rohan472000Awaiting requested review from rohan472000

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Backtracking/Rat Maze


4 participants

@Muhammadummerr@rohan472000@dlesnoff@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[UPDATED]rat_in_maze.py - #9087
Closed
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Closed
[UPDATED]rat_in_maze.py#9087
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Conversation
@Muhammadummerr
@MuhammadummerrMuhammadummerr
commented
Sep 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
FIXES#9066

I have made updates to the rat_in_maze.py file to enhance code clarity.

These updates include:

1.Adding more descriptive comments to explain the logic and steps of the maze-solving algorithm.

2.Introducing variables that allow for easy customization of the source and destination cells within the maze.

3.Refactor path representation in solution:
  • Previously, in solution paths were represented as 1s, but I have updated it to use 0s to align with the standard convention where 0s represent paths and 1s represent walls.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@MuhammadummerrMuhammadummerr
changed the title
New branch[UPDATED]#9066 rat_in_maze.pySep 24, 2023
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Kindly tick the checkboxes while raising PR, don't delete them.
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Kindly tick the checkboxes while raising PR, don't delete them.
Ok, but now how to tick checkboxes when PR is raised?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Replace • [ ] to • [x]
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Sorry, but where?
@rohan472000
rohan472000
commented
Sep 25, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
While creating PR, you will get a box to describe the change, below in the box there are multiple checkboxes to tick.
https://github.com/TheAlgorithms/Python/blob/master/.github/pull_request_template.md
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
should I delete this PR now, and create another one and tick checkboxes?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
No...copy from that link which I provided, and paste it in description box above, then tick required checkboxes.
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Also revise the PR title, don't include 9066, this should be in description box, see contributing guidelines beforehand.
@MuhammadummerrMuhammadummerr
changed the title
[UPDATED]#9066 rat_in_maze.py[UPDATED]rat_in_maze.pySep 25, 2023
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot, your guidance meant a lot to me:)
dlesnoff
dlesnoff
reviewed
Sep 26, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

@Muhammadummerr@dlesnoff
Update backtracking/rat_in_maze.py
8ff2d65
Co-authored-by: dlesnoff <54949944+dlesnoff@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Sep 26, 2023
Muhammadummerr
Muhammadummerr
commented
Sep 26, 2023
View reviewed changes
@MuhammadummerrMuhammadummerr
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the correction.
@dlesnoff
dlesnoff
commented
Sep 27, 2023

Copy link


Copy Markdown

I am not familiar with the Python repository, but I think that you should reflect the changes in the unittest.

What happens if I change the starting cell and the end cell?

An example in the docstring with this new feature would be welcome too.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 28, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
@Muhammadummerr@rohan472000
Update backtracking/rat_in_maze.py
553d1f0
Co-authored-by: Rohan Anand <96521078+rohan472000@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
None would be better.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Use ruff . then ruff . --fix to rectify ruff issues.
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Use ruff . then ruff . --fix to rectify ruff issues.
3 errors found ,then how should I resolve them without using ruff --fix .

On running the file it showing error of whitespaces ====== ,How it can be resolved?
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
run : ruff . --fix
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
still 3 errors found

Desktop\Python\backtracking\rat_in_maze.py:35:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:82:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:105:89: E501 Line too long (216 > 88 characters)
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
using black . showing All done but ruff . --fix showing 3 erros found
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
I understand what the problem is. The output of solve_maze is a 2D array written in the docstring as [[0, 1, 1], [0, 0, 1], [0, 0, 1]], but it exceeds the 88-character word limit. Now, when I format the line, the expected output does not match the obtained output. Can you help me in how to approach this issue now?
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
@rohan472000rohan472000
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove print statement as it is returning None.
Comment threadbacktracking/rat_in_maze.py
Outdated

 size = len(maze)
 # Check if source and destination coordinates are Invalid.
 if not (0 <= source_row <= size - 1 and 0 <= source_column <= size - 1):
 print("Invalid source coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid source coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

 print("Invalid source coordinates")
 return None
 elif not (0 <= destination_row <= size - 1 and 0 <= destination_column <= size - 1):
 print("Invalid destination coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid destination coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

print("\n".join(str(row) for row in solutions))
return solutions
 else:
 print("No solution exists!")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("No solution exists!")
@tianyizheng02
tianyizheng02
commented
Sep 30, 2023

Copy link


Copy Markdown

Contributor
Thank you for your contribution, but unfortunately we're not accepting new PRs at the moment. We're currently trying to clear our backlog of existing PRs in preparation for Hacktoberfest. If you want to contribute, please wait until after October 1 to do so. See this discussion for more info.
@Muhammadummerr
Muhammadummerr
deleted the

new_branch

branch
September 30, 2023 16:24
@dlesnoff
dlesnoff
commented
Oct 1, 2023•

edited

Loading

Copy link


Copy Markdown

At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
The '>>>>>>>' and '======' stuff comes from the git merge. When there is a conflict (a file being changed in the two original branches), git modify the file and let the two code versions in the same file separated by <<<<<<<, ========== and >>>>>>. See the Git documentation.
@Muhammadummerr Muhammadummerr deleted the new_branch branch
Why did you deleted the branch? It is a temporary closed PR. A link to the new PR would have been welcomed!
@dlesnoffdlesnoff
mentioned this pull request
Oct 3, 2023
 Merged

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dlesnoffdlesnoffAwaiting requested review from dlesnoff
@rohan472000rohan472000Awaiting requested review from rohan472000

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Backtracking/Rat Maze


4 participants

@Muhammadummerr@rohan472000@dlesnoff@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[UPDATED]rat_in_maze.py - #9087
Closed
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Closed
[UPDATED]rat_in_maze.py#9087
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Conversation
@Muhammadummerr
@MuhammadummerrMuhammadummerr
commented
Sep 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
FIXES#9066

I have made updates to the rat_in_maze.py file to enhance code clarity.

These updates include:

1.Adding more descriptive comments to explain the logic and steps of the maze-solving algorithm.

2.Introducing variables that allow for easy customization of the source and destination cells within the maze.

3.Refactor path representation in solution:
  • Previously, in solution paths were represented as 1s, but I have updated it to use 0s to align with the standard convention where 0s represent paths and 1s represent walls.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@MuhammadummerrMuhammadummerr
changed the title
New branch[UPDATED]#9066 rat_in_maze.pySep 24, 2023
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Kindly tick the checkboxes while raising PR, don't delete them.
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Kindly tick the checkboxes while raising PR, don't delete them.
Ok, but now how to tick checkboxes when PR is raised?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Replace • [ ] to • [x]
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Sorry, but where?
@rohan472000
rohan472000
commented
Sep 25, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
While creating PR, you will get a box to describe the change, below in the box there are multiple checkboxes to tick.
https://github.com/TheAlgorithms/Python/blob/master/.github/pull_request_template.md
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
should I delete this PR now, and create another one and tick checkboxes?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
No...copy from that link which I provided, and paste it in description box above, then tick required checkboxes.
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Also revise the PR title, don't include 9066, this should be in description box, see contributing guidelines beforehand.
@MuhammadummerrMuhammadummerr
changed the title
[UPDATED]#9066 rat_in_maze.py[UPDATED]rat_in_maze.pySep 25, 2023
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot, your guidance meant a lot to me:)
dlesnoff
dlesnoff
reviewed
Sep 26, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

@Muhammadummerr@dlesnoff
Update backtracking/rat_in_maze.py
8ff2d65
Co-authored-by: dlesnoff <54949944+dlesnoff@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Sep 26, 2023
Muhammadummerr
Muhammadummerr
commented
Sep 26, 2023
View reviewed changes
@MuhammadummerrMuhammadummerr
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the correction.
@dlesnoff
dlesnoff
commented
Sep 27, 2023

Copy link


Copy Markdown

I am not familiar with the Python repository, but I think that you should reflect the changes in the unittest.

What happens if I change the starting cell and the end cell?

An example in the docstring with this new feature would be welcome too.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 28, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
@Muhammadummerr@rohan472000
Update backtracking/rat_in_maze.py
553d1f0
Co-authored-by: Rohan Anand <96521078+rohan472000@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
None would be better.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Use ruff . then ruff . --fix to rectify ruff issues.
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Use ruff . then ruff . --fix to rectify ruff issues.
3 errors found ,then how should I resolve them without using ruff --fix .

On running the file it showing error of whitespaces ====== ,How it can be resolved?
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
run : ruff . --fix
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
still 3 errors found

Desktop\Python\backtracking\rat_in_maze.py:35:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:82:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:105:89: E501 Line too long (216 > 88 characters)
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
using black . showing All done but ruff . --fix showing 3 erros found
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
I understand what the problem is. The output of solve_maze is a 2D array written in the docstring as [[0, 1, 1], [0, 0, 1], [0, 0, 1]], but it exceeds the 88-character word limit. Now, when I format the line, the expected output does not match the obtained output. Can you help me in how to approach this issue now?
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
@rohan472000rohan472000
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove print statement as it is returning None.
Comment threadbacktracking/rat_in_maze.py
Outdated

 size = len(maze)
 # Check if source and destination coordinates are Invalid.
 if not (0 <= source_row <= size - 1 and 0 <= source_column <= size - 1):
 print("Invalid source coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid source coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

 print("Invalid source coordinates")
 return None
 elif not (0 <= destination_row <= size - 1 and 0 <= destination_column <= size - 1):
 print("Invalid destination coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid destination coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

print("\n".join(str(row) for row in solutions))
return solutions
 else:
 print("No solution exists!")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("No solution exists!")
@tianyizheng02
tianyizheng02
commented
Sep 30, 2023

Copy link


Copy Markdown

Contributor
Thank you for your contribution, but unfortunately we're not accepting new PRs at the moment. We're currently trying to clear our backlog of existing PRs in preparation for Hacktoberfest. If you want to contribute, please wait until after October 1 to do so. See this discussion for more info.
@Muhammadummerr
Muhammadummerr
deleted the

new_branch

branch
September 30, 2023 16:24
@dlesnoff
dlesnoff
commented
Oct 1, 2023•

edited

Loading

Copy link


Copy Markdown

At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
The '>>>>>>>' and '======' stuff comes from the git merge. When there is a conflict (a file being changed in the two original branches), git modify the file and let the two code versions in the same file separated by <<<<<<<, ========== and >>>>>>. See the Git documentation.
@Muhammadummerr Muhammadummerr deleted the new_branch branch
Why did you deleted the branch? It is a temporary closed PR. A link to the new PR would have been welcomed!
@dlesnoffdlesnoff
mentioned this pull request
Oct 3, 2023
 Merged

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dlesnoffdlesnoffAwaiting requested review from dlesnoff
@rohan472000rohan472000Awaiting requested review from rohan472000

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Backtracking/Rat Maze


4 participants

@Muhammadummerr@rohan472000@dlesnoff@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[UPDATED]rat_in_maze.py - #9087
Closed
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Closed
[UPDATED]rat_in_maze.py#9087
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Conversation
@Muhammadummerr
@MuhammadummerrMuhammadummerr
commented
Sep 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
FIXES#9066

I have made updates to the rat_in_maze.py file to enhance code clarity.

These updates include:

1.Adding more descriptive comments to explain the logic and steps of the maze-solving algorithm.

2.Introducing variables that allow for easy customization of the source and destination cells within the maze.

3.Refactor path representation in solution:
  • Previously, in solution paths were represented as 1s, but I have updated it to use 0s to align with the standard convention where 0s represent paths and 1s represent walls.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@MuhammadummerrMuhammadummerr
changed the title
New branch[UPDATED]#9066 rat_in_maze.pySep 24, 2023
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Kindly tick the checkboxes while raising PR, don't delete them.
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Kindly tick the checkboxes while raising PR, don't delete them.
Ok, but now how to tick checkboxes when PR is raised?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Replace • [ ] to • [x]
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Sorry, but where?
@rohan472000
rohan472000
commented
Sep 25, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
While creating PR, you will get a box to describe the change, below in the box there are multiple checkboxes to tick.
https://github.com/TheAlgorithms/Python/blob/master/.github/pull_request_template.md
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
should I delete this PR now, and create another one and tick checkboxes?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
No...copy from that link which I provided, and paste it in description box above, then tick required checkboxes.
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Also revise the PR title, don't include 9066, this should be in description box, see contributing guidelines beforehand.
@MuhammadummerrMuhammadummerr
changed the title
[UPDATED]#9066 rat_in_maze.py[UPDATED]rat_in_maze.pySep 25, 2023
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot, your guidance meant a lot to me:)
dlesnoff
dlesnoff
reviewed
Sep 26, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

@Muhammadummerr@dlesnoff
Update backtracking/rat_in_maze.py
8ff2d65
Co-authored-by: dlesnoff <54949944+dlesnoff@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Sep 26, 2023
Muhammadummerr
Muhammadummerr
commented
Sep 26, 2023
View reviewed changes
@MuhammadummerrMuhammadummerr
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the correction.
@dlesnoff
dlesnoff
commented
Sep 27, 2023

Copy link


Copy Markdown

I am not familiar with the Python repository, but I think that you should reflect the changes in the unittest.

What happens if I change the starting cell and the end cell?

An example in the docstring with this new feature would be welcome too.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 28, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
@Muhammadummerr@rohan472000
Update backtracking/rat_in_maze.py
553d1f0
Co-authored-by: Rohan Anand <96521078+rohan472000@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
None would be better.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Use ruff . then ruff . --fix to rectify ruff issues.
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Use ruff . then ruff . --fix to rectify ruff issues.
3 errors found ,then how should I resolve them without using ruff --fix .

On running the file it showing error of whitespaces ====== ,How it can be resolved?
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
run : ruff . --fix
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
still 3 errors found

Desktop\Python\backtracking\rat_in_maze.py:35:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:82:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:105:89: E501 Line too long (216 > 88 characters)
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
using black . showing All done but ruff . --fix showing 3 erros found
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
I understand what the problem is. The output of solve_maze is a 2D array written in the docstring as [[0, 1, 1], [0, 0, 1], [0, 0, 1]], but it exceeds the 88-character word limit. Now, when I format the line, the expected output does not match the obtained output. Can you help me in how to approach this issue now?
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
@rohan472000rohan472000
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove print statement as it is returning None.
Comment threadbacktracking/rat_in_maze.py
Outdated

 size = len(maze)
 # Check if source and destination coordinates are Invalid.
 if not (0 <= source_row <= size - 1 and 0 <= source_column <= size - 1):
 print("Invalid source coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid source coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

 print("Invalid source coordinates")
 return None
 elif not (0 <= destination_row <= size - 1 and 0 <= destination_column <= size - 1):
 print("Invalid destination coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid destination coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

print("\n".join(str(row) for row in solutions))
return solutions
 else:
 print("No solution exists!")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("No solution exists!")
@tianyizheng02
tianyizheng02
commented
Sep 30, 2023

Copy link


Copy Markdown

Contributor
Thank you for your contribution, but unfortunately we're not accepting new PRs at the moment. We're currently trying to clear our backlog of existing PRs in preparation for Hacktoberfest. If you want to contribute, please wait until after October 1 to do so. See this discussion for more info.
@Muhammadummerr
Muhammadummerr
deleted the

new_branch

branch
September 30, 2023 16:24
@dlesnoff
dlesnoff
commented
Oct 1, 2023•

edited

Loading

Copy link


Copy Markdown

At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
The '>>>>>>>' and '======' stuff comes from the git merge. When there is a conflict (a file being changed in the two original branches), git modify the file and let the two code versions in the same file separated by <<<<<<<, ========== and >>>>>>. See the Git documentation.
@Muhammadummerr Muhammadummerr deleted the new_branch branch
Why did you deleted the branch? It is a temporary closed PR. A link to the new PR would have been welcomed!
@dlesnoffdlesnoff
mentioned this pull request
Oct 3, 2023
 Merged

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dlesnoffdlesnoffAwaiting requested review from dlesnoff
@rohan472000rohan472000Awaiting requested review from rohan472000

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Backtracking/Rat Maze


4 participants

@Muhammadummerr@rohan472000@dlesnoff@tianyizheng02

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[UPDATED]rat_in_maze.py - #9087
Closed
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Closed
[UPDATED]rat_in_maze.py#9087
Muhammadummerr wants to merge 22 commits into
TheAlgorithms:masterfrom 
Muhammadummerr:new_branch
Conversation
@Muhammadummerr
@MuhammadummerrMuhammadummerr
commented
Sep 24, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
Describe your change:
FIXES#9066

I have made updates to the rat_in_maze.py file to enhance code clarity.

These updates include:

1.Adding more descriptive comments to explain the logic and steps of the maze-solving algorithm.

2.Introducing variables that allow for easy customization of the source and destination cells within the maze.

3.Refactor path representation in solution:
  • Previously, in solution paths were represented as 1s, but I have updated it to use 0s to align with the standard convention where 0s represent paths and 1s represent walls.
  •  Add an algorithm?
  •  Fix a bug or typo in an existing algorithm?
  •  Documentation change?
Checklist:
  •  I have read CONTRIBUTING.md.
  •  This pull request is all my own work -- I have not plagiarized.
  •  I know that pull requests will not be merged if they fail the automated tests.
  •  This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  •  All new Python files are placed inside an existing directory.
  •  All filenames are in all lowercase characters with no spaces or dashes.
  •  All functions and variable names follow Python naming conventions.
  •  All function parameters and return values are annotated with Python type hints.
  •  All functions have doctests that pass the automated testing.
  •  All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  •  If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".
@MuhammadummerrMuhammadummerr
changed the title
New branch[UPDATED]#9066 rat_in_maze.pySep 24, 2023
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Kindly tick the checkboxes while raising PR, don't delete them.
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Kindly tick the checkboxes while raising PR, don't delete them.
Ok, but now how to tick checkboxes when PR is raised?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Replace • [ ] to • [x]
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Sorry, but where?
@rohan472000
rohan472000
commented
Sep 25, 2023•

edited

Loading

Copy link


Copy Markdown

Contributor
While creating PR, you will get a box to describe the change, below in the box there are multiple checkboxes to tick.
https://github.com/TheAlgorithms/Python/blob/master/.github/pull_request_template.md
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
should I delete this PR now, and create another one and tick checkboxes?
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
No...copy from that link which I provided, and paste it in description box above, then tick required checkboxes.
@rohan472000
rohan472000
commented
Sep 25, 2023

Copy link


Copy Markdown

Contributor
Also revise the PR title, don't include 9066, this should be in description box, see contributing guidelines beforehand.
@MuhammadummerrMuhammadummerr
changed the title
[UPDATED]#9066 rat_in_maze.py[UPDATED]rat_in_maze.pySep 25, 2023
@Muhammadummerr
Muhammadummerr
commented
Sep 25, 2023

Copy link


Copy Markdown

ContributorAuthor
Thanks a lot, your guidance meant a lot to me:)
dlesnoff
dlesnoff
reviewed
Sep 26, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

@Muhammadummerr@dlesnoff
Update backtracking/rat_in_maze.py
8ff2d65
Co-authored-by: dlesnoff <54949944+dlesnoff@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
added
the 
awaiting reviews
This PR is ready to be reviewed
label
Sep 26, 2023
Muhammadummerr
Muhammadummerr
commented
Sep 26, 2023
View reviewed changes
@MuhammadummerrMuhammadummerr
left a comment


Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the correction.
@dlesnoff
dlesnoff
commented
Sep 27, 2023

Copy link


Copy Markdown

I am not familiar with the Python repository, but I think that you should reflect the changes in the unittest.

What happens if I change the starting cell and the end cell?

An example in the docstring with this new feature would be welcome too.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 28, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

Comment threadbacktracking/rat_in_maze.py
Outdated

@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
@Muhammadummerr@rohan472000
Update backtracking/rat_in_maze.py
553d1f0
Co-authored-by: Rohan Anand <96521078+rohan472000@users.noreply.github.com>
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
None would be better.
@algorithms-keeperalgorithms-keeperBot
added
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
Use ruff . then ruff . --fix to rectify ruff issues.
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
Use ruff . then ruff . --fix to rectify ruff issues.
3 errors found ,then how should I resolve them without using ruff --fix .

On running the file it showing error of whitespaces ====== ,How it can be resolved?
@rohan472000
rohan472000
commented
Sep 29, 2023

Copy link


Copy Markdown

Contributor
run : ruff . --fix
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
still 3 errors found

Desktop\Python\backtracking\rat_in_maze.py:35:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:82:89: E501 Line too long (93 > 88 characters)

Desktop\Python\backtracking\rat_in_maze.py:105:89: E501 Line too long (216 > 88 characters)
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
run : ruff . --fix
using black . showing All done but ruff . --fix showing 3 erros found
@Muhammadummerr
Muhammadummerr
commented
Sep 29, 2023

Copy link


Copy Markdown

ContributorAuthor
I understand what the problem is. The output of solve_maze is a 2D array written in the docstring as [[0, 1, 1], [0, 0, 1], [0, 0, 1]], but it exceeds the 88-character word limit. Now, when I format the line, the expected output does not match the obtained output. Can you help me in how to approach this issue now?
@algorithms-keeperalgorithms-keeperBot
removed
the 
tests are failing
Do not merge until tests pass
label
Sep 29, 2023
rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
Comment threadbacktracking/rat_in_maze.py
Outdated

rohan472000
rohan472000
suggested changes
Sep 29, 2023
View reviewed changes
@rohan472000rohan472000
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove print statement as it is returning None.
Comment threadbacktracking/rat_in_maze.py
Outdated

 size = len(maze)
 # Check if source and destination coordinates are Invalid.
 if not (0 <= source_row <= size - 1 and 0 <= source_column <= size - 1):
 print("Invalid source coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid source coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

 print("Invalid source coordinates")
 return None
 elif not (0 <= destination_row <= size - 1 and 0 <= destination_column <= size - 1):
 print("Invalid destination coordinates")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("Invalid destination coordinates")
Comment threadbacktracking/rat_in_maze.py
Outdated

print("\n".join(str(row) for row in solutions))
return solutions
 else:
 print("No solution exists!")
@rohan472000rohan472000Sep 29, 2023

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

print("No solution exists!")
@tianyizheng02
tianyizheng02
commented
Sep 30, 2023

Copy link


Copy Markdown

Contributor
Thank you for your contribution, but unfortunately we're not accepting new PRs at the moment. We're currently trying to clear our backlog of existing PRs in preparation for Hacktoberfest. If you want to contribute, please wait until after October 1 to do so. See this discussion for more info.
@Muhammadummerr
Muhammadummerr
deleted the

new_branch

branch
September 30, 2023 16:24
@dlesnoff
dlesnoff
commented
Oct 1, 2023•

edited

Loading

Copy link


Copy Markdown

At line 19, a lack of a blank line after >>>: '>>>>>>> origin/new_branch' is given in error but text '>>>>>>> origin/new_branch' doesn't appear to be related to the code or docstring.
I have suggested change, commit that and see if it resolves the issue or not.
The '>>>>>>>' and '======' stuff comes from the git merge. When there is a conflict (a file being changed in the two original branches), git modify the file and let the two code versions in the same file separated by <<<<<<<, ========== and >>>>>>. See the Git documentation.
@Muhammadummerr Muhammadummerr deleted the new_branch branch
Why did you deleted the branch? It is a temporary closed PR. A link to the new PR would have been welcomed!
@dlesnoffdlesnoff
mentioned this pull request
Oct 3, 2023
 Merged

14 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@dlesnoffdlesnoffAwaiting requested review from dlesnoff
@rohan472000rohan472000Awaiting requested review from rohan472000

Assignees


No one assigned


Labels

awaiting reviewsThis PR is ready to be reviewed

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

Backtracking/Rat Maze


4 participants

@Muhammadummerr@rohan472000@dlesnoff@tianyizheng02