Uh oh!
There was an error while loading. Please reload this page.
fix(client): version-skew warning + compiled-XML model fallback - #3
Open
jonathanembleyriches wants to merge 2 commits into
Open
fix(client): version-skew warning + compiled-XML model fallback#3jonathanembleyriches wants to merge 2 commits into
jonathanembleyriches wants to merge 2 commits into
Conversation
…XML model An unloadable MJB (cross-version) now falls back to building the local model from the handshake's mjcf_compiled + vfs_assets instead of leaving art.joints/art.actuators silently empty. Removes the local_model=False bypasses from the dashboard and integration conftest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A client built with `local_model=False`, or one whose MJB fails to load (the MJB binary format is version-locked to the exact MuJoCo release that saved it), ends up with empty `art.joints` / `art.actuators` and no warning. Every name-based consumer then no-ops: the RoboJuDo policy adapter logs `dof joint 'X' not found in art.joints` for all 29 DoFs, drops all ctrl, and the robot stands still while the pipeline steps. The dashboard shipped exactly this state via a temporary `local_model=False` bypass, which is what URLab-Sim/UnrealRoboticsLab#76 ran into.
Changes
Testing
4 new tests: skew warns not raises, bypass stays silent, unloadable MJB falls back to compiled XML, unloadable MJB without XML warns loudly. Verified live end to end: dashboard -> BeyondMimic on a G1 scene resolves all 29 joints and the robot tracks the policy.