Minor: Code formatting

[patricknelson]

A few modifications (goals hinted at in #101):

• Ensure file formatting is consistent with .editorconfig.
  • NOTE: Files were autoformatted using PhpStorm which has been configured to conform to .editorconfig so you will notice it has also introduced space around the equal sign for variable assignment (e.g. $var=1 changed to $var = 1).
• Remove excess closing ?> tags
• Merging separate else if into single elseif keyword (this is just a common style/aesthetic choice but functions precisely the same as else if).

Recommendation:

Also, I would recommend abstracting the many calls to !empty($this->custom_relation_name) ? $this->custom_relation_name : $gridField->getName()) to a method which accepts the GridField as a parameter. It could be possibly abstracted a bit further. I just noticed this repeated code while skimming and figured it could be a bit more DRY (not originally the purpose of this PR).

[UndefinedOffset]

Thanks for this going to merge as part of the changes to support SS 4.x when I find the time to do it :S. As a side I've never been much of a fan of elseif since not many (if any) other programming languages use it.

[patricknelson]

You're right, it's just a PHP'ism (in this case surprisingly not a bad one per se, given PHP's... quirks). Since PHP has it, I typically utilize it's built-in elseif keyword for style/aesthetic reasons only anyway. I can remove it!

[UndefinedOffset]

I can also just replace them when after merging, gonna be allot of changes to make this module 4.0 compatible anyways. Which I do want to tackle, mostly to learn so I can be ready to start building client sites when 4.0 comes out ;).

[UndefinedOffset]

Looks like this was also included in 106 which brings compatibility for SilverStripe 4, thanks again

[patricknelson]

A few modifications (goals hinted at in #101):

• Ensure file formatting is consistent with .editorconfig.
  • NOTE: Files were autoformatted using PhpStorm which has been configured to conform to .editorconfig so you will notice it has also introduced space around the equal sign for variable assignment (e.g. $var=1 changed to $var = 1).
• Remove excess closing ?> tags
• Merging separate else if into single elseif keyword (this is just a common style/aesthetic choice but functions precisely the same as else if).

Recommendation:

Also, I would recommend abstracting the many calls to !empty($this->custom_relation_name) ? $this->custom_relation_name : $gridField->getName()) to a method which accepts the GridField as a parameter. It could be possibly abstracted a bit further. I just noticed this repeated code while skimming and figured it could be a bit more DRY (not originally the purpose of this PR).

[UndefinedOffset]

Thanks for this going to merge as part of the changes to support SS 4.x when I find the time to do it :S. As a side I've never been much of a fan of elseif since not many (if any) other programming languages use it.

[patricknelson]

You're right, it's just a PHP'ism (in this case surprisingly not a bad one per se, given PHP's... quirks). Since PHP has it, I typically utilize it's built-in elseif keyword for style/aesthetic reasons only anyway. I can remove it!

[UndefinedOffset]

I can also just replace them when after merging, gonna be allot of changes to make this module 4.0 compatible anyways. Which I do want to tackle, mostly to learn so I can be ready to start building client sites when 4.0 comes out ;).

[UndefinedOffset]

Looks like this was also included in 106 which brings compatibility for SilverStripe 4, thanks again

[patricknelson]

A few modifications (goals hinted at in #101):

• Ensure file formatting is consistent with .editorconfig.
  • NOTE: Files were autoformatted using PhpStorm which has been configured to conform to .editorconfig so you will notice it has also introduced space around the equal sign for variable assignment (e.g. $var=1 changed to $var = 1).
• Remove excess closing ?> tags
• Merging separate else if into single elseif keyword (this is just a common style/aesthetic choice but functions precisely the same as else if).

Recommendation:

Also, I would recommend abstracting the many calls to !empty($this->custom_relation_name) ? $this->custom_relation_name : $gridField->getName()) to a method which accepts the GridField as a parameter. It could be possibly abstracted a bit further. I just noticed this repeated code while skimming and figured it could be a bit more DRY (not originally the purpose of this PR).

[UndefinedOffset]

Thanks for this going to merge as part of the changes to support SS 4.x when I find the time to do it :S. As a side I've never been much of a fan of elseif since not many (if any) other programming languages use it.

[patricknelson]

You're right, it's just a PHP'ism (in this case surprisingly not a bad one per se, given PHP's... quirks). Since PHP has it, I typically utilize it's built-in elseif keyword for style/aesthetic reasons only anyway. I can remove it!

[UndefinedOffset]

I can also just replace them when after merging, gonna be allot of changes to make this module 4.0 compatible anyways. Which I do want to tackle, mostly to learn so I can be ready to start building client sites when 4.0 comes out ;).

[UndefinedOffset]

Looks like this was also included in 106 which brings compatibility for SilverStripe 4, thanks again

[patricknelson]

A few modifications (goals hinted at in #101):

• Ensure file formatting is consistent with .editorconfig.
  • NOTE: Files were autoformatted using PhpStorm which has been configured to conform to .editorconfig so you will notice it has also introduced space around the equal sign for variable assignment (e.g. $var=1 changed to $var = 1).
• Remove excess closing ?> tags
• Merging separate else if into single elseif keyword (this is just a common style/aesthetic choice but functions precisely the same as else if).

Recommendation:

Also, I would recommend abstracting the many calls to !empty($this->custom_relation_name) ? $this->custom_relation_name : $gridField->getName()) to a method which accepts the GridField as a parameter. It could be possibly abstracted a bit further. I just noticed this repeated code while skimming and figured it could be a bit more DRY (not originally the purpose of this PR).

[UndefinedOffset]

Thanks for this going to merge as part of the changes to support SS 4.x when I find the time to do it :S. As a side I've never been much of a fan of elseif since not many (if any) other programming languages use it.

[patricknelson]

You're right, it's just a PHP'ism (in this case surprisingly not a bad one per se, given PHP's... quirks). Since PHP has it, I typically utilize it's built-in elseif keyword for style/aesthetic reasons only anyway. I can remove it!

[UndefinedOffset]

I can also just replace them when after merging, gonna be allot of changes to make this module 4.0 compatible anyways. Which I do want to tackle, mostly to learn so I can be ready to start building client sites when 4.0 comes out ;).

[UndefinedOffset]

Looks like this was also included in 106 which brings compatibility for SilverStripe 4, thanks again

[patricknelson]

A few modifications (goals hinted at in #101):

• Ensure file formatting is consistent with .editorconfig.
  • NOTE: Files were autoformatted using PhpStorm which has been configured to conform to .editorconfig so you will notice it has also introduced space around the equal sign for variable assignment (e.g. $var=1 changed to $var = 1).
• Remove excess closing ?> tags
• Merging separate else if into single elseif keyword (this is just a common style/aesthetic choice but functions precisely the same as else if).

Recommendation:

Also, I would recommend abstracting the many calls to !empty($this->custom_relation_name) ? $this->custom_relation_name : $gridField->getName()) to a method which accepts the GridField as a parameter. It could be possibly abstracted a bit further. I just noticed this repeated code while skimming and figured it could be a bit more DRY (not originally the purpose of this PR).

[UndefinedOffset]

Thanks for this going to merge as part of the changes to support SS 4.x when I find the time to do it :S. As a side I've never been much of a fan of elseif since not many (if any) other programming languages use it.

[patricknelson]

You're right, it's just a PHP'ism (in this case surprisingly not a bad one per se, given PHP's... quirks). Since PHP has it, I typically utilize it's built-in elseif keyword for style/aesthetic reasons only anyway. I can remove it!

[UndefinedOffset]

I can also just replace them when after merging, gonna be allot of changes to make this module 4.0 compatible anyways. Which I do want to tackle, mostly to learn so I can be ready to start building client sites when 4.0 comes out ;).

[UndefinedOffset]

Looks like this was also included in 106 which brings compatibility for SilverStripe 4, thanks again

[patricknelson]

A few modifications (goals hinted at in #101):

• Ensure file formatting is consistent with .editorconfig.
  • NOTE: Files were autoformatted using PhpStorm which has been configured to conform to .editorconfig so you will notice it has also introduced space around the equal sign for variable assignment (e.g. $var=1 changed to $var = 1).
• Remove excess closing ?> tags
• Merging separate else if into single elseif keyword (this is just a common style/aesthetic choice but functions precisely the same as else if).

Recommendation:

Also, I would recommend abstracting the many calls to !empty($this->custom_relation_name) ? $this->custom_relation_name : $gridField->getName()) to a method which accepts the GridField as a parameter. It could be possibly abstracted a bit further. I just noticed this repeated code while skimming and figured it could be a bit more DRY (not originally the purpose of this PR).

[UndefinedOffset]

Thanks for this going to merge as part of the changes to support SS 4.x when I find the time to do it :S. As a side I've never been much of a fan of elseif since not many (if any) other programming languages use it.

[patricknelson]

You're right, it's just a PHP'ism (in this case surprisingly not a bad one per se, given PHP's... quirks). Since PHP has it, I typically utilize it's built-in elseif keyword for style/aesthetic reasons only anyway. I can remove it!

[UndefinedOffset]

I can also just replace them when after merging, gonna be allot of changes to make this module 4.0 compatible anyways. Which I do want to tackle, mostly to learn so I can be ready to start building client sites when 4.0 comes out ;).

[UndefinedOffset]

Looks like this was also included in 106 which brings compatibility for SilverStripe 4, thanks again

[patricknelson]

A few modifications (goals hinted at in #101):

• Ensure file formatting is consistent with .editorconfig.
  • NOTE: Files were autoformatted using PhpStorm which has been configured to conform to .editorconfig so you will notice it has also introduced space around the equal sign for variable assignment (e.g. $var=1 changed to $var = 1).
• Remove excess closing ?> tags
• Merging separate else if into single elseif keyword (this is just a common style/aesthetic choice but functions precisely the same as else if).

Recommendation:

Also, I would recommend abstracting the many calls to !empty($this->custom_relation_name) ? $this->custom_relation_name : $gridField->getName()) to a method which accepts the GridField as a parameter. It could be possibly abstracted a bit further. I just noticed this repeated code while skimming and figured it could be a bit more DRY (not originally the purpose of this PR).

[UndefinedOffset]

Thanks for this going to merge as part of the changes to support SS 4.x when I find the time to do it :S. As a side I've never been much of a fan of elseif since not many (if any) other programming languages use it.

[patricknelson]

You're right, it's just a PHP'ism (in this case surprisingly not a bad one per se, given PHP's... quirks). Since PHP has it, I typically utilize it's built-in elseif keyword for style/aesthetic reasons only anyway. I can remove it!

[UndefinedOffset]

I can also just replace them when after merging, gonna be allot of changes to make this module 4.0 compatible anyways. Which I do want to tackle, mostly to learn so I can be ready to start building client sites when 4.0 comes out ;).

[UndefinedOffset]

Looks like this was also included in 106 which brings compatibility for SilverStripe 4, thanks again

[patricknelson]

A few modifications (goals hinted at in #101):

• Ensure file formatting is consistent with .editorconfig.
  • NOTE: Files were autoformatted using PhpStorm which has been configured to conform to .editorconfig so you will notice it has also introduced space around the equal sign for variable assignment (e.g. $var=1 changed to $var = 1).
• Remove excess closing ?> tags
• Merging separate else if into single elseif keyword (this is just a common style/aesthetic choice but functions precisely the same as else if).

Recommendation:

Also, I would recommend abstracting the many calls to !empty($this->custom_relation_name) ? $this->custom_relation_name : $gridField->getName()) to a method which accepts the GridField as a parameter. It could be possibly abstracted a bit further. I just noticed this repeated code while skimming and figured it could be a bit more DRY (not originally the purpose of this PR).

[UndefinedOffset]

Thanks for this going to merge as part of the changes to support SS 4.x when I find the time to do it :S. As a side I've never been much of a fan of elseif since not many (if any) other programming languages use it.

[patricknelson]

You're right, it's just a PHP'ism (in this case surprisingly not a bad one per se, given PHP's... quirks). Since PHP has it, I typically utilize it's built-in elseif keyword for style/aesthetic reasons only anyway. I can remove it!

[UndefinedOffset]

I can also just replace them when after merging, gonna be allot of changes to make this module 4.0 compatible anyways. Which I do want to tackle, mostly to learn so I can be ready to start building client sites when 4.0 comes out ;).

[UndefinedOffset]

Looks like this was also included in 106 which brings compatibility for SilverStripe 4, thanks again