SS4 Compatibility - #106

Closed
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom
zanderwar:todo/ss4-upgrade
Closed

SS4 Compatibility#106
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom
zanderwar:todo/ss4-upgrade

Conversation

@zanderwar

@zanderwarzanderwar commented May 27, 2017•
edited
Loading

Copy link
Copy Markdown

This PR is a compatibility upgrade to SilverStripe 4.x

Todo

  • Namespacing
  • Update all previously deprecated and/or now removed classes/functions
  • Ensure tests pass
    • Update fixtures to use FQCN
  • Update README.md
  • Update composer.json
  • Update .travis.yml and .scrutinizer.yml
  • Ensure examples are working
  • Clean up display of the sortable grid header

@zanderwarzanderwar mentioned this pull request May 27, 2017
Closed
10 tasks
@UndefinedOffset

UndefinedOffset commented May 27, 2017

Copy link
Copy Markdown
Owner

Watch when you squash this, I think if you include the first two commits in the squash you'll loose the history because too much will change and git will see it as a new file. Also before I merge this (which will be next week likely) I may start a 2.0.x branch or at least start with #103 and #102. The later brings code formatting inline with the core.

@zanderwar

zanderwar commented May 27, 2017

Copy link
Copy Markdown
Author

Correct, have been stung by the renames before hence the seperate commits purely for those reasons :)

@zanderwar

zanderwar commented May 27, 2017

Copy link
Copy Markdown
Author

I'd go for dropping that latter PR in favour of this just to reduce any concern of conflict

@zanderwar
zanderwarforce-pushed the todo/ss4-upgrade branch 5 times, most recently from 6a936f0 to 826d0fbCompareMay 27, 2017 04:03
@zanderwar

zanderwar commented May 27, 2017•
edited
Loading

Copy link
Copy Markdown
Author

Javascript appears to be perfectly fine, so theres no urgent rush to port it over to the new API at this moment

Actually there seems to be an issue with the ItemIDs key not existing when clicking the buttons in the header that are usually hidden

PHP Fatal error: No items to sort in /Applications/MAMP/htdocs/alpha7/sortablegridfield/src/Forms/GridFieldSortableRows.php on line 446

Other than that, the drag and drop sort works perfect

CSS needs some love

@zanderwarzanderwar mentioned this pull request May 28, 2017
Closed
@UndefinedOffset
UndefinedOffset changed the base branch from master to 2.0.xJune 5, 2017 12:39
@UndefinedOffset

UndefinedOffset commented Jun 5, 2017

Copy link
Copy Markdown
Owner

This is merged into the 2.0.x branch, not sure why this didn't auto marked merged, probably because I merged it to another branch

@zanderwarzanderwar changed the title WIP: SS4 CompatibilitySS4 CompatibilityJun 14, 2017
@zanderwar

zanderwar commented Jun 14, 2017

Copy link
Copy Markdown
Author

May have been the WIP. I know gitlab prevents it atleast

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zanderwar@UndefinedOffset
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
SS4 Compatibility - #106
Closed
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Closed
SS4 Compatibility#106
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Conversation
@zanderwar
@zanderwarzanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

This PR is a compatibility upgrade to SilverStripe 4.x
Todo
  •  Namespacing
  •  Update all previously deprecated and/or now removed classes/functions
  •  Ensure tests pass

    •  Update fixtures to use FQCN
  •  Update README.md
  •  Update composer.json
  •  Update .travis.yml and .scrutinizer.yml
  •  Ensure examples are working
  •  Clean up display of the sortable grid header
@zanderwarzanderwar
mentioned this pull request
May 27, 2017

Closed

10 tasks
@UndefinedOffset
UndefinedOffset
commented
May 27, 2017

Copy link


Copy Markdown

Owner
Watch when you squash this, I think if you include the first two commits in the squash you'll loose the history because too much will change and git will see it as a new file. Also before I merge this (which will be next week likely) I may start a 2.0.x branch or at least start with #103 and #102. The later brings code formatting inline with the core.
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
Correct, have been stung by the renames before hence the seperate commits purely for those reasons :)
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
I'd go for dropping that latter PR in favour of this just to reduce any concern of conflict
@zanderwar
zanderwarforce-pushed
the
todo/ss4-upgrade
branch
5 times, most recently
from
6a936f0 to
826d0fbCompareMay 27, 2017 04:03
@zanderwar
zanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Javascript appears to be perfectly fine, so theres no urgent rush to port it over to the new API at this moment
Actually there seems to be an issue with the ItemIDs key not existing when clicking the buttons in the header that are usually hidden
PHP Fatal error: No items to sort in /Applications/MAMP/htdocs/alpha7/sortablegridfield/src/Forms/GridFieldSortableRows.php on line 446
Other than that, the drag and drop sort works perfect
CSS needs some love
@zanderwarzanderwar
mentioned this pull request
May 28, 2017

Closed

@UndefinedOffset
UndefinedOffset
changed the base branch from
master
to
2.0.xJune 5, 2017 12:39
@UndefinedOffset
UndefinedOffset
commented
Jun 5, 2017

Copy link


Copy Markdown

Owner
This is merged into the 2.0.x branch, not sure why this didn't auto marked merged, probably because I merged it to another branch
@zanderwarzanderwar
changed the title
WIP: SS4 CompatibilitySS4 CompatibilityJun 14, 2017
@zanderwar
zanderwar
commented
Jun 14, 2017

Copy link


Copy Markdown

Author
May have been the WIP. I know gitlab prevents it atleast
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zanderwar@UndefinedOffset

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
SS4 Compatibility - #106
Closed
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Closed
SS4 Compatibility#106
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Conversation
@zanderwar
@zanderwarzanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

This PR is a compatibility upgrade to SilverStripe 4.x
Todo
  •  Namespacing
  •  Update all previously deprecated and/or now removed classes/functions
  •  Ensure tests pass

    •  Update fixtures to use FQCN
  •  Update README.md
  •  Update composer.json
  •  Update .travis.yml and .scrutinizer.yml
  •  Ensure examples are working
  •  Clean up display of the sortable grid header
@zanderwarzanderwar
mentioned this pull request
May 27, 2017

Closed

10 tasks
@UndefinedOffset
UndefinedOffset
commented
May 27, 2017

Copy link


Copy Markdown

Owner
Watch when you squash this, I think if you include the first two commits in the squash you'll loose the history because too much will change and git will see it as a new file. Also before I merge this (which will be next week likely) I may start a 2.0.x branch or at least start with #103 and #102. The later brings code formatting inline with the core.
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
Correct, have been stung by the renames before hence the seperate commits purely for those reasons :)
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
I'd go for dropping that latter PR in favour of this just to reduce any concern of conflict
@zanderwar
zanderwarforce-pushed
the
todo/ss4-upgrade
branch
5 times, most recently
from
6a936f0 to
826d0fbCompareMay 27, 2017 04:03
@zanderwar
zanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Javascript appears to be perfectly fine, so theres no urgent rush to port it over to the new API at this moment
Actually there seems to be an issue with the ItemIDs key not existing when clicking the buttons in the header that are usually hidden
PHP Fatal error: No items to sort in /Applications/MAMP/htdocs/alpha7/sortablegridfield/src/Forms/GridFieldSortableRows.php on line 446
Other than that, the drag and drop sort works perfect
CSS needs some love
@zanderwarzanderwar
mentioned this pull request
May 28, 2017

Closed

@UndefinedOffset
UndefinedOffset
changed the base branch from
master
to
2.0.xJune 5, 2017 12:39
@UndefinedOffset
UndefinedOffset
commented
Jun 5, 2017

Copy link


Copy Markdown

Owner
This is merged into the 2.0.x branch, not sure why this didn't auto marked merged, probably because I merged it to another branch
@zanderwarzanderwar
changed the title
WIP: SS4 CompatibilitySS4 CompatibilityJun 14, 2017
@zanderwar
zanderwar
commented
Jun 14, 2017

Copy link


Copy Markdown

Author
May have been the WIP. I know gitlab prevents it atleast
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zanderwar@UndefinedOffset

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
SS4 Compatibility - #106
Closed
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Closed
SS4 Compatibility#106
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Conversation
@zanderwar
@zanderwarzanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

This PR is a compatibility upgrade to SilverStripe 4.x
Todo
  •  Namespacing
  •  Update all previously deprecated and/or now removed classes/functions
  •  Ensure tests pass

    •  Update fixtures to use FQCN
  •  Update README.md
  •  Update composer.json
  •  Update .travis.yml and .scrutinizer.yml
  •  Ensure examples are working
  •  Clean up display of the sortable grid header
@zanderwarzanderwar
mentioned this pull request
May 27, 2017

Closed

10 tasks
@UndefinedOffset
UndefinedOffset
commented
May 27, 2017

Copy link


Copy Markdown

Owner
Watch when you squash this, I think if you include the first two commits in the squash you'll loose the history because too much will change and git will see it as a new file. Also before I merge this (which will be next week likely) I may start a 2.0.x branch or at least start with #103 and #102. The later brings code formatting inline with the core.
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
Correct, have been stung by the renames before hence the seperate commits purely for those reasons :)
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
I'd go for dropping that latter PR in favour of this just to reduce any concern of conflict
@zanderwar
zanderwarforce-pushed
the
todo/ss4-upgrade
branch
5 times, most recently
from
6a936f0 to
826d0fbCompareMay 27, 2017 04:03
@zanderwar
zanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Javascript appears to be perfectly fine, so theres no urgent rush to port it over to the new API at this moment
Actually there seems to be an issue with the ItemIDs key not existing when clicking the buttons in the header that are usually hidden
PHP Fatal error: No items to sort in /Applications/MAMP/htdocs/alpha7/sortablegridfield/src/Forms/GridFieldSortableRows.php on line 446
Other than that, the drag and drop sort works perfect
CSS needs some love
@zanderwarzanderwar
mentioned this pull request
May 28, 2017

Closed

@UndefinedOffset
UndefinedOffset
changed the base branch from
master
to
2.0.xJune 5, 2017 12:39
@UndefinedOffset
UndefinedOffset
commented
Jun 5, 2017

Copy link


Copy Markdown

Owner
This is merged into the 2.0.x branch, not sure why this didn't auto marked merged, probably because I merged it to another branch
@zanderwarzanderwar
changed the title
WIP: SS4 CompatibilitySS4 CompatibilityJun 14, 2017
@zanderwar
zanderwar
commented
Jun 14, 2017

Copy link


Copy Markdown

Author
May have been the WIP. I know gitlab prevents it atleast
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zanderwar@UndefinedOffset

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
SS4 Compatibility - #106
Closed
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Closed
SS4 Compatibility#106
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Conversation
@zanderwar
@zanderwarzanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

This PR is a compatibility upgrade to SilverStripe 4.x
Todo
  •  Namespacing
  •  Update all previously deprecated and/or now removed classes/functions
  •  Ensure tests pass

    •  Update fixtures to use FQCN
  •  Update README.md
  •  Update composer.json
  •  Update .travis.yml and .scrutinizer.yml
  •  Ensure examples are working
  •  Clean up display of the sortable grid header
@zanderwarzanderwar
mentioned this pull request
May 27, 2017

Closed

10 tasks
@UndefinedOffset
UndefinedOffset
commented
May 27, 2017

Copy link


Copy Markdown

Owner
Watch when you squash this, I think if you include the first two commits in the squash you'll loose the history because too much will change and git will see it as a new file. Also before I merge this (which will be next week likely) I may start a 2.0.x branch or at least start with #103 and #102. The later brings code formatting inline with the core.
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
Correct, have been stung by the renames before hence the seperate commits purely for those reasons :)
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
I'd go for dropping that latter PR in favour of this just to reduce any concern of conflict
@zanderwar
zanderwarforce-pushed
the
todo/ss4-upgrade
branch
5 times, most recently
from
6a936f0 to
826d0fbCompareMay 27, 2017 04:03
@zanderwar
zanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Javascript appears to be perfectly fine, so theres no urgent rush to port it over to the new API at this moment
Actually there seems to be an issue with the ItemIDs key not existing when clicking the buttons in the header that are usually hidden
PHP Fatal error: No items to sort in /Applications/MAMP/htdocs/alpha7/sortablegridfield/src/Forms/GridFieldSortableRows.php on line 446
Other than that, the drag and drop sort works perfect
CSS needs some love
@zanderwarzanderwar
mentioned this pull request
May 28, 2017

Closed

@UndefinedOffset
UndefinedOffset
changed the base branch from
master
to
2.0.xJune 5, 2017 12:39
@UndefinedOffset
UndefinedOffset
commented
Jun 5, 2017

Copy link


Copy Markdown

Owner
This is merged into the 2.0.x branch, not sure why this didn't auto marked merged, probably because I merged it to another branch
@zanderwarzanderwar
changed the title
WIP: SS4 CompatibilitySS4 CompatibilityJun 14, 2017
@zanderwar
zanderwar
commented
Jun 14, 2017

Copy link


Copy Markdown

Author
May have been the WIP. I know gitlab prevents it atleast
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zanderwar@UndefinedOffset

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
SS4 Compatibility - #106
Closed
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Closed
SS4 Compatibility#106
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Conversation
@zanderwar
@zanderwarzanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

This PR is a compatibility upgrade to SilverStripe 4.x
Todo
  •  Namespacing
  •  Update all previously deprecated and/or now removed classes/functions
  •  Ensure tests pass

    •  Update fixtures to use FQCN
  •  Update README.md
  •  Update composer.json
  •  Update .travis.yml and .scrutinizer.yml
  •  Ensure examples are working
  •  Clean up display of the sortable grid header
@zanderwarzanderwar
mentioned this pull request
May 27, 2017

Closed

10 tasks
@UndefinedOffset
UndefinedOffset
commented
May 27, 2017

Copy link


Copy Markdown

Owner
Watch when you squash this, I think if you include the first two commits in the squash you'll loose the history because too much will change and git will see it as a new file. Also before I merge this (which will be next week likely) I may start a 2.0.x branch or at least start with #103 and #102. The later brings code formatting inline with the core.
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
Correct, have been stung by the renames before hence the seperate commits purely for those reasons :)
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
I'd go for dropping that latter PR in favour of this just to reduce any concern of conflict
@zanderwar
zanderwarforce-pushed
the
todo/ss4-upgrade
branch
5 times, most recently
from
6a936f0 to
826d0fbCompareMay 27, 2017 04:03
@zanderwar
zanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Javascript appears to be perfectly fine, so theres no urgent rush to port it over to the new API at this moment
Actually there seems to be an issue with the ItemIDs key not existing when clicking the buttons in the header that are usually hidden
PHP Fatal error: No items to sort in /Applications/MAMP/htdocs/alpha7/sortablegridfield/src/Forms/GridFieldSortableRows.php on line 446
Other than that, the drag and drop sort works perfect
CSS needs some love
@zanderwarzanderwar
mentioned this pull request
May 28, 2017

Closed

@UndefinedOffset
UndefinedOffset
changed the base branch from
master
to
2.0.xJune 5, 2017 12:39
@UndefinedOffset
UndefinedOffset
commented
Jun 5, 2017

Copy link


Copy Markdown

Owner
This is merged into the 2.0.x branch, not sure why this didn't auto marked merged, probably because I merged it to another branch
@zanderwarzanderwar
changed the title
WIP: SS4 CompatibilitySS4 CompatibilityJun 14, 2017
@zanderwar
zanderwar
commented
Jun 14, 2017

Copy link


Copy Markdown

Author
May have been the WIP. I know gitlab prevents it atleast
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zanderwar@UndefinedOffset

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
SS4 Compatibility - #106
Closed
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Closed
SS4 Compatibility#106
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Conversation
@zanderwar
@zanderwarzanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

This PR is a compatibility upgrade to SilverStripe 4.x
Todo
  •  Namespacing
  •  Update all previously deprecated and/or now removed classes/functions
  •  Ensure tests pass

    •  Update fixtures to use FQCN
  •  Update README.md
  •  Update composer.json
  •  Update .travis.yml and .scrutinizer.yml
  •  Ensure examples are working
  •  Clean up display of the sortable grid header
@zanderwarzanderwar
mentioned this pull request
May 27, 2017

Closed

10 tasks
@UndefinedOffset
UndefinedOffset
commented
May 27, 2017

Copy link


Copy Markdown

Owner
Watch when you squash this, I think if you include the first two commits in the squash you'll loose the history because too much will change and git will see it as a new file. Also before I merge this (which will be next week likely) I may start a 2.0.x branch or at least start with #103 and #102. The later brings code formatting inline with the core.
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
Correct, have been stung by the renames before hence the seperate commits purely for those reasons :)
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
I'd go for dropping that latter PR in favour of this just to reduce any concern of conflict
@zanderwar
zanderwarforce-pushed
the
todo/ss4-upgrade
branch
5 times, most recently
from
6a936f0 to
826d0fbCompareMay 27, 2017 04:03
@zanderwar
zanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Javascript appears to be perfectly fine, so theres no urgent rush to port it over to the new API at this moment
Actually there seems to be an issue with the ItemIDs key not existing when clicking the buttons in the header that are usually hidden
PHP Fatal error: No items to sort in /Applications/MAMP/htdocs/alpha7/sortablegridfield/src/Forms/GridFieldSortableRows.php on line 446
Other than that, the drag and drop sort works perfect
CSS needs some love
@zanderwarzanderwar
mentioned this pull request
May 28, 2017

Closed

@UndefinedOffset
UndefinedOffset
changed the base branch from
master
to
2.0.xJune 5, 2017 12:39
@UndefinedOffset
UndefinedOffset
commented
Jun 5, 2017

Copy link


Copy Markdown

Owner
This is merged into the 2.0.x branch, not sure why this didn't auto marked merged, probably because I merged it to another branch
@zanderwarzanderwar
changed the title
WIP: SS4 CompatibilitySS4 CompatibilityJun 14, 2017
@zanderwar
zanderwar
commented
Jun 14, 2017

Copy link


Copy Markdown

Author
May have been the WIP. I know gitlab prevents it atleast
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zanderwar@UndefinedOffset

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
SS4 Compatibility - #106
Closed
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Closed
SS4 Compatibility#106
zanderwar wants to merge 9 commits into
UndefinedOffset:2.0.xfrom 
zanderwar:todo/ss4-upgrade
Conversation
@zanderwar
@zanderwarzanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

This PR is a compatibility upgrade to SilverStripe 4.x
Todo
  •  Namespacing
  •  Update all previously deprecated and/or now removed classes/functions
  •  Ensure tests pass

    •  Update fixtures to use FQCN
  •  Update README.md
  •  Update composer.json
  •  Update .travis.yml and .scrutinizer.yml
  •  Ensure examples are working
  •  Clean up display of the sortable grid header
@zanderwarzanderwar
mentioned this pull request
May 27, 2017

Closed

10 tasks
@UndefinedOffset
UndefinedOffset
commented
May 27, 2017

Copy link


Copy Markdown

Owner
Watch when you squash this, I think if you include the first two commits in the squash you'll loose the history because too much will change and git will see it as a new file. Also before I merge this (which will be next week likely) I may start a 2.0.x branch or at least start with #103 and #102. The later brings code formatting inline with the core.
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
Correct, have been stung by the renames before hence the seperate commits purely for those reasons :)
@zanderwar
zanderwar
commented
May 27, 2017

Copy link


Copy Markdown

Author
I'd go for dropping that latter PR in favour of this just to reduce any concern of conflict
@zanderwar
zanderwarforce-pushed
the
todo/ss4-upgrade
branch
5 times, most recently
from
6a936f0 to
826d0fbCompareMay 27, 2017 04:03
@zanderwar
zanderwar
commented
May 27, 2017•

edited

Loading

Copy link


Copy Markdown

Author
Javascript appears to be perfectly fine, so theres no urgent rush to port it over to the new API at this moment
Actually there seems to be an issue with the ItemIDs key not existing when clicking the buttons in the header that are usually hidden
PHP Fatal error: No items to sort in /Applications/MAMP/htdocs/alpha7/sortablegridfield/src/Forms/GridFieldSortableRows.php on line 446
Other than that, the drag and drop sort works perfect
CSS needs some love
@zanderwarzanderwar
mentioned this pull request
May 28, 2017

Closed

@UndefinedOffset
UndefinedOffset
changed the base branch from
master
to
2.0.xJune 5, 2017 12:39
@UndefinedOffset
UndefinedOffset
commented
Jun 5, 2017

Copy link


Copy Markdown

Owner
This is merged into the 2.0.x branch, not sure why this didn't auto marked merged, probably because I merged it to another branch
@zanderwarzanderwar
changed the title
WIP: SS4 CompatibilitySS4 CompatibilityJun 14, 2017
@zanderwar
zanderwar
commented
Jun 14, 2017

Copy link


Copy Markdown

Author
May have been the WIP. I know gitlab prevents it atleast
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@zanderwar@UndefinedOffset