fix(skill): resolve references/ wikilinks whose stem contains a dot

[jichaowang02-lang]

Summary

validate_skill reports a false "doesn't exist" error for a valid
[[references/...]] wikilink whose target stem contains a dot (e.g.
[[references/api.v2]], [[references/v1.2-guide]]), even when the file
(references/api.v2.md) is present and correctly linked.

Root cause

openkb/skill/validator.py only appended the implicit .md when
Path(link).suffix was empty:

target=refs_dir/linkifnottarget.suffix: # <-- ".v2" is a truthy suffixtarget=target.with_suffix(".md")
ifnottarget.exists(): # looks for "references/api.v2" (no .md) -> false error

Path.suffix returns everything after the last dot, so api.v2 has a
truthy suffix (.v2). The .md is never appended, and the validator then
checks for an extension-less references/api.v2, which doesn't exist —
producing a false error. WIKILINK_RE ([a-z0-9._/-]+) allows . in the
target, so such links are legal and reach this branch.

link	file on disk	before	after
[[references/topic]]	topic.md	✅ resolves	✅ (unchanged)
[[references/api.v2.md]]	api.v2.md	✅ resolves	✅ (unchanged)
[[references/api.v2]]	api.v2.md	❌ false "doesn't exist"	✅ resolves
[[references/ghost]]	(absent)	✅ errors	✅ errors (unchanged)

Fix

Append .md based on a literal .md check instead of Path.suffix:

target=refs_dir/ (linkiflink.lower().endswith(".md") elsef"{link}.md")

A dotted stem is now suffixed correctly; an explicit ...md link is left
alone; genuinely missing references still error.

Testing

$ pytest tests/test_skill_validator.py -q
30 passed
$ ruff check openkb/skill/validator.py tests/test_skill_validator.py
All checks passed!

Adds test_wikilink_dotted_stem_without_md_suffix_resolves — the existing
test_wikilink_without_md_suffix_resolves only covered a dot-free stem, so
this path was uncovered.

[Copilot]

Pull request overview

Fixes validate_skill false negatives when resolving [[references/...]] wikilinks whose stems contain dots (e.g. api.v2), by appending .md based on a literal suffix check rather than Path.suffix. This aligns validator behavior with the allowed wikilink pattern and adds a regression test to cover the previously untested path.

Changes:

• Update openkb/skill/validator.py to treat links as “already suffixed” only when they literally end with .md (case-insensitive).
• Add a unit test ensuring dotted stems without an explicit .md suffix resolve correctly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
openkb/skill/validator.py	Fixes reference target path construction so dotted stems still resolve to *.md.
tests/test_skill_validator.py	Adds regression coverage for [[references/api.v2]] resolving to references/api.v2.md.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[KylinMountain]

Thanks @jichaowang02-lang — clean fix. The dotted-stem resolution is correct, and the escape guard is a nice catch (the old code silently accepted [[references/../SKILL]]). LGTM 👍

[jichaowang02-lang]

Summary

validate_skill reports a false "doesn't exist" error for a valid
[[references/...]] wikilink whose target stem contains a dot (e.g.
[[references/api.v2]], [[references/v1.2-guide]]), even when the file
(references/api.v2.md) is present and correctly linked.

Root cause

openkb/skill/validator.py only appended the implicit .md when
Path(link).suffix was empty:

target=refs_dir/linkifnottarget.suffix: # <-- ".v2" is a truthy suffixtarget=target.with_suffix(".md")
ifnottarget.exists(): # looks for "references/api.v2" (no .md) -> false error

Path.suffix returns everything after the last dot, so api.v2 has a
truthy suffix (.v2). The .md is never appended, and the validator then
checks for an extension-less references/api.v2, which doesn't exist —
producing a false error. WIKILINK_RE ([a-z0-9._/-]+) allows . in the
target, so such links are legal and reach this branch.

link	file on disk	before	after
[[references/topic]]	topic.md	✅ resolves	✅ (unchanged)
[[references/api.v2.md]]	api.v2.md	✅ resolves	✅ (unchanged)
[[references/api.v2]]	api.v2.md	❌ false "doesn't exist"	✅ resolves
[[references/ghost]]	(absent)	✅ errors	✅ errors (unchanged)

Fix

Append .md based on a literal .md check instead of Path.suffix:

target=refs_dir/ (linkiflink.lower().endswith(".md") elsef"{link}.md")

A dotted stem is now suffixed correctly; an explicit ...md link is left
alone; genuinely missing references still error.

Testing

$ pytest tests/test_skill_validator.py -q
30 passed
$ ruff check openkb/skill/validator.py tests/test_skill_validator.py
All checks passed!

Adds test_wikilink_dotted_stem_without_md_suffix_resolves — the existing
test_wikilink_without_md_suffix_resolves only covered a dot-free stem, so
this path was uncovered.

[Copilot]

Pull request overview

Fixes validate_skill false negatives when resolving [[references/...]] wikilinks whose stems contain dots (e.g. api.v2), by appending .md based on a literal suffix check rather than Path.suffix. This aligns validator behavior with the allowed wikilink pattern and adds a regression test to cover the previously untested path.

Changes:

• Update openkb/skill/validator.py to treat links as “already suffixed” only when they literally end with .md (case-insensitive).
• Add a unit test ensuring dotted stems without an explicit .md suffix resolve correctly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
openkb/skill/validator.py	Fixes reference target path construction so dotted stems still resolve to *.md.
tests/test_skill_validator.py	Adds regression coverage for [[references/api.v2]] resolving to references/api.v2.md.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[KylinMountain]

Thanks @jichaowang02-lang — clean fix. The dotted-stem resolution is correct, and the escape guard is a nice catch (the old code silently accepted [[references/../SKILL]]). LGTM 👍

[jichaowang02-lang]

Summary

validate_skill reports a false "doesn't exist" error for a valid
[[references/...]] wikilink whose target stem contains a dot (e.g.
[[references/api.v2]], [[references/v1.2-guide]]), even when the file
(references/api.v2.md) is present and correctly linked.

Root cause

openkb/skill/validator.py only appended the implicit .md when
Path(link).suffix was empty:

target=refs_dir/linkifnottarget.suffix: # <-- ".v2" is a truthy suffixtarget=target.with_suffix(".md")
ifnottarget.exists(): # looks for "references/api.v2" (no .md) -> false error

Path.suffix returns everything after the last dot, so api.v2 has a
truthy suffix (.v2). The .md is never appended, and the validator then
checks for an extension-less references/api.v2, which doesn't exist —
producing a false error. WIKILINK_RE ([a-z0-9._/-]+) allows . in the
target, so such links are legal and reach this branch.

link	file on disk	before	after
[[references/topic]]	topic.md	✅ resolves	✅ (unchanged)
[[references/api.v2.md]]	api.v2.md	✅ resolves	✅ (unchanged)
[[references/api.v2]]	api.v2.md	❌ false "doesn't exist"	✅ resolves
[[references/ghost]]	(absent)	✅ errors	✅ errors (unchanged)

Fix

Append .md based on a literal .md check instead of Path.suffix:

target=refs_dir/ (linkiflink.lower().endswith(".md") elsef"{link}.md")

A dotted stem is now suffixed correctly; an explicit ...md link is left
alone; genuinely missing references still error.

Testing

$ pytest tests/test_skill_validator.py -q
30 passed
$ ruff check openkb/skill/validator.py tests/test_skill_validator.py
All checks passed!

Adds test_wikilink_dotted_stem_without_md_suffix_resolves — the existing
test_wikilink_without_md_suffix_resolves only covered a dot-free stem, so
this path was uncovered.

[Copilot]

Pull request overview

Fixes validate_skill false negatives when resolving [[references/...]] wikilinks whose stems contain dots (e.g. api.v2), by appending .md based on a literal suffix check rather than Path.suffix. This aligns validator behavior with the allowed wikilink pattern and adds a regression test to cover the previously untested path.

Changes:

• Update openkb/skill/validator.py to treat links as “already suffixed” only when they literally end with .md (case-insensitive).
• Add a unit test ensuring dotted stems without an explicit .md suffix resolve correctly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
openkb/skill/validator.py	Fixes reference target path construction so dotted stems still resolve to *.md.
tests/test_skill_validator.py	Adds regression coverage for [[references/api.v2]] resolving to references/api.v2.md.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[KylinMountain]

Thanks @jichaowang02-lang — clean fix. The dotted-stem resolution is correct, and the escape guard is a nice catch (the old code silently accepted [[references/../SKILL]]). LGTM 👍

[jichaowang02-lang]

Summary

validate_skill reports a false "doesn't exist" error for a valid
[[references/...]] wikilink whose target stem contains a dot (e.g.
[[references/api.v2]], [[references/v1.2-guide]]), even when the file
(references/api.v2.md) is present and correctly linked.

Root cause

openkb/skill/validator.py only appended the implicit .md when
Path(link).suffix was empty:

target=refs_dir/linkifnottarget.suffix: # <-- ".v2" is a truthy suffixtarget=target.with_suffix(".md")
ifnottarget.exists(): # looks for "references/api.v2" (no .md) -> false error

Path.suffix returns everything after the last dot, so api.v2 has a
truthy suffix (.v2). The .md is never appended, and the validator then
checks for an extension-less references/api.v2, which doesn't exist —
producing a false error. WIKILINK_RE ([a-z0-9._/-]+) allows . in the
target, so such links are legal and reach this branch.

link	file on disk	before	after
[[references/topic]]	topic.md	✅ resolves	✅ (unchanged)
[[references/api.v2.md]]	api.v2.md	✅ resolves	✅ (unchanged)
[[references/api.v2]]	api.v2.md	❌ false "doesn't exist"	✅ resolves
[[references/ghost]]	(absent)	✅ errors	✅ errors (unchanged)

Fix

Append .md based on a literal .md check instead of Path.suffix:

target=refs_dir/ (linkiflink.lower().endswith(".md") elsef"{link}.md")

A dotted stem is now suffixed correctly; an explicit ...md link is left
alone; genuinely missing references still error.

Testing

$ pytest tests/test_skill_validator.py -q
30 passed
$ ruff check openkb/skill/validator.py tests/test_skill_validator.py
All checks passed!

Adds test_wikilink_dotted_stem_without_md_suffix_resolves — the existing
test_wikilink_without_md_suffix_resolves only covered a dot-free stem, so
this path was uncovered.

[Copilot]

Pull request overview

Fixes validate_skill false negatives when resolving [[references/...]] wikilinks whose stems contain dots (e.g. api.v2), by appending .md based on a literal suffix check rather than Path.suffix. This aligns validator behavior with the allowed wikilink pattern and adds a regression test to cover the previously untested path.

Changes:

• Update openkb/skill/validator.py to treat links as “already suffixed” only when they literally end with .md (case-insensitive).
• Add a unit test ensuring dotted stems without an explicit .md suffix resolve correctly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
openkb/skill/validator.py	Fixes reference target path construction so dotted stems still resolve to *.md.
tests/test_skill_validator.py	Adds regression coverage for [[references/api.v2]] resolving to references/api.v2.md.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[KylinMountain]

Thanks @jichaowang02-lang — clean fix. The dotted-stem resolution is correct, and the escape guard is a nice catch (the old code silently accepted [[references/../SKILL]]). LGTM 👍

[jichaowang02-lang]

Summary

validate_skill reports a false "doesn't exist" error for a valid
[[references/...]] wikilink whose target stem contains a dot (e.g.
[[references/api.v2]], [[references/v1.2-guide]]), even when the file
(references/api.v2.md) is present and correctly linked.

Root cause

openkb/skill/validator.py only appended the implicit .md when
Path(link).suffix was empty:

target=refs_dir/linkifnottarget.suffix: # <-- ".v2" is a truthy suffixtarget=target.with_suffix(".md")
ifnottarget.exists(): # looks for "references/api.v2" (no .md) -> false error

Path.suffix returns everything after the last dot, so api.v2 has a
truthy suffix (.v2). The .md is never appended, and the validator then
checks for an extension-less references/api.v2, which doesn't exist —
producing a false error. WIKILINK_RE ([a-z0-9._/-]+) allows . in the
target, so such links are legal and reach this branch.

link	file on disk	before	after
[[references/topic]]	topic.md	✅ resolves	✅ (unchanged)
[[references/api.v2.md]]	api.v2.md	✅ resolves	✅ (unchanged)
[[references/api.v2]]	api.v2.md	❌ false "doesn't exist"	✅ resolves
[[references/ghost]]	(absent)	✅ errors	✅ errors (unchanged)

Fix

Append .md based on a literal .md check instead of Path.suffix:

target=refs_dir/ (linkiflink.lower().endswith(".md") elsef"{link}.md")

A dotted stem is now suffixed correctly; an explicit ...md link is left
alone; genuinely missing references still error.

Testing

$ pytest tests/test_skill_validator.py -q
30 passed
$ ruff check openkb/skill/validator.py tests/test_skill_validator.py
All checks passed!

Adds test_wikilink_dotted_stem_without_md_suffix_resolves — the existing
test_wikilink_without_md_suffix_resolves only covered a dot-free stem, so
this path was uncovered.

[Copilot]

Pull request overview

Fixes validate_skill false negatives when resolving [[references/...]] wikilinks whose stems contain dots (e.g. api.v2), by appending .md based on a literal suffix check rather than Path.suffix. This aligns validator behavior with the allowed wikilink pattern and adds a regression test to cover the previously untested path.

Changes:

• Update openkb/skill/validator.py to treat links as “already suffixed” only when they literally end with .md (case-insensitive).
• Add a unit test ensuring dotted stems without an explicit .md suffix resolve correctly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
openkb/skill/validator.py	Fixes reference target path construction so dotted stems still resolve to *.md.
tests/test_skill_validator.py	Adds regression coverage for [[references/api.v2]] resolving to references/api.v2.md.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[KylinMountain]

Thanks @jichaowang02-lang — clean fix. The dotted-stem resolution is correct, and the escape guard is a nice catch (the old code silently accepted [[references/../SKILL]]). LGTM 👍

[jichaowang02-lang]

Summary

validate_skill reports a false "doesn't exist" error for a valid
[[references/...]] wikilink whose target stem contains a dot (e.g.
[[references/api.v2]], [[references/v1.2-guide]]), even when the file
(references/api.v2.md) is present and correctly linked.

Root cause

openkb/skill/validator.py only appended the implicit .md when
Path(link).suffix was empty:

target=refs_dir/linkifnottarget.suffix: # <-- ".v2" is a truthy suffixtarget=target.with_suffix(".md")
ifnottarget.exists(): # looks for "references/api.v2" (no .md) -> false error

Path.suffix returns everything after the last dot, so api.v2 has a
truthy suffix (.v2). The .md is never appended, and the validator then
checks for an extension-less references/api.v2, which doesn't exist —
producing a false error. WIKILINK_RE ([a-z0-9._/-]+) allows . in the
target, so such links are legal and reach this branch.

link	file on disk	before	after
[[references/topic]]	topic.md	✅ resolves	✅ (unchanged)
[[references/api.v2.md]]	api.v2.md	✅ resolves	✅ (unchanged)
[[references/api.v2]]	api.v2.md	❌ false "doesn't exist"	✅ resolves
[[references/ghost]]	(absent)	✅ errors	✅ errors (unchanged)

Fix

Append .md based on a literal .md check instead of Path.suffix:

target=refs_dir/ (linkiflink.lower().endswith(".md") elsef"{link}.md")

A dotted stem is now suffixed correctly; an explicit ...md link is left
alone; genuinely missing references still error.

Testing

$ pytest tests/test_skill_validator.py -q
30 passed
$ ruff check openkb/skill/validator.py tests/test_skill_validator.py
All checks passed!

Adds test_wikilink_dotted_stem_without_md_suffix_resolves — the existing
test_wikilink_without_md_suffix_resolves only covered a dot-free stem, so
this path was uncovered.

[Copilot]

Pull request overview

Fixes validate_skill false negatives when resolving [[references/...]] wikilinks whose stems contain dots (e.g. api.v2), by appending .md based on a literal suffix check rather than Path.suffix. This aligns validator behavior with the allowed wikilink pattern and adds a regression test to cover the previously untested path.

Changes:

• Update openkb/skill/validator.py to treat links as “already suffixed” only when they literally end with .md (case-insensitive).
• Add a unit test ensuring dotted stems without an explicit .md suffix resolve correctly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
openkb/skill/validator.py	Fixes reference target path construction so dotted stems still resolve to *.md.
tests/test_skill_validator.py	Adds regression coverage for [[references/api.v2]] resolving to references/api.v2.md.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[KylinMountain]

Thanks @jichaowang02-lang — clean fix. The dotted-stem resolution is correct, and the escape guard is a nice catch (the old code silently accepted [[references/../SKILL]]). LGTM 👍

[jichaowang02-lang]

Summary

validate_skill reports a false "doesn't exist" error for a valid
[[references/...]] wikilink whose target stem contains a dot (e.g.
[[references/api.v2]], [[references/v1.2-guide]]), even when the file
(references/api.v2.md) is present and correctly linked.

Root cause

openkb/skill/validator.py only appended the implicit .md when
Path(link).suffix was empty:

target=refs_dir/linkifnottarget.suffix: # <-- ".v2" is a truthy suffixtarget=target.with_suffix(".md")
ifnottarget.exists(): # looks for "references/api.v2" (no .md) -> false error

Path.suffix returns everything after the last dot, so api.v2 has a
truthy suffix (.v2). The .md is never appended, and the validator then
checks for an extension-less references/api.v2, which doesn't exist —
producing a false error. WIKILINK_RE ([a-z0-9._/-]+) allows . in the
target, so such links are legal and reach this branch.

link	file on disk	before	after
[[references/topic]]	topic.md	✅ resolves	✅ (unchanged)
[[references/api.v2.md]]	api.v2.md	✅ resolves	✅ (unchanged)
[[references/api.v2]]	api.v2.md	❌ false "doesn't exist"	✅ resolves
[[references/ghost]]	(absent)	✅ errors	✅ errors (unchanged)

Fix

Append .md based on a literal .md check instead of Path.suffix:

target=refs_dir/ (linkiflink.lower().endswith(".md") elsef"{link}.md")

A dotted stem is now suffixed correctly; an explicit ...md link is left
alone; genuinely missing references still error.

Testing

$ pytest tests/test_skill_validator.py -q
30 passed
$ ruff check openkb/skill/validator.py tests/test_skill_validator.py
All checks passed!

Adds test_wikilink_dotted_stem_without_md_suffix_resolves — the existing
test_wikilink_without_md_suffix_resolves only covered a dot-free stem, so
this path was uncovered.

[Copilot]

Pull request overview

Fixes validate_skill false negatives when resolving [[references/...]] wikilinks whose stems contain dots (e.g. api.v2), by appending .md based on a literal suffix check rather than Path.suffix. This aligns validator behavior with the allowed wikilink pattern and adds a regression test to cover the previously untested path.

Changes:

• Update openkb/skill/validator.py to treat links as “already suffixed” only when they literally end with .md (case-insensitive).
• Add a unit test ensuring dotted stems without an explicit .md suffix resolve correctly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
openkb/skill/validator.py	Fixes reference target path construction so dotted stems still resolve to *.md.
tests/test_skill_validator.py	Adds regression coverage for [[references/api.v2]] resolving to references/api.v2.md.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[KylinMountain]

Thanks @jichaowang02-lang — clean fix. The dotted-stem resolution is correct, and the escape guard is a nice catch (the old code silently accepted [[references/../SKILL]]). LGTM 👍

[jichaowang02-lang]

Summary

validate_skill reports a false "doesn't exist" error for a valid
[[references/...]] wikilink whose target stem contains a dot (e.g.
[[references/api.v2]], [[references/v1.2-guide]]), even when the file
(references/api.v2.md) is present and correctly linked.

Root cause

openkb/skill/validator.py only appended the implicit .md when
Path(link).suffix was empty:

target=refs_dir/linkifnottarget.suffix: # <-- ".v2" is a truthy suffixtarget=target.with_suffix(".md")
ifnottarget.exists(): # looks for "references/api.v2" (no .md) -> false error

Path.suffix returns everything after the last dot, so api.v2 has a
truthy suffix (.v2). The .md is never appended, and the validator then
checks for an extension-less references/api.v2, which doesn't exist —
producing a false error. WIKILINK_RE ([a-z0-9._/-]+) allows . in the
target, so such links are legal and reach this branch.

link	file on disk	before	after
[[references/topic]]	topic.md	✅ resolves	✅ (unchanged)
[[references/api.v2.md]]	api.v2.md	✅ resolves	✅ (unchanged)
[[references/api.v2]]	api.v2.md	❌ false "doesn't exist"	✅ resolves
[[references/ghost]]	(absent)	✅ errors	✅ errors (unchanged)

Fix

Append .md based on a literal .md check instead of Path.suffix:

target=refs_dir/ (linkiflink.lower().endswith(".md") elsef"{link}.md")

A dotted stem is now suffixed correctly; an explicit ...md link is left
alone; genuinely missing references still error.

Testing

$ pytest tests/test_skill_validator.py -q
30 passed
$ ruff check openkb/skill/validator.py tests/test_skill_validator.py
All checks passed!

Adds test_wikilink_dotted_stem_without_md_suffix_resolves — the existing
test_wikilink_without_md_suffix_resolves only covered a dot-free stem, so
this path was uncovered.

[Copilot]

Pull request overview

Fixes validate_skill false negatives when resolving [[references/...]] wikilinks whose stems contain dots (e.g. api.v2), by appending .md based on a literal suffix check rather than Path.suffix. This aligns validator behavior with the allowed wikilink pattern and adds a regression test to cover the previously untested path.

Changes:

• Update openkb/skill/validator.py to treat links as “already suffixed” only when they literally end with .md (case-insensitive).
• Add a unit test ensuring dotted stems without an explicit .md suffix resolve correctly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
openkb/skill/validator.py	Fixes reference target path construction so dotted stems still resolve to *.md.
tests/test_skill_validator.py	Adds regression coverage for [[references/api.v2]] resolving to references/api.v2.md.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[KylinMountain]

Thanks @jichaowang02-lang — clean fix. The dotted-stem resolution is correct, and the escape guard is a nice catch (the old code silently accepted [[references/../SKILL]]). LGTM 👍