Skip to content

fix(skill): resolve references/ wikilinks whose stem contains a dot#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KylinMountain merged 2 commits into from
Jun 23, 2026
Merged

fix(skill): resolve references/ wikilinks whose stem contains a dot #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bbe6b3
fix(skill): resolve references/ wikilinks whose stem contains a dot
jichaowang02-lang Jun 20, 2026
883b227
skill: reject references/ wikilinks that escape the references directory
jichaowang02-lang Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions openkb/skill/validator.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -207,10 +207,20 @@ def validate_skill(skill_dir: Path, *, strict: bool = False) -> ValidationResult
# references/ wikilink resolution
wikilinks = WIKILINK_RE.findall(text)
for link in wikilinks:
# link may or may not include .md suffix
target = refs_dir / link
if not target.suffix:
target = target.with_suffix(".md")
# The link may already include the .md suffix; append it otherwise.
# Test the literal ".md" rather than Path.suffix — a dotted stem like
# "api.v2" has a truthy suffix (".v2"), so Path.suffix would skip the
# ".md" and then look for a non-existent extension-less file.
target = refs_dir / (link if link.lower().endswith(".md") else f"{link}.md")
# A reference must resolve to a file *under* references/ — reject any
# that escape it (e.g. "[[references/../SKILL]]"), which would also
# break the relative_to(skill_dir) call in the not-found message below.
if not target.resolve().is_relative_to(refs_dir.resolve()):
result.errors.append(
f"SKILL.md references [[references/{link}]] which resolves "
f"outside the references/ directory."
)
continue
if not target.exists():
result.errors.append(
f"SKILL.md references [[references/{link}]] but "
Expand Down
26 changes: 26 additions & 0 deletions tests/test_skill_validator.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -259,6 +259,32 @@ def test_wikilink_without_md_suffix_resolves(tmp_path):
assert result.passed, result.errors


def test_wikilink_dotted_stem_without_md_suffix_resolves(tmp_path):
# A reference name whose stem contains a dot (e.g. "api.v2") must still get
# the implicit ".md". Path.suffix would treat ".v2" as the suffix and skip
# appending ".md", falsely reporting the existing api.v2.md as missing.
sd = _write_skill(
tmp_path, "ref-dotted-stem",
body="See [[references/api.v2]] for details.\n",
refs={"api.v2.md": "# api v2\n"},
)
result = validate_skill(sd)
assert result.passed, result.errors


def test_wikilink_escaping_references_dir_is_rejected(tmp_path):
# A link that resolves outside references/ (e.g. "../SKILL") must error —
# not be accepted just because the resolved target (here SKILL.md) exists.
sd = _write_skill(
tmp_path, "ref-escape",
body="See [[references/../SKILL]] for details.\n",
refs={"topic.md": "# topic\n"},
)
result = validate_skill(sd)
assert not result.passed
assert any("outside the references/" in e for e in result.errors)


# ---------------------------------------------------------------------------
# scripts/ imports — strict mode only
# ---------------------------------------------------------------------------
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(skill): resolve references/ wikilinks whose stem contains a dot by jichaowang02-lang · Pull Request #120 · VectifyAI/OpenKB · GitHub
Skip to content
fix(skill): resolve references/ wikilinks whose stem contains a dot#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KylinMountain
merged 2 commits into

from

Jun 23, 2026
 Merged


fix(skill): resolve references/ wikilinks whose stem contains a dot
#120
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8bbe6b3

fix(skill): resolve references/ wikilinks whose stem contains a dot


jichaowang02-lang Jun 20, 2026
883b227

skill: reject references/ wikilinks that escape the references directory


jichaowang02-lang Jun 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 14 additions & 4 deletions
openkb/skill/validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -207,10 +207,20 @@ def validate_skill(skill_dir: Path, *, strict: bool = False) -> ValidationResult
 # references/ wikilink resolution
 wikilinks = WIKILINK_RE.findall(text)
 for link in wikilinks:
 # link may or may not include .md suffix
 target = refs_dir / link
 if not target.suffix:
 target = target.with_suffix(".md")
 # The link may already include the .md suffix; append it otherwise.
 # Test the literal ".md" rather than Path.suffix — a dotted stem like
 # "api.v2" has a truthy suffix (".v2"), so Path.suffix would skip the
 # ".md" and then look for a non-existent extension-less file.
 target = refs_dir / (link if link.lower().endswith(".md") else f"{link}.md")
 # A reference must resolve to a file *under* references/ — reject any
 # that escape it (e.g. "[[references/../SKILL]]"), which would also
 # break the relative_to(skill_dir) call in the not-found message below.
 if not target.resolve().is_relative_to(refs_dir.resolve()):
 result.errors.append(
 f"SKILL.md references [[references/{link}]] which resolves "
 f"outside the references/ directory."
 )
 continue
 if not target.exists():
 result.errors.append(
 f"SKILL.md references [[references/{link}]] but "
Expand Down

26 changes: 26 additions & 0 deletions
tests/test_skill_validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -259,6 +259,32 @@ def test_wikilink_without_md_suffix_resolves(tmp_path):
 assert result.passed, result.errors


def test_wikilink_dotted_stem_without_md_suffix_resolves(tmp_path):
 # A reference name whose stem contains a dot (e.g. "api.v2") must still get
 # the implicit ".md". Path.suffix would treat ".v2" as the suffix and skip
 # appending ".md", falsely reporting the existing api.v2.md as missing.
 sd = _write_skill(
 tmp_path, "ref-dotted-stem",
 body="See [[references/api.v2]] for details.\n",
 refs={"api.v2.md": "# api v2\n"},
 )
 result = validate_skill(sd)
 assert result.passed, result.errors


def test_wikilink_escaping_references_dir_is_rejected(tmp_path):
 # A link that resolves outside references/ (e.g. "../SKILL") must error —
 # not be accepted just because the resolved target (here SKILL.md) exists.
 sd = _write_skill(
 tmp_path, "ref-escape",
 body="See [[references/../SKILL]] for details.\n",
 refs={"topic.md": "# topic\n"},
 )
 result = validate_skill(sd)
 assert not result.passed
 assert any("outside the references/" in e for e in result.errors)


# ---------------------------------------------------------------------------
# scripts/ imports — strict mode only
# ---------------------------------------------------------------------------
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(skill): resolve references/ wikilinks whose stem contains a dot by jichaowang02-lang · Pull Request #120 · VectifyAI/OpenKB · GitHub
Skip to content
fix(skill): resolve references/ wikilinks whose stem contains a dot#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KylinMountain
merged 2 commits into

from

Jun 23, 2026
 Merged


fix(skill): resolve references/ wikilinks whose stem contains a dot
#120
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8bbe6b3

fix(skill): resolve references/ wikilinks whose stem contains a dot


jichaowang02-lang Jun 20, 2026
883b227

skill: reject references/ wikilinks that escape the references directory


jichaowang02-lang Jun 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 14 additions & 4 deletions
openkb/skill/validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -207,10 +207,20 @@ def validate_skill(skill_dir: Path, *, strict: bool = False) -> ValidationResult
 # references/ wikilink resolution
 wikilinks = WIKILINK_RE.findall(text)
 for link in wikilinks:
 # link may or may not include .md suffix
 target = refs_dir / link
 if not target.suffix:
 target = target.with_suffix(".md")
 # The link may already include the .md suffix; append it otherwise.
 # Test the literal ".md" rather than Path.suffix — a dotted stem like
 # "api.v2" has a truthy suffix (".v2"), so Path.suffix would skip the
 # ".md" and then look for a non-existent extension-less file.
 target = refs_dir / (link if link.lower().endswith(".md") else f"{link}.md")
 # A reference must resolve to a file *under* references/ — reject any
 # that escape it (e.g. "[[references/../SKILL]]"), which would also
 # break the relative_to(skill_dir) call in the not-found message below.
 if not target.resolve().is_relative_to(refs_dir.resolve()):
 result.errors.append(
 f"SKILL.md references [[references/{link}]] which resolves "
 f"outside the references/ directory."
 )
 continue
 if not target.exists():
 result.errors.append(
 f"SKILL.md references [[references/{link}]] but "
Expand Down

26 changes: 26 additions & 0 deletions
tests/test_skill_validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -259,6 +259,32 @@ def test_wikilink_without_md_suffix_resolves(tmp_path):
 assert result.passed, result.errors


def test_wikilink_dotted_stem_without_md_suffix_resolves(tmp_path):
 # A reference name whose stem contains a dot (e.g. "api.v2") must still get
 # the implicit ".md". Path.suffix would treat ".v2" as the suffix and skip
 # appending ".md", falsely reporting the existing api.v2.md as missing.
 sd = _write_skill(
 tmp_path, "ref-dotted-stem",
 body="See [[references/api.v2]] for details.\n",
 refs={"api.v2.md": "# api v2\n"},
 )
 result = validate_skill(sd)
 assert result.passed, result.errors


def test_wikilink_escaping_references_dir_is_rejected(tmp_path):
 # A link that resolves outside references/ (e.g. "../SKILL") must error —
 # not be accepted just because the resolved target (here SKILL.md) exists.
 sd = _write_skill(
 tmp_path, "ref-escape",
 body="See [[references/../SKILL]] for details.\n",
 refs={"topic.md": "# topic\n"},
 )
 result = validate_skill(sd)
 assert not result.passed
 assert any("outside the references/" in e for e in result.errors)


# ---------------------------------------------------------------------------
# scripts/ imports — strict mode only
# ---------------------------------------------------------------------------
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(skill): resolve references/ wikilinks whose stem contains a dot by jichaowang02-lang · Pull Request #120 · VectifyAI/OpenKB · GitHub
Skip to content
fix(skill): resolve references/ wikilinks whose stem contains a dot#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KylinMountain
merged 2 commits into

from

Jun 23, 2026
 Merged


fix(skill): resolve references/ wikilinks whose stem contains a dot
#120
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8bbe6b3

fix(skill): resolve references/ wikilinks whose stem contains a dot


jichaowang02-lang Jun 20, 2026
883b227

skill: reject references/ wikilinks that escape the references directory


jichaowang02-lang Jun 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 14 additions & 4 deletions
openkb/skill/validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -207,10 +207,20 @@ def validate_skill(skill_dir: Path, *, strict: bool = False) -> ValidationResult
 # references/ wikilink resolution
 wikilinks = WIKILINK_RE.findall(text)
 for link in wikilinks:
 # link may or may not include .md suffix
 target = refs_dir / link
 if not target.suffix:
 target = target.with_suffix(".md")
 # The link may already include the .md suffix; append it otherwise.
 # Test the literal ".md" rather than Path.suffix — a dotted stem like
 # "api.v2" has a truthy suffix (".v2"), so Path.suffix would skip the
 # ".md" and then look for a non-existent extension-less file.
 target = refs_dir / (link if link.lower().endswith(".md") else f"{link}.md")
 # A reference must resolve to a file *under* references/ — reject any
 # that escape it (e.g. "[[references/../SKILL]]"), which would also
 # break the relative_to(skill_dir) call in the not-found message below.
 if not target.resolve().is_relative_to(refs_dir.resolve()):
 result.errors.append(
 f"SKILL.md references [[references/{link}]] which resolves "
 f"outside the references/ directory."
 )
 continue
 if not target.exists():
 result.errors.append(
 f"SKILL.md references [[references/{link}]] but "
Expand Down

26 changes: 26 additions & 0 deletions
tests/test_skill_validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -259,6 +259,32 @@ def test_wikilink_without_md_suffix_resolves(tmp_path):
 assert result.passed, result.errors


def test_wikilink_dotted_stem_without_md_suffix_resolves(tmp_path):
 # A reference name whose stem contains a dot (e.g. "api.v2") must still get
 # the implicit ".md". Path.suffix would treat ".v2" as the suffix and skip
 # appending ".md", falsely reporting the existing api.v2.md as missing.
 sd = _write_skill(
 tmp_path, "ref-dotted-stem",
 body="See [[references/api.v2]] for details.\n",
 refs={"api.v2.md": "# api v2\n"},
 )
 result = validate_skill(sd)
 assert result.passed, result.errors


def test_wikilink_escaping_references_dir_is_rejected(tmp_path):
 # A link that resolves outside references/ (e.g. "../SKILL") must error —
 # not be accepted just because the resolved target (here SKILL.md) exists.
 sd = _write_skill(
 tmp_path, "ref-escape",
 body="See [[references/../SKILL]] for details.\n",
 refs={"topic.md": "# topic\n"},
 )
 result = validate_skill(sd)
 assert not result.passed
 assert any("outside the references/" in e for e in result.errors)


# ---------------------------------------------------------------------------
# scripts/ imports — strict mode only
# ---------------------------------------------------------------------------
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(skill): resolve references/ wikilinks whose stem contains a dot by jichaowang02-lang · Pull Request #120 · VectifyAI/OpenKB · GitHub
Skip to content
fix(skill): resolve references/ wikilinks whose stem contains a dot#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KylinMountain
merged 2 commits into

from

Jun 23, 2026
 Merged


fix(skill): resolve references/ wikilinks whose stem contains a dot
#120
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8bbe6b3

fix(skill): resolve references/ wikilinks whose stem contains a dot


jichaowang02-lang Jun 20, 2026
883b227

skill: reject references/ wikilinks that escape the references directory


jichaowang02-lang Jun 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 14 additions & 4 deletions
openkb/skill/validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -207,10 +207,20 @@ def validate_skill(skill_dir: Path, *, strict: bool = False) -> ValidationResult
 # references/ wikilink resolution
 wikilinks = WIKILINK_RE.findall(text)
 for link in wikilinks:
 # link may or may not include .md suffix
 target = refs_dir / link
 if not target.suffix:
 target = target.with_suffix(".md")
 # The link may already include the .md suffix; append it otherwise.
 # Test the literal ".md" rather than Path.suffix — a dotted stem like
 # "api.v2" has a truthy suffix (".v2"), so Path.suffix would skip the
 # ".md" and then look for a non-existent extension-less file.
 target = refs_dir / (link if link.lower().endswith(".md") else f"{link}.md")
 # A reference must resolve to a file *under* references/ — reject any
 # that escape it (e.g. "[[references/../SKILL]]"), which would also
 # break the relative_to(skill_dir) call in the not-found message below.
 if not target.resolve().is_relative_to(refs_dir.resolve()):
 result.errors.append(
 f"SKILL.md references [[references/{link}]] which resolves "
 f"outside the references/ directory."
 )
 continue
 if not target.exists():
 result.errors.append(
 f"SKILL.md references [[references/{link}]] but "
Expand Down

26 changes: 26 additions & 0 deletions
tests/test_skill_validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -259,6 +259,32 @@ def test_wikilink_without_md_suffix_resolves(tmp_path):
 assert result.passed, result.errors


def test_wikilink_dotted_stem_without_md_suffix_resolves(tmp_path):
 # A reference name whose stem contains a dot (e.g. "api.v2") must still get
 # the implicit ".md". Path.suffix would treat ".v2" as the suffix and skip
 # appending ".md", falsely reporting the existing api.v2.md as missing.
 sd = _write_skill(
 tmp_path, "ref-dotted-stem",
 body="See [[references/api.v2]] for details.\n",
 refs={"api.v2.md": "# api v2\n"},
 )
 result = validate_skill(sd)
 assert result.passed, result.errors


def test_wikilink_escaping_references_dir_is_rejected(tmp_path):
 # A link that resolves outside references/ (e.g. "../SKILL") must error —
 # not be accepted just because the resolved target (here SKILL.md) exists.
 sd = _write_skill(
 tmp_path, "ref-escape",
 body="See [[references/../SKILL]] for details.\n",
 refs={"topic.md": "# topic\n"},
 )
 result = validate_skill(sd)
 assert not result.passed
 assert any("outside the references/" in e for e in result.errors)


# ---------------------------------------------------------------------------
# scripts/ imports — strict mode only
# ---------------------------------------------------------------------------
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(skill): resolve references/ wikilinks whose stem contains a dot by jichaowang02-lang · Pull Request #120 · VectifyAI/OpenKB · GitHub
Skip to content
fix(skill): resolve references/ wikilinks whose stem contains a dot#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KylinMountain
merged 2 commits into

from

Jun 23, 2026
 Merged


fix(skill): resolve references/ wikilinks whose stem contains a dot
#120
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8bbe6b3

fix(skill): resolve references/ wikilinks whose stem contains a dot


jichaowang02-lang Jun 20, 2026
883b227

skill: reject references/ wikilinks that escape the references directory


jichaowang02-lang Jun 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 14 additions & 4 deletions
openkb/skill/validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -207,10 +207,20 @@ def validate_skill(skill_dir: Path, *, strict: bool = False) -> ValidationResult
 # references/ wikilink resolution
 wikilinks = WIKILINK_RE.findall(text)
 for link in wikilinks:
 # link may or may not include .md suffix
 target = refs_dir / link
 if not target.suffix:
 target = target.with_suffix(".md")
 # The link may already include the .md suffix; append it otherwise.
 # Test the literal ".md" rather than Path.suffix — a dotted stem like
 # "api.v2" has a truthy suffix (".v2"), so Path.suffix would skip the
 # ".md" and then look for a non-existent extension-less file.
 target = refs_dir / (link if link.lower().endswith(".md") else f"{link}.md")
 # A reference must resolve to a file *under* references/ — reject any
 # that escape it (e.g. "[[references/../SKILL]]"), which would also
 # break the relative_to(skill_dir) call in the not-found message below.
 if not target.resolve().is_relative_to(refs_dir.resolve()):
 result.errors.append(
 f"SKILL.md references [[references/{link}]] which resolves "
 f"outside the references/ directory."
 )
 continue
 if not target.exists():
 result.errors.append(
 f"SKILL.md references [[references/{link}]] but "
Expand Down

26 changes: 26 additions & 0 deletions
tests/test_skill_validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -259,6 +259,32 @@ def test_wikilink_without_md_suffix_resolves(tmp_path):
 assert result.passed, result.errors


def test_wikilink_dotted_stem_without_md_suffix_resolves(tmp_path):
 # A reference name whose stem contains a dot (e.g. "api.v2") must still get
 # the implicit ".md". Path.suffix would treat ".v2" as the suffix and skip
 # appending ".md", falsely reporting the existing api.v2.md as missing.
 sd = _write_skill(
 tmp_path, "ref-dotted-stem",
 body="See [[references/api.v2]] for details.\n",
 refs={"api.v2.md": "# api v2\n"},
 )
 result = validate_skill(sd)
 assert result.passed, result.errors


def test_wikilink_escaping_references_dir_is_rejected(tmp_path):
 # A link that resolves outside references/ (e.g. "../SKILL") must error —
 # not be accepted just because the resolved target (here SKILL.md) exists.
 sd = _write_skill(
 tmp_path, "ref-escape",
 body="See [[references/../SKILL]] for details.\n",
 refs={"topic.md": "# topic\n"},
 )
 result = validate_skill(sd)
 assert not result.passed
 assert any("outside the references/" in e for e in result.errors)


# ---------------------------------------------------------------------------
# scripts/ imports — strict mode only
# ---------------------------------------------------------------------------
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(skill): resolve references/ wikilinks whose stem contains a dot by jichaowang02-lang · Pull Request #120 · VectifyAI/OpenKB · GitHub
Skip to content
fix(skill): resolve references/ wikilinks whose stem contains a dot#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KylinMountain
merged 2 commits into

from

Jun 23, 2026
 Merged


fix(skill): resolve references/ wikilinks whose stem contains a dot
#120
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8bbe6b3

fix(skill): resolve references/ wikilinks whose stem contains a dot


jichaowang02-lang Jun 20, 2026
883b227

skill: reject references/ wikilinks that escape the references directory


jichaowang02-lang Jun 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 14 additions & 4 deletions
openkb/skill/validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -207,10 +207,20 @@ def validate_skill(skill_dir: Path, *, strict: bool = False) -> ValidationResult
 # references/ wikilink resolution
 wikilinks = WIKILINK_RE.findall(text)
 for link in wikilinks:
 # link may or may not include .md suffix
 target = refs_dir / link
 if not target.suffix:
 target = target.with_suffix(".md")
 # The link may already include the .md suffix; append it otherwise.
 # Test the literal ".md" rather than Path.suffix — a dotted stem like
 # "api.v2" has a truthy suffix (".v2"), so Path.suffix would skip the
 # ".md" and then look for a non-existent extension-less file.
 target = refs_dir / (link if link.lower().endswith(".md") else f"{link}.md")
 # A reference must resolve to a file *under* references/ — reject any
 # that escape it (e.g. "[[references/../SKILL]]"), which would also
 # break the relative_to(skill_dir) call in the not-found message below.
 if not target.resolve().is_relative_to(refs_dir.resolve()):
 result.errors.append(
 f"SKILL.md references [[references/{link}]] which resolves "
 f"outside the references/ directory."
 )
 continue
 if not target.exists():
 result.errors.append(
 f"SKILL.md references [[references/{link}]] but "
Expand Down

26 changes: 26 additions & 0 deletions
tests/test_skill_validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -259,6 +259,32 @@ def test_wikilink_without_md_suffix_resolves(tmp_path):
 assert result.passed, result.errors


def test_wikilink_dotted_stem_without_md_suffix_resolves(tmp_path):
 # A reference name whose stem contains a dot (e.g. "api.v2") must still get
 # the implicit ".md". Path.suffix would treat ".v2" as the suffix and skip
 # appending ".md", falsely reporting the existing api.v2.md as missing.
 sd = _write_skill(
 tmp_path, "ref-dotted-stem",
 body="See [[references/api.v2]] for details.\n",
 refs={"api.v2.md": "# api v2\n"},
 )
 result = validate_skill(sd)
 assert result.passed, result.errors


def test_wikilink_escaping_references_dir_is_rejected(tmp_path):
 # A link that resolves outside references/ (e.g. "../SKILL") must error —
 # not be accepted just because the resolved target (here SKILL.md) exists.
 sd = _write_skill(
 tmp_path, "ref-escape",
 body="See [[references/../SKILL]] for details.\n",
 refs={"topic.md": "# topic\n"},
 )
 result = validate_skill(sd)
 assert not result.passed
 assert any("outside the references/" in e for e in result.errors)


# ---------------------------------------------------------------------------
# scripts/ imports — strict mode only
# ---------------------------------------------------------------------------
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(skill): resolve references/ wikilinks whose stem contains a dot by jichaowang02-lang · Pull Request #120 · VectifyAI/OpenKB · GitHub
Skip to content
fix(skill): resolve references/ wikilinks whose stem contains a dot#120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

KylinMountain
merged 2 commits into

from

Jun 23, 2026
 Merged


fix(skill): resolve references/ wikilinks whose stem contains a dot
#120
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


2 commits


Select commit
Hold shift + click to select a range
8bbe6b3

fix(skill): resolve references/ wikilinks whose stem contains a dot


jichaowang02-lang Jun 20, 2026
883b227

skill: reject references/ wikilinks that escape the references directory


jichaowang02-lang Jun 21, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


18 changes: 14 additions & 4 deletions
openkb/skill/validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -207,10 +207,20 @@ def validate_skill(skill_dir: Path, *, strict: bool = False) -> ValidationResult
 # references/ wikilink resolution
 wikilinks = WIKILINK_RE.findall(text)
 for link in wikilinks:
 # link may or may not include .md suffix
 target = refs_dir / link
 if not target.suffix:
 target = target.with_suffix(".md")
 # The link may already include the .md suffix; append it otherwise.
 # Test the literal ".md" rather than Path.suffix — a dotted stem like
 # "api.v2" has a truthy suffix (".v2"), so Path.suffix would skip the
 # ".md" and then look for a non-existent extension-less file.
 target = refs_dir / (link if link.lower().endswith(".md") else f"{link}.md")
 # A reference must resolve to a file *under* references/ — reject any
 # that escape it (e.g. "[[references/../SKILL]]"), which would also
 # break the relative_to(skill_dir) call in the not-found message below.
 if not target.resolve().is_relative_to(refs_dir.resolve()):
 result.errors.append(
 f"SKILL.md references [[references/{link}]] which resolves "
 f"outside the references/ directory."
 )
 continue
 if not target.exists():
 result.errors.append(
 f"SKILL.md references [[references/{link}]] but "
Expand Down

26 changes: 26 additions & 0 deletions
tests/test_skill_validator.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -259,6 +259,32 @@ def test_wikilink_without_md_suffix_resolves(tmp_path):
 assert result.passed, result.errors


def test_wikilink_dotted_stem_without_md_suffix_resolves(tmp_path):
 # A reference name whose stem contains a dot (e.g. "api.v2") must still get
 # the implicit ".md". Path.suffix would treat ".v2" as the suffix and skip
 # appending ".md", falsely reporting the existing api.v2.md as missing.
 sd = _write_skill(
 tmp_path, "ref-dotted-stem",
 body="See [[references/api.v2]] for details.\n",
 refs={"api.v2.md": "# api v2\n"},
 )
 result = validate_skill(sd)
 assert result.passed, result.errors


def test_wikilink_escaping_references_dir_is_rejected(tmp_path):
 # A link that resolves outside references/ (e.g. "../SKILL") must error —
 # not be accepted just because the resolved target (here SKILL.md) exists.
 sd = _write_skill(
 tmp_path, "ref-escape",
 body="See [[references/../SKILL]] for details.\n",
 refs={"topic.md": "# topic\n"},
 )
 result = validate_skill(sd)
 assert not result.passed
 assert any("outside the references/" in e for e in result.errors)


# ---------------------------------------------------------------------------
# scripts/ imports — strict mode only
# ---------------------------------------------------------------------------
Expand Down