Cleanup. Needs review

[karbassi]

No description provided.

[rgroves]

I'm going to clean up the unmatched tag issue; other than that looks good.

[karbassi]

Fixes #834

[rgroves]

I was able to run through testing for a guardian and a mentor.

For the guardian I created an account, added multiple students, registered students for a class, canceled a class, and removed a student.
For the mentor I created an account, signed up for classes and canceled a class.

Here are a couple things I ran into, that I don't think are deal breakers for merging this (already large changeset)—these could be future issues and if you agree I can open separate issues for these:

• Guardian Student Registration Form

  • If you leave in a form error (like an unfilled name) and click the button at the bottom of the form, if the field in error is off-screen the browser will scroll to it, focus it, but no validation/error message appears. This might be a Chrome specific issue (I was using Chrome Version 87.0.4280.141 Official Build/64-bit). It does not seem to happen in Firefox.

  • After successfully registering a student, the flow stays on the register student form. Not sure if that is the expected behavior. If so, it would be a nice UX addition to have one, or both, of the following options on that same page: a "Done" option that takes you back to the account screen or a "Find Classes" option that takes you to the class list to register.

• Mentor Form

  • Once registered, on the account page form, it allows a mentor to clear their first & last name and save. This will then show a message above the form that states to enter a full name, but that is something we should possibly disallow in the future.

• Email Confirmation

  • I noticed on the email confirmation screen, it shows the username instead of the full name (First Last). See screen shot

• Also noticed when in the Django Admin, that previous usernames were using first and last name concatenated together and currently it seems to use only the first name and if there are duplicates it appends a number (like that shown in the email confirmation screen shot above).

[rgroves]

LGTM

[karbassi]

No description provided.

[rgroves]

I'm going to clean up the unmatched tag issue; other than that looks good.

[karbassi]

Fixes #834

[rgroves]

I was able to run through testing for a guardian and a mentor.

For the guardian I created an account, added multiple students, registered students for a class, canceled a class, and removed a student.
For the mentor I created an account, signed up for classes and canceled a class.

Here are a couple things I ran into, that I don't think are deal breakers for merging this (already large changeset)—these could be future issues and if you agree I can open separate issues for these:

• Guardian Student Registration Form

  • If you leave in a form error (like an unfilled name) and click the button at the bottom of the form, if the field in error is off-screen the browser will scroll to it, focus it, but no validation/error message appears. This might be a Chrome specific issue (I was using Chrome Version 87.0.4280.141 Official Build/64-bit). It does not seem to happen in Firefox.

  • After successfully registering a student, the flow stays on the register student form. Not sure if that is the expected behavior. If so, it would be a nice UX addition to have one, or both, of the following options on that same page: a "Done" option that takes you back to the account screen or a "Find Classes" option that takes you to the class list to register.

• Mentor Form

  • Once registered, on the account page form, it allows a mentor to clear their first & last name and save. This will then show a message above the form that states to enter a full name, but that is something we should possibly disallow in the future.

• Email Confirmation

  • I noticed on the email confirmation screen, it shows the username instead of the full name (First Last). See screen shot

• Also noticed when in the Django Admin, that previous usernames were using first and last name concatenated together and currently it seems to use only the first name and if there are duplicates it appends a number (like that shown in the email confirmation screen shot above).

[rgroves]

LGTM

[karbassi]

No description provided.

[rgroves]

I'm going to clean up the unmatched tag issue; other than that looks good.

[karbassi]

Fixes #834

[rgroves]

I was able to run through testing for a guardian and a mentor.

For the guardian I created an account, added multiple students, registered students for a class, canceled a class, and removed a student.
For the mentor I created an account, signed up for classes and canceled a class.

Here are a couple things I ran into, that I don't think are deal breakers for merging this (already large changeset)—these could be future issues and if you agree I can open separate issues for these:

• Guardian Student Registration Form

  • If you leave in a form error (like an unfilled name) and click the button at the bottom of the form, if the field in error is off-screen the browser will scroll to it, focus it, but no validation/error message appears. This might be a Chrome specific issue (I was using Chrome Version 87.0.4280.141 Official Build/64-bit). It does not seem to happen in Firefox.

  • After successfully registering a student, the flow stays on the register student form. Not sure if that is the expected behavior. If so, it would be a nice UX addition to have one, or both, of the following options on that same page: a "Done" option that takes you back to the account screen or a "Find Classes" option that takes you to the class list to register.

• Mentor Form

  • Once registered, on the account page form, it allows a mentor to clear their first & last name and save. This will then show a message above the form that states to enter a full name, but that is something we should possibly disallow in the future.

• Email Confirmation

  • I noticed on the email confirmation screen, it shows the username instead of the full name (First Last). See screen shot

• Also noticed when in the Django Admin, that previous usernames were using first and last name concatenated together and currently it seems to use only the first name and if there are duplicates it appends a number (like that shown in the email confirmation screen shot above).

[rgroves]

LGTM

[karbassi]

No description provided.

[rgroves]

I'm going to clean up the unmatched tag issue; other than that looks good.

[karbassi]

Fixes #834

[rgroves]

I was able to run through testing for a guardian and a mentor.

For the guardian I created an account, added multiple students, registered students for a class, canceled a class, and removed a student.
For the mentor I created an account, signed up for classes and canceled a class.

Here are a couple things I ran into, that I don't think are deal breakers for merging this (already large changeset)—these could be future issues and if you agree I can open separate issues for these:

• Guardian Student Registration Form

  • If you leave in a form error (like an unfilled name) and click the button at the bottom of the form, if the field in error is off-screen the browser will scroll to it, focus it, but no validation/error message appears. This might be a Chrome specific issue (I was using Chrome Version 87.0.4280.141 Official Build/64-bit). It does not seem to happen in Firefox.

  • After successfully registering a student, the flow stays on the register student form. Not sure if that is the expected behavior. If so, it would be a nice UX addition to have one, or both, of the following options on that same page: a "Done" option that takes you back to the account screen or a "Find Classes" option that takes you to the class list to register.

• Mentor Form

  • Once registered, on the account page form, it allows a mentor to clear their first & last name and save. This will then show a message above the form that states to enter a full name, but that is something we should possibly disallow in the future.

• Email Confirmation

  • I noticed on the email confirmation screen, it shows the username instead of the full name (First Last). See screen shot

• Also noticed when in the Django Admin, that previous usernames were using first and last name concatenated together and currently it seems to use only the first name and if there are duplicates it appends a number (like that shown in the email confirmation screen shot above).

[rgroves]

LGTM

[karbassi]

No description provided.

[rgroves]

I'm going to clean up the unmatched tag issue; other than that looks good.

[karbassi]

Fixes #834

[rgroves]

I was able to run through testing for a guardian and a mentor.

For the guardian I created an account, added multiple students, registered students for a class, canceled a class, and removed a student.
For the mentor I created an account, signed up for classes and canceled a class.

Here are a couple things I ran into, that I don't think are deal breakers for merging this (already large changeset)—these could be future issues and if you agree I can open separate issues for these:

• Guardian Student Registration Form

  • If you leave in a form error (like an unfilled name) and click the button at the bottom of the form, if the field in error is off-screen the browser will scroll to it, focus it, but no validation/error message appears. This might be a Chrome specific issue (I was using Chrome Version 87.0.4280.141 Official Build/64-bit). It does not seem to happen in Firefox.

  • After successfully registering a student, the flow stays on the register student form. Not sure if that is the expected behavior. If so, it would be a nice UX addition to have one, or both, of the following options on that same page: a "Done" option that takes you back to the account screen or a "Find Classes" option that takes you to the class list to register.

• Mentor Form

  • Once registered, on the account page form, it allows a mentor to clear their first & last name and save. This will then show a message above the form that states to enter a full name, but that is something we should possibly disallow in the future.

• Email Confirmation

  • I noticed on the email confirmation screen, it shows the username instead of the full name (First Last). See screen shot

• Also noticed when in the Django Admin, that previous usernames were using first and last name concatenated together and currently it seems to use only the first name and if there are duplicates it appends a number (like that shown in the email confirmation screen shot above).

[rgroves]

LGTM

[karbassi]

No description provided.

[rgroves]

I'm going to clean up the unmatched tag issue; other than that looks good.

[karbassi]

Fixes #834

[rgroves]

I was able to run through testing for a guardian and a mentor.

For the guardian I created an account, added multiple students, registered students for a class, canceled a class, and removed a student.
For the mentor I created an account, signed up for classes and canceled a class.

Here are a couple things I ran into, that I don't think are deal breakers for merging this (already large changeset)—these could be future issues and if you agree I can open separate issues for these:

• Guardian Student Registration Form

  • If you leave in a form error (like an unfilled name) and click the button at the bottom of the form, if the field in error is off-screen the browser will scroll to it, focus it, but no validation/error message appears. This might be a Chrome specific issue (I was using Chrome Version 87.0.4280.141 Official Build/64-bit). It does not seem to happen in Firefox.

  • After successfully registering a student, the flow stays on the register student form. Not sure if that is the expected behavior. If so, it would be a nice UX addition to have one, or both, of the following options on that same page: a "Done" option that takes you back to the account screen or a "Find Classes" option that takes you to the class list to register.

• Mentor Form

  • Once registered, on the account page form, it allows a mentor to clear their first & last name and save. This will then show a message above the form that states to enter a full name, but that is something we should possibly disallow in the future.

• Email Confirmation

  • I noticed on the email confirmation screen, it shows the username instead of the full name (First Last). See screen shot

• Also noticed when in the Django Admin, that previous usernames were using first and last name concatenated together and currently it seems to use only the first name and if there are duplicates it appends a number (like that shown in the email confirmation screen shot above).

[rgroves]

LGTM

[karbassi]

No description provided.

[rgroves]

I'm going to clean up the unmatched tag issue; other than that looks good.

[karbassi]

Fixes #834

[rgroves]

I was able to run through testing for a guardian and a mentor.

For the guardian I created an account, added multiple students, registered students for a class, canceled a class, and removed a student.
For the mentor I created an account, signed up for classes and canceled a class.

Here are a couple things I ran into, that I don't think are deal breakers for merging this (already large changeset)—these could be future issues and if you agree I can open separate issues for these:

• Guardian Student Registration Form

  • If you leave in a form error (like an unfilled name) and click the button at the bottom of the form, if the field in error is off-screen the browser will scroll to it, focus it, but no validation/error message appears. This might be a Chrome specific issue (I was using Chrome Version 87.0.4280.141 Official Build/64-bit). It does not seem to happen in Firefox.

  • After successfully registering a student, the flow stays on the register student form. Not sure if that is the expected behavior. If so, it would be a nice UX addition to have one, or both, of the following options on that same page: a "Done" option that takes you back to the account screen or a "Find Classes" option that takes you to the class list to register.

• Mentor Form

  • Once registered, on the account page form, it allows a mentor to clear their first & last name and save. This will then show a message above the form that states to enter a full name, but that is something we should possibly disallow in the future.

• Email Confirmation

  • I noticed on the email confirmation screen, it shows the username instead of the full name (First Last). See screen shot

• Also noticed when in the Django Admin, that previous usernames were using first and last name concatenated together and currently it seems to use only the first name and if there are duplicates it appends a number (like that shown in the email confirmation screen shot above).

[rgroves]

LGTM

[karbassi]

No description provided.

[rgroves]

I'm going to clean up the unmatched tag issue; other than that looks good.

[karbassi]

Fixes #834

[rgroves]

I was able to run through testing for a guardian and a mentor.

For the guardian I created an account, added multiple students, registered students for a class, canceled a class, and removed a student.
For the mentor I created an account, signed up for classes and canceled a class.

Here are a couple things I ran into, that I don't think are deal breakers for merging this (already large changeset)—these could be future issues and if you agree I can open separate issues for these:

• Guardian Student Registration Form

  • If you leave in a form error (like an unfilled name) and click the button at the bottom of the form, if the field in error is off-screen the browser will scroll to it, focus it, but no validation/error message appears. This might be a Chrome specific issue (I was using Chrome Version 87.0.4280.141 Official Build/64-bit). It does not seem to happen in Firefox.

  • After successfully registering a student, the flow stays on the register student form. Not sure if that is the expected behavior. If so, it would be a nice UX addition to have one, or both, of the following options on that same page: a "Done" option that takes you back to the account screen or a "Find Classes" option that takes you to the class list to register.

• Mentor Form

  • Once registered, on the account page form, it allows a mentor to clear their first & last name and save. This will then show a message above the form that states to enter a full name, but that is something we should possibly disallow in the future.

• Email Confirmation

  • I noticed on the email confirmation screen, it shows the username instead of the full name (First Last). See screen shot

• Also noticed when in the Django Admin, that previous usernames were using first and last name concatenated together and currently it seems to use only the first name and if there are duplicates it appends a number (like that shown in the email confirmation screen shot above).

[rgroves]

LGTM