Uh oh!
There was an error while loading. Please reload this page.
Remove subscription_t's clock.identifier field. - #125
Conversation
As noticed in rust-lang/rust#65617 (comment), the `clock.identifier` field in `subscription_t` isn't used for anything. It came from CloudABI, where it appears to be a holdover from an earlier API feature which is no longer present.
| (typename $subscription_clock_t | ||
| (struct | ||
| ;; The user-defined unique identifier of the clock. | ||
| (field $identifier $userdata_t) |
There was a problem hiding this comment.
This may theoretically be useful for debuggers.
There was a problem hiding this comment.
What would it add beyond the clock_id field?
There was a problem hiding this comment.
I though I read that it was a string. In that case, a debugger could show that string to the user. I think it would be better to design such debugger integrations separately and for all things it makes sense for at a later time though.
dunnock
commented
Oct 24, 2019
BTW, what is the right way to land this spec change in the code, e.g. is it ok to just remove it from the structure in https://github.com/CraneStation/rust-wasi and fix dependencies in other projects? E.g. If so it seems quite simple, I can take it. |
newpavlov
commented
Oct 25, 2019
@dunnock |
dunnock
commented
Oct 25, 2019
@newpavlov thanks, it does not seem an entry level stuff then |
sunfishcode
commented
Oct 25, 2019
Yes, following the phases document, this change is happening to ephemeral, which we'll batch up with other changes and snapshot to a versioned interface. As for keeping rust-wasi up to date, I'm working on a way to make that easier; hopefully I'll have the PR ready soon. |
As noticed in rust-lang/rust#65617 (comment), the `clock.identifier` field in `subscription_t` isn't used for anything. It came from CloudABI, where it appears to be a holdover from an earlier API feature which is no longer present.
As noticed in rust-lang/rust#65617 (comment), the `clock.identifier` field in `subscription_t` isn't used for anything. It came from CloudABI, where it appears to be a holdover from an earlier API feature which is no longer present.
…_stream_concern descriptor-flags: eliminate non-blocking flag, and therefore set-flags
As noticed in rust-lang/rust#65617 (comment), the `clock.identifier` field in `subscription_t` isn't used for anything. It came from CloudABI, where it appears to be a holdover from an earlier API feature which is no longer present.
As noticed in
rust-lang/rust#65617 (comment),
the
clock.identifierfield insubscription_tisn't used foranything. It came from CloudABI, where it appears to be a holdover from
an earlier API feature which is no longer present.